36345 2010-03-18 23:56:00 -0700 Move find_green_to_red_transition out of "what-broke" onto Builder for easier re-use 2010-03-19 00:20:27 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 eric webkit-unassigned abarth commit-queue oldest_to_newest 201737 0 eric 2010-03-18 23:56:00 -0700 Move find_green_to_red_transition out of "what-broke" onto Builder for easier re-use 201738 1 51128 eric 2010-03-18 23:56:56 -0700 Created attachment 51128 Patch 201739 2 51128 abarth 2010-03-18 23:59:08 -0700 Comment on attachment 51128 Patch Ok. You're lame for not testing! We need a network abstraction to work from. 201747 3 51128 abarth 2010-03-19 00:15:43 -0700 Comment on attachment 51128 Patch Clearing flags on attachment: 51128 Committed r56220: <http://trac.webkit.org/changeset/56220> 201748 4 abarth 2010-03-19 00:15:48 -0700 All reviewed patches have been landed. Closing bug. 51128 2010-03-18 23:56:56 -0700 2010-03-19 00:15:43 -0700 Patch bug-36345-20100318235654.patch text/plain 4997 eric ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBlZTIyNTA3Li4yODQ4YWZhIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTUgQEAKIDIwMTAtMDMt MTggIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgogCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1vdmUgZmluZF9ncmVlbl90b19yZWRfdHJhbnNp dGlvbiBvdXQgb2YgIndoYXQtYnJva2UiIG9udG8gQnVpbGRlciBmb3IgZWFzaWVyIHJlLXVzZQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzYzNDUKKwor ICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvYnVpbGRib3QucHk6CisgICAgICAgICogU2NyaXB0 cy93ZWJraXRweS9jb21tYW5kcy9xdWVyaWVzLnB5OgorCisyMDEwLTAzLTE4ICBFcmljIFNlaWRl bCAgPGVyaWNAd2Via2l0Lm9yZz4KKwogICAgICAgICBSZXZpZXdlZCBieSBBZGFtIEJhcnRoLgog CiAgICAgICAgIFNwbGl0IG91dCBDb21taXRJbmZvIGNsYXNzIGFuZCBhZGQgdW5pdCB0ZXN0cwpk aWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9idWlsZGJvdC5weSBiL1dl YktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvYnVpbGRib3QucHkKaW5kZXggYjRlMzYzYi4uMzI2 OGY5ZCAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9idWlsZGJvdC5w eQorKysgYi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2J1aWxkYm90LnB5CkBAIC02NSw2 ICs2NSwyOCBAQCBjbGFzcyBCdWlsZGVyKG9iamVjdCk6CiAgICAgICAgIHNlbGYuX2J1aWxkc19j YWNoZVtidWlsZF9udW1iZXJdID0gYnVpbGQKICAgICAgICAgcmV0dXJuIGJ1aWxkCiAKKyAgICAj IEZJWE1FOiBXZSBzaG91bGQgbm90IGhhdmUgdG8gcGFzcyBhIHJlZF9idWlsZF9udW1iZXIsIGJ1 dCByYXRoZXIgQnVpbGRlciBzaG91bGQKKyAgICAjIGtub3cgd2hhdCBpdHMgImxhdGVzdF9idWls ZCIgaXMuCisgICAgIyBGSVhNRTogVGhpcyBuZWVkcyB1bml0IHRlc3RpbmcuCisgICAgZGVmIGZp bmRfZ3JlZW5fdG9fcmVkX3RyYW5zaXRpb24oc2VsZiwgcmVkX2J1aWxkX251bWJlciwgbG9va19i YWNrX2xpbWl0PTMwKToKKyAgICAgICAgIyB3YWxrIGJhY2t3YXJkcyB1bnRpbCB3ZSBmaW5kIGEg Z3JlZW4gYnVpbGQKKyAgICAgICAgcmVkX2J1aWxkID0gc2VsZi5idWlsZChyZWRfYnVpbGRfbnVt YmVyKQorICAgICAgICBncmVlbl9idWlsZCA9IE5vbmUKKyAgICAgICAgbG9va19iYWNrX2NvdW50 ID0gMAorICAgICAgICB3aGlsZSBUcnVlOgorICAgICAgICAgICAgaWYgbG9va19iYWNrX2NvdW50 ID49IGxvb2tfYmFja19saW1pdDoKKyAgICAgICAgICAgICAgICBicmVhaworICAgICAgICAgICAg IyBVc2UgYSBwcmV2aW91c19idWlsZCgpIG1ldGhvZCB0byBhdm9pZCBhc3N1bWluZyBidWlsZCBu dW1iZXJzIGFyZSBzZXF1ZW50aWFsLgorICAgICAgICAgICAgYmVmb3JlX3JlZF9idWlsZCA9IHJl ZF9idWlsZC5wcmV2aW91c19idWlsZCgpCisgICAgICAgICAgICBpZiBub3QgYmVmb3JlX3JlZF9i dWlsZDoKKyAgICAgICAgICAgICAgICBicmVhaworICAgICAgICAgICAgaWYgYmVmb3JlX3JlZF9i dWlsZC5pc19ncmVlbigpOgorICAgICAgICAgICAgICAgIGdyZWVuX2J1aWxkID0gYmVmb3JlX3Jl ZF9idWlsZAorICAgICAgICAgICAgICAgIGJyZWFrCisgICAgICAgICAgICByZWRfYnVpbGQgPSBi ZWZvcmVfcmVkX2J1aWxkCisgICAgICAgICAgICBsb29rX2JhY2tfY291bnQgKz0gMQorICAgICAg ICByZXR1cm4gKGdyZWVuX2J1aWxkLCByZWRfYnVpbGQpCisKIAogY2xhc3MgQnVpbGQob2JqZWN0 KToKICAgICBkZWYgX19pbml0X18oc2VsZiwgYnVpbGRfZGljdGlvbmFyeSwgYnVpbGRlcik6CmRp ZmYgLS1naXQgYS9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1hbmRzL3F1ZXJpZXMu cHkgYi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1hbmRzL3F1ZXJpZXMucHkKaW5k ZXggNGQyMDljMi4uZDIzNTYzZiAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJr aXRweS9jb21tYW5kcy9xdWVyaWVzLnB5CisrKyBiL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0 cHkvY29tbWFuZHMvcXVlcmllcy5weQpAQCAtMTE1LDI3ICsxMTUsNiBAQCBhbmQgZGlzcGxheWVz IHRoZSBzdGF0dXMgb2YgZWFjaCBidWlsZGVyLiIiIgogICAgIGRlZiBfbG9uZ2VzdF9idWlsZGVy X25hbWUoc2VsZiwgYnVpbGRlcnMpOgogICAgICAgICByZXR1cm4gbWF4KG1hcChsYW1iZGEgYnVp bGRlcjogbGVuKGJ1aWxkZXJbIm5hbWUiXSksIGJ1aWxkZXJzKSkKIAotICAgICMgRklYTUU6IFRo aXMgc2hvdWxkIG1vdmUgb250byBidWlsZGJvdC5CdWlsZGVyCi0gICAgZGVmIF9maW5kX2dyZWVu X3RvX3JlZF90cmFuc2l0aW9uKHNlbGYsIGJ1aWxkZXJfc3RhdHVzLCBsb29rX2JhY2tfbGltaXQ9 MzApOgotICAgICAgICAjIHdhbGsgYmFja3dhcmRzIHVudGlsIHdlIGZpbmQgYSBncmVlbiBidWls ZAotICAgICAgICBidWlsZGVyID0gc2VsZi50b29sLmJ1aWxkYm90LmJ1aWxkZXJfd2l0aF9uYW1l KGJ1aWxkZXJfc3RhdHVzWyJuYW1lIl0pCi0gICAgICAgIHJlZF9idWlsZCA9IGJ1aWxkZXIuYnVp bGQoYnVpbGRlcl9zdGF0dXNbImJ1aWxkX251bWJlciJdKQotICAgICAgICBncmVlbl9idWlsZCA9 IE5vbmUKLSAgICAgICAgbG9va19iYWNrX2NvdW50ID0gMAotICAgICAgICB3aGlsZSBUcnVlOgot ICAgICAgICAgICAgaWYgbG9va19iYWNrX2NvdW50ID49IGxvb2tfYmFja19saW1pdDoKLSAgICAg ICAgICAgICAgICBicmVhawotICAgICAgICAgICAgIyBVc2UgYSBwcmV2aW91c19idWlsZCgpIG1l dGhvZCB0byBhdm9pZCBhc3N1bWluZyBidWlsZCBudW1iZXJzIGFyZSBzZXF1ZW50aWFsLgotICAg ICAgICAgICAgYmVmb3JlX3JlZF9idWlsZCA9IHJlZF9idWlsZC5wcmV2aW91c19idWlsZCgpCi0g ICAgICAgICAgICBpZiBub3QgYmVmb3JlX3JlZF9idWlsZDoKLSAgICAgICAgICAgICAgICBicmVh awotICAgICAgICAgICAgaWYgYmVmb3JlX3JlZF9idWlsZC5pc19ncmVlbigpOgotICAgICAgICAg ICAgICAgIGdyZWVuX2J1aWxkID0gYmVmb3JlX3JlZF9idWlsZAotICAgICAgICAgICAgICAgIGJy ZWFrCi0gICAgICAgICAgICByZWRfYnVpbGQgPSBiZWZvcmVfcmVkX2J1aWxkCi0gICAgICAgICAg ICBsb29rX2JhY2tfY291bnQgKz0gMQotICAgICAgICByZXR1cm4gKGdyZWVuX2J1aWxkLCByZWRf YnVpbGQpCi0KICAgICBkZWYgX3ByaW50X2J1aWxkZXJfbGluZShzZWxmLCBidWlsZGVyX25hbWUs IG1heF9uYW1lX3dpZHRoLCBzdGF0dXNfbWVzc2FnZSk6CiAgICAgICAgIHByaW50ICIlcyA6ICVz IiAlIChidWlsZGVyX25hbWUubGp1c3QobWF4X25hbWVfd2lkdGgpLCBzdGF0dXNfbWVzc2FnZSkK IApAQCAtMTQ5LDE1ICsxMjgsMTYgQEAgYW5kIGRpc3BsYXllcyB0aGUgc3RhdHVzIG9mIGVhY2gg YnVpbGRlci4iIiIKICAgICAgICAgcHJpbnQgIiAgQ29tbWl0dGVyOiAlcyIgJSBjb21taXRfaW5m by5jb21taXR0ZXIoKQogCiAgICAgZGVmIF9wcmludF9ibGFtZV9pbmZvcm1hdGlvbl9mb3JfYnVp bGRlcihzZWxmLCBidWlsZGVyX3N0YXR1cywgbmFtZV93aWR0aCk6Ci0gICAgICAgIChsYXN0X2dy ZWVuX2J1aWxkLCBmaXJzdF9yZWRfYnVpbGQpID0gc2VsZi5fZmluZF9ncmVlbl90b19yZWRfdHJh bnNpdGlvbihidWlsZGVyX3N0YXR1cykKKyAgICAgICAgYnVpbGRlciA9IHNlbGYudG9vbC5idWls ZGJvdC5idWlsZGVyX3dpdGhfbmFtZShidWlsZGVyX3N0YXR1c1sibmFtZSJdKQorICAgICAgICAo bGFzdF9ncmVlbl9idWlsZCwgZmlyc3RfcmVkX2J1aWxkKSA9IGJ1aWxkZXIuZmluZF9ncmVlbl90 b19yZWRfdHJhbnNpdGlvbihidWlsZGVyX3N0YXR1c1siYnVpbGRfbnVtYmVyIl0pCiAgICAgICAg IGlmIG5vdCBsYXN0X2dyZWVuX2J1aWxkOgotICAgICAgICAgICAgc2VsZi5fcHJpbnRfYnVpbGRl cl9saW5lKGJ1aWxkZXJfc3RhdHVzWyJuYW1lIl0sIG5hbWVfd2lkdGgsICJGQUlMIChibGFtZS1s aXN0OiBzb21ldGltZSBiZWZvcmUgJXM/KSIgJSBmaXJzdF9yZWRfYnVpbGQucmV2aXNpb24oKSkK KyAgICAgICAgICAgIHNlbGYuX3ByaW50X2J1aWxkZXJfbGluZShidWlsZGVyLm5hbWUoKSwgbmFt ZV93aWR0aCwgIkZBSUwgKGJsYW1lLWxpc3Q6IHNvbWV0aW1lIGJlZm9yZSAlcz8pIiAlIGZpcnN0 X3JlZF9idWlsZC5yZXZpc2lvbigpKQogICAgICAgICAgICAgcmV0dXJuCiAKICAgICAgICAgc3Vz cGVjdF9yZXZpc2lvbnMgPSByYW5nZShmaXJzdF9yZWRfYnVpbGQucmV2aXNpb24oKSwgbGFzdF9n cmVlbl9idWlsZC5yZXZpc2lvbigpLCAtMSkKICAgICAgICAgc3VzcGVjdF9yZXZpc2lvbnMucmV2 ZXJzZSgpCiAgICAgICAgICMgRklYTUU6IFBhcnNlIHJldmlld2VyIGFuZCBjb21taXR0ZXIgZnJv bSByZWQgY2hlY2tpbgotICAgICAgICBzZWxmLl9wcmludF9idWlsZGVyX2xpbmUoYnVpbGRlcl9z dGF0dXNbIm5hbWUiXSwgbmFtZV93aWR0aCwgIkZBSUwgKGJsYW1lLWxpc3Q6ICVzKSIgJSBzdXNw ZWN0X3JldmlzaW9ucykKKyAgICAgICAgc2VsZi5fcHJpbnRfYnVpbGRlcl9saW5lKGJ1aWxkZXIu bmFtZSgpLCBuYW1lX3dpZHRoLCAiRkFJTCAoYmxhbWUtbGlzdDogJXMpIiAlIHN1c3BlY3RfcmV2 aXNpb25zKQogICAgICAgICBmb3IgcmV2aXNpb24gaW4gc3VzcGVjdF9yZXZpc2lvbnM6CiAgICAg ICAgICAgICBjb21taXRfaW5mbyA9IENvbW1pdEluZm8uY29tbWl0X2luZm9fZm9yX3JldmlzaW9u KHNlbGYudG9vbC5zY20oKSwgcmV2aXNpb24pCiAgICAgICAgICAgICBzZWxmLl9wcmludF9ibGFt ZV9pbmZvcm1hdGlvbl9mb3JfY29tbWl0KGNvbW1pdF9pbmZvKQo=