36336 2010-03-18 16:43:49 -0700 [v8] Crash if the worker is terminated before its initial script is executed. 2010-03-22 19:22:25 -0700 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 dimich dimich atwilson dglazkov oldest_to_newest 201636 0 dimich 2010-03-18 16:43:49 -0700 TerminateExecution() which happens during v8 initialization will terminate init and return NULL context. Need a check. 201639 1 51111 dimich 2010-03-18 16:53:19 -0700 Created attachment 51111 Patch. I figured out a test for this, but it is a flakey test (because of timing involved). Thankfully, when it hits unfortunate timing, it is a false positive. When it fails, it's a failure. 202047 2 51111 japhet 2010-03-19 14:53:34 -0700 Comment on attachment 51111 Patch. Ok. My only concern is with the (admittedly unavoidable) inherently flaky test. Do you happen to know what the false positive rate is? 202859 3 dimich 2010-03-22 18:11:04 -0700 > My only concern is with the (admittedly unavoidable) inherently flaky test. Do > you happen to know what the false positive rate is? It's fairly 'stable'. The v8 initialization takes ~50ms on a 2.6GHz machine, debug build. The termination request comes right about in the middle of that range at the moment, so I have 100% repro rate on my local Mac. 202897 4 dimich 2010-03-22 19:22:09 -0700 Landed: http://trac.webkit.org/changeset/56375 51111 2010-03-18 16:53:19 -0700 2010-03-19 14:53:34 -0700 Patch. patch.txt text/plain 7135 dimich ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAwNzNhZjc4Li45MzkzMWQxIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTAtMDMt MTggIERtaXRyeSBUaXRvdiAgPGRpbWljaEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW3Y4XSBDcmFzaCBpZiB0aGUgd29ya2Vy IGlzIHRlcm1pbmF0ZWQgYmVmb3JlIGl0cyBpbml0aWFsIHNjcmlwdCBpcyBleGVjdXRlZC4KKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM2MzM2CisKKyAg ICAgICAgKiBmYXN0L3dvcmtlcnMvdGVybWluYXRpb24tZWFybHktZXhwZWN0ZWQudHh0OiBBZGRl ZC4KKyAgICAgICAgKiBmYXN0L3dvcmtlcnMvdGVybWluYXRpb24tZWFybHkuaHRtbDogQWRkZWQu CisKIDIwMTAtMDMtMTggIERhbiBCZXJuc3RlaW4gIDxtaXR6QGFwcGxlLmNvbT4KIAogICAgICAg ICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3Qv d29ya2Vycy90ZXJtaW5hdGlvbi1lYXJseS1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9mYXN0 L3dvcmtlcnMvdGVybWluYXRpb24tZWFybHktZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAw NjQ0CmluZGV4IDAwMDAwMDAuLjg1ZDM5MjEKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0 cy9mYXN0L3dvcmtlcnMvdGVybWluYXRpb24tZWFybHktZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEs NSBAQAorVGhpcyB0ZXN0IHRlcm1pbmF0ZXMgYSB3b3JrZXIgYXQgdGhlIG1vbWVudCBiZWZvcmUg V29ya2VyVGhyZWFkOjp3b3JrZXJUaHJlYWQgc3RhcnRzIGV4ZWN1dGUgdGhlIGluaXRpYWwgc2Ny aXB0LiBUaGlzIHN0YWdlIGluY2x1ZGVzIGluaXRpYWxpemF0aW9uIG9mIHRoZSBzY3JpcHQgZW5n aW5lLCBhbmQgVjggbWF5IGNyYXNoIGlmIHRlcm1pbmF0ZWQgZHVyaW5nIGluaXRpYWxpemF0aW9u LiBUZXN0IHN1Y2NlZWRzIGlmIGl0IGRvZXMgbm90IGhhbmcgb3IgY3Jhc2ggKGlmIHdvcmtlciB0 aHJlYWQgaXMgcnVubmluZyBpbiB0aGUgc2VwYXJhdGUgcHJvY2VzcywgdGhhdCBwcm9jZXNzIGNv dWxkIGhhbmcgb3IgY3Jhc2gpLgorCitUaGlzIHRlc3QgcmVwcm9kdWNlcyBjcmFzaCBzcGVjaWZp YyB0byB2OCBhbmQgbXVsdGktcHJvY2VzcyBDaHJvbWl1bSBhcmNoaXRlY3R1cmUuIEluIGNhc2Ug b2YgSlNDLCB0aGUgdGVzdCBpcyBqdXN0IGFub3RoZXIgb3Bwb3J0dW5pdHkgdG8gZXhlcmNpc2Ug dGhlIFdvcmtlciBjb2RlLgorCitET05FCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L3dv cmtlcnMvdGVybWluYXRpb24tZWFybHkuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3Qvd29ya2Vycy90 ZXJtaW5hdGlvbi1lYXJseS5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAu LjA5YWIyZjIKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L3dvcmtlcnMvdGVy bWluYXRpb24tZWFybHkuaHRtbApAQCAtMCwwICsxLDM2IEBACis8c2NyaXB0PgorZnVuY3Rpb24g dGVzdCgpCit7CisgICAgaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikgeworICAgICAg ICBsYXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0KCk7CisgICAgICAgIGxheW91dFRlc3RD b250cm9sbGVyLndhaXRVbnRpbERvbmUoKTsKKyAgICB9CisKKyAgICB3b3JrZXIgPSBuZXcgV29y a2VyKCJyZXNvdXJjZXMvd29ya2VyLWNvbW1vbi5qcyIpOworCisgICAgLy8gVGhlIHNldFRpbWVv dXQgaXMgZ2VuZXJhbGx5IGEgYmFkIGlkZWEgaW4gdGVzdHMsIGJ1dCB0aGlzIG9uZSBpcyBoZXJl IGJlY2F1c2UgdGhlIHRlc3QgaXMgdHJ5aW5nIHRvIGNhbGwgdGVybWluYXRlKCkgaW4gdGhlIHRp bWUKKyAgICAvLyB3aW5kb3cgYWZ0ZXIgbG9hZGluZyB0aGUgd29ya2VyJ3Mgc2NyaXB0IChhbmQg Y3JlYXRpb24gb2Ygd29ya2VyIHByb2Nlc3MgaW4gY2FzZSBvZiBDaHJvbWl1bSkgYnV0IGJlZm9y ZSB0aGUgaW5pdGlhbCBzY3JpcHQgaXMgZXhlY3V0ZWQuCisgICAgLy8gVGhlIGNyYXNoIGhhcHBl bmVkIHdoZW4gSlMgZW5naW5lIGluIHdvcmtlciBpcyBpbml0aWFsaXplZCwgc28gdGhlIHRpbWVv dXQgaGVyZSBpcyBhcHByb3hpbWF0ZS4gSlMgaW5pdGlhbGl6YXRpb24gaW4gQ2hyb21pdW0gY2Fz ZQorICAgIC8vIGlzIHF1aXRlIGxvbmcgZm9yIHRoZSBwcm9jZXNzLXdpZGUgaW5zdGFuY2Ugb2Yg VjgsIGVzcGVjaWFsbHkgaW4gZGVidWcgYnVpbGRzIC0gc28gdGhpcyB0ZXN0IGhpdHMgdGhlIGNy YXNoIHF1aXRlIG9mdGVuLgorICAgIC8vIFRoZSB0ZXN0IGlzIGluaGVyZW50bHkgZmxha2V5IGJl Y2F1c2Ugb2YgaXQgYnV0IG9uIGEgJ2ZhbHNlIHBvc2l0aXZlJyBzaWRlLCBtZWFuaW5nIGlmIHRo ZSB0aW1lb3V0IGlzIG5vdCBlbm91Z2ggdGhlIHRlc3QgaXMgU1VDQ0VTUworICAgIC8vIHNvIHRo ZXJlIGFyZSBubyBhbm5veWluZyBmYWlsdXJlcy4KKyAgICBzZXRUaW1lb3V0KGNvbnRpbnVlVGVz dCwgMTAwKTsKK30KKworZnVuY3Rpb24gY29udGludWVUZXN0KCkgeworICAgIC8vIFRoZXNlIG1l c3NhZ2VzIGFyZSB0byBsZXQgV29ya2VyVGhyZWFkOjp3b3JrZXJUaHJlYWQgZ28gcGFzdCB0aGUg cG9pbnQgb2YgY2hlY2tpbmcgZm9yIHRlcm1pbmF0aW9uIGFuZCBzdGFydCBpbml0aWFsaXphdGlv bi4KKyAgICAvLyBTaW5jZSBpdCB0YWtlcyB0aW1lIGZvciB0aGVzZSBtZXNzYWdlcyB0byBiZSBx dWV1ZWQsIHRoZSB0ZXJtaW5hdGlvbiBtZXNzYWdlIGlzIHJlYWNoaW5nIHRoZSBXb3JrZXJUaHJl YWQgd2hlbiBpdCBpcyBhbHJlYWR5IGluIFY4IGNvZGUuCisgICAgZm9yIChpID0gMDsgaSA8IDEw MDA7IGkrKykKKyAgICAgICAgd29ya2VyLnBvc3RNZXNzYWdlKCJ5YWRhIHlhZGEiKTsKKworICAg IHdvcmtlci50ZXJtaW5hdGUoKTsKKyAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgicmVzdWx0 IikuaW5uZXJUZXh0ID0gIkRPTkUiOworICAgIGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xs ZXIpCisgICAgICAgIGxheW91dFRlc3RDb250cm9sbGVyLm5vdGlmeURvbmUoKTsKK30KKzwvc2Ny aXB0PgorPGJvZHkgb25sb2FkPXRlc3QoKT4KKzxwPlRoaXMgdGVzdCB0ZXJtaW5hdGVzIGEgd29y a2VyIGF0IHRoZSBtb21lbnQgYmVmb3JlIFdvcmtlclRocmVhZDo6d29ya2VyVGhyZWFkIHN0YXJ0 cyBleGVjdXRlIHRoZSBpbml0aWFsIHNjcmlwdC4gVGhpcyBzdGFnZSBpbmNsdWRlcyBpbml0aWFs aXphdGlvbiBvZiB0aGUgc2NyaXB0IGVuZ2luZSwgYW5kIFY4IG1heSBjcmFzaCBpZiB0ZXJtaW5h dGVkIGR1cmluZyBpbml0aWFsaXphdGlvbi4gVGVzdCBzdWNjZWVkcyBpZiBpdCBkb2VzIG5vdCBo YW5nIG9yIGNyYXNoIChpZiB3b3JrZXIgdGhyZWFkIGlzIHJ1bm5pbmcgaW4gdGhlIHNlcGFyYXRl IHByb2Nlc3MsIHRoYXQgcHJvY2VzcyBjb3VsZCBoYW5nIG9yIGNyYXNoKS48L3A+Cis8cD5UaGlz IHRlc3QgcmVwcm9kdWNlcyBjcmFzaCBzcGVjaWZpYyB0byB2OCBhbmQgbXVsdGktcHJvY2VzcyBD aHJvbWl1bSBhcmNoaXRlY3R1cmUuIEluIGNhc2Ugb2YgSlNDLCB0aGUgdGVzdCBpcyBqdXN0IGFu b3RoZXIgb3Bwb3J0dW5pdHkgdG8gZXhlcmNpc2UgdGhlIFdvcmtlciBjb2RlLjwvcD4KKzxwcmUg aWQ9InJlc3VsdCI+PC9wcmU+Cis8L2JvZHk+CmRpZmYgLS1naXQgYS9XZWJDb3JlL0NoYW5nZUxv ZyBiL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IGJmNDE4ZmQuLjcwZGMxNTIgMTAwNjQ0Ci0tLSBh L1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTAtMDMtMTggIERtaXRyeSBUaXRvdiAgPGRpbWljaEBjaHJvbWl1bS5vcmc+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW3Y4XSBDcmFzaCBp ZiB0aGUgd29ya2VyIGlzIHRlcm1pbmF0ZWQgYmVmb3JlIGl0cyBpbml0aWFsIHNjcmlwdCBpcyBl eGVjdXRlZC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTM2MzM2CisKKyAgICAgICAgVGVzdDogZmFzdC93b3JrZXJzL3Rlcm1pbmF0aW9uLWVhcmx5Lmh0 bWwKKworICAgICAgICAqIGJpbmRpbmdzL3Y4L1dvcmtlckNvbnRleHRFeGVjdXRpb25Qcm94eS5j cHA6CisgICAgICAgIChXZWJDb3JlOjpXb3JrZXJDb250ZXh0RXhlY3V0aW9uUHJveHk6OmluaXRD b250ZXh0SWZOZWVkZWQpOiBDaGVjayBmb3IgMCBjb250ZXh0LiBXaGVuIHRlcm1pbmF0ZWQsIHRo ZSB2OCBoZWFwIGluaXRpYWxpemF0aW9uIHJldHVybnMgMC4KKyAgICAgICAgKFdlYkNvcmU6Oldv cmtlckNvbnRleHRFeGVjdXRpb25Qcm94eTo6ZXZhbHVhdGUpOiBEb24ndCBleGVjdXRlIHNjcmlw dCBpZiBpbml0aWFsaXphdGlvbiBmYWlsZWQuCisgICAgICAgICogYmluZGluZ3MvdjgvV29ya2Vy Q29udGV4dEV4ZWN1dGlvblByb3h5Lmg6CisKIDIwMTAtMDMtMTggIERhcmluIEFkbGVyICA8ZGFy aW5AYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEtlbm5ldGggUm9oZGUgQ2hyaXN0 aWFuc2VuLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9iaW5kaW5ncy92OC9Xb3JrZXJDb250ZXh0RXhl Y3V0aW9uUHJveHkuY3BwIGIvV2ViQ29yZS9iaW5kaW5ncy92OC9Xb3JrZXJDb250ZXh0RXhlY3V0 aW9uUHJveHkuY3BwCmluZGV4IDNlZDkyNmMuLjZiN2UzMDggMTAwNjQ0Ci0tLSBhL1dlYkNvcmUv YmluZGluZ3MvdjgvV29ya2VyQ29udGV4dEV4ZWN1dGlvblByb3h5LmNwcAorKysgYi9XZWJDb3Jl L2JpbmRpbmdzL3Y4L1dvcmtlckNvbnRleHRFeGVjdXRpb25Qcm94eS5jcHAKQEAgLTEyMSwxOCAr MTIxLDIxIEBAIHZvaWQgV29ya2VyQ29udGV4dEV4ZWN1dGlvblByb3h5Ojppbml0VjhJZk5lZWRl ZCgpCiAgICAgdjhJbml0aWFsaXplZCA9IHRydWU7CiB9CiAKLXZvaWQgV29ya2VyQ29udGV4dEV4 ZWN1dGlvblByb3h5Ojppbml0Q29udGV4dElmTmVlZGVkKCkKK2Jvb2wgV29ya2VyQ29udGV4dEV4 ZWN1dGlvblByb3h5Ojppbml0Q29udGV4dElmTmVlZGVkKCkKIHsKICAgICAvLyBCYWlsIG91dCBp ZiB0aGUgY29udGV4dCBoYXMgYWxyZWFkeSBiZWVuIGluaXRpYWxpemVkLgogICAgIGlmICghbV9j b250ZXh0LklzRW1wdHkoKSkKLSAgICAgICAgcmV0dXJuOworICAgICAgICByZXR1cm4gdHJ1ZTsK IAogICAgIC8vIENyZWF0ZSBhIG5ldyBlbnZpcm9ubWVudAogICAgIHY4OjpQZXJzaXN0ZW50PHY4 OjpPYmplY3RUZW1wbGF0ZT4gZ2xvYmFsVGVtcGxhdGU7CiAgICAgbV9jb250ZXh0ID0gdjg6OkNv bnRleHQ6Ok5ldygwLCBnbG9iYWxUZW1wbGF0ZSk7CisgICAgaWYgKG1fY29udGV4dC5Jc0VtcHR5 KCkpCisgICAgICAgIHJldHVybiBmYWxzZTsKIAogICAgIC8vIFN0YXJ0aW5nIGZyb20gbm93LCB1 c2UgbG9jYWwgY29udGV4dCBvbmx5LgogICAgIHY4OjpMb2NhbDx2ODo6Q29udGV4dD4gY29udGV4 dCA9IHY4OjpMb2NhbDx2ODo6Q29udGV4dD46Ok5ldyhtX2NvbnRleHQpOworCiAgICAgdjg6OkNv bnRleHQ6OlNjb3BlIHNjb3BlKGNvbnRleHQpOwogCiAgICAgLy8gQWxsb2NhdGUgc3RyaW5ncyB1 c2VkIGR1cmluZyBpbml0aWFsaXphdGlvbi4KQEAgLTE0OSw3ICsxNTIsNyBAQCB2b2lkIFdvcmtl ckNvbnRleHRFeGVjdXRpb25Qcm94eTo6aW5pdENvbnRleHRJZk5lZWRlZCgpCiAgICAgLy8gQmFp bCBvdXQgaWYgYWxsb2NhdGlvbiBmYWlsZWQuCiAgICAgaWYgKGpzV29ya2VyQ29udGV4dC5Jc0Vt cHR5KCkpIHsKICAgICAgICAgZGlzcG9zZSgpOwotICAgICAgICByZXR1cm47CisgICAgICAgIHJl dHVybiBmYWxzZTsKICAgICB9CiAKICAgICAvLyBXcmFwIHRoZSBvYmplY3QuCkBAIC0xNjEsNiAr MTY0LDcgQEAgdm9pZCBXb3JrZXJDb250ZXh0RXhlY3V0aW9uUHJveHk6OmluaXRDb250ZXh0SWZO ZWVkZWQoKQogICAgIC8vIEluc2VydCB0aGUgb2JqZWN0IGluc3RhbmNlIGFzIHRoZSBwcm90b3R5 cGUgb2YgdGhlIHNoYWRvdyBvYmplY3QuCiAgICAgdjg6OkhhbmRsZTx2ODo6T2JqZWN0PiBnbG9i YWxPYmplY3QgPSBtX2NvbnRleHQtPkdsb2JhbCgpOwogICAgIGdsb2JhbE9iamVjdC0+U2V0KGlt cGxpY2l0UHJvdG9TdHJpbmcsIGpzV29ya2VyQ29udGV4dCk7CisgICAgcmV0dXJuIHRydWU7CiB9 CiAKIGJvb2wgV29ya2VyQ29udGV4dEV4ZWN1dGlvblByb3h5Ojpmb3JnZXRWOEV2ZW50T2JqZWN0 KEV2ZW50KiBldmVudCkKQEAgLTE3Niw3ICsxODAsOSBAQCBTY3JpcHRWYWx1ZSBXb3JrZXJDb250 ZXh0RXhlY3V0aW9uUHJveHk6OmV2YWx1YXRlKGNvbnN0IFN0cmluZyYgc2NyaXB0LCBjb25zdCBT dAogewogICAgIHY4OjpIYW5kbGVTY29wZSBoczsKIAotICAgIGluaXRDb250ZXh0SWZOZWVkZWQo KTsKKyAgICBpZiAoIWluaXRDb250ZXh0SWZOZWVkZWQoKSkKKyAgICAgICAgcmV0dXJuIFNjcmlw dFZhbHVlKCk7CisKICAgICB2ODo6Q29udGV4dDo6U2NvcGUgc2NvcGUobV9jb250ZXh0KTsKIAog ICAgIHY4OjpUcnlDYXRjaCBleGNlcHRpb25DYXRjaGVyOwpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9i aW5kaW5ncy92OC9Xb3JrZXJDb250ZXh0RXhlY3V0aW9uUHJveHkuaCBiL1dlYkNvcmUvYmluZGlu Z3MvdjgvV29ya2VyQ29udGV4dEV4ZWN1dGlvblByb3h5LmgKaW5kZXggYjZjMTk5NC4uMTk3ZDMx OCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9iaW5kaW5ncy92OC9Xb3JrZXJDb250ZXh0RXhlY3V0aW9u UHJveHkuaAorKysgYi9XZWJDb3JlL2JpbmRpbmdzL3Y4L1dvcmtlckNvbnRleHRFeGVjdXRpb25Q cm94eS5oCkBAIC03OSw3ICs3OSw3IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogICAgIHByaXZh dGU6CiAgICAgICAgIHZvaWQgaW5pdFY4SWZOZWVkZWQoKTsKLSAgICAgICAgdm9pZCBpbml0Q29u dGV4dElmTmVlZGVkKCk7CisgICAgICAgIGJvb2wgaW5pdENvbnRleHRJZk5lZWRlZCgpOwogICAg ICAgICB2b2lkIGRpc3Bvc2UoKTsKIAogICAgICAgICAvLyBSdW4gYW4gYWxyZWFkeSBjb21waWxl ZCBzY3JpcHQuCg==