3633 2005-06-21 05:38:37 -0700 Layout order of bidi level runs is incorrect 2005-11-04 00:30:48 -0800 1 1 1 Unclassified WebKit Layout and Rendering 412 Mac OS X 10.4 CLOSED FIXED P2 Normal --- 1 mitz darin bugs.mano oldest_to_newest 12790 0 mitz 2005-06-21 05:38:37 -0700 [Note: this issue was previously covered by bug 3599 ]. Summary: The final layout order of text runs with different bidi embedding levels is incorrect. To Reproduce: See testcase. Expected/Actual: Testcase includes a description of expected rendering. Firefox renders as expected. WebKit renders the first (leftmost) box as expected, the second and third boxes are broken in different ways. Analysis: bidiReorderLine ()'s implementation of rule L2 of the Unicode bidi algorithm is broken for lines where the embedding levels aren't unimodal (the index variable is advancing too fast). 12791 1 2530 mitz 2005-06-21 05:41:26 -0700 Created attachment 2530 testcase 12793 2 2531 mitz 2005-06-21 05:55:31 -0700 Created attachment 2531 Proposed fix 12796 3 2531 darin 2005-06-21 08:47:50 -0700 Comment on attachment 2531 Proposed fix Patch looks fine. Clearly we should remove the bogus if statement too, since it does the same thing the while loop already does. This test case will work as a layout test too, which is great. r=me 12801 4 2535 mitz 2005-06-21 10:21:56 -0700 Created attachment 2535 Proposed fix Removed the unnecessary if statement. 2530 2005-06-21 05:41:26 -0700 2005-06-21 05:41:26 -0700 testcase L2runReordering.html text/html 663 mitz PCFET0NUWVBFIEhUTUwgUFVCTElDICItLy9XM0MvL0RURCBIVE1MIDQuMDEgVHJhbnNpdGlvbmFs Ly9FTiIgCiJodHRwOi8vd3d3LnczLm9yZy9UUi9odG1sNC9sb29zZS5kdGQiPgo8aHRtbD4NCjxo ZWFkPg0KPHRpdGxlPkwyIHJ1biByZW9yZGVyaW5nIGJ1ZzwvdGl0bGU+DQo8L2hlYWQ+DQo8Ym9k eT4KPHA+ClRoZSB0aHJlZSBib3hlcyBzaG91bGQgYmUgdGhlIHNhbWUuIFRoZSBvcmRlciBpbiBl YWNoCmJveCBzaG91bGQgYmU6IFJvbWFuIGxldHRlcnMsIEhlYnJldyBsZXR0ZXJzLCBkaWdpdHMs IEhlYnJldyBsZXR0ZXJzLCBSb21hbgpsZXR0ZXJzLgo8L3A+CjxwPgo8c3BhbiBzdHlsZT0iYm9y ZGVyOmdyZWVuIDFweCBzb2xpZDsiPmFiYyAmI3gwNWQwOyYjeDA1ZDE7JiN4MDVkMjsgMTIzICYj eDA1ZDM7JiN4MDVkNDsmI3gwNWQ1OyBkZWY8L3NwYW4+CjxzcGFuIHN0eWxlPSJib3JkZXI6Z3Jl ZW4gMXB4IHNvbGlkOyI+YWJjICYjeDA1ZDA7JiN4MDVkMTsmI3gwNWQyOyAxMjMgJiN4MDVkMzsm I3gwNWQ0OyYjeDA1ZDU7IGRlZjwvc3Bhbj4KPHNwYW4gc3R5bGU9ImJvcmRlcjpncmVlbiAxcHgg c29saWQ7Ij5hYmMgJiN4MDVkMDsmI3gwNWQxOyYjeDA1ZDI7IDEyMyAmI3gwNWQzOyYjeDA1ZDQ7 JiN4MDVkNTsgZGVmPC9zcGFuPgo8L2JvZHk+CjwvaHRtbD4K 2531 2005-06-21 05:55:31 -0700 2005-06-21 10:21:56 -0700 Proposed fix 366_patch_r1.txt text/plain 523 mitz SW5kZXg6IGJpZGkuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9jdnMvcm9vdC9XZWJDb3JlL2to dG1sL3JlbmRlcmluZy9iaWRpLmNwcCx2CnJldHJpZXZpbmcgcmV2aXNpb24gMS4xMjcKZGlmZiAt cCAtdSAtcjEuMTI3IGJpZGkuY3BwCi0tLSBiaWRpLmNwcAkyMDA1LzA1LzI3IDAxOjE3OjMyCTEu MTI3CisrKyBiaWRpLmNwcAkyMDA1LzA2LzIxIDEyOjU1OjIzCkBAIC0xMjg4LDcgKzEyODgsNiBA QCB2b2lkIFJlbmRlckJsb2NrOjpiaWRpUmVvcmRlckxpbmUoY29uc3QgCiAgICAgICAgICAgICAg ICAgfQogICAgICAgICAgICAgICAgIGludCBlbmQgPSBpLTE7CiAgICAgICAgICAgICAgICAgcmV2 ZXJzZVJ1bnMoc3RhcnQsIGVuZCk7Ci0gICAgICAgICAgICAgICAgaSsrOwogICAgICAgICAgICAg ICAgIGlmKGkgPj0gY291bnQpIGJyZWFrOwogICAgICAgICAgICAgfQogICAgICAgICAgICAgbGV2 ZWxIaWdoLS07Cg== 2535 2005-06-21 10:21:56 -0700 2005-06-21 10:28:29 -0700 Proposed fix 3633_patch_r2.txt text/plain 534 mitz SW5kZXg6IGJpZGkuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9jdnMvcm9vdC9XZWJDb3JlL2to dG1sL3JlbmRlcmluZy9iaWRpLmNwcCx2CnJldHJpZXZpbmcgcmV2aXNpb24gMS4xMjcKZGlmZiAt cCAtdSAtcjEuMTI3IGJpZGkuY3BwCi0tLSBiaWRpLmNwcAkyMDA1LzA1LzI3IDAxOjE3OjMyCTEu MTI3CisrKyBiaWRpLmNwcAkyMDA1LzA2LzIxIDE3OjE3OjI1CkBAIC0xMjg4LDggKzEyODgsNiBA QCB2b2lkIFJlbmRlckJsb2NrOjpiaWRpUmVvcmRlckxpbmUoY29uc3QgCiAgICAgICAgICAgICAg ICAgfQogICAgICAgICAgICAgICAgIGludCBlbmQgPSBpLTE7CiAgICAgICAgICAgICAgICAgcmV2 ZXJzZVJ1bnMoc3RhcnQsIGVuZCk7Ci0gICAgICAgICAgICAgICAgaSsrOwotICAgICAgICAgICAg ICAgIGlmKGkgPj0gY291bnQpIGJyZWFrOwogICAgICAgICAgICAgfQogICAgICAgICAgICAgbGV2 ZWxIaWdoLS07CiAgICAgICAgIH0K