36324 2010-03-18 14:31:27 -0700 new-run-webkit-tests needs to be able to find Chromium baselines upstream as well as downstream 2010-03-18 15:45:36 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 dpranke dpranke dglazkov victorw oldest_to_newest 201562 0 dpranke 2010-03-18 14:31:27 -0700 We are getting ready to land all of the Chromium LayoutTest baselines upstream, and so we need to modify the new-run-webkit-tests infrastructure to look for them upstream as well as downstream (downstream expectations trump upstream ones). 201563 1 51094 dpranke 2010-03-18 14:34:01 -0700 Created attachment 51094 Patch 201572 2 51094 ojan 2010-03-18 14:46:55 -0700 Comment on attachment 51094 Patch Please put in FIXMEs to remove the chromium_baseline_path calls once the baselines are all moved upstream. Otherwise, lgtm. 201591 3 dpranke 2010-03-18 15:22:39 -0700 (In reply to comment #2) > (From update of attachment 51094 [details]) > Please put in FIXMEs to remove the chromium_baseline_path calls once the > baselines are all moved upstream. Otherwise, lgtm. I'm not actually 100% sure that we won't want to keep the downstream paths around in case we need to (temporarily) check in downstream baselines. But, it's probably safer for the gardeners if we don't make this possible out of the gate, so I will do as you say. We can always add this back in if we need it. 201600 4 51094 dglazkov 2010-03-18 15:38:27 -0700 Comment on attachment 51094 Patch rs=me. 201609 5 dpranke 2010-03-18 15:45:36 -0700 Committed r56199: <http://trac.webkit.org/changeset/56199> 51094 2010-03-18 14:34:01 -0700 2010-03-18 15:38:26 -0700 Patch bug-36324-20100318143400.patch text/plain 3999 dpranke ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBmYjZiMTdjLi5kOWM1YjE4IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTAtMDMt MTggIERpcmsgUHJhbmtlICA8ZHByYW5rZUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIHVwc3RyZWFtIExheW91dFRlc3Rz L3BsYXRmb3JtL2Nocm9taXVtKiBkaXJlY3RvcmllcyB0byB0aGUKKyAgICAgICAgYmFzZWxpbmUg c2VhcmNoIHBhdGggZm9yIG5ldy1ydW4td2Via2l0LXRlc3RzIGluIHByZXBhcmF0aW9uIGZvcgor ICAgICAgICB1cHN0cmVhbWluZyBhbGwgb2YgdGhlIENocm9taXVtIGJhc2VsaW5lcy4gTm90ZSB0 aGF0IHRoaXMgZG9lcworICAgICAgICBub3QgYWN0dWFsbHkgY3JlYXRlIHRoZSBkaXJlY3Rvcmll cyB0aGVtc2VsdmVzLCBidXQgdGhhdCdzIG9rYXkuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM2MzI0CisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtp dHB5L2xheW91dF90ZXN0cy9wb3J0L2Nocm9taXVtX2xpbnV4LnB5OgorICAgICAgICAqIFNjcmlw dHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvY2hyb21pdW1fbWFjLnB5OgorICAgICAgICAq IFNjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvY2hyb21pdW1fd2luLnB5OgorCiAy MDEwLTAzLTE3ICBEaXJrIFByYW5rZSAgPGRwcmFua2VAY2hyb21pdW0ub3JnPgogCiAgICAgICAg IFJldmlld2VkIGJ5IERpbWl0cmkgR2xhemtvdi4KZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1Nj cmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvY2hyb21pdW1fbGludXgucHkgYi9XZWJL aXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2Nocm9taXVtX2xpbnV4 LnB5CmluZGV4IGUxNDdiZmQuLmEzY2UxNWYgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL1Njcmlw dHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvY2hyb21pdW1fbGludXgucHkKKysrIGIvV2Vi S2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9jaHJvbWl1bV9saW51 eC5weQpAQCAtNTEsOCArNTEsMTEgQEAgY2xhc3MgQ2hyb21pdW1MaW51eFBvcnQoY2hyb21pdW0u Q2hyb21pdW1Qb3J0KToKICAgICAgICAgY2hyb21pdW0uQ2hyb21pdW1Qb3J0Ll9faW5pdF9fKHNl bGYsIHBvcnRfbmFtZSwgb3B0aW9ucykKIAogICAgIGRlZiBiYXNlbGluZV9zZWFyY2hfcGF0aChz ZWxmKToKLSAgICAgICAgcmV0dXJuIFtzZWxmLmJhc2VsaW5lX3BhdGgoKSwKKyAgICAgICAgcmV0 dXJuIFtzZWxmLl9jaHJvbWl1bV9iYXNlbGluZV9wYXRoKCdjaHJvbWl1bS1saW51eCcpLAogICAg ICAgICAgICAgICAgIHNlbGYuX2Nocm9taXVtX2Jhc2VsaW5lX3BhdGgoJ2Nocm9taXVtLXdpbicp LAorICAgICAgICAgICAgICAgIHNlbGYuX3dlYmtpdF9iYXNlbGluZV9wYXRoKCdjaHJvbWl1bS1s aW51eCcpLAorICAgICAgICAgICAgICAgIHNlbGYuX3dlYmtpdF9iYXNlbGluZV9wYXRoKCdjaHJv bWl1bS13aW4nKSwKKyAgICAgICAgICAgICAgICBzZWxmLl93ZWJraXRfYmFzZWxpbmVfcGF0aCgn Y2hyb21pdW0nKSwKICAgICAgICAgICAgICAgICBzZWxmLl93ZWJraXRfYmFzZWxpbmVfcGF0aCgn d2luJyksCiAgICAgICAgICAgICAgICAgc2VsZi5fd2Via2l0X2Jhc2VsaW5lX3BhdGgoJ21hYycp XQogCmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0 cy9wb3J0L2Nocm9taXVtX21hYy5weSBiL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5 b3V0X3Rlc3RzL3BvcnQvY2hyb21pdW1fbWFjLnB5CmluZGV4IGY2NDkwMDEuLjRkY2JiY2EgMTAw NjQ0Ci0tLSBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQv Y2hyb21pdW1fbWFjLnB5CisrKyBiL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0 X3Rlc3RzL3BvcnQvY2hyb21pdW1fbWFjLnB5CkBAIC01MSw3ICs1MSw5IEBAIGNsYXNzIENocm9t aXVtTWFjUG9ydChjaHJvbWl1bS5DaHJvbWl1bVBvcnQpOgogICAgICAgICBjaHJvbWl1bS5DaHJv bWl1bVBvcnQuX19pbml0X18oc2VsZiwgcG9ydF9uYW1lLCBvcHRpb25zKQogCiAgICAgZGVmIGJh c2VsaW5lX3NlYXJjaF9wYXRoKHNlbGYpOgotICAgICAgICByZXR1cm4gW3NlbGYuYmFzZWxpbmVf cGF0aCgpLAorICAgICAgICByZXR1cm4gW3NlbGYuX2Nocm9taXVtX2Jhc2VsaW5lX3BhdGgoJ2No cm9taXVtLW1hYycpLAorICAgICAgICAgICAgICAgIHNlbGYuX3dlYmtpdF9iYXNlbGluZV9wYXRo KCdjaHJvbWl1bS1tYWMnKSwKKyAgICAgICAgICAgICAgICBzZWxmLl93ZWJraXRfYmFzZWxpbmVf cGF0aCgnY2hyb21pdW0nKSwKICAgICAgICAgICAgICAgICBzZWxmLl93ZWJraXRfYmFzZWxpbmVf cGF0aCgnbWFjJyArIHNlbGYudmVyc2lvbigpKSwKICAgICAgICAgICAgICAgICBzZWxmLl93ZWJr aXRfYmFzZWxpbmVfcGF0aCgnbWFjJyldCiAKZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1Njcmlw dHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvY2hyb21pdW1fd2luLnB5IGIvV2ViS2l0VG9v bHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9jaHJvbWl1bV93aW4ucHkKaW5k ZXggNmQ5ZDEyMC4uNzk4MjkxNCAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJr aXRweS9sYXlvdXRfdGVzdHMvcG9ydC9jaHJvbWl1bV93aW4ucHkKKysrIGIvV2ViS2l0VG9vbHMv U2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9jaHJvbWl1bV93aW4ucHkKQEAgLTU0 LDEwICs1NCwxNiBAQCBjbGFzcyBDaHJvbWl1bVdpblBvcnQoY2hyb21pdW0uQ2hyb21pdW1Qb3J0 KToKICAgICBkZWYgYmFzZWxpbmVfc2VhcmNoX3BhdGgoc2VsZik6CiAgICAgICAgIGRpcnMgPSBb XQogICAgICAgICBpZiBzZWxmLl9uYW1lID09ICdjaHJvbWl1bS13aW4teHAnOgotICAgICAgICAg ICAgZGlycy5hcHBlbmQoc2VsZi5fY2hyb21pdW1fYmFzZWxpbmVfcGF0aChzZWxmLl9uYW1lKSkK KyAgICAgICAgICAgIGRpcnMuYXBwZW5kKHNlbGYuX2Nocm9taXVtX2Jhc2VsaW5lX3BhdGgoJ2No cm9taXVtLXdpbi14cCcpKQogICAgICAgICBpZiBzZWxmLl9uYW1lIGluICgnY2hyb21pdW0td2lu LXhwJywgJ2Nocm9taXVtLXdpbi12aXN0YScpOgogICAgICAgICAgICAgZGlycy5hcHBlbmQoc2Vs Zi5fY2hyb21pdW1fYmFzZWxpbmVfcGF0aCgnY2hyb21pdW0td2luLXZpc3RhJykpCiAgICAgICAg IGRpcnMuYXBwZW5kKHNlbGYuX2Nocm9taXVtX2Jhc2VsaW5lX3BhdGgoJ2Nocm9taXVtLXdpbicp KQorICAgICAgICBpZiBzZWxmLl9uYW1lID09ICdjaHJvbWl1bS13aW4teHAnOgorICAgICAgICAg ICAgZGlycy5hcHBlbmQoc2VsZi5fd2Via2l0X2Jhc2VsaW5lX3BhdGgoJ2Nocm9taXVtLXdpbi14 cCcpKQorICAgICAgICBpZiBzZWxmLl9uYW1lIGluICgnY2hyb21pdW0td2luLXhwJywgJ2Nocm9t aXVtLXdpbi12aXN0YScpOgorICAgICAgICAgICAgZGlycy5hcHBlbmQoc2VsZi5fd2Via2l0X2Jh c2VsaW5lX3BhdGgoJ2Nocm9taXVtLXdpbi12aXN0YScpKQorICAgICAgICBkaXJzLmFwcGVuZChz ZWxmLl93ZWJraXRfYmFzZWxpbmVfcGF0aCgnY2hyb21pdW0td2luJykpCisgICAgICAgIGRpcnMu YXBwZW5kKHNlbGYuX3dlYmtpdF9iYXNlbGluZV9wYXRoKCdjaHJvbWl1bScpKQogICAgICAgICBk aXJzLmFwcGVuZChzZWxmLl93ZWJraXRfYmFzZWxpbmVfcGF0aCgnd2luJykpCiAgICAgICAgIGRp cnMuYXBwZW5kKHNlbGYuX3dlYmtpdF9iYXNlbGluZV9wYXRoKCdtYWMnKSkKICAgICAgICAgcmV0 dXJuIGRpcnMK