36318 2010-03-18 12:39:35 -0700 QtLauncher doesn't start when using Qt/QWS 2010-03-22 15:56:40 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 agbakken webkit-unassigned commit-queue eric hausmann oldest_to_newest 201473 0 agbakken 2010-03-18 12:39:35 -0700 Qt/QWS apps need to run as GuiServer when running standalone. The app needs to either pass -qws or pass QApplication::GuiServer to the QApplication constructor. 201482 1 51074 agbakken 2010-03-18 12:49:31 -0700 Created attachment 51074 This patch fixes the bug #36318 201498 2 hausmann 2010-03-18 13:02:53 -0700 No objection from me, just curious: Why not pass -qws on the commandline? Or is that a recently changing trend in qws apps to not require it anymore but instead use this flag? 201499 3 51074 hausmann 2010-03-18 13:03:36 -0700 Comment on attachment 51074 This patch fixes the bug #36318 > LauncherApplication::LauncherApplication(int& argc, char** argv) > - : QApplication(argc, argv) > + : QApplication(argc, argv > +#ifdef Q_WS_QWS > + , QApplication::GuiServer > +#endif > + ) > , m_isRobotized(false) > { Is the #ifdef worth it? Why not always pass GuiServer? 201521 4 agbakken 2010-03-18 13:36:43 -0700 (In reply to comment #2) > No objection from me, just curious: Why not pass -qws on the commandline? Or is > that a recently changing trend in qws apps to not require it anymore but > instead use this flag? Mostly because I didn't easily understand how to add arguments to the scripts that run the launcher (webkit-tests etc). It seemed like it requires hacking perl code. 201524 5 agbakken 2010-03-18 13:37:58 -0700 (In reply to comment #3) > (From update of attachment 51074 [details]) > > > LauncherApplication::LauncherApplication(int& argc, char** argv) > > - : QApplication(argc, argv) > > + : QApplication(argc, argv > > +#ifdef Q_WS_QWS > > + , QApplication::GuiServer > > +#endif > > + ) > > , m_isRobotized(false) > > { > > Is the #ifdef worth it? Why not always pass GuiServer? No reason. I am fine with changing that. It's a noop on desktop anyway. 201527 6 51086 agbakken 2010-03-18 13:40:08 -0700 Created attachment 51086 Updated patch for 36318 201546 7 51086 hausmann 2010-03-18 13:57:32 -0700 Comment on attachment 51086 Updated patch for 36318 Thanks Anders :) 201704 8 51086 commit-queue 2010-03-18 22:28:01 -0700 Comment on attachment 51086 Updated patch for 36318 Rejecting patch 51086 from commit-queue. Found no modified ChangeLogs, cannot create a commit message. All changes require a ChangeLog. See: http://webkit.org/coding/contributing.html 201751 9 hausmann 2010-03-19 00:20:26 -0700 Committed r56222: <http://trac.webkit.org/changeset/56222> 202697 10 eric 2010-03-22 12:35:07 -0700 @simon: There was a bug in the ChangeLog, which is why the queue rejected it. You didn't correct it when you landed either. :( double >> in the date line. 202813 11 hausmann 2010-03-22 15:56:40 -0700 (In reply to comment #10) > @simon: > > There was a bug in the ChangeLog, which is why the queue rejected it. You > didn't correct it when you landed either. :( > > double >> in the date line. Oops! Indeed, the name appeared twice with too many angle brackets. Fixed up in r56364. /me bows low to the bot and his/her master 51074 2010-03-18 12:49:31 -0700 2010-03-19 00:15:14 -0700 This patch fixes the bug #36318 patch.36318 text/plain 1159 agbakken LS0tIFdlYktpdFRvb2xzL0NoYW5nZUxvZwkocmV2aXNpb24gNTYxODApCisrKyBXZWJLaXRUb29s cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNiBAQAorMjAxMC0wMy0xOCAg QW5kZXJzIEJha2tlbiAgPEFuZGVycyBCYWtrZW4gPGFnYmFra2VuQGdtYWlsLmNvbT4+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM2MzE4CisKKyAgICAgICAgUXRMYXVuY2hlciBy dW5zIGFzIGEgR3VpQ2xpZW50IGJ5IGRlZmF1bHQgaW4gUXQgRW1iZWRkZWQgd2hpY2ggd2lsbAor ICAgICAgICBtYWtlIGl0IHRyeSB0byBjb25uZWN0IHRvIGFuIGV4aXN0aW5nIEd1aVNlcnZlci4g VGhpcyBwYXRjaCBtYWtlcyBpdAorICAgICAgICBydW4gbGlrZSBhIHN0YW5kLWFsb25lIGFwcC4K KworICAgICAgICAqIFF0TGF1bmNoZXIvbWFpbi5jcHA6CisgICAgICAgIChMYXVuY2hlckFwcGxp Y2F0aW9uOjpMYXVuY2hlckFwcGxpY2F0aW9uKToKKwogMjAxMC0wMy0xOCAgQW50dGkgS29pdmlz dG8gIDxrb2l2aXN0b0Bpa2kuZmk+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgS2VubmV0aCBSb2hk ZSBDaHJpc3RpYW5zZW4uCkluZGV4OiBXZWJLaXRUb29scy9RdExhdW5jaGVyL21haW4uY3BwCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFdlYktpdFRvb2xzL1F0TGF1bmNoZXIvbWFpbi5jcHAJKHJldmlzaW9uIDU2 MTYyKQorKysgV2ViS2l0VG9vbHMvUXRMYXVuY2hlci9tYWluLmNwcAkod29ya2luZyBjb3B5KQpA QCAtODg0LDcgKzg4NCwxMSBAQCB2b2lkIExhdW5jaGVyQXBwbGljYXRpb246OmFwcGx5RGVmYXVs dFNlCiB9CiAKIExhdW5jaGVyQXBwbGljYXRpb246OkxhdW5jaGVyQXBwbGljYXRpb24oaW50JiBh cmdjLCBjaGFyKiogYXJndikKLSAgICA6IFFBcHBsaWNhdGlvbihhcmdjLCBhcmd2KQorICAgIDog UUFwcGxpY2F0aW9uKGFyZ2MsIGFyZ3YKKyNpZmRlZiBRX1dTX1FXUworICAgICAgICAgICAgICAg ICAgICwgUUFwcGxpY2F0aW9uOjpHdWlTZXJ2ZXIKKyNlbmRpZgorICAgICkKICAgICAsIG1faXNS b2JvdGl6ZWQoZmFsc2UpCiB7Cg== 51086 2010-03-18 13:40:08 -0700 2010-03-18 22:28:01 -0700 Updated patch for 36318 patch.36318 text/plain 1165 agbakken LS0tIFdlYktpdFRvb2xzL0NoYW5nZUxvZwkocmV2aXNpb24gNTYxODApCisrKyBXZWJLaXRUb29s cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNiBAQAorMjAxMC0wMy0xOCAg QW5kZXJzIEJha2tlbiAgPEFuZGVycyBCYWtrZW4gPGFnYmFra2VuQGdtYWlsLmNvbT4+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM2MzE4CisKKyAgICAgICAgUXRMYXVuY2hlciBy dW5zIGFzIGEgR3VpQ2xpZW50IGJ5IGRlZmF1bHQgaW4gUXQgRW1iZWRkZWQgd2hpY2ggd2lsbAor ICAgICAgICBtYWtlIGl0IHRyeSB0byBjb25uZWN0IHRvIGFuIGV4aXN0aW5nIEd1aVNlcnZlci4g VGhpcyBwYXRjaCBtYWtlcyBpdAorICAgICAgICBydW4gbGlrZSBhIHN0YW5kLWFsb25lIGFwcC4K KworICAgICAgICAqIFF0TGF1bmNoZXIvbWFpbi5jcHA6CisgICAgICAgIChMYXVuY2hlckFwcGxp Y2F0aW9uOjpMYXVuY2hlckFwcGxpY2F0aW9uKToKKwogMjAxMC0wMy0xOCAgQW50dGkgS29pdmlz dG8gIDxrb2l2aXN0b0Bpa2kuZmk+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgS2VubmV0aCBSb2hk ZSBDaHJpc3RpYW5zZW4uCkluZGV4OiBXZWJLaXRUb29scy9RdExhdW5jaGVyL21haW4uY3BwCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFdlYktpdFRvb2xzL1F0TGF1bmNoZXIvbWFpbi5jcHAJKHJldmlzaW9uIDU2 MTYyKQorKysgV2ViS2l0VG9vbHMvUXRMYXVuY2hlci9tYWluLmNwcAkod29ya2luZyBjb3B5KQpA QCAtODg0LDcgKzg4NCw3IEBAIHZvaWQgTGF1bmNoZXJBcHBsaWNhdGlvbjo6YXBwbHlEZWZhdWx0 U2UKIH0KIAogTGF1bmNoZXJBcHBsaWNhdGlvbjo6TGF1bmNoZXJBcHBsaWNhdGlvbihpbnQmIGFy Z2MsIGNoYXIqKiBhcmd2KQotICAgIDogUUFwcGxpY2F0aW9uKGFyZ2MsIGFyZ3YpCisgICAgOiBR QXBwbGljYXRpb24oYXJnYywgYXJndiwgUUFwcGxpY2F0aW9uOjpHdWlTZXJ2ZXIpCiAgICAgLCBt X2lzUm9ib3RpemVkKGZhbHNlKQogewogICAgIC8vIFRvIGFsbG93IFFXZWJJbnNwZWN0b3IncyBj b25maWd1cmF0aW9uIHBlcnNpc3RlbmNlCg==