36315 2010-03-18 12:04:55 -0700 Remove obsolete Geolocation::m_currentPosition 2010-04-21 11:54:28 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 bulach webkit-unassigned bulach commit-queue jorlow joth steveblock webkit.review.bot oldest_to_newest 201456 0 bulach 2010-03-18 12:04:55 -0700 A follow up on https://bugs.webkit.org/show_bug.cgi?id=30676 needs to remove Geolocation::m_currentPosition. Main reason: void Geolocation::setIsAllowed(bool allowed) ... 436 if (lastPosition()) 437 makeSuccessCallbacks(); ... but makeSuccessCallbacks() uses m_currentPosition rather than lastPosition(), and asserts if it's not set. 201555 1 51091 bulach 2010-03-18 14:16:33 -0700 Created attachment 51091 Patch 203095 2 webkit.review.bot 2010-03-23 10:16:11 -0700 Attachment 51091 did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebCore/ChangeLog:6: Line contains tab character. [whitespace/tab] [5] WebCore/ChangeLog:7: Line contains tab character. [whitespace/tab] [5] WebCore/ChangeLog:8: Line contains tab character. [whitespace/tab] [5] Total errors found: 3 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 203140 3 51091 steveblock 2010-03-23 12:06:21 -0700 Comment on attachment 51091 Patch + Remove obsolete Geolocation::m_currentPosition + (follow up on https://bugs.webkit.org/show_bug.cgi?id=30676) tabs Looks good to me otherwise. To further clarify the code, we could remove the Geoposition argument from positionChanged() and hence setPosition(). Instead, positionChanged() would just call m_service->lastPosition() directly. This would also bring the client-based code path in line with the existing code path. Also, I think that in a future change we should remove m_lastPosition, as it serves no purpose as far as I can see. 203145 4 51091 jorlow 2010-03-23 12:15:41 -0700 Comment on attachment 51091 Patch r- per Steve's comments...looks close tho 205438 5 51910 bulach 2010-03-29 07:58:28 -0700 Created attachment 51910 Patch 205440 6 bulach 2010-03-29 08:05:11 -0700 (In reply to comment #3) > (From update of attachment 51091 [details]) > + Remove obsolete Geolocation::m_currentPosition > + (follow up on https://bugs.webkit.org/show_bug.cgi?id=30676) > tabs > Ops, fixed. > Looks good to me otherwise. To further clarify the code, we could remove the > Geoposition argument from positionChanged() and hence setPosition(). Instead, > positionChanged() would just call m_service->lastPosition() directly. This > would also bring the client-based code path in line with the existing code > path. Hmm, I don't quite understood this bit: setPosition is part of the public API, I'm not sure if I can just remove GeolocationPosition (not Geoposition) from it. If you're saying to remove only from the call to positionChanged(), that would require pushing up "m_positionCache->setCachedPosition(newPosition.get());" to the two APIs. Since this would be just a further clarification, I hope you don't mind if I do as a follow up? > > Also, I think that in a future change we should remove m_lastPosition, as it > serves no purpose as far as I can see. Agreed. Right now, it only serves to ensure ownership of either the service or client-based geoposition, but clarifying it would definitely be a good idea. 205443 7 51910 jorlow 2010-03-29 08:12:59 -0700 Comment on attachment 51910 Patch r=me Thanks for the review Steve. 205500 8 51910 commit-queue 2010-03-29 09:56:09 -0700 Comment on attachment 51910 Patch Clearing flags on attachment: 51910 Committed r56726: <http://trac.webkit.org/changeset/56726> 205501 9 commit-queue 2010-03-29 09:56:14 -0700 All reviewed patches have been landed. Closing bug. 215434 10 steveblock 2010-04-21 11:54:28 -0700 > > Looks good to me otherwise. To further clarify the code, we could remove the > > Geoposition argument from positionChanged() and hence setPosition(). Instead, > > positionChanged() would just call m_service->lastPosition() directly. This > > would also bring the client-based code path in line with the existing code > > path. > > Hmm, I don't quite understood this bit: setPosition is part of the public API, > I'm not sure if I can just remove GeolocationPosition (not Geoposition) from > it. If you're saying to remove only from the call to positionChanged(), that > would require pushing up > "m_positionCache->setCachedPosition(newPosition.get());" to the two APIs. Sorry for not being more clear. My point is: given that we no longer use m_currentPosition, and makeSuccessCallbacks() now calls lastPosition() to get the position directly from the service, positionChanged() could do this too - i.e. call lastPosition() rather than needing the position to be passed in as a parameter. So we would remove the Geoposition parameter from positionChanged(). This would allow us to remove the GeolocationPosition parameter from setPosition(). This would bring the client-based implementation (which uses setPosition()) into line with the existing implementation (which uses geolocationServicePositionChanged(), which does not take a position parameter). Does that make sense? > Since this would be just a further clarification, I hope you don't mind if I do > as a follow up? Sure, no problem 51091 2010-03-18 14:16:33 -0700 2010-03-23 12:15:41 -0700 Patch 36315.patch text/plain 3227 bulach SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1NjE5MCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTkgQEAKKzIwMTAtMDMtMTggIE1hcmN1cyBCdWxhY2ggIDxidWxhY2hAY2hyb21p dW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNjMxNQorCQkKKwkJUmVt b3ZlIG9ic29sZXRlIEdlb2xvY2F0aW9uOjptX2N1cnJlbnRQb3NpdGlvbgorCQkoZm9sbG93IHVw IG9uIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMDY3NikKKworICAg ICAgICAqIHBhZ2UvR2VvbG9jYXRpb24uY3BwOgorICAgICAgICAoV2ViQ29yZTo6R2VvbG9jYXRp b246OnBvc2l0aW9uQ2hhbmdlZCk6CisgICAgICAgIChXZWJDb3JlOjpHZW9sb2NhdGlvbjo6bWFr ZVN1Y2Nlc3NDYWxsYmFja3MpOgorICAgICAgICAqIHBhZ2UvR2VvbG9jYXRpb24uaDoKKyAgICAg ICAgKiBwbGF0Zm9ybS9jaHJvbWl1bS9HZW9sb2NhdGlvblNlcnZpY2VDaHJvbWl1bS5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpHZW9sb2NhdGlvblNlcnZpY2VDaHJvbWl1bTo6R2VvbG9jYXRpb25T ZXJ2aWNlQ2hyb21pdW0pOgorCiAyMDEwLTAzLTE4ICBEYXZpZCBIeWF0dCAgPGh5YXR0QGFwcGxl LmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBPbGl2ZXIgSHVudC4KSW5kZXg6IFdlYkNvcmUv cGFnZS9HZW9sb2NhdGlvbi5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9wYWdlL0dlb2xvY2F0 aW9uLmNwcAkocmV2aXNpb24gNTYxODIpCisrKyBXZWJDb3JlL3BhZ2UvR2VvbG9jYXRpb24uY3Bw CSh3b3JraW5nIGNvcHkpCkBAIC01MzYsOSArNTM2LDcgQEAgdm9pZCBHZW9sb2NhdGlvbjo6cmVx dWVzdFBlcm1pc3Npb24oKQogCiB2b2lkIEdlb2xvY2F0aW9uOjpwb3NpdGlvbkNoYW5nZWQoUGFz c1JlZlB0cjxHZW9wb3NpdGlvbj4gbmV3UG9zaXRpb24pCiB7Ci0gICAgbV9jdXJyZW50UG9zaXRp b24gPSBuZXdQb3NpdGlvbjsKLQotICAgIG1fcG9zaXRpb25DYWNoZS0+c2V0Q2FjaGVkUG9zaXRp b24obV9jdXJyZW50UG9zaXRpb24uZ2V0KCkpOworICAgIG1fcG9zaXRpb25DYWNoZS0+c2V0Q2Fj aGVkUG9zaXRpb24obmV3UG9zaXRpb24uZ2V0KCkpOwogCiAgICAgLy8gU3RvcCBhbGwgY3VycmVu dGx5IHJ1bm5pbmcgdGltZXJzLgogICAgIHN0b3BUaW1lcnMoKTsKQEAgLTU1Nyw3ICs1NTUsNyBA QCB2b2lkIEdlb2xvY2F0aW9uOjpwb3NpdGlvbkNoYW5nZWQoUGFzc1JlCiAKIHZvaWQgR2VvbG9j YXRpb246Om1ha2VTdWNjZXNzQ2FsbGJhY2tzKCkKIHsKLSAgICBBU1NFUlQobV9jdXJyZW50UG9z aXRpb24pOworICAgIEFTU0VSVChsYXN0UG9zaXRpb24oKSk7CiAgICAgQVNTRVJUKGlzQWxsb3dl ZCgpKTsKICAgICAKICAgICBWZWN0b3I8UmVmUHRyPEdlb05vdGlmaWVyPiA+IG9uZVNob3RzQ29w eTsKQEAgLTU3MSw4ICs1NjksOCBAQCB2b2lkIEdlb2xvY2F0aW9uOjptYWtlU3VjY2Vzc0NhbGxi YWNrcygpCiAgICAgLy8gZnVydGhlciBjYWxsYmFja3MgdG8gdGhlc2Ugbm90aWZpZXJzLgogICAg IG1fb25lU2hvdHMuY2xlYXIoKTsKIAotICAgIHNlbmRQb3NpdGlvbihvbmVTaG90c0NvcHksIG1f Y3VycmVudFBvc2l0aW9uLmdldCgpKTsKLSAgICBzZW5kUG9zaXRpb24od2F0Y2hlcnNDb3B5LCBt X2N1cnJlbnRQb3NpdGlvbi5nZXQoKSk7CisgICAgc2VuZFBvc2l0aW9uKG9uZVNob3RzQ29weSwg bGFzdFBvc2l0aW9uKCkpOworICAgIHNlbmRQb3NpdGlvbih3YXRjaGVyc0NvcHksIGxhc3RQb3Np dGlvbigpKTsKIAogICAgIGlmICghaGFzTGlzdGVuZXJzKCkpCiAgICAgICAgIHN0b3BVcGRhdGlu ZygpOwpJbmRleDogV2ViQ29yZS9wYWdlL0dlb2xvY2F0aW9uLmgKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2Vi Q29yZS9wYWdlL0dlb2xvY2F0aW9uLmgJKHJldmlzaW9uIDU2MTgyKQorKysgV2ViQ29yZS9wYWdl L0dlb2xvY2F0aW9uLmgJKHdvcmtpbmcgY29weSkKQEAgLTE3NCw3ICsxNzQsNiBAQCBwcml2YXRl OgogICAgIFJlZlB0cjxHZW9Ob3RpZmllcj4gbV9zdGFydFJlcXVlc3RQZXJtaXNzaW9uTm90aWZp ZXI7CiAjZW5kaWYKICAgICBSZWZQdHI8R2VvcG9zaXRpb24+IG1fbGFzdFBvc2l0aW9uOwotICAg IFJlZlB0cjxHZW9wb3NpdGlvbj4gbV9jdXJyZW50UG9zaXRpb247CiAKICAgICBlbnVtIHsKICAg ICAgICAgVW5rbm93biwKSW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vR2VvbG9jYXRp b25TZXJ2aWNlQ2hyb21pdW0uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGxhdGZvcm0vY2hy b21pdW0vR2VvbG9jYXRpb25TZXJ2aWNlQ2hyb21pdW0uY3BwCShyZXZpc2lvbiA1NjE4MikKKysr IFdlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vR2VvbG9jYXRpb25TZXJ2aWNlQ2hyb21pdW0uY3Bw CSh3b3JraW5nIGNvcHkpCkBAIC0zOSw3ICszOSw2IEBAIEdlb2xvY2F0aW9uU2VydmljZUNocm9t aXVtOjpHZW9sb2NhdGlvblMKICAgICAgICAgOiBHZW9sb2NhdGlvblNlcnZpY2UoYyksCiAgICAg ICAgICAgbV9nZW9sb2NhdGlvbihyZWludGVycHJldF9jYXN0PEdlb2xvY2F0aW9uKj4oYykpLAog ICAgICAgICAgIG1fZ2VvbG9jYXRpb25TZXJ2aWNlQnJpZGdlKENocm9taXVtQnJpZGdlOjpjcmVh dGVHZW9sb2NhdGlvblNlcnZpY2VCcmlkZ2UodGhpcykpLAotICAgICAgICAgIG1fbGFzdFBvc2l0 aW9uKEdlb3Bvc2l0aW9uOjpjcmVhdGUoQ29vcmRpbmF0ZXM6OmNyZWF0ZSgwLjAsIDAuMCwgZmFs c2UsIDAuMCwgMC4wLCBmYWxzZSwgMC4wLCBmYWxzZSwgMC4wLCBmYWxzZSwgMC4wKSwgMCkpLAog ICAgICAgICAgIG1fbGFzdEVycm9yKFBvc2l0aW9uRXJyb3I6OmNyZWF0ZShQb3NpdGlvbkVycm9y OjpQT1NJVElPTl9VTkFWQUlMQUJMRSwgIiIpKQogewogfQo= 51910 2010-03-29 07:58:28 -0700 2010-03-29 09:56:09 -0700 Patch patch.txt text/plain 3245 bulach SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1NjcxOSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTkgQEAKKzIwMTAtMDMtMjkgIE1hcmN1cyBCdWxhY2ggIDxidWxhY2hAY2hyb21p dW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNjMxNQorCisgICAgICAg IFJlbW92ZSBvYnNvbGV0ZSBHZW9sb2NhdGlvbjo6bV9jdXJyZW50UG9zaXRpb24KKyAgICAgICAg KGZvbGxvdyB1cCBvbiBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzA2 NzYpCisKKyAgICAgICAgKiBwYWdlL0dlb2xvY2F0aW9uLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 Okdlb2xvY2F0aW9uOjpwb3NpdGlvbkNoYW5nZWQpOgorICAgICAgICAoV2ViQ29yZTo6R2VvbG9j YXRpb246Om1ha2VTdWNjZXNzQ2FsbGJhY2tzKToKKyAgICAgICAgKiBwYWdlL0dlb2xvY2F0aW9u Lmg6CisgICAgICAgICogcGxhdGZvcm0vY2hyb21pdW0vR2VvbG9jYXRpb25TZXJ2aWNlQ2hyb21p dW0uY3BwOgorICAgICAgICAoV2ViQ29yZTo6R2VvbG9jYXRpb25TZXJ2aWNlQ2hyb21pdW06Okdl b2xvY2F0aW9uU2VydmljZUNocm9taXVtKToKKwogMjAxMC0wMy0yOSAgVGhvbWFzIFphbmRlciAg PHQuemFuZGVyQG5va2lhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBTaW1vbiBIYXVzbWFu bi4KSW5kZXg6IFdlYkNvcmUvcGFnZS9HZW9sb2NhdGlvbi5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2Vi Q29yZS9wYWdlL0dlb2xvY2F0aW9uLmNwcAkocmV2aXNpb24gNTY3MTkpCisrKyBXZWJDb3JlL3Bh Z2UvR2VvbG9jYXRpb24uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC01MjEsOSArNTIxLDcgQEAgdm9p ZCBHZW9sb2NhdGlvbjo6cmVxdWVzdFBlcm1pc3Npb24oKQogCiB2b2lkIEdlb2xvY2F0aW9uOjpw b3NpdGlvbkNoYW5nZWQoUGFzc1JlZlB0cjxHZW9wb3NpdGlvbj4gbmV3UG9zaXRpb24pCiB7Ci0g ICAgbV9jdXJyZW50UG9zaXRpb24gPSBuZXdQb3NpdGlvbjsKLQotICAgIG1fcG9zaXRpb25DYWNo ZS0+c2V0Q2FjaGVkUG9zaXRpb24obV9jdXJyZW50UG9zaXRpb24uZ2V0KCkpOworICAgIG1fcG9z aXRpb25DYWNoZS0+c2V0Q2FjaGVkUG9zaXRpb24obmV3UG9zaXRpb24uZ2V0KCkpOwogCiAgICAg Ly8gU3RvcCBhbGwgY3VycmVudGx5IHJ1bm5pbmcgdGltZXJzLgogICAgIHN0b3BUaW1lcnMoKTsK QEAgLTU0Miw3ICs1NDAsNyBAQCB2b2lkIEdlb2xvY2F0aW9uOjpwb3NpdGlvbkNoYW5nZWQoUGFz c1JlCiAKIHZvaWQgR2VvbG9jYXRpb246Om1ha2VTdWNjZXNzQ2FsbGJhY2tzKCkKIHsKLSAgICBB U1NFUlQobV9jdXJyZW50UG9zaXRpb24pOworICAgIEFTU0VSVChsYXN0UG9zaXRpb24oKSk7CiAg ICAgQVNTRVJUKGlzQWxsb3dlZCgpKTsKICAgICAKICAgICBWZWN0b3I8UmVmUHRyPEdlb05vdGlm aWVyPiA+IG9uZVNob3RzQ29weTsKQEAgLTU1Niw4ICs1NTQsOCBAQCB2b2lkIEdlb2xvY2F0aW9u OjptYWtlU3VjY2Vzc0NhbGxiYWNrcygpCiAgICAgLy8gZnVydGhlciBjYWxsYmFja3MgdG8gdGhl c2Ugbm90aWZpZXJzLgogICAgIG1fb25lU2hvdHMuY2xlYXIoKTsKIAotICAgIHNlbmRQb3NpdGlv bihvbmVTaG90c0NvcHksIG1fY3VycmVudFBvc2l0aW9uLmdldCgpKTsKLSAgICBzZW5kUG9zaXRp b24od2F0Y2hlcnNDb3B5LCBtX2N1cnJlbnRQb3NpdGlvbi5nZXQoKSk7CisgICAgc2VuZFBvc2l0 aW9uKG9uZVNob3RzQ29weSwgbGFzdFBvc2l0aW9uKCkpOworICAgIHNlbmRQb3NpdGlvbih3YXRj aGVyc0NvcHksIGxhc3RQb3NpdGlvbigpKTsKIAogICAgIGlmICghaGFzTGlzdGVuZXJzKCkpCiAg ICAgICAgIHN0b3BVcGRhdGluZygpOwpJbmRleDogV2ViQ29yZS9wYWdlL0dlb2xvY2F0aW9uLmgK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gV2ViQ29yZS9wYWdlL0dlb2xvY2F0aW9uLmgJKHJldmlzaW9uIDU2NzE5 KQorKysgV2ViQ29yZS9wYWdlL0dlb2xvY2F0aW9uLmgJKHdvcmtpbmcgY29weSkKQEAgLTE2Miw3 ICsxNjIsNiBAQCBwcml2YXRlOgogICAgIFJlZlB0cjxHZW9Ob3RpZmllcj4gbV9zdGFydFJlcXVl c3RQZXJtaXNzaW9uTm90aWZpZXI7CiAjZW5kaWYKICAgICBSZWZQdHI8R2VvcG9zaXRpb24+IG1f bGFzdFBvc2l0aW9uOwotICAgIFJlZlB0cjxHZW9wb3NpdGlvbj4gbV9jdXJyZW50UG9zaXRpb247 CiAKICAgICBlbnVtIHsKICAgICAgICAgVW5rbm93biwKSW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0v Y2hyb21pdW0vR2VvbG9jYXRpb25TZXJ2aWNlQ2hyb21pdW0uY3BwCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdl YkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vR2VvbG9jYXRpb25TZXJ2aWNlQ2hyb21pdW0uY3BwCShy ZXZpc2lvbiA1NjcxOSkKKysrIFdlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vR2VvbG9jYXRpb25T ZXJ2aWNlQ2hyb21pdW0uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zOSw3ICszOSw2IEBAIEdlb2xv Y2F0aW9uU2VydmljZUNocm9taXVtOjpHZW9sb2NhdGlvblMKICAgICAgICAgOiBHZW9sb2NhdGlv blNlcnZpY2UoYyksCiAgICAgICAgICAgbV9nZW9sb2NhdGlvbihyZWludGVycHJldF9jYXN0PEdl b2xvY2F0aW9uKj4oYykpLAogICAgICAgICAgIG1fZ2VvbG9jYXRpb25TZXJ2aWNlQnJpZGdlKENo cm9taXVtQnJpZGdlOjpjcmVhdGVHZW9sb2NhdGlvblNlcnZpY2VCcmlkZ2UodGhpcykpLAotICAg ICAgICAgIG1fbGFzdFBvc2l0aW9uKEdlb3Bvc2l0aW9uOjpjcmVhdGUoQ29vcmRpbmF0ZXM6OmNy ZWF0ZSgwLjAsIDAuMCwgZmFsc2UsIDAuMCwgMC4wLCBmYWxzZSwgMC4wLCBmYWxzZSwgMC4wLCBm YWxzZSwgMC4wKSwgMCkpLAogICAgICAgICAgIG1fbGFzdEVycm9yKFBvc2l0aW9uRXJyb3I6OmNy ZWF0ZShQb3NpdGlvbkVycm9yOjpQT1NJVElPTl9VTkFWQUlMQUJMRSwgIiIpKQogewogfQo=