36304 2010-03-18 10:54:41 -0700 Web Inspector: CSS shorthand properties expand unnecessarily 2010-12-24 04:05:13 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED Regression P2 Normal --- 1 paradox460 apavlov bweinstein joepeck keishi pfeldman pmuellr rik timothy oldest_to_newest 201387 0 paradox460 2010-03-18 10:54:41 -0700 If you type certain properties into the web inspectors CSS edit area, they expand in a manner that can prove quite annoying. To reproduce, open inspector, and add a new property. Type border-radius: 5px; Hit return The property will expand to 4 different properties: border-top-left-radius: 5px 5px; etc Possible solution: Cause the border-radius to remain as one complex syntax, with an expanding dropdown, much like with other properties, of the sub-properties. 201402 1 timothy 2010-03-18 11:02:27 -0700 This is a regression. We use to handle this correctly. 201422 2 pfeldman 2010-03-18 11:23:47 -0700 (In reply to comment #1) > This is a regression. We use to handle this correctly. That's what comment was saying: // Some shorthands (like border) return a null value, so compute a shorthand value. // FIXME: remove this when http://bugs.webkit.org/show_bug.cgi?id=15823 is fixed. Turns out it was not only 15823. 201425 3 pfeldman 2010-03-18 11:26:26 -0700 Ok, I can now see that the bug is still open. Turns out only test has landed for it. Bringing the hack back... 201450 4 pfeldman 2010-03-18 11:52:09 -0700 I don't think this is regression - style does not return shorthand for border-radius specifically. It works with the rest of the shorthands. 326004 5 77319 apavlov 2010-12-23 02:48:22 -0800 Created attachment 77319 [PATCH] Suggested fix 326505 6 77319 eric 2010-12-24 01:32:54 -0800 Comment on attachment 77319 [PATCH] Suggested fix View in context: https://bugs.webkit.org/attachment.cgi?id=77319&action=review This patch needs more explanation in the ChangeLog of what's going on and why its' right. > WebCore/css/CSSParser.cpp:4601 > + m_implicitShorthand = true; Why is this needed separately from a shorthand scope? 326506 7 77319 mjs 2010-12-24 01:37:00 -0800 Comment on attachment 77319 [PATCH] Suggested fix r=me 326509 8 77319 mjs 2010-12-24 01:40:43 -0800 Comment on attachment 77319 [PATCH] Suggested fix r=me 326576 9 apavlov 2010-12-24 03:50:40 -0800 (In reply to comment #6) > (From update of attachment 77319 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=77319&action=review > > This patch needs more explanation in the ChangeLog of what's going on and why its' right. Fixed. > > WebCore/css/CSSParser.cpp:4601 > > + m_implicitShorthand = true; > > Why is this needed separately from a shorthand scope? Filed bug 51586 for that. 326583 10 apavlov 2010-12-24 04:05:13 -0800 Landed with the comments addressed: http://trac.webkit.org/changeset/74630 77319 2010-12-23 02:48:22 -0800 2010-12-24 01:41:04 -0800 [PATCH] Suggested fix borderradius.patch text/plain 5708 apavlov Y29tbWl0IGQwZmYwMmRhMzk5MjA1YmY1MTIyNzRlNTM3NTBkNWUzZmQ2ODI2MDUKQXV0aG9yOiBB bGV4YW5kZXIgUGF2bG92IDxhcGF2bG92QGNocm9taXVtLm9yZz4KRGF0ZTogICBXZWQgRGVjIDIy IDIwOjQwOjI0IDIwMTAgKzAzMDAKCiAgICBmaXhib3JkZXJyYWRpdXMKCmRpZmYgLS1naXQgYS9M YXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNThmMzUz Ni4uYmViOGViZCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91 dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEwLTEyLTIzICBBbGV4YW5kZXIg UGF2bG92ICA8YXBhdmxvdkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogQ1NTIHNob3J0aGFuZCBwcm9w ZXJ0aWVzIGV4cGFuZCB1bm5lY2Vzc2FyaWx5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0zNjMwNAorCisgICAgICAgICogaW5zcGVjdG9yL2VsZW1lbnRz LXBhbmVsLXN0eWxlcy1leHBlY3RlZC50eHQ6CisgICAgICAgICogaW5zcGVjdG9yL3Jlc291cmNl cy9lbGVtZW50cy1wYW5lbC1zdHlsZXMuY3NzOgorICAgICAgICAoLmZvbyk6CisKIDIwMTAtMTIt MjIgIEFuZHJlaSBQb3Blc2N1ICA8YW5kcmVpcEBnb29nbGUuY29tPgogCiAgICAgICAgIFVucmV2 aWV3ZWQgYnVpbGRmaXguCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvZWxlbWVu dHMtcGFuZWwtc3R5bGVzLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2luc3BlY3Rvci9lbGVt ZW50cy1wYW5lbC1zdHlsZXMtZXhwZWN0ZWQudHh0CmluZGV4IDMyYzZmY2UuLjQxZjM0M2MgMTAw NjQ0Ci0tLSBhL0xheW91dFRlc3RzL2luc3BlY3Rvci9lbGVtZW50cy1wYW5lbC1zdHlsZXMtZXhw ZWN0ZWQudHh0CisrKyBiL0xheW91dFRlc3RzL2luc3BlY3Rvci9lbGVtZW50cy1wYW5lbC1zdHls ZXMtZXhwZWN0ZWQudHh0CkBAIC0xLDggKzEsMTYgQEAKIFRlc3RzIHRoYXQgZWxlbWVudHMgcGFu ZWwgc2hvd3MgcHJvcGVyIHN0eWxlcyBpbiB0aGUgc2lkZWJhciBwYW5lbC4KIAogW2V4cGFuZGVk XSAgKCkKK2JvcmRlci1ib3R0b20tbGVmdC1yYWRpdXM6IDVweDsKKyAgICAuZm9vIC0gNXB4IDVw eCBlbGVtZW50cy1wYW5lbC1zdHlsZXMuY3NzOjEwCitib3JkZXItYm90dG9tLXJpZ2h0LXJhZGl1 czogNXB4OworICAgIC5mb28gLSA1cHggNXB4IGVsZW1lbnRzLXBhbmVsLXN0eWxlcy5jc3M6MTAK K2JvcmRlci10b3AtbGVmdC1yYWRpdXM6IDVweDsKKyAgICAuZm9vIC0gNXB4IDVweCBlbGVtZW50 cy1wYW5lbC1zdHlsZXMuY3NzOjEwCitib3JkZXItdG9wLXJpZ2h0LXJhZGl1czogNXB4OworICAg IC5mb28gLSA1cHggNXB4IGVsZW1lbnRzLXBhbmVsLXN0eWxlcy5jc3M6MTAKIGNvbG9yOiBibHVl OwotICAgIC5mb28sIC5mb286OmJlZm9yZSAtIGJsdWUgZWxlbWVudHMtcGFuZWwtc3R5bGVzLmNz czoxNQorICAgIC5mb28sIC5mb286OmJlZm9yZSAtIGJsdWUgZWxlbWVudHMtcGFuZWwtc3R5bGVz LmNzczoxNgogICAgIC8tLSBvdmVybG9hZGVkIC0tLyAuZm9vIC0gYmxhY2sgZWxlbWVudHMtcGFu ZWwtc3R5bGVzLmNzczoxMAogZGlzcGxheTogbm9uZTsKICAgICBlbGVtZW50LnN0eWxlIC0gbm9u ZSAKQEAgLTI1LDkgKzMzLDkgQEAgbWFyZ2luLXRvcDogMTBweDsKIGRpc3BsYXk6IG5vbmU7CiAK ID09PT09PT09IE1hdGNoZWQgQ1NTIFJ1bGVzID09PT09PT09Ci1bZXhwYW5kZWRdIC5mb28geyAo ZWxlbWVudHMtcGFuZWwtc3R5bGVzLmNzczozMykKK1tleHBhbmRlZF0gLmZvbyB7IChlbGVtZW50 cy1wYW5lbC1zdHlsZXMuY3NzOjM0KQogCi1bZXhwYW5kZWRdIC5mb28sIC5mb286OmJlZm9yZSB7 IChlbGVtZW50cy1wYW5lbC1zdHlsZXMuY3NzOjE1KQorW2V4cGFuZGVkXSAuZm9vLCAuZm9vOjpi ZWZvcmUgeyAoZWxlbWVudHMtcGFuZWwtc3R5bGVzLmNzczoxNikKIGNvbnRlbnQ6ICJbYmVmb3Jl IEZvb10iOwogY29sb3I6IGJsdWU7CiAKQEAgLTM4LDYgKzQ2LDExIEBAIG1hcmdpbjogMTBweCAw IDJweDsKICAgICBtYXJnaW4tcmlnaHQ6IDBweDsKICAgICBtYXJnaW4tYm90dG9tOiAycHg7CiAg ICAgbWFyZ2luLWxlZnQ6IDBweDsKK2JvcmRlci1yYWRpdXM6IDVweDsKKyAgICBib3JkZXItdG9w LWxlZnQtcmFkaXVzOiA1cHggNXB4OworICAgIGJvcmRlci10b3AtcmlnaHQtcmFkaXVzOiA1cHgg NXB4OworICAgIGJvcmRlci1ib3R0b20tcmlnaHQtcmFkaXVzOiA1cHggNXB4OworICAgIGJvcmRl ci1ib3R0b20tbGVmdC1yYWRpdXM6IDVweCA1cHg7CiAKIFtleHBhbmRlZF0gZGl2IHsgKHVzZXIg YWdlbnQgc3R5bGVzaGVldCkKIC8tLSBvdmVybG9hZGVkIC0tLyBkaXNwbGF5OiBibG9jazsKQEAg LTUzLDIyICs2NiwyMiBAQCBmb250LXNpemU6IDE0cHg7CiAKIAogPT09PT09PT0gUHNldWRvIDo6 YmVmb3JlIGVsZW1lbnQgPT09PT09PT0KLVtleHBhbmRlZF0gLmZvbzo6YmVmb3JlIHsgKGVsZW1l bnRzLXBhbmVsLXN0eWxlcy5jc3M6MzcpCitbZXhwYW5kZWRdIC5mb286OmJlZm9yZSB7IChlbGVt ZW50cy1wYW5lbC1zdHlsZXMuY3NzOjM4KQogCi1bZXhwYW5kZWRdIC5mb286OmJlZm9yZSB7IChl bGVtZW50cy1wYW5lbC1zdHlsZXMuY3NzOjIwKQorW2V4cGFuZGVkXSAuZm9vOjpiZWZvcmUgeyAo ZWxlbWVudHMtcGFuZWwtc3R5bGVzLmNzczoyMSkKIGNvbG9yOiByZWQ7CiAKLVtleHBhbmRlZF0g LmZvbywgLmZvbzo6YmVmb3JlIHsgKGVsZW1lbnRzLXBhbmVsLXN0eWxlcy5jc3M6MTUpCitbZXhw YW5kZWRdIC5mb28sIC5mb286OmJlZm9yZSB7IChlbGVtZW50cy1wYW5lbC1zdHlsZXMuY3NzOjE2 KQogY29udGVudDogIltiZWZvcmUgRm9vXSI7CiAvLS0gb3ZlcmxvYWRlZCAtLS8gY29sb3I6IGJs dWU7CiAKIAogPT09PT09PT0gUHNldWRvIDo6YWZ0ZXIgZWxlbWVudCA9PT09PT09PQotW2V4cGFu ZGVkXSAuZm9vOjphZnRlciB7IChlbGVtZW50cy1wYW5lbC1zdHlsZXMuY3NzOjI4KQorW2V4cGFu ZGVkXSAuZm9vOjphZnRlciB7IChlbGVtZW50cy1wYW5lbC1zdHlsZXMuY3NzOjI5KQogZm9udC1m YW1pbHk6IGNvdXJpZXI7CiBjb250ZW50OiAiW2FmdGVyIEZvbyAyXSI7CiAKLVtleHBhbmRlZF0g LmZvbzo6YWZ0ZXIgeyAoZWxlbWVudHMtcGFuZWwtc3R5bGVzLmNzczoyNCkKK1tleHBhbmRlZF0g LmZvbzo6YWZ0ZXIgeyAoZWxlbWVudHMtcGFuZWwtc3R5bGVzLmNzczoyNSkKIC8tLSBvdmVybG9h ZGVkIC0tLyBjb250ZW50OiAiW2FmdGVyIEZvb10iOwogY29sb3I6IGdyZWVuOwogCmRpZmYgLS1n aXQgYS9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvcmVzb3VyY2VzL2VsZW1lbnRzLXBhbmVsLXN0eWxl cy5jc3MgYi9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvcmVzb3VyY2VzL2VsZW1lbnRzLXBhbmVsLXN0 eWxlcy5jc3MKaW5kZXggMWIzMDY2My4uYjFiMzAzNSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMv aW5zcGVjdG9yL3Jlc291cmNlcy9lbGVtZW50cy1wYW5lbC1zdHlsZXMuY3NzCisrKyBiL0xheW91 dFRlc3RzL2luc3BlY3Rvci9yZXNvdXJjZXMvZWxlbWVudHMtcGFuZWwtc3R5bGVzLmNzcwpAQCAt MTAsNiArMTAsNyBAQCBib2R5IHsKIC5mb28gewogCWNvbG9yOiBibGFjazsKIAltYXJnaW46IDEw cHggMCAycHg7CisJYm9yZGVyLXJhZGl1czogNXB4OwogfQogCiAuZm9vLCAuZm9vOjpiZWZvcmUg ewpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRl eCA1MDJiZWMyLi5mNmMwNDJiIDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9X ZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEwLTEyLTIzICBBbGV4YW5kZXIg UGF2bG92ICA8YXBhdmxvdkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogQ1NTIHNob3J0aGFuZCBwcm9w ZXJ0aWVzIGV4cGFuZCB1bm5lY2Vzc2FyaWx5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0zNjMwNAorCisgICAgICAgIFRoZSBib3JkZXItcmFkaXVzIGlt cGxpY2l0IGxvbmdoYW5kcyB3ZXJlIG5vdCBhZGRlZCBhcyBzdWNoLCBidXQgaW5zdGVhZCBhcwor ICAgICAgICBub3JtYWwgcHJvcGVydGllcyBmb3VuZCBpbiB0aGUgQ1NTIChuZWl0aGVyIGltcGxp Y2l0LCBub3IgbG9uZ2hhbmRzKS4KKworICAgICAgICAqIGNzcy9DU1NQYXJzZXIuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6Q1NTUGFyc2VyOjpwYXJzZUJvcmRlclJhZGl1cyk6CisKIDIwMTAtMTIt MjIgIERpcmsgU2NodWx6ZSAgPGtyaXRAd2Jla2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBi eSBOaWtvbGFzIFppbW1lcm1hbm4uCmRpZmYgLS1naXQgYS9XZWJDb3JlL2Nzcy9DU1NQYXJzZXIu Y3BwIGIvV2ViQ29yZS9jc3MvQ1NTUGFyc2VyLmNwcAppbmRleCA3NDRkOWI3Li45M2EzOGJhIDEw MDY0NAotLS0gYS9XZWJDb3JlL2Nzcy9DU1NQYXJzZXIuY3BwCisrKyBiL1dlYkNvcmUvY3NzL0NT U1BhcnNlci5jcHAKQEAgLTQ1NTMsNiArNDU1Myw3IEBAIGJvb2wgQ1NTUGFyc2VyOjpwYXJzZUJv cmRlclJhZGl1cyhpbnQgcHJvcElkLCBib29sIGltcG9ydGFudCkKICAgICBpZiAobnVtID4gOSkK ICAgICAgICAgcmV0dXJuIGZhbHNlOwogCisgICAgU2hvcnRoYW5kU2NvcGUgc2NvcGUodGhpcywg cHJvcElkKTsKICAgICBSZWZQdHI8Q1NTUHJpbWl0aXZlVmFsdWU+IHJhZGlpWzJdWzRdOwogCiAg ICAgdW5zaWduZWQgaW5kZXhBZnRlclNsYXNoID0gMDsKQEAgLTQ1OTcsMTAgKzQ1OTgsMTIgQEAg Ym9vbCBDU1NQYXJzZXI6OnBhcnNlQm9yZGVyUmFkaXVzKGludCBwcm9wSWQsIGJvb2wgaW1wb3J0 YW50KQogICAgIH0gZWxzZQogICAgICAgICBjb21wbGV0ZUJvcmRlclJhZGlpKHJhZGlpWzFdKTsK IAorICAgIG1faW1wbGljaXRTaG9ydGhhbmQgPSB0cnVlOwogICAgIGFkZFByb3BlcnR5KENTU1By b3BlcnR5Qm9yZGVyVG9wTGVmdFJhZGl1cywgQ1NTUHJpbWl0aXZlVmFsdWU6OmNyZWF0ZShQYWly OjpjcmVhdGUocmFkaWlbMF1bMF0ucmVsZWFzZSgpLCByYWRpaVsxXVswXS5yZWxlYXNlKCkpKSwg aW1wb3J0YW50KTsKICAgICBhZGRQcm9wZXJ0eShDU1NQcm9wZXJ0eUJvcmRlclRvcFJpZ2h0UmFk aXVzLCBDU1NQcmltaXRpdmVWYWx1ZTo6Y3JlYXRlKFBhaXI6OmNyZWF0ZShyYWRpaVswXVsxXS5y ZWxlYXNlKCksIHJhZGlpWzFdWzFdLnJlbGVhc2UoKSkpLCBpbXBvcnRhbnQpOwogICAgIGFkZFBy b3BlcnR5KENTU1Byb3BlcnR5Qm9yZGVyQm90dG9tUmlnaHRSYWRpdXMsIENTU1ByaW1pdGl2ZVZh bHVlOjpjcmVhdGUoUGFpcjo6Y3JlYXRlKHJhZGlpWzBdWzJdLnJlbGVhc2UoKSwgcmFkaWlbMV1b Ml0ucmVsZWFzZSgpKSksIGltcG9ydGFudCk7CiAgICAgYWRkUHJvcGVydHkoQ1NTUHJvcGVydHlC b3JkZXJCb3R0b21MZWZ0UmFkaXVzLCBDU1NQcmltaXRpdmVWYWx1ZTo6Y3JlYXRlKFBhaXI6OmNy ZWF0ZShyYWRpaVswXVszXS5yZWxlYXNlKCksIHJhZGlpWzFdWzNdLnJlbGVhc2UoKSkpLCBpbXBv cnRhbnQpOworICAgIG1faW1wbGljaXRTaG9ydGhhbmQgPSBmYWxzZTsKICAgICByZXR1cm4gdHJ1 ZTsKIH0KIAo=