36292 2010-03-18 06:04:59 -0700 [Qt] The numbers are not displayed properly when entering through VKB in number mode 2010-03-24 04:15:47 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC Linux RESOLVED FIXED Qt P2 Normal --- 1 kristian.amlie webkit-qt-unassigned commit-queue harry hausmann joseph.ligman koshuin sakari.peltomaki oldest_to_newest 201261 0 51020 kristian.amlie 2010-03-18 06:04:59 -0700 Created attachment 51020 Patch Steps to reproduce: 1. Compile this program: int main(int argc, char **argv) { QApplication app(argc, argv); QWidget w; QLayout *layout = new QVBoxLayout; QGraphicsScene scene; QGraphicsView view(&scene); QGraphicsWebView *wv = new QGraphicsWebView; wv->load(QUrl("http://www.google.com/")); scene.addItem(wv); layout->addWidget(&view); w.setLayout(layout); w.showMaximized(); return app.exec(); } 2. Tap the lineedit so the input panel opens. 3. Enter number mode. 4. Try to enter numbers. The result is that the numbers lag behind, that is, when entering "23", the first character will produce nothing, and the 3 will produce "2". Must be a QInputContext::update issue, since the content is correct in the widget itself. 201277 1 51020 kristian.amlie 2010-03-18 07:17:47 -0700 Comment on attachment 51020 Patch > diff --git a/src/3rdparty/webkit/WebKit/qt/Api/qgraphicswebview.cpp b/src/3rdparty/webkit/WebKit/qt/Api/qgraphicswebview.cpp > index ceb5ee1..5786965 100644 > --- a/src/3rdparty/webkit/WebKit/qt/Api/qgraphicswebview.cpp > +++ b/src/3rdparty/webkit/WebKit/qt/Api/qgraphicswebview.cpp > @@ -30,6 +30,7 @@ > #include <QtGui/qapplication.h> > #include <QtGui/qgraphicssceneevent.h> > #include <QtGui/qstyleoption.h> > +#include <QtGui/qinputcontext.h> > #if defined(Q_WS_X11) > #include <QX11Info> > #endif > @@ -63,6 +64,8 @@ public: > > void _q_doLoadFinished(bool success); > > + void _q_updateMicroFocus(); > + > QGraphicsWebView* q; > QWebPage* page; > }; > @@ -80,6 +83,18 @@ void QGraphicsWebViewPrivate::_q_doLoadFinished(bool success) > emit q->loadFinished(success); > } > > +void QGraphicsWebViewPrivate::_q_updateMicroFocus() > +{ > +#if !defined(QT_NO_IM) && (defined(Q_WS_X11) || defined(Q_WS_QWS) || defined(Q_OS_SYMBIAN)) > + QList<QGraphicsView *> views = q->scene()->views(); > + for (int c = 0; c < views.size(); ++c) { > + QInputContext *ic = views[c]->inputContext(); > + if (ic) > + ic->update(); > + } > +#endif > +} > + > void QGraphicsWebViewPrivate::scroll(int dx, int dy, const QRect& rectToScroll) > { > q->scroll(qreal(dx), qreal(dy), QRectF(rectToScroll)); > @@ -435,6 +450,8 @@ void QGraphicsWebView::setPage(QWebPage* page) > this, SIGNAL(statusBarMessage(QString))); > connect(d->page, SIGNAL(linkClicked(QUrl)), > this, SIGNAL(linkClicked(QUrl))); > + connect(d->page, SIGNAL(microFocusChanged()), > + this, SLOT(_q_updateMicroFocus())); > } > > /*! > diff --git a/src/3rdparty/webkit/WebKit/qt/Api/qgraphicswebview.h b/src/3rdparty/webkit/WebKit/qt/Api/qgraphicswebview.h > index f3afb4c..f983ae4 100644 > --- a/src/3rdparty/webkit/WebKit/qt/Api/qgraphicswebview.h > +++ b/src/3rdparty/webkit/WebKit/qt/Api/qgraphicswebview.h > @@ -134,6 +134,7 @@ protected: > > private: > Q_PRIVATE_SLOT(d, void _q_doLoadFinished(bool success)) > + Q_PRIVATE_SLOT(d, void _q_updateMicroFocus()) > > QGraphicsWebViewPrivate* const d; > friend class QGraphicsWebViewPrivate; 201278 2 51020 hausmann 2010-03-18 07:21:53 -0700 Comment on attachment 51020 Patch I think in principle this looks good, but I can see two things missing: * A ChangeLog entry * A comment indicating that this is a missing feature in QGraphicsItem, ideally with a link to an entry in the Qt JIRA tracking this missing feature. Then we can remove this code again once it's fixed in Qt. > +#if !defined(QT_NO_IM) && (defined(Q_WS_X11) || defined(Q_WS_QWS) || defined(Q_OS_SYMBIAN)) > + QList<QGraphicsView *> views = q->scene()->views(); Coding style, no space before the '*' > + for (int c = 0; c < views.size(); ++c) { > + QInputContext *ic = views[c]->inputContext(); I think you may want to use views.at(c) instead of [], to avoid detaching the QList that the scene returns. > + if (ic) > + ic->update(); Shouldn't this be a call to views.at(c)->updateMicroFocus() instead? 201301 3 kristian.amlie 2010-03-18 08:14:38 -0700 (In reply to comment #2) > * A comment indicating that this is a missing feature in QGraphicsItem, ideally > with a link to an entry in the Qt JIRA tracking this missing feature. Then we > can remove this code again once it's fixed in Qt. So what you are talking about is basically to have QGraphicsItem::updateMicroFocus()? I guess that makes sense, although it can't be a slot, because QGraphicsItem is not a QObject, so we would still need the extra slot in QGraphicsWebView. QGraphicsTextItem currently also solves this by calling ic->update(), although it looks at qApp->focusWidget() only, which might be smarter. > > + for (int c = 0; c < views.size(); ++c) { > > + QInputContext *ic = views[c]->inputContext(); > > I think you may want to use views.at(c) instead of [], to avoid detaching the > QList that the scene returns. I don't think it detaches as long as the called function is also const, but in the sake of clarity, you're right. :-) > > + if (ic) > > + ic->update(); > > Shouldn't this be a call to views.at(c)->updateMicroFocus() instead? Would be nice, but updateMicroFocus() is protected. 201321 4 hausmann 2010-03-18 08:46:14 -0700 (In reply to comment #3) > (In reply to comment #2) > > * A comment indicating that this is a missing feature in QGraphicsItem, ideally > > with a link to an entry in the Qt JIRA tracking this missing feature. Then we > > can remove this code again once it's fixed in Qt. > > So what you are talking about is basically to have > QGraphicsItem::updateMicroFocus()? I guess that makes sense, although it can't > be a slot, because QGraphicsItem is not a QObject, so we would still need the > extra slot in QGraphicsWebView. Right. It could be turned into a slot in QGraphicsObject, btw. Then we could also use it. But either way I think this should be filed in the Qt bug tracker and we should reference it here. > QGraphicsTextItem currently also solves this by calling ic->update(), although > it looks at qApp->focusWidget() only, which might be smarter. That's a good argument in favour of fixing it really in QGraphicsItem :-) > > > + for (int c = 0; c < views.size(); ++c) { > > > + QInputContext *ic = views[c]->inputContext(); > > > > I think you may want to use views.at(c) instead of [], to avoid detaching the > > QList that the scene returns. > > I don't think it detaches as long as the called function is also const, but in > the sake of clarity, you're right. :-) The variable is local, so why would the compiler choose the non-const [] overload? The constness of the currect function doesn't change that. > > > + if (ic) > > > + ic->update(); > > > > Shouldn't this be a call to views.at(c)->updateMicroFocus() instead? > > Would be nice, but updateMicroFocus() is protected. Dang! :) 201584 5 hausmann 2010-03-18 15:15:49 -0700 This is tracked upstream at http://bugreports.qt.nokia.com/browse/QTBUG-7578 . Kristian, can you add a link to that as a comment in the code? 201586 6 hausmann 2010-03-18 15:16:44 -0700 *** Bug 33836 has been marked as a duplicate of this bug. *** 201802 7 kristian.amlie 2010-03-19 03:19:52 -0700 (In reply to comment #4) > (In reply to comment #3) > > QGraphicsTextItem currently also solves this by calling ic->update(), although > > it looks at qApp->focusWidget() only, which might be smarter. > > That's a good argument in favour of fixing it really in QGraphicsItem :-) Indeed. I'll leave that in the task you mentioned for now, since this needs to go into 4.6 as well. > > > > + for (int c = 0; c < views.size(); ++c) { > > > > + QInputContext *ic = views[c]->inputContext(); > > > > > > I think you may want to use views.at(c) instead of [], to avoid detaching the > > > QList that the scene returns. > > > > I don't think it detaches as long as the called function is also const, but in > > the sake of clarity, you're right. :-) > > The variable is local, so why would the compiler choose the non-const [] > overload? The constness of the currect function doesn't change that. You're right, I was assuming that inputContext() was a const function, but it isn't, so the compiler would indeed choose the non-const operator[]. I'll get a modified patch up shortly. 201809 8 51142 kristian.amlie 2010-03-19 04:06:06 -0700 Created attachment 51142 Patch v2 201834 9 51142 hausmann 2010-03-19 06:35:27 -0700 Comment on attachment 51142 Patch v2 > +void QGraphicsWebViewPrivate::_q_updateMicroFocus() > +{ > +#if !defined(QT_NO_IM) && (defined(Q_WS_X11) || defined(Q_WS_QWS) || defined(Q_OS_SYMBIAN)) > + // Ideally, this should be handled by a common call to an updateMicroFocus function > + // in QGraphicsItem. See http://bugreports.qt.nokia.com/browse/QTBUG-7578. Why is this only enabled for X11/QWS/Symbian? 201861 10 kristian.amlie 2010-03-19 08:21:31 -0700 (In reply to comment #9) > (From update of attachment 51142 [details]) > > > +void QGraphicsWebViewPrivate::_q_updateMicroFocus() > > +{ > > +#if !defined(QT_NO_IM) && (defined(Q_WS_X11) || defined(Q_WS_QWS) || defined(Q_OS_SYMBIAN)) > > + // Ideally, this should be handled by a common call to an updateMicroFocus function > > + // in QGraphicsItem. See http://bugreports.qt.nokia.com/browse/QTBUG-7578. > > Why is this only enabled for X11/QWS/Symbian? I copied it from QWidget::updateMicroFocus(). 202369 11 51142 commit-queue 2010-03-21 16:21:12 -0700 Comment on attachment 51142 Patch v2 Clearing flags on attachment: 51142 Committed r56322: <http://trac.webkit.org/changeset/56322> 202370 12 commit-queue 2010-03-21 16:21:17 -0700 All reviewed patches have been landed. Closing bug. 203375 13 hausmann 2010-03-24 04:15:47 -0700 Cherry-picked into qtwebkit-4.6 with commit aa40cdb9595eb15a68e7be03322f973aa613a8f9 51020 2010-03-18 06:04:59 -0700 2010-03-19 04:06:06 -0700 Patch patch.txt text/plain 2119 kristian.amlie ZGlmZiAtLWdpdCBhL3NyYy8zcmRwYXJ0eS93ZWJraXQvV2ViS2l0L3F0L0FwaS9xZ3JhcGhpY3N3 ZWJ2aWV3LmNwcCBiL3NyYy8zcmRwYXJ0eS93ZWJraXQvV2ViS2l0L3F0L0FwaS9xZ3JhcGhpY3N3 ZWJ2aWV3LmNwcAppbmRleCBjZWI1ZWUxLi41Nzg2OTY1IDEwMDY0NAotLS0gYS9zcmMvM3JkcGFy dHkvd2Via2l0L1dlYktpdC9xdC9BcGkvcWdyYXBoaWNzd2Vidmlldy5jcHAKKysrIGIvc3JjLzNy ZHBhcnR5L3dlYmtpdC9XZWJLaXQvcXQvQXBpL3FncmFwaGljc3dlYnZpZXcuY3BwCkBAIC0zMCw2 ICszMCw3IEBACiAjaW5jbHVkZSA8UXRHdWkvcWFwcGxpY2F0aW9uLmg+CiAjaW5jbHVkZSA8UXRH dWkvcWdyYXBoaWNzc2NlbmVldmVudC5oPgogI2luY2x1ZGUgPFF0R3VpL3FzdHlsZW9wdGlvbi5o PgorI2luY2x1ZGUgPFF0R3VpL3FpbnB1dGNvbnRleHQuaD4KICNpZiBkZWZpbmVkKFFfV1NfWDEx KQogI2luY2x1ZGUgPFFYMTFJbmZvPgogI2VuZGlmCkBAIC02Myw2ICs2NCw4IEBAIHB1YmxpYzoK IAogICAgIHZvaWQgX3FfZG9Mb2FkRmluaXNoZWQoYm9vbCBzdWNjZXNzKTsKIAorICAgIHZvaWQg X3FfdXBkYXRlTWljcm9Gb2N1cygpOworCiAgICAgUUdyYXBoaWNzV2ViVmlldyogcTsKICAgICBR V2ViUGFnZSogcGFnZTsKIH07CkBAIC04MCw2ICs4MywxOCBAQCB2b2lkIFFHcmFwaGljc1dlYlZp ZXdQcml2YXRlOjpfcV9kb0xvYWRGaW5pc2hlZChib29sIHN1Y2Nlc3MpCiAgICAgZW1pdCBxLT5s b2FkRmluaXNoZWQoc3VjY2Vzcyk7CiB9CiAKK3ZvaWQgUUdyYXBoaWNzV2ViVmlld1ByaXZhdGU6 Ol9xX3VwZGF0ZU1pY3JvRm9jdXMoKQoreworI2lmICFkZWZpbmVkKFFUX05PX0lNKSAmJiAoZGVm aW5lZChRX1dTX1gxMSkgfHwgZGVmaW5lZChRX1dTX1FXUykgfHwgZGVmaW5lZChRX09TX1NZTUJJ QU4pKQorICAgIFFMaXN0PFFHcmFwaGljc1ZpZXcgKj4gdmlld3MgPSBxLT5zY2VuZSgpLT52aWV3 cygpOworICAgIGZvciAoaW50IGMgPSAwOyBjIDwgdmlld3Muc2l6ZSgpOyArK2MpIHsKKyAgICAg ICAgUUlucHV0Q29udGV4dCAqaWMgPSB2aWV3c1tjXS0+aW5wdXRDb250ZXh0KCk7CisgICAgICAg IGlmIChpYykKKyAgICAgICAgICAgIGljLT51cGRhdGUoKTsKKyAgICB9CisjZW5kaWYKK30KKwog dm9pZCBRR3JhcGhpY3NXZWJWaWV3UHJpdmF0ZTo6c2Nyb2xsKGludCBkeCwgaW50IGR5LCBjb25z dCBRUmVjdCYgcmVjdFRvU2Nyb2xsKQogewogICAgIHEtPnNjcm9sbChxcmVhbChkeCksIHFyZWFs KGR5KSwgUVJlY3RGKHJlY3RUb1Njcm9sbCkpOwpAQCAtNDM1LDYgKzQ1MCw4IEBAIHZvaWQgUUdy YXBoaWNzV2ViVmlldzo6c2V0UGFnZShRV2ViUGFnZSogcGFnZSkKICAgICAgICAgICAgIHRoaXMs IFNJR05BTChzdGF0dXNCYXJNZXNzYWdlKFFTdHJpbmcpKSk7CiAgICAgY29ubmVjdChkLT5wYWdl LCBTSUdOQUwobGlua0NsaWNrZWQoUVVybCkpLAogICAgICAgICAgICAgdGhpcywgU0lHTkFMKGxp bmtDbGlja2VkKFFVcmwpKSk7CisgICAgY29ubmVjdChkLT5wYWdlLCBTSUdOQUwobWljcm9Gb2N1 c0NoYW5nZWQoKSksCisgICAgICAgICAgICB0aGlzLCBTTE9UKF9xX3VwZGF0ZU1pY3JvRm9jdXMo KSkpOwogfQogCiAvKiEKZGlmZiAtLWdpdCBhL3NyYy8zcmRwYXJ0eS93ZWJraXQvV2ViS2l0L3F0 L0FwaS9xZ3JhcGhpY3N3ZWJ2aWV3LmggYi9zcmMvM3JkcGFydHkvd2Via2l0L1dlYktpdC9xdC9B cGkvcWdyYXBoaWNzd2Vidmlldy5oCmluZGV4IGYzYWZiNGMuLmY5ODNhZTQgMTAwNjQ0Ci0tLSBh L3NyYy8zcmRwYXJ0eS93ZWJraXQvV2ViS2l0L3F0L0FwaS9xZ3JhcGhpY3N3ZWJ2aWV3LmgKKysr IGIvc3JjLzNyZHBhcnR5L3dlYmtpdC9XZWJLaXQvcXQvQXBpL3FncmFwaGljc3dlYnZpZXcuaApA QCAtMTM0LDYgKzEzNCw3IEBAIHByb3RlY3RlZDoKIAogcHJpdmF0ZToKICAgICBRX1BSSVZBVEVf U0xPVChkLCB2b2lkIF9xX2RvTG9hZEZpbmlzaGVkKGJvb2wgc3VjY2VzcykpCisgICAgUV9QUklW QVRFX1NMT1QoZCwgdm9pZCBfcV91cGRhdGVNaWNyb0ZvY3VzKCkpCiAKICAgICBRR3JhcGhpY3NX ZWJWaWV3UHJpdmF0ZSogY29uc3QgZDsKICAgICBmcmllbmQgY2xhc3MgUUdyYXBoaWNzV2ViVmll d1ByaXZhdGU7Cg== 51142 2010-03-19 04:06:06 -0700 2010-03-21 16:21:11 -0700 Patch v2 patch.txt text/plain 3149 kristian.amlie Y29tbWl0IDc5OWI5YjdhZGMzYWFmZGM5ZDliY2UyZmNlN2NhNzM4MmNmYjE3MWIKQXV0aG9yOiBh eGlzIDxxdC1pbmZvQG5va2lhLmNvbT4KRGF0ZTogICBGcmkgTWFyIDE5IDEyOjAwOjQxIDIwMTAg KzAxMDAKCiAgICBGaXhlZCB1cGRhdGluZyB0aGUgVktCIGRpc3BsYXkgd2hlbiBpbnB1dHRpbmcg aW50byBRR3JhcGhpY3NXZWJWaWV3LgogICAgCiAgICBSZXZpZXdlZC1ieTogU2ltb24gSGF1c21h bm4KCmRpZmYgLS1naXQgYS9XZWJLaXQvcXQvQXBpL3FncmFwaGljc3dlYnZpZXcuY3BwIGIvV2Vi S2l0L3F0L0FwaS9xZ3JhcGhpY3N3ZWJ2aWV3LmNwcAppbmRleCA1YWI4MTNkLi42MmExM2E0IDEw MDY0NAotLS0gYS9XZWJLaXQvcXQvQXBpL3FncmFwaGljc3dlYnZpZXcuY3BwCisrKyBiL1dlYktp dC9xdC9BcGkvcWdyYXBoaWNzd2Vidmlldy5jcHAKQEAgLTQwLDYgKzQwLDcgQEAKICNpbmNsdWRl IDxRdEd1aS9xcGl4bWFwY2FjaGUuaD4KICNpbmNsdWRlIDxRdEd1aS9xc2Nyb2xsYmFyLmg+CiAj aW5jbHVkZSA8UXRHdWkvcXN0eWxlb3B0aW9uLmg+CisjaW5jbHVkZSA8UXRHdWkvcWlucHV0Y29u dGV4dC5oPgogI2lmIGRlZmluZWQoUV9XU19YMTEpCiAjaW5jbHVkZSA8UVgxMUluZm8+CiAjZW5k aWYKQEAgLTEzMiw2ICsxMzMsOCBAQCBwdWJsaWM6CiAgICAgdm9pZCBfcV9jb250ZW50c1NpemVD aGFuZ2VkKGNvbnN0IFFTaXplJik7CiAgICAgdm9pZCBfcV9zY2FsZUNoYW5nZWQoKTsKIAorICAg IHZvaWQgX3FfdXBkYXRlTWljcm9Gb2N1cygpOworCiAgICAgUUdyYXBoaWNzV2ViVmlldyogcTsK ICAgICBRV2ViUGFnZSogcGFnZTsKIApAQCAtMjQxLDYgKzI0NCwyMCBAQCB2b2lkIFFHcmFwaGlj c1dlYlZpZXdQcml2YXRlOjpfcV9kb0xvYWRGaW5pc2hlZChib29sIHN1Y2Nlc3MpCiAgICAgZW1p dCBxLT5sb2FkRmluaXNoZWQoc3VjY2Vzcyk7CiB9CiAKK3ZvaWQgUUdyYXBoaWNzV2ViVmlld1By aXZhdGU6Ol9xX3VwZGF0ZU1pY3JvRm9jdXMoKQoreworI2lmICFkZWZpbmVkKFFUX05PX0lNKSAm JiAoZGVmaW5lZChRX1dTX1gxMSkgfHwgZGVmaW5lZChRX1dTX1FXUykgfHwgZGVmaW5lZChRX09T X1NZTUJJQU4pKQorICAgIC8vIElkZWFsbHksIHRoaXMgc2hvdWxkIGJlIGhhbmRsZWQgYnkgYSBj b21tb24gY2FsbCB0byBhbiB1cGRhdGVNaWNyb0ZvY3VzIGZ1bmN0aW9uCisgICAgLy8gaW4gUUdy YXBoaWNzSXRlbS4gU2VlIGh0dHA6Ly9idWdyZXBvcnRzLnF0Lm5va2lhLmNvbS9icm93c2UvUVRC VUctNzU3OC4KKyAgICBRTGlzdDxRR3JhcGhpY3NWaWV3Kj4gdmlld3MgPSBxLT5zY2VuZSgpLT52 aWV3cygpOworICAgIGZvciAoaW50IGMgPSAwOyBjIDwgdmlld3Muc2l6ZSgpOyArK2MpIHsKKyAg ICAgICAgUUlucHV0Q29udGV4dCogaWMgPSB2aWV3cy5hdChjKS0+aW5wdXRDb250ZXh0KCk7Cisg ICAgICAgIGlmIChpYykKKyAgICAgICAgICAgIGljLT51cGRhdGUoKTsKKyAgICB9CisjZW5kaWYK K30KKwogdm9pZCBRR3JhcGhpY3NXZWJWaWV3UHJpdmF0ZTo6c2Nyb2xsKGludCBkeCwgaW50IGR5 LCBjb25zdCBRUmVjdCYgcmVjdFRvU2Nyb2xsKQogewogICAgIHEtPnNjcm9sbChxcmVhbChkeCks IHFyZWFsKGR5KSwgUVJlY3RGKHJlY3RUb1Njcm9sbCkpOwpAQCAtNzE2LDYgKzczMyw4IEBAIHZv aWQgUUdyYXBoaWNzV2ViVmlldzo6c2V0UGFnZShRV2ViUGFnZSogcGFnZSkKICAgICAgICAgICAg IHRoaXMsIFNJR05BTChzdGF0dXNCYXJNZXNzYWdlKFFTdHJpbmcpKSk7CiAgICAgY29ubmVjdChk LT5wYWdlLCBTSUdOQUwobGlua0NsaWNrZWQoUVVybCkpLAogICAgICAgICAgICAgdGhpcywgU0lH TkFMKGxpbmtDbGlja2VkKFFVcmwpKSk7CisgICAgY29ubmVjdChkLT5wYWdlLCBTSUdOQUwobWlj cm9Gb2N1c0NoYW5nZWQoKSksCisgICAgICAgICAgICB0aGlzLCBTTE9UKF9xX3VwZGF0ZU1pY3Jv Rm9jdXMoKSkpOwogfQogCiAvKiEKZGlmZiAtLWdpdCBhL1dlYktpdC9xdC9BcGkvcWdyYXBoaWNz d2Vidmlldy5oIGIvV2ViS2l0L3F0L0FwaS9xZ3JhcGhpY3N3ZWJ2aWV3LmgKaW5kZXggMzcyYzU1 MS4uZTcwYTBiOCAxMDA2NDQKLS0tIGEvV2ViS2l0L3F0L0FwaS9xZ3JhcGhpY3N3ZWJ2aWV3LmgK KysrIGIvV2ViS2l0L3F0L0FwaS9xZ3JhcGhpY3N3ZWJ2aWV3LmgKQEAgLTE0Miw2ICsxNDIsNyBA QCBwcm90ZWN0ZWQ6CiAKIHByaXZhdGU6CiAgICAgUV9QUklWQVRFX1NMT1QoZCwgdm9pZCBfcV9k b0xvYWRGaW5pc2hlZChib29sIHN1Y2Nlc3MpKQorICAgIFFfUFJJVkFURV9TTE9UKGQsIHZvaWQg X3FfdXBkYXRlTWljcm9Gb2N1cygpKQogICAgIC8vIHdlIGRvbid0IHdhbnQgdG8gY2hhbmdlIHRo ZSBtb2MgYmFzZWQgb24gVVNFKCkgbWFjcm8sIHNvIHRoaXMgZnVuY3Rpb24gaXMgaGVyZQogICAg IC8vIGJ1dCB3aWxsIGJlIGVtcHR5IGlmIEFDQ0xFUkFURURfQ09NUE9TSVRJTkcgaXMgZGlzYWJs ZWQKICAgICBRX1BSSVZBVEVfU0xPVChkLCB2b2lkIHN5bmNMYXllcnMoKSkKZGlmZiAtLWdpdCBh L1dlYktpdC9xdC9DaGFuZ2VMb2cgYi9XZWJLaXQvcXQvQ2hhbmdlTG9nCmluZGV4IGIyZDJiMjgu LjY2ZTJmMTMgMTAwNjQ0Ci0tLSBhL1dlYktpdC9xdC9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L3F0 L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEwLTAzLTE5ICBLcmlzdGlhbiBBbWxpZSAg PGtyaXN0aWFuLmFtbGllQG5va2lhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBTaW1vbiBI YXVzbWFubi4KKworICAgICAgICBGaXhlZCB1cGRhdGluZyB0aGUgVktCIGRpc3BsYXkgd2hlbiBp bnB1dHRpbmcgaW50byBRR3JhcGhpY3NXZWJWaWV3LgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzYyOTIKKworICAgICAgICAqIEFwaS9xZ3JhcGhpY3N3 ZWJ2aWV3LmNwcDoKKyAgICAgICAgKFFHcmFwaGljc1dlYlZpZXdQcml2YXRlOjpfcV91cGRhdGVN aWNyb0ZvY3VzKToKKyAgICAgICAgKFFHcmFwaGljc1dlYlZpZXc6OnNldFBhZ2UpOgorICAgICAg ICAqIEFwaS9xZ3JhcGhpY3N3ZWJ2aWV3Lmg6CisKIDIwMTAtMDMtMTggIEtlbm5ldGggUm9oZGUg Q2hyaXN0aWFuc2VuICA8a2VubmV0aEB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5 IERhcmluIEFkbGVyLgo=