36288 2010-03-18 01:07:40 -0700 Need a layout test for finding yensign from documents with Japanese encodings 2010-03-19 08:03:30 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 hamaji webkit-unassigned ap darin oldest_to_newest 201215 0 hamaji 2010-03-18 01:07:40 -0700 We need a layout test to ensure we can find a backslash in Japanese encodings by searching a yen sign. This test will help Bug 24906 because we can avoid regressions of searching. 201218 1 51014 hamaji 2010-03-18 01:11:10 -0700 Created attachment 51014 Patch v1 201219 2 hamaji 2010-03-18 01:18:28 -0700 On Windows, Qt, and Gtk, this test fails. I didn't examine the reason yet. On Windows and Qt, finding a backslash in non-text-control is failing. On Gtk, finding a backslash in both text-control and non-text-control is failing. Anyway, as I wrote in Bug 24906, I think we want to allow users to find both backslashes and yen signs by searching either a backslash or a yen sign. If people agrees with me, I'll change the searching code in some future day and these skip lists will be gone. 201656 3 51014 darin 2010-03-18 17:48:56 -0700 Comment on attachment 51014 Patch v1 In cases like this, I think that landing expected results that expect failure is better than adding tests to the Skipped lists. We can remove the expected failures when we fix the bug. r=me as-is, but I'd prefer to run tests rather than skipping them 201687 4 hamaji 2010-03-18 20:47:15 -0700 I see. I'll add failing expectations when I land. Thanks for your review! 201852 5 hamaji 2010-03-19 08:03:30 -0700 Committed r56238: <http://trac.webkit.org/changeset/56238> 51014 2010-03-18 01:11:10 -0700 2010-03-18 17:48:56 -0700 Patch v1 bug-36288-20100318011108.patch text/plain 4959 hamaji ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA2ODU0YWU3Li42ZGJlYmNkIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTAtMDMt MTggIFNoaW5pY2hpcm8gSGFtYWppICA8aGFtYWppQGNocm9taXVtLm9yZz4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBOZWVkIGEgbGF5b3V0IHRlc3Qg Zm9yIGZpbmRpbmcgeWVuc2lnbiBmcm9tIGRvY3VtZW50cyB3aXRoIEphcGFuZXNlIGVuY29kaW5n cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzYyODgK KworICAgICAgICAqIGVkaXRpbmcvc2VsZWN0aW9uL2ZpbmQteWVuc2lnbi1hbmQtYmFja3NsYXNo LWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogZWRpdGluZy9zZWxlY3Rpb24vZmluZC15 ZW5zaWduLWFuZC1iYWNrc2xhc2guaHRtbDogQWRkZWQuCisgICAgICAgICogcGxhdGZvcm0vZ3Rr L1NraXBwZWQ6CisgICAgICAgICogcGxhdGZvcm0vcXQvU2tpcHBlZDoKKyAgICAgICAgKiBwbGF0 Zm9ybS93aW4vU2tpcHBlZDoKKwogMjAxMC0wMy0xNiAgSm9obiBBYmQtRWwtTWFsZWsgIDxqYW1A Y2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEZpc2hlci4KZGlmZiAt LWdpdCBhL0xheW91dFRlc3RzL2VkaXRpbmcvc2VsZWN0aW9uL2ZpbmQteWVuc2lnbi1hbmQtYmFj a3NsYXNoLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2VkaXRpbmcvc2VsZWN0aW9uL2ZpbmQt eWVuc2lnbi1hbmQtYmFja3NsYXNoLWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NApp bmRleCAwMDAwMDAwLi5iYWEwNDkzCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZWRp dGluZy9zZWxlY3Rpb24vZmluZC15ZW5zaWduLWFuZC1iYWNrc2xhc2gtZXhwZWN0ZWQudHh0CkBA IC0wLDAgKzEsMTEgQEAKK1wtaW4tYm9keQorICAKK1Jlc3VsdHMKKworV2UgY2FuIGZpbmQgYSBi YWNrc2xhc2ggaW4gRVVDLUpQIHBhZ2UgYnkgZmluZGluZyBhIHllbiBzaWduOiBQQVNTCitXZSBj YW4gZmluZCBhIGJhY2tzbGFzaCBpbiBFVUMtSlAgdGV4dCBjb250cm9sIGJ5IGZpbmRpbmcgYSB5 ZW4gc2lnbjogUEFTUworV2UgY2FuIGZpbmQgYSBiYWNrc2xhc2ggaW4gU2hpZnRfSklTX1gwMjEz LTIwMDAgcGFnZSBieSBmaW5kaW5nIGEgeWVuIHNpZ246IFBBU1MKK1dlIGNhbiBmaW5kIGEgYmFj a3NsYXNoIGluIFNoaWZ0X0pJU19YMDIxMy0yMDAwIHRleHQgY29udHJvbCBieSBmaW5kaW5nIGEg eWVuIHNpZ246IFBBU1MKK1dlIGNhbiBOT1QgZmluZCBhIGJhY2tzbGFzaCBpbiBVVEY4IHBhZ2Ug YnkgZmluZGluZyBhIHllbiBzaWduOiBQQVNTCitXZSBjYW4gTk9UIGZpbmQgYSBiYWNrc2xhc2gg aW4gVVRGOCB0ZXh0IGNvbnRyb2wgYnkgZmluZGluZyBhIHllbiBzaWduOiBQQVNTCisKZGlmZiAt LWdpdCBhL0xheW91dFRlc3RzL2VkaXRpbmcvc2VsZWN0aW9uL2ZpbmQteWVuc2lnbi1hbmQtYmFj a3NsYXNoLmh0bWwgYi9MYXlvdXRUZXN0cy9lZGl0aW5nL3NlbGVjdGlvbi9maW5kLXllbnNpZ24t YW5kLWJhY2tzbGFzaC5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAuLjFi NzQ4YTEKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9lZGl0aW5nL3NlbGVjdGlvbi9m aW5kLXllbnNpZ24tYW5kLWJhY2tzbGFzaC5odG1sCkBAIC0wLDAgKzEsNTQgQEAKKzwhRE9DVFlQ RSBodG1sPgorPGh0bWw+CisKKzxoZWFkPgorPG1ldGEgY2hhcnNldD0iVVRGLTgiPgorPHNjcmlw dD4KKworaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikKKyAgICBsYXlvdXRUZXN0Q29u dHJvbGxlci5kdW1wQXNUZXh0KCk7CisKK2Z1bmN0aW9uIHNob3VsZEJlVHJ1ZShjb25kaXRpb24s IHRlc3ROYW1lKQoreworICAgIHZhciByZXN1bHQgPSB0ZXN0TmFtZSArICI6ICI7CisgICAgaWYg KGNvbmRpdGlvbikKKyAgICAgICAgcmVzdWx0ICs9ICJQQVNTIjsKKyAgICBlbHNlCisgICAgICAg IHJlc3VsdCArPSAiRkFJTCI7CisKKyAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgicmVzdWx0 cyIpLmlubmVySFRNTCArPSByZXN1bHQgKyAiPGJyPiI7Cit9CisKK2Z1bmN0aW9uIHRlc3QoKQor eworICAgIC8vIFdpdGggdGhlc2UgZW5jb2RpbmdzLCBiYWNrc2xhc2hlcyB3aWxsIGJlIHRyYW5z Y29kZWQgaW50byB5ZW4gc2lnbnMuCisgICAgdmFyIGVuY29kaW5ncyA9IFsiRVVDLUpQIiwgIlNo aWZ0X0pJU19YMDIxMy0yMDAwIl07CisgICAgZm9yICh2YXIgaSA9IDA7IGkgPCBlbmNvZGluZ3Mu bGVuZ3RoOyBpKyspIHsKKyAgICAgICAgdmFyIGVuY29kaW5nID0gZW5jb2RpbmdzW2ldOworICAg ICAgICB2YXIgZnJhbWVEb2N1bWVudCA9IGZyYW1lc1tpXS5kb2N1bWVudDsKKyAgICAgICAgc2hv dWxkQmVUcnVlKGZyYW1lRG9jdW1lbnQuZXhlY0NvbW1hbmQoIkZpbmRTdHJpbmciLCBmYWxzZSwg IsKlLWluLWJvZHkiKSwgIldlIGNhbiBmaW5kIGEgYmFja3NsYXNoIGluICIgKyBlbmNvZGluZyAr ICIgcGFnZSBieSBmaW5kaW5nIGEgeWVuIHNpZ24iKTsKKyAgICAgICAgc2hvdWxkQmVUcnVlKGZy YW1lRG9jdW1lbnQuZXhlY0NvbW1hbmQoIkZpbmRTdHJpbmciLCBmYWxzZSwgIsKlLWluLWlucHV0 IiksICJXZSBjYW4gZmluZCBhIGJhY2tzbGFzaCBpbiAiICsgZW5jb2RpbmcgKyAiIHRleHQgY29u dHJvbCBieSBmaW5kaW5nIGEgeWVuIHNpZ24iKTsKKyAgICB9CisKKyAgICBzaG91bGRCZVRydWUo IWRvY3VtZW50LmV4ZWNDb21tYW5kKCJGaW5kU3RyaW5nIiwgZmFsc2UsICLCpS1pbi1ib2R5Iiks ICJXZSBjYW4gTk9UIGZpbmQgYSBiYWNrc2xhc2ggaW4gVVRGOCBwYWdlIGJ5IGZpbmRpbmcgYSB5 ZW4gc2lnbiIpOworICAgIHNob3VsZEJlVHJ1ZSghZG9jdW1lbnQuZXhlY0NvbW1hbmQoIkZpbmRT dHJpbmciLCBmYWxzZSwgIsKlLWluLWlucHV0IiksICJXZSBjYW4gTk9UIGZpbmQgYSBiYWNrc2xh c2ggaW4gVVRGOCB0ZXh0IGNvbnRyb2wgYnkgZmluZGluZyBhIHllbiBzaWduIik7Cit9CisKKzwv c2NyaXB0PgorPC9oZWFkPgorCis8Ym9keSBvbmxvYWQ9InRlc3QoKSI+CisKKzxkaXY+XC1pbi1i b2R5PC9kaXY+Cis8aW5wdXQgdmFsdWU9XC1pbi1pbnB1dD4KKzxpZnJhbWUgc3JjPSJkYXRhOnRl eHQvaHRtbDtjaGFyc2V0PUVVQy1KUCw8Ym9keT5cLWluLWJvZHk8aW5wdXQgdmFsdWU9XC1pbi1p bnB1dD48L2JvZHk+Ij48L2lmcmFtZT4KKzxpZnJhbWUgc3JjPSJkYXRhOnRleHQvaHRtbDtjaGFy c2V0PVNoaWZ0X0pJU19YMDIxMy0yMDAwLDxib2R5PlwtaW4tYm9keTxpbnB1dCB2YWx1ZT1cLWlu LWlucHV0PjwvYm9keT4iPjwvaWZyYW1lPgorCis8cD5SZXN1bHRzPC9wPgorCis8cCBpZD0icmVz dWx0cyI+Cis8L3A+CisKKzwvYm9keT4KKworPC9odG1sPgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVz dHMvcGxhdGZvcm0vZ3RrL1NraXBwZWQgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvU2tpcHBl ZAppbmRleCBkNGU3YjIxLi4xMzdhNmUyIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9y bS9ndGsvU2tpcHBlZAorKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvU2tpcHBlZApAQCAt NTg0NSwzICs1ODQ1LDYgQEAgZmFzdC9kb20vR2VvbG9jYXRpb24vbWF4aW11bS1hZ2UuaHRtbAog IyBza2lwcGluZyBpdC4KICMgU2VlIGFsc28gaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTM2MTY1CiBtZWRpYS92aWRlby1wbGF5ZWQtY29sbGFwc2UuaHRtbAorCisjIFNl ZSBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzYyODgKK2VkaXRpbmcv c2VsZWN0aW9uL2ZpbmQteWVuc2lnbi1hbmQtYmFja3NsYXNoLmh0bWwKZGlmZiAtLWdpdCBhL0xh eW91dFRlc3RzL3BsYXRmb3JtL3F0L1NraXBwZWQgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC9T a2lwcGVkCmluZGV4IGNmYzMzNGIuLjA0MzE4MTcgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3Bs YXRmb3JtL3F0L1NraXBwZWQKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQvU2tpcHBlZApA QCAtNTExMCwzICs1MTEwLDYgQEAgZWRpdGluZy9leGVjQ29tbWFuZC9tb3ZlLXNlbGVjdGlvbi1i YWNrLWxpbmUuaHRtbAogCiAjIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0zNTk3MwogZmFzdC9tdWx0aWNvbC9oaXQtdGVzdC1hYm92ZS1vci1iZWxvdy5odG1sCisKKyMg U2VlIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNjI4OAorZWRpdGlu Zy9zZWxlY3Rpb24vZmluZC15ZW5zaWduLWFuZC1iYWNrc2xhc2guaHRtbApkaWZmIC0tZ2l0IGEv TGF5b3V0VGVzdHMvcGxhdGZvcm0vd2luL1NraXBwZWQgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS93 aW4vU2tpcHBlZAppbmRleCA5YTFmNTBiLi5mZDY0MWU5IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9wbGF0Zm9ybS93aW4vU2tpcHBlZAorKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS93aW4vU2tp cHBlZApAQCAtODA1LDMgKzgwNSw2IEBAIGZhc3QvZXZlbnRzL2NvbnRpbnVvdXMtcGxhdGZvcm0t d2hlZWxldmVudC1pbi1zY3JvbGxpbmctZGl2Lmh0bWwKIAogIyBXaW5kb3dzIHBvcnQgZG9lc24n dCB5ZXQgc3VwcG9ydCByZW5kZXJpbmcgb2Ygbm9uLUJNUCBjaGFyYWN0ZXJzIGV2ZW4gdGhvdWdo IHRoZXJlJ3MgYSBmb250IGF2YWlsYWJsZS4KIGZhc3QvdGV4dC9pbnRlcm5hdGlvbmFsL3BsYW5l Mi5odG1sIAorCisjIFNlZSBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MzYyODgKK2VkaXRpbmcvc2VsZWN0aW9uL2ZpbmQteWVuc2lnbi1hbmQtYmFja3NsYXNoLmh0bWwK