36272 2010-03-17 20:16:30 -0700 CSS3 :nth-child selector with implied step test fails 2010-03-23 13:53:07 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) All OS X 10.5 RESOLVED FIXED http://samples.msdn.microsoft.com/ietestcenter/css3/selectors/impliedValue.htm P2 Normal --- 1 simon.fraser hyatt oldest_to_newest 201153 0 50998 simon.fraser 2010-03-17 20:16:30 -0700 Created attachment 50998 Testcase The test here fails: http://samples.msdn.microsoft.com/ietestcenter/css3/selectors/impliedValue.htm 203180 1 51451 hyatt 2010-03-23 13:45:04 -0700 Created attachment 51451 Patch 203183 2 51451 simon.fraser 2010-03-23 13:48:01 -0700 Comment on attachment 51451 Patch Where is LayoutTests/ChangeLog? r=me. 203185 3 51451 darin 2010-03-23 13:49:36 -0700 Comment on attachment 51451 Patch > - $$->setArgument(String::number($4)); > + $$->setArgument(String::number($4*$5)); Should be $4 * $5 with spaces around the multiplication operator. I'd like to see test cases covering the edge cases, for example the maximum negative number. r=me 203189 4 hyatt 2010-03-23 13:53:07 -0700 Fixed in r56414. 50998 2010-03-17 20:16:30 -0700 2010-03-23 13:45:04 -0700 Testcase impliedValue.htm text/html 1840 simon.fraser PCFET0NUWVBFIEhUTUwgUFVCTElDICItLy9XM0MvL0RURCBIVE1MIDQuMCBTdHJpY3QvL0VOIj4N CjxodG1sPg0KPGhlYWQ+DQogICAgPHRpdGxlPkNTUyBUZXN0OiA6bnRoLWNoaWxkIHNlbGVjdG9y IHdpdGggaW1wbGllZCBzdGVwPC90aXRsZT4NCiAgICA8c3R5bGUgdHlwZT0idGV4dC9jc3MiPg0K ICAgIGRpdiBkaXY6bnRoLWNoaWxkKCsxKQ0KICAgIHsNCiAgICAgICAgY29sb3I6IGdyZWVuOw0K ICAgIH0NCjwvc3R5bGU+DQo8L2hlYWQ+DQo8Ym9keT4NCiAgICA8cD5UaGUgdGVzdCBwYXNzZXMg aWYgb25seSB0aGUgZmlyc3QgRElWIGlzIGdyZWVuLjwvcD4NCiAgICAgIDxkaXYgaWQ9InRlc3Qi Pg0KICAgICAgICAgIDxkaXY+RElWMTwvZGl2Pg0KICAgICAgICAgIDxkaXY+RElWMjwvZGl2Pg0K ICAgICAgICAgIDxkaXY+RElWMzwvZGl2Pg0KICAgICAgICAgIDxkaXY+RElWNDwvZGl2Pg0KICAg ICAgICAgIDxkaXY+RElWNTwvZGl2Pg0KICAgICAgICAgIDxkaXY+RElWNjwvZGl2Pg0KICAgICAg ICAgIDxkaXY+RElWNzwvZGl2Pg0KICAgICAgICAgIDxkaXY+RElWODwvZGl2Pg0KICAgICAgICAg IDxkaXY+RElWOTwvZGl2Pg0KICAgICAgICAgIDxkaXY+RElWMTA8L2Rpdj4NCiAgICAgIDwvZGl2 Pg0KICAgICAgPGRpdiBpZD0idGVzdHJlc3VsdCIgc3R5bGU9ImNvbG9yOiBibHVlIj5SdW5uaW5n PC9kaXY+DQogICAgPHNjcmlwdCB0eXBlPSJ0ZXh0L2phdmFzY3JpcHQiPg0KICAgICAgICBmdW5j dGlvbiBBcnJheUNvbnRhaW5zKGFycmF5LCB2YWx1ZSwgY2kpDQogICAgICAgIHsNCiAgICAgICAg ICAgIGNpID0gY2kgPT0gdHJ1ZSA/IHRydWUgOiBmYWxzZTsNCiAgICAgICAgICAgIGZvciAodmFy IGkgPSAwOyBpIDwgYXJyYXkubGVuZ3RoOyBpKyspDQogICAgICAgICAgICB7DQogICAgICAgICAg ICAgICAgaWYgKGNpICYmIGFycmF5W2ldLnRvTG93ZXJDYXNlKCkgPT0gdmFsdWUudG9Mb3dlckNh c2UoKSkNCiAgICAgICAgICAgICAgICB7DQogICAgICAgICAgICAgICAgICAgIHJldHVybiB0cnVl Ow0KICAgICAgICAgICAgICAgIH0NCiAgICAgICAgICAgICAgICBlbHNlIGlmIChhcnJheVtpXSA9 PSB2YWx1ZSkNCiAgICAgICAgICAgICAgICB7DQogICAgICAgICAgICAgICAgICAgIHJldHVybiB0 cnVlOw0KICAgICAgICAgICAgICAgIH0NCiAgICAgICAgICAgIH0NCiAgICAgICAgICAgIHJldHVy biBmYWxzZTsNCiAgICAgICAgfQ0KDQogICAgICAgIGZ1bmN0aW9uIFRlc3RDYXNlKCkNCiAgICAg ICAgew0KICAgICAgICAgdHJ5DQogICAgICAgICB7DQogICAgICAgIHZhciBncmVlblZhbHVlcyA9 IG5ldyBBcnJheSgiZ3JlZW4iLCAiIzAwODAwMCIsICJyZ2IoMCwgMTI4LCAwKSIpOw0KDQogICAg ICAgIHZhciBlbGVtID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoInRlc3QiKTsNCiAgICAgICAg dmFyIHZhbCA9IGdldENvbXB1dGVkU3R5bGUoZWxlbS5jaGlsZHJlblswXSwgbnVsbCkuZ2V0UHJv cGVydHlWYWx1ZSgiY29sb3IiKTsNCiAgICAgICAgaWYgKEFycmF5Q29udGFpbnMoZ3JlZW5WYWx1 ZXMsIHZhbCwgZmFsc2UpKQ0KICAgICAgICB7DQogICAgICAgICAgICBkb2N1bWVudC5nZXRFbGVt ZW50QnlJZCgidGVzdHJlc3VsdCIpLmlubmVySFRNTCA9ICJQYXNzIjsNCiAgICAgICAgICAgIHJl dHVybjsNCiAgICAgICAgfQ0KICAgICAgICAgfQ0KICAgICAgICAgY2F0Y2goZSl7fQ0KICAgICAg ICAgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoInRlc3RyZXN1bHQiKS5pbm5lckhUTUwgPSAi RmFpbCI7DQogICAgICAgIH0NCiAgICAgICAgVGVzdENhc2UoKTsNCiAgICA8L3NjcmlwdD4NCjwv Ym9keT4NCjwvaHRtbD4NCg== 51451 2010-03-23 13:45:04 -0700 2010-03-23 13:49:36 -0700 Patch patch.txt text/plain 5062 hyatt SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1NjQxMSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMTAtMDMtMjMgIERhdmlkIEh5YXR0ICA8aHlhdHRAYXBwbGUuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNjI3MiwgbWFrZSBzdXJlIG50aC1j aGlsZCBjYW4gd29yayB3aGVuIHRoZSBwb3J0aW9uIHdpdGggIm4iIGlzIG9taXR0ZWQuCisKKyAg ICAgICAgQWRkZWQgZmFzdC9jc3MvbnRoLWNoaWxkLWltcGxpZWQtc3RlcC5odG1sCisKKyAgICAg ICAgKiBjc3MvQ1NTR3JhbW1hci55OgorICAgICAgICAqIGNzcy90b2tlbml6ZXIuZmxleDoKKwog MjAxMC0wMy0yMyAgTHVpeiBBZ29zdGluaSAgPGx1aXouYWdvc3RpbmlAb3BlbmJvc3NhLm9yZz4K IAogICAgICAgICBSZXZpZXdlZCBieSBLZW5uZXRoIFJvaGRlIENocmlzdGlhbnNlbi4KSW5kZXg6 IFdlYkNvcmUvY3NzL0NTU0dyYW1tYXIueQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2Nzcy9DU1NH cmFtbWFyLnkJKHJldmlzaW9uIDU2NDEwKQorKysgV2ViQ29yZS9jc3MvQ1NTR3JhbW1hci55CSh3 b3JraW5nIGNvcHkpCkBAIC0yNDYsNiArMjQ2LDcgQEAgc3RhdGljIGludCBjc3N5eWxleChZWVNU WVBFKiB5eWx2YWwsIHZvaQogCiAldHlwZSA8aW50ZWdlcj4gbWF0Y2gKICV0eXBlIDxpbnRlZ2Vy PiB1bmFyeV9vcGVyYXRvcgorJXR5cGUgPGludGVnZXI+IG1heWJlX3VuYXJ5X29wZXJhdG9yCiAl dHlwZSA8Y2hhcmFjdGVyPiBvcGVyYXRvcgogCiAldHlwZSA8dmFsdWVMaXN0PiBleHByCkBAIC03 NjcsNiArNzY4LDExIEBAIGNvbWJpbmF0b3I6CiAgIHwgJz4nIG1heWJlX3NwYWNlIHsgJCQgPSBD U1NTZWxlY3Rvcjo6Q2hpbGQ7IH0KICAgOwogCittYXliZV91bmFyeV9vcGVyYXRvcjoKKyAgICB1 bmFyeV9vcGVyYXRvciB7ICQkID0gJDE7IH0KKyAgICB8IHsgJCQgPSAxOyB9CisgICAgOworCiB1 bmFyeV9vcGVyYXRvcjoKICAgICAnLScgeyAkJCA9IC0xOyB9CiAgIHwgJysnIHsgJCQgPSAxOyB9 CkBAIC0xMTI5LDExICsxMTM1LDExIEBAIHBzZXVkbzoKICAgICAgICAgfQogICAgIH0KICAgICAv LyB1c2VkIGJ5IDpudGgtKgotICAgIHwgJzonIEZVTkNUSU9OIG1heWJlX3NwYWNlIElOVEVHRVIg bWF5YmVfc3BhY2UgJyknIHsKKyAgICB8ICc6JyBGVU5DVElPTiBtYXliZV9zcGFjZSBtYXliZV91 bmFyeV9vcGVyYXRvciBJTlRFR0VSIG1heWJlX3NwYWNlICcpJyB7CiAgICAgICAgIENTU1BhcnNl ciAqcCA9IHN0YXRpY19jYXN0PENTU1BhcnNlcio+KHBhcnNlcik7CiAgICAgICAgICQkID0gcC0+ Y3JlYXRlRmxvYXRpbmdTZWxlY3RvcigpOwogICAgICAgICAkJC0+bV9tYXRjaCA9IENTU1NlbGVj dG9yOjpQc2V1ZG9DbGFzczsKLSAgICAgICAgJCQtPnNldEFyZ3VtZW50KFN0cmluZzo6bnVtYmVy KCQ0KSk7CisgICAgICAgICQkLT5zZXRBcmd1bWVudChTdHJpbmc6Om51bWJlcigkNCokNSkpOwog ICAgICAgICAkJC0+bV92YWx1ZSA9ICQyOwogICAgICAgICBDU1NTZWxlY3Rvcjo6UHNldWRvVHlw ZSB0eXBlID0gJCQtPnBzZXVkb1R5cGUoKTsKICAgICAgICAgaWYgKHR5cGUgPT0gQ1NTU2VsZWN0 b3I6OlBzZXVkb1Vua25vd24pCkluZGV4OiBXZWJDb3JlL2Nzcy90b2tlbml6ZXIuZmxleAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBXZWJDb3JlL2Nzcy90b2tlbml6ZXIuZmxleAkocmV2aXNpb24gNTY0MTApCisr KyBXZWJDb3JlL2Nzcy90b2tlbml6ZXIuZmxleAkod29ya2luZyBjb3B5KQpAQCAtMjQsNyArMjQs NyBAQCB1cmwgICAgICAgICAgICAgKFshIyQlJiotfl18e25vbmFzY2lpfXx7CiB3ICAgICAgICAg ICAgICAgWyBcdFxyXG5cZl0qCiBubCAgICAgICAgICAgICAgXG58XHJcbnxccnxcZgogcmFuZ2Ug ICAgICAgICAgIFw/ezEsNn18e2h9KFw/ezAsNX18e2h9KFw/ezAsNH18e2h9KFw/ezAsM318e2h9 KFw/ezAsMn18e2h9KFw/P3x7aH0pKSkpKQotbnRoICAgICAgICAgICAgIChbXCstXT9bMC05XSpu W1wrLV1bMC05XSspfCgtP1swLTldKm4pCitudGggICAgICAgICAgICAgW1wrLV0/e2ludG51bX0q bihbXCstXXtpbnRudW19KT8KIAogJSUKIApJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9jc3MvbnRo LWNoaWxkLWltcGxpZWQtc3RlcC1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVz dHMvZmFzdC9jc3MvbnRoLWNoaWxkLWltcGxpZWQtc3RlcC1leHBlY3RlZC50eHQJKHJldmlzaW9u IDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L2Nzcy9udGgtY2hpbGQtaW1wbGllZC1zdGVwLWV4cGVj dGVkLnR4dAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwxMyBAQAorVGhlIHRlc3QgcGFzc2VzIGlm IG9ubHkgdGhlIGZpcnN0IERJViBpcyBncmVlbi4KKworRElWMQorRElWMgorRElWMworRElWNAor RElWNQorRElWNgorRElWNworRElWOAorRElWOQorRElWMTAKK1Bhc3MKSW5kZXg6IExheW91dFRl c3RzL2Zhc3QvY3NzL250aC1jaGlsZC1pbXBsaWVkLXN0ZXAuaHRtbAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBM YXlvdXRUZXN0cy9mYXN0L2Nzcy9udGgtY2hpbGQtaW1wbGllZC1zdGVwLmh0bWwJKHJldmlzaW9u IDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L2Nzcy9udGgtY2hpbGQtaW1wbGllZC1zdGVwLmh0bWwJ KHJldmlzaW9uIDApCkBAIC0wLDAgKzEsNjkgQEAKKzwhRE9DVFlQRSBIVE1MIFBVQkxJQyAiLS8v VzNDLy9EVEQgSFRNTCA0LjAgU3RyaWN0Ly9FTiI+DQorPGh0bWw+DQorPGhlYWQ+DQorICAgIDx0 aXRsZT5DU1MgVGVzdDogOm50aC1jaGlsZCBzZWxlY3RvciB3aXRoIGltcGxpZWQgc3RlcDwvdGl0 bGU+DQorICAgIDxzdHlsZSB0eXBlPSJ0ZXh0L2NzcyI+DQorICAgIGRpdiBkaXY6bnRoLWNoaWxk KCsxKQ0KKyAgICB7DQorICAgICAgICBjb2xvcjogZ3JlZW47DQorICAgIH0NCis8L3N0eWxlPg0K KzxzY3JpcHQ+DQoraWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikNCisgICAgd2luZG93 LmxheW91dFRlc3RDb250cm9sbGVyLmR1bXBBc1RleHQoKTsNCis8L3NjcmlwdD4NCis8L2hlYWQ+ DQorPGJvZHk+DQorICAgIDxwPlRoZSB0ZXN0IHBhc3NlcyBpZiBvbmx5IHRoZSBmaXJzdCBESVYg aXMgZ3JlZW4uPC9wPg0KKyAgICAgIDxkaXYgaWQ9InRlc3QiPg0KKyAgICAgICAgICA8ZGl2PkRJ VjE8L2Rpdj4NCisgICAgICAgICAgPGRpdj5ESVYyPC9kaXY+DQorICAgICAgICAgIDxkaXY+RElW MzwvZGl2Pg0KKyAgICAgICAgICA8ZGl2PkRJVjQ8L2Rpdj4NCisgICAgICAgICAgPGRpdj5ESVY1 PC9kaXY+DQorICAgICAgICAgIDxkaXY+RElWNjwvZGl2Pg0KKyAgICAgICAgICA8ZGl2PkRJVjc8 L2Rpdj4NCisgICAgICAgICAgPGRpdj5ESVY4PC9kaXY+DQorICAgICAgICAgIDxkaXY+RElWOTwv ZGl2Pg0KKyAgICAgICAgICA8ZGl2PkRJVjEwPC9kaXY+DQorICAgICAgPC9kaXY+DQorICAgICAg PGRpdiBpZD0idGVzdHJlc3VsdCIgc3R5bGU9ImNvbG9yOiBibHVlIj5SdW5uaW5nPC9kaXY+DQor ICAgIDxzY3JpcHQgdHlwZT0idGV4dC9qYXZhc2NyaXB0Ij4NCisgICAgICAgIGZ1bmN0aW9uIEFy cmF5Q29udGFpbnMoYXJyYXksIHZhbHVlLCBjaSkNCisgICAgICAgIHsNCisgICAgICAgICAgICBj aSA9IGNpID09IHRydWUgPyB0cnVlIDogZmFsc2U7DQorICAgICAgICAgICAgZm9yICh2YXIgaSA9 IDA7IGkgPCBhcnJheS5sZW5ndGg7IGkrKykNCisgICAgICAgICAgICB7DQorICAgICAgICAgICAg ICAgIGlmIChjaSAmJiBhcnJheVtpXS50b0xvd2VyQ2FzZSgpID09IHZhbHVlLnRvTG93ZXJDYXNl KCkpDQorICAgICAgICAgICAgICAgIHsNCisgICAgICAgICAgICAgICAgICAgIHJldHVybiB0cnVl Ow0KKyAgICAgICAgICAgICAgICB9DQorICAgICAgICAgICAgICAgIGVsc2UgaWYgKGFycmF5W2ld ID09IHZhbHVlKQ0KKyAgICAgICAgICAgICAgICB7DQorICAgICAgICAgICAgICAgICAgICByZXR1 cm4gdHJ1ZTsNCisgICAgICAgICAgICAgICAgfQ0KKyAgICAgICAgICAgIH0NCisgICAgICAgICAg ICByZXR1cm4gZmFsc2U7DQorICAgICAgICB9DQorDQorICAgICAgICBmdW5jdGlvbiBUZXN0Q2Fz ZSgpDQorICAgICAgICB7DQorICAgICAgICAgdHJ5DQorICAgICAgICAgew0KKyAgICAgICAgdmFy IGdyZWVuVmFsdWVzID0gbmV3IEFycmF5KCJncmVlbiIsICIjMDA4MDAwIiwgInJnYigwLCAxMjgs IDApIik7DQorDQorICAgICAgICB2YXIgZWxlbSA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJ0 ZXN0Iik7DQorICAgICAgICB2YXIgdmFsID0gZ2V0Q29tcHV0ZWRTdHlsZShlbGVtLmNoaWxkcmVu WzBdLCBudWxsKS5nZXRQcm9wZXJ0eVZhbHVlKCJjb2xvciIpOw0KKyAgICAgICAgaWYgKEFycmF5 Q29udGFpbnMoZ3JlZW5WYWx1ZXMsIHZhbCwgZmFsc2UpKQ0KKyAgICAgICAgew0KKyAgICAgICAg ICAgIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJ0ZXN0cmVzdWx0IikuaW5uZXJIVE1MID0gIlBh c3MiOw0KKyAgICAgICAgICAgIHJldHVybjsNCisgICAgICAgIH0NCisgICAgICAgICB9DQorICAg ICAgICAgY2F0Y2goZSl7fQ0KKyAgICAgICAgICAgIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJ0 ZXN0cmVzdWx0IikuaW5uZXJIVE1MID0gIkZhaWwiOw0KKyAgICAgICAgfQ0KKyAgICAgICAgVGVz dENhc2UoKTsNCisgICAgPC9zY3JpcHQ+DQorPC9ib2R5Pg0KKzwvaHRtbD4NCg==