36264 2010-03-17 19:18:51 -0700 Teach what-broke how to look up reviewer and author Committer objects by name 2010-03-18 05:47:12 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 eric webkit-unassigned abarth commit-queue oldest_to_newest 201131 0 eric 2010-03-17 19:18:51 -0700 Teach what-broke how to look up reviewer and author Committer objects by name 201132 1 50993 eric 2010-03-17 19:20:43 -0700 Created attachment 50993 Patch 201134 2 eric 2010-03-17 19:22:19 -0700 It is clear to me now that we need a CommitInfo object to encapsulate all this logic. I will add one tomorrow. 201192 3 50993 abarth 2010-03-17 22:46:56 -0700 Comment on attachment 50993 Patch Ok. We'll need to add the SVN email address to committers.py if we don't have that there already. 201193 4 eric 2010-03-17 22:47:49 -0700 All emails are there for all committers. Or should be. The first email in the list is assumed to be the bugzilla email address. 201259 5 50993 commit-queue 2010-03-18 05:47:07 -0700 Comment on attachment 50993 Patch Clearing flags on attachment: 50993 Committed r56156: <http://trac.webkit.org/changeset/56156> 201260 6 commit-queue 2010-03-18 05:47:12 -0700 All reviewed patches have been landed. Closing bug. 50993 2010-03-17 19:20:43 -0700 2010-03-18 05:47:07 -0700 Patch bug-36264-20100317192042.patch text/plain 5020 eric ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBkY2Y4NTgzLi5kMTg5NzMyIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTAtMDMt MTcgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRlYWNoIHdoYXQtYnJva2UgaG93IHRvIGxvb2sg dXAgcmV2aWV3ZXIgYW5kIGF1dGhvciBDb21taXR0ZXIgb2JqZWN0cyBieSBuYW1lCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNjI2NAorCisgICAgICAg ICogU2NyaXB0cy93ZWJraXRweS9jb21tYW5kcy9xdWVyaWVzLnB5OgorICAgICAgICAgLSBBZGQg Y29tbWl0dGVyX2J5X25hbWUgbG9va3VwcyBmb3IgYm90aCByZXZpZXdlciBhbmQgYXV0aG9yCisg ICAgICAgICAtIEltcHJvdmUgcHJpbnRpbmcgaW4gdGhlIGNhc2VzIHdoZXJlIGxvb2t1cHMgZmFp bC4KKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2NvbW1pdHRlcnMucHk6CisgICAgICAgICAt IEFkZCBjb21taXR0ZXJfYnlfbmFtZQorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvY29tbWl0 dGVyc191bml0dGVzdC5weToKKyAgICAgICAgIC0gVGVzdCBjb21taXR0ZXJfYnlfbmFtZQorCiAy MDEwLTAzLTE3ICBDaGFuZyBTaHUgIDxjaGFuZy5zaHVAbm9raWEuY29tPgogCiAgICAgICAgIFJl dmlld2VkIGJ5IExhc3psbyBHb21ib3MuCmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9TY3JpcHRz L3dlYmtpdHB5L2NvbW1hbmRzL3F1ZXJpZXMucHkgYi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtp dHB5L2NvbW1hbmRzL3F1ZXJpZXMucHkKaW5kZXggMGFhM2NkMy4uMjg2MDAxMSAxMDA2NDQKLS0t IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tYW5kcy9xdWVyaWVzLnB5CisrKyBi L1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbWFuZHMvcXVlcmllcy5weQpAQCAtMTU3 LDIzICsxNTcsMjYgQEAgYW5kIGRpc3BsYXllcyB0aGUgc3RhdHVzIG9mIGVhY2ggYnVpbGRlci4i IiIKICAgICAgICAgIyBBc3N1bWUgZm9yIG5vdyB0aGF0IHRoZSBmaXJzdCBlbnRyeSBoYXMgZXZl cnl0aGluZyB3ZSBuZWVkOgogICAgICAgICBjaGFuZ2Vsb2dfZW50cnkgPSBjaGFuZ2Vsb2dfZW50 cmllc1swXQogICAgICAgICAjIEZJWE1FOiBUaGUgY29tbWl0IGluZm8gZGljdGlvbmFyeSBoZXJl IHNob3VsZCBwcm9iYWJseSBiZSBpdHMgb3duIGNsYXNzPworICAgICAgICBjb21taXR0ZXJfbGlz dCA9IENvbW1pdHRlckxpc3QoKQogICAgICAgICByZXR1cm4gewogICAgICAgICAgICAgImJ1Z19p ZCIgOiBwYXJzZV9idWdfaWQoY2hhbmdlbG9nX2VudHJ5LmNvbnRlbnRzKCkpLAogICAgICAgICAg ICAgInJldmlzaW9uIiA6IHJldmlzaW9uLAogICAgICAgICAgICAgImF1dGhvcl9uYW1lIiA6IGNo YW5nZWxvZ19lbnRyeS5hdXRob3JfbmFtZSgpLAogICAgICAgICAgICAgImF1dGhvcl9lbWFpbCIg OiBjaGFuZ2Vsb2dfZW50cnkuYXV0aG9yX2VtYWlsKCksCisgICAgICAgICAgICAiYXV0aG9yIiA6 IGNvbW1pdHRlcl9saXN0LmNvbW1pdHRlcl9ieV9lbWFpbChjaGFuZ2Vsb2dfZW50cnkuYXV0aG9y X2VtYWlsKCkpIG9yIGNvbW1pdHRlcl9saXN0LmNvbW1pdHRlcl9ieV9uYW1lKGNoYW5nZWxvZ19l bnRyeS5hdXRob3JfbmFtZSgpKSwKICAgICAgICAgICAgICJyZXZpZXdlcl90ZXh0IiA6IGNoYW5n ZWxvZ19lbnRyeS5yZXZpZXdlcl90ZXh0KCksICMgRklYTUU6IEV2ZW50dWFseSB3ZSBzaG91bGQg cmV0dXJuIGFuIG9iamVjdCBoZXJlLgorICAgICAgICAgICAgInJldmlld2VyIiA6IGNvbW1pdHRl cl9saXN0LmNvbW1pdHRlcl9ieV9uYW1lKGNoYW5nZWxvZ19lbnRyeS5yZXZpZXdlcl90ZXh0KCkp LAogICAgICAgICAgICAgImNvbW1pdHRlcl9lbWFpbCIgOiBjb21taXR0ZXJfZW1haWwsCi0gICAg ICAgICAgICAiY29tbWl0dGVyIiA6IENvbW1pdHRlckxpc3QoKS5jb21taXR0ZXJfYnlfZW1haWwo Y29tbWl0dGVyX2VtYWlsKSBpZiBjb21taXR0ZXJfZW1haWwgZWxzZSBOb25lCisgICAgICAgICAg ICAiY29tbWl0dGVyIiA6IGNvbW1pdHRlcl9saXN0LmNvbW1pdHRlcl9ieV9lbWFpbChjb21taXR0 ZXJfZW1haWwpIGlmIGNvbW1pdHRlcl9lbWFpbCBlbHNlIE5vbmUKICAgICAgICAgfQogCiAgICAg ZGVmIF9wcmludF9ibGFtZV9pbmZvcm1hdGlvbl9mb3JfY29tbWl0KHNlbGYsIGNvbW1pdF9pbmZv KToKICAgICAgICAgcHJpbnQgInIlczoiICUgY29tbWl0X2luZm9bInJldmlzaW9uIl0KICAgICAg ICAgcHJpbnQgIiAgJXMiICUgdmlld19zb3VyY2VfdXJsKGNvbW1pdF9pbmZvWyJyZXZpc2lvbiJd KQogICAgICAgICBwcmludCAiICBCdWc6ICVzICglcykiICUgKGNvbW1pdF9pbmZvWyJidWdfaWQi XSwgc2VsZi50b29sLmJ1Z3MuYnVnX3VybF9mb3JfYnVnX2lkKGNvbW1pdF9pbmZvWyJidWdfaWQi XSkpCi0gICAgICAgIHByaW50ICIgIEF1dGhvcjogJXMgPCVzPiIgJSAoY29tbWl0X2luZm9bImF1 dGhvcl9uYW1lIl0sIGNvbW1pdF9pbmZvWyJhdXRob3JfZW1haWwiXSkKLSAgICAgICAgcHJpbnQg IiAgUmV2aWV3ZXI6ICVzIiAlIGNvbW1pdF9pbmZvWyJyZXZpZXdlcl90ZXh0Il0KLSAgICAgICAg cHJpbnQgIiAgQ29tbWl0dGVyOiAlcyIgJSBjb21taXRfaW5mb1siY29tbWl0dGVyIl0KKyAgICAg ICAgcHJpbnQgIiAgQXV0aG9yOiAlcyIgJSBjb21taXRfaW5mb1siYXV0aG9yIl0gb3IgKCJcIiVz XCIgPCVzPiAlIiAlIChjb21taXRfaW5mb1siYXV0aG9yX25hbWUiXSwgY29tbWl0X2luZm9bImF1 dGhvcl9lbWFpbCJdKSkKKyAgICAgICAgcHJpbnQgIiAgUmV2aWV3ZXI6ICVzIiAlIGNvbW1pdF9p bmZvWyJyZXZpZXdlciJdIG9yIGNvbW1pdF9pbmZvWyJyZXZpZXdlcl90ZXh0Il0KKyAgICAgICAg cHJpbnQgIiAgQ29tbWl0dGVyOiAlcyIgJSBjb21taXRfaW5mb1siY29tbWl0dGVyIl0gb3IgY29t bWl0X2luZm9bImNvbW1pdHRlcl9lbWFpbCJdCiAKICAgICBkZWYgX3ByaW50X2JsYW1lX2luZm9y bWF0aW9uX2Zvcl9idWlsZGVyKHNlbGYsIGJ1aWxkZXJfc3RhdHVzLCBuYW1lX3dpZHRoKToKICAg ICAgICAgKGxhc3RfZ3JlZW5fYnVpbGQsIGZpcnN0X3JlZF9idWlsZCkgPSBzZWxmLl9maW5kX2dy ZWVuX3RvX3JlZF90cmFuc2l0aW9uKGJ1aWxkZXJfc3RhdHVzKQpkaWZmIC0tZ2l0IGEvV2ViS2l0 VG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21taXR0ZXJzLnB5IGIvV2ViS2l0VG9vbHMvU2NyaXB0 cy93ZWJraXRweS9jb21taXR0ZXJzLnB5CmluZGV4IDcyYjg0MjQuLmZlZmQ3OTAgMTAwNjQ0Ci0t LSBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbWl0dGVycy5weQorKysgYi9XZWJL aXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1pdHRlcnMucHkKQEAgLTI2Miw2ICsyNjIsMTIg QEAgY2xhc3MgQ29tbWl0dGVyTGlzdDoKICAgICAgICAgICAgICAgICAgICAgc2VsZi5fY29tbWl0 dGVyc19ieV9lbWFpbFtlbWFpbF0gPSBjb21taXR0ZXIKICAgICAgICAgcmV0dXJuIHNlbGYuX2Nv bW1pdHRlcnNfYnlfZW1haWwKIAorICAgIGRlZiBjb21taXR0ZXJfYnlfbmFtZShzZWxmLCBuYW1l KToKKyAgICAgICAgIyBUaGlzIGNvdWxkIGJlIG1hZGUgaW50byBhIGhhc2ggbG9va3VwIGlmIGNh bGxlcnMgbmVlZCBpdCB0byBiZSBmYXN0LgorICAgICAgICBmb3IgY29tbWl0dGVyIGluIHNlbGYu Y29tbWl0dGVycygpOgorICAgICAgICAgICAgaWYgY29tbWl0dGVyLmZ1bGxfbmFtZSA9PSBuYW1l OgorICAgICAgICAgICAgICAgIHJldHVybiBjb21taXR0ZXIKKwogICAgIGRlZiBjb21taXR0ZXJf YnlfZW1haWwoc2VsZiwgZW1haWwpOgogICAgICAgICByZXR1cm4gc2VsZi5fZW1haWxfdG9fY29t bWl0dGVyX21hcCgpLmdldChlbWFpbCkKIApkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvU2NyaXB0 cy93ZWJraXRweS9jb21taXR0ZXJzX3VuaXR0ZXN0LnB5IGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93 ZWJraXRweS9jb21taXR0ZXJzX3VuaXR0ZXN0LnB5CmluZGV4IGY1ZGM1MzkuLmMwMGMyYTQgMTAw NjQ0Ci0tLSBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbWl0dGVyc191bml0dGVz dC5weQorKysgYi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1pdHRlcnNfdW5pdHRl c3QucHkKQEAgLTQzLDYgKzQzLDExIEBAIGNsYXNzIENvbW1pdHRlcnNUZXN0KHVuaXR0ZXN0LlRl c3RDYXNlKToKICAgICAgICAgc2VsZi5hc3NlcnRFcXVhbChjb21taXR0ZXJfbGlzdC5jb21taXR0 ZXJfYnlfZW1haWwoJ3R3b0ByYWQuY29tJyksIHJldmlld2VyKQogICAgICAgICBzZWxmLmFzc2Vy dEVxdWFsKGNvbW1pdHRlcl9saXN0LnJldmlld2VyX2J5X2VtYWlsKCdzb190d29AZ21haWwuY29t JyksIHJldmlld2VyKQogCisgICAgICAgICMgVGVzdCB2YWxpZCBjb21taXR0ZXIgYW5kIHJldmll d2VyIGxvb2t1cAorICAgICAgICBzZWxmLmFzc2VydEVxdWFsKGNvbW1pdHRlcl9saXN0LmNvbW1p dHRlcl9ieV9uYW1lKCJUZXN0IE9uZSIpLCBjb21taXR0ZXIpCisgICAgICAgIHNlbGYuYXNzZXJ0 RXF1YWwoY29tbWl0dGVyX2xpc3QuY29tbWl0dGVyX2J5X25hbWUoIlRlc3QgVHdvIiksIHJldmll d2VyKQorICAgICAgICBzZWxmLmFzc2VydEVxdWFsKGNvbW1pdHRlcl9saXN0LmNvbW1pdHRlcl9i eV9uYW1lKCJUZXN0IFRocmVlIiksIE5vbmUpCisKICAgICAgICAgIyBUZXN0IHRoYXQgdGhlIGZp cnN0IGVtYWlsIGlzIGFzc3VtZWQgdG8gYmUgdGhlIEJ1Z3ppbGxhIGVtYWlsIGFkZHJlc3MgKGZv ciBub3cpCiAgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWwoY29tbWl0dGVyX2xpc3QuY29tbWl0dGVy X2J5X2VtYWlsKCd0d29AcmFkLmNvbScpLmJ1Z3ppbGxhX2VtYWlsKCksICd0d29AdGVzdC5jb20n KQogCg==