36255 2010-03-17 17:47:36 -0700 Remove Geolocation.lastPosition, no longer in the spec. 2010-04-21 13:16:05 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 darin darin kenneth steveblock oldest_to_newest 201079 0 darin 2010-03-17 17:47:36 -0700 Remove Geolocation.lastPosition, no longer in the spec. 201082 1 50983 darin 2010-03-17 17:50:37 -0700 Created attachment 50983 Patch 201087 2 50983 kenneth 2010-03-17 17:57:43 -0700 Comment on attachment 50983 Patch LGTM. 201515 3 darin 2010-03-18 13:33:55 -0700 Not sure why the EWS is not running on this patch. Maybe it only runs on review? patches? 201529 4 darin 2010-03-18 13:42:33 -0700 http://trac.webkit.org/changeset/56188 201635 5 steveblock 2010-03-18 16:37:32 -0700 The suspend() and resume() methods are used by Android (and soon Chromium). Is it possible to add them back? See Bug 36255 for how they're used. 201646 6 darin 2010-03-18 17:09:22 -0700 GeolocationServiceBridgeChromium.cpp says: getWebViewClient()->getGeolocationService()->suspend(m_bridgeId) Bug 36255 is this bug. If you do need those functions on certain platforms, then I suppose it's OK to bring them back. It's not good to have requirements that can't be seen by someone just be looking at the WebKit source tree. Android is not in a good state for maintenance until the WebKit code is checked in to the open source project. 201670 7 steveblock 2010-03-18 18:38:22 -0700 > Bug 36255 is this bug. Sorry, I meant Bug 34082 > It's not good to have requirements that can't be seen by > someone just be looking at the WebKit source tree. Android is not in a good > state for maintenance until the WebKit code is checked in to the open source > project. Agreed. We're working hard right now to upstream all of Android's WebKit code. 215459 8 steveblock 2010-04-21 13:16:05 -0700 > If you do need those functions on certain platforms, then I suppose it's OK to > bring them back. OK, I've opened Bug 37942 to track this. 50983 2010-03-17 17:50:37 -0700 2010-03-17 17:57:43 -0700 Patch bug-36255-20100317175036.patch text/plain 4863 darin SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1NjEzNikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjQgQEAKKzIwMTAtMDMtMTcgIERhcmluIEFkbGVyICA8ZGFyaW5AYXBwbGUuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlbW92 ZSBHZW9sb2NhdGlvbi5sYXN0UG9zaXRpb24sIG5vIGxvbmdlciBpbiB0aGUgc3BlYy4KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM2MjU1CisgICAgICAg IHJkYXI6Ly9wcm9ibGVtLzc3NDYzNTcKKworICAgICAgICAqIHBhZ2UvR2VvbG9jYXRpb24uY3Bw OgorICAgICAgICAoV2ViQ29yZTo6R2VvbG9jYXRpb246Omxhc3RQb3NpdGlvbik6IEFkZCBhbiBh c3NlcnRpb247IGl0J3Mgb25seSBsZWdhbCB0bworICAgICAgICBjYWxsIHRoaXMgaWYgYWNjZXNz IHRvIHRoZSBsb2NhdGlvbiBpcyBhbGxvd2VkLgorCisgICAgICAgICogcGFnZS9HZW9sb2NhdGlv bi5oOiBSZW1vdmVkIHVubmVlZGVkIGluY2x1ZGVzLiBNYWRlIGRlc3RydWN0b3Igbm9uLXZpcnR1 YWwsCisgICAgICAgIGFsdGhvdWdoIGl0IHdpbGwgc3RpbGwgYmUgdmlydHVhbCBpZiBhbnkgb2Yg dGhlIGJhc2UgY2xhc3NlcyBoYXZlIGEgdmlydHVhbAorICAgICAgICBkZXN0cnVjdG9yLiBNYWRl IGxhc3RQb3NpdGlvbiwgc2V0SXNBbGxvd2VkLCBpc0FsbG93ZWQsIGFuZCBpc0RlbmllZCBmdW5j dGlvbnMKKyAgICAgICAgcHJpdmF0ZS4gUmVtb3ZlZCB1bnVzZWQgc3VzcGVuZCwgcmVzdW1lLCBz ZXRTaG91bGRDbGVhckNhY2hlLCBzaG91bGRDbGVhckNhY2hlLAorICAgICAgICBhbmQgZnJhbWUg ZnVuY3Rpb25zLgorCisgICAgICAgICogcGFnZS9HZW9sb2NhdGlvbi5pZGw6IFJlbW92ZWQgbGFz dFBvc2l0aW9uIHJlYWQtb25seSBhdHRyaWJ1dGUuIE5vIGxvbmdlciBpbgorICAgICAgICB0aGUg R2VvbG9jYXRpb24gc3BlY2lmaWNhdGlvbi4KKwogMjAxMC0wMy0xNyAgRG1pdHJ5IFRpdG92ICA8 ZGltaWNoQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEaW1pdHJpIEdsYXpr b3YuCkluZGV4OiBXZWJDb3JlL3BhZ2UvR2VvbG9jYXRpb24uY3BwCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdl YkNvcmUvcGFnZS9HZW9sb2NhdGlvbi5jcHAJKHJldmlzaW9uIDU2MTM1KQorKysgV2ViQ29yZS9w YWdlL0dlb2xvY2F0aW9uLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjksNyArMjksNiBAQAogI2lu Y2x1ZGUgIkdlb2xvY2F0aW9uLmgiCiAKICNpbmNsdWRlICJDaHJvbWUuaCIKLSNpbmNsdWRlICJE b2N1bWVudC5oIgogI2luY2x1ZGUgIkZyYW1lLmgiCiAjaW5jbHVkZSAiUGFnZS5oIgogI2luY2x1 ZGUgPHd0Zi9DdXJyZW50VGltZS5oPgpAQCAtMjMyLDYgKzIzMSw4IEBAIHZvaWQgR2VvbG9jYXRp b246OmRpc2Nvbm5lY3RGcmFtZSgpCiAKIEdlb3Bvc2l0aW9uKiBHZW9sb2NhdGlvbjo6bGFzdFBv c2l0aW9uKCkKIHsKKyAgICBBU1NFUlQoaXNBbGxvd2VkKCkpOworCiAjaWYgRU5BQkxFKENMSUVO VF9CQVNFRF9HRU9MT0NBVElPTikKICAgICBpZiAoIW1fZnJhbWUpCiAgICAgICAgIHJldHVybiAw OwpAQCAtMzc5LDIyICszODAsNiBAQCB2b2lkIEdlb2xvY2F0aW9uOjpjbGVhcldhdGNoKGludCB3 YXRjaElkCiAgICAgICAgIHN0b3BVcGRhdGluZygpOwogfQogCi12b2lkIEdlb2xvY2F0aW9uOjpz dXNwZW5kKCkKLXsKLSNpZiAhRU5BQkxFKENMSUVOVF9CQVNFRF9HRU9MT0NBVElPTikKLSAgICBp ZiAoaGFzTGlzdGVuZXJzKCkpCi0gICAgICAgIG1fc2VydmljZS0+c3VzcGVuZCgpOwotI2VuZGlm Ci19Ci0KLXZvaWQgR2VvbG9jYXRpb246OnJlc3VtZSgpCi17Ci0jaWYgIUVOQUJMRShDTElFTlRf QkFTRURfR0VPTE9DQVRJT04pCi0gICAgaWYgKGhhc0xpc3RlbmVycygpKQotICAgICAgICBtX3Nl cnZpY2UtPnJlc3VtZSgpOwotI2VuZGlmCi19Ci0KIHZvaWQgR2VvbG9jYXRpb246OnNldElzQWxs b3dlZChib29sIGFsbG93ZWQpCiB7CiAgICAgLy8gVGhpcyBtYXkgYmUgZHVlIHRvIGVpdGhlciBh IG5ldyBwb3NpdGlvbiBmcm9tIHRoZSBzZXJ2aWNlLCBvciBhIGNhY2hlZApJbmRleDogV2ViQ29y ZS9wYWdlL0dlb2xvY2F0aW9uLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9wYWdlL0dlb2xvY2F0 aW9uLmgJKHJldmlzaW9uIDU2MTM1KQorKysgV2ViQ29yZS9wYWdlL0dlb2xvY2F0aW9uLmgJKHdv cmtpbmcgY29weSkKQEAgLTM1LDEzICszNSw2IEBACiAjaW5jbHVkZSAiUG9zaXRpb25FcnJvckNh bGxiYWNrLmgiCiAjaW5jbHVkZSAiUG9zaXRpb25PcHRpb25zLmgiCiAjaW5jbHVkZSAiVGltZXIu aCIKLSNpbmNsdWRlIDx3dGYvSGFzaE1hcC5oPgotI2luY2x1ZGUgPHd0Zi9IYXNoU2V0Lmg+Ci0j aW5jbHVkZSA8d3RmL093blB0ci5oPgotI2luY2x1ZGUgPHd0Zi9QYXNzUmVmUHRyLmg+Ci0jaW5j bHVkZSA8d3RmL1JlZkNvdW50ZWQuaD4KLSNpbmNsdWRlIDx3dGYvUmVmUHRyLmg+Ci0jaW5jbHVk ZSA8d3RmL1ZlY3Rvci5oPgogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKQEAgLTYwLDI3ICs1Mywx NCBAQCBjbGFzcyBHZW9sb2NhdGlvbiA6IHB1YmxpYyBSZWZDb3VudGVkPEdlCiBwdWJsaWM6CiAg ICAgc3RhdGljIFBhc3NSZWZQdHI8R2VvbG9jYXRpb24+IGNyZWF0ZShGcmFtZSogZnJhbWUpIHsg cmV0dXJuIGFkb3B0UmVmKG5ldyBHZW9sb2NhdGlvbihmcmFtZSkpOyB9CiAKLSAgICB2aXJ0dWFs IH5HZW9sb2NhdGlvbigpOworICAgIH5HZW9sb2NhdGlvbigpOwogCiAgICAgdm9pZCBkaXNjb25u ZWN0RnJhbWUoKTsKICAgICAKLSAgICBHZW9wb3NpdGlvbiogbGFzdFBvc2l0aW9uKCk7Ci0KICAg ICB2b2lkIGdldEN1cnJlbnRQb3NpdGlvbihQYXNzUmVmUHRyPFBvc2l0aW9uQ2FsbGJhY2s+LCBQ YXNzUmVmUHRyPFBvc2l0aW9uRXJyb3JDYWxsYmFjaz4sIFBhc3NSZWZQdHI8UG9zaXRpb25PcHRp b25zPik7CiAgICAgaW50IHdhdGNoUG9zaXRpb24oUGFzc1JlZlB0cjxQb3NpdGlvbkNhbGxiYWNr PiwgUGFzc1JlZlB0cjxQb3NpdGlvbkVycm9yQ2FsbGJhY2s+LCBQYXNzUmVmUHRyPFBvc2l0aW9u T3B0aW9ucz4pOwogICAgIHZvaWQgY2xlYXJXYXRjaChpbnQgd2F0Y2hJZCk7CiAKLSAgICB2b2lk IHN1c3BlbmQoKTsKLSAgICB2b2lkIHJlc3VtZSgpOwotCi0gICAgdm9pZCBzZXRJc0FsbG93ZWQo Ym9vbCk7Ci0gICAgYm9vbCBpc0FsbG93ZWQoKSBjb25zdCB7IHJldHVybiBtX2FsbG93R2VvbG9j YXRpb24gPT0gWWVzOyB9Ci0gICAgYm9vbCBpc0RlbmllZCgpIGNvbnN0IHsgcmV0dXJuIG1fYWxs b3dHZW9sb2NhdGlvbiA9PSBObzsgfQotICAgIAotICAgIHZvaWQgc2V0U2hvdWxkQ2xlYXJDYWNo ZShib29sIHNob3VsZENsZWFyQ2FjaGUpIHsgbV9zaG91bGRDbGVhckNhY2hlID0gc2hvdWxkQ2xl YXJDYWNoZTsgfQotICAgIGJvb2wgc2hvdWxkQ2xlYXJDYWNoZSgpIGNvbnN0IHsgcmV0dXJuIG1f c2hvdWxkQ2xlYXJDYWNoZTsgfQotICAgIEZyYW1lKiBmcmFtZSgpIGNvbnN0IHsgcmV0dXJuIG1f ZnJhbWU7IH0KLQogI2lmIEVOQUJMRShDTElFTlRfQkFTRURfR0VPTE9DQVRJT04pCiAgICAgdm9p ZCBzZXRQb3NpdGlvbihHZW9sb2NhdGlvblBvc2l0aW9uKik7CiAgICAgdm9pZCBzZXRFcnJvcihH ZW9sb2NhdGlvbkVycm9yKik7CkBAIC04OSw2ICs2OSwxMiBAQCBwdWJsaWM6CiAjZW5kaWYKIAog cHJpdmF0ZToKKyAgICBHZW9wb3NpdGlvbiogbGFzdFBvc2l0aW9uKCk7CisKKyAgICB2b2lkIHNl dElzQWxsb3dlZChib29sKTsKKyAgICBib29sIGlzQWxsb3dlZCgpIGNvbnN0IHsgcmV0dXJuIG1f YWxsb3dHZW9sb2NhdGlvbiA9PSBZZXM7IH0KKyAgICBib29sIGlzRGVuaWVkKCkgY29uc3QgeyBy ZXR1cm4gbV9hbGxvd0dlb2xvY2F0aW9uID09IE5vOyB9CisgICAgCiAgICAgR2VvbG9jYXRpb24o RnJhbWUqKTsKIAogICAgIGNsYXNzIEdlb05vdGlmaWVyIDogcHVibGljIFJlZkNvdW50ZWQ8R2Vv Tm90aWZpZXI+IHsKSW5kZXg6IFdlYkNvcmUvcGFnZS9HZW9sb2NhdGlvbi5pZGwKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gV2ViQ29yZS9wYWdlL0dlb2xvY2F0aW9uLmlkbAkocmV2aXNpb24gNTYxMzUpCisrKyBX ZWJDb3JlL3BhZ2UvR2VvbG9jYXRpb24uaWRsCSh3b3JraW5nIGNvcHkpCkBAIC0yNiw4ICsyNiw2 IEBACiBtb2R1bGUgY29yZSB7CiAKICAgICBpbnRlcmZhY2UgW09taXRDb25zdHJ1Y3Rvcl0gR2Vv bG9jYXRpb24gewotICAgICAgICByZWFkb25seSBhdHRyaWJ1dGUgR2VvcG9zaXRpb24gbGFzdFBv c2l0aW9uOwotCiAgICAgICAgIFtDdXN0b21dIHZvaWQgZ2V0Q3VycmVudFBvc2l0aW9uKGluIFBv c2l0aW9uQ2FsbGJhY2sgc3VjY2Vzc0NhbGxiYWNrLCBpbiBQb3NpdGlvbkVycm9yQ2FsbGJhY2sg ZXJyb3JDYWxsYmFjaywgaW4gUG9zaXRpb25PcHRpb25zIG9wdGlvbnMpOwogCiAgICAgICAgIFtD dXN0b21dIGxvbmcgd2F0Y2hQb3NpdGlvbihpbiBQb3NpdGlvbkNhbGxiYWNrIHN1Y2Nlc3NDYWxs YmFjaywgaW4gUG9zaXRpb25FcnJvckNhbGxiYWNrIGVycm9yQ2FsbGJhY2ssIGluIFBvc2l0aW9u T3B0aW9ucyBvcHRpb25zKTsK