36247 2010-03-17 15:58:37 -0700 Dragging a PDF image triggers assertion in DragController::startDrag() 2010-03-18 18:06:41 -0700 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 1 jianli jianli dglazkov oldest_to_newest 201019 0 jianli 2010-03-17 15:58:37 -0700 DragController.cpp:675: ASSERT(!image->filenameExtension().isEmpty()); We need to do the similar thing as in the fix for bug 32511: make PDFDocumentImage::filenameExtension() return a valid string. 201021 1 50967 jianli 2010-03-17 16:00:33 -0700 Created attachment 50967 Proposed Patch 201659 2 50967 dimich 2010-03-18 17:54:38 -0700 Comment on attachment 50967 Proposed Patch Looks good. 201662 3 jianli 2010-03-18 18:06:41 -0700 Committed as http://trac.webkit.org/changeset/56205. 50967 2010-03-17 16:00:33 -0700 2010-03-18 17:54:38 -0700 Proposed Patch 36247 text/plain 3668 jianli ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA0NWUzYWJhLi4yYTQ0NWQyIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTAtMDMt MTcgIEppYW4gTGkgIDxqaWFubGlAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIERyYWdnaW5nIGEgUERGIGltYWdlIHRyaWdnZXJz IGFzc2VydGlvbiBpbiBEcmFnQ29udHJvbGxlcjo6c3RhcnREcmFnKCkKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM2MjQ3CisKKyAgICAgICAgKiBmYXN0 L2ltYWdlcy9kcmFnLXBkZi1hcy1pbWFnZS1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAq IGZhc3QvaW1hZ2VzL2RyYWctcGRmLWFzLWltYWdlLmh0bWw6IEFkZGVkLgorCiAyMDEwLTAzLTE3 ICBLZW5uZXRoIFJ1c3NlbGwgIDxrYnJAZ29vZ2xlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBi eSBEYXJpbiBGaXNoZXIuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2ltYWdlcy9kcmFn LXBkZi1hcy1pbWFnZS1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9mYXN0L2ltYWdlcy9kcmFn LXBkZi1hcy1pbWFnZS1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAw MDAwMC4uNWM3NjhhOAotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvaW1hZ2Vz L2RyYWctcGRmLWFzLWltYWdlLWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDIgQEAKKworVGhpcyB0 ZXN0IGNoZWNrcyB0aGF0IGRyYWdnaW5nIGEgcGRmIGRvZXNuJ3QgY3Jhc2ggdGhlIGJyb3dzZXIu CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2ltYWdlcy9kcmFnLXBkZi1hcy1pbWFnZS5o dG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9pbWFnZXMvZHJhZy1wZGYtYXMtaW1hZ2UuaHRtbApuZXcg ZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwLi5hZGM3OTczCi0tLSAvZGV2L251bGwKKysr IGIvTGF5b3V0VGVzdHMvZmFzdC9pbWFnZXMvZHJhZy1wZGYtYXMtaW1hZ2UuaHRtbApAQCAtMCww ICsxLDMwIEBACis8aHRtbD4KKzxoZWFkPgorPHNjcmlwdCB0eXBlPSJ0ZXh0L2phdmFzY3JpcHQi PgorZnVuY3Rpb24gdGVzdCgpIHsKKworICAgIGlmICghd2luZG93LmxheW91dFRlc3RDb250cm9s bGVyIHx8ICF3aW5kb3cuZXZlbnRTZW5kZXIpCisgICAgICAgIHJldHVybjsKKworICAgIGxheW91 dFRlc3RDb250cm9sbGVyLmR1bXBBc1RleHQoKTsKKworICAgIHZhciBkcmFnTWUgPSBkb2N1bWVu dC5nZXRFbGVtZW50QnlJZCgiZHJhZ01lIik7CisgICAgdmFyIHN0YXJ0WCA9IGRyYWdNZS5vZmZz ZXRMZWZ0ICsgKGRyYWdNZS5vZmZzZXRXaWR0aCAvIDIpOworICAgIHZhciBzdGFydFkgPSBkcmFn TWUub2Zmc2V0VG9wICsgKGRyYWdNZS5vZmZzZXRUb3AgLyAyKTsKKyAgICB2YXIgZW5kWCA9IHN0 YXJ0WCArIDEwMDsKKyAgICB2YXIgZW5kWSA9IHN0YXJ0WSArIDEwMDsKKworICAgIGV2ZW50U2Vu ZGVyLm1vdXNlTW92ZVRvKHN0YXJ0WCwgc3RhcnRZKTsKKyAgICBldmVudFNlbmRlci5tb3VzZURv d24oKTsKKyAgICBldmVudFNlbmRlci5tb3VzZU1vdmVUbyhlbmRYLCBlbmRZKTsKKyAgICBldmVu dFNlbmRlci5tb3VzZVVwKCk7Cit9Cis8L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5IG9ubG9hZD0i dGVzdCgpIj4KKyAgICA8aW1nIGlkPSJkcmFnTWUiIHNyYz0ncmVzb3VyY2VzL3BkZl90ZXN0X2xh bmRzY2FwZS5wZGYnPgorICAgIDxkaXY+CisgICAgICAgIFRoaXMgdGVzdCBjaGVja3MgdGhhdCBk cmFnZ2luZyBhIHBkZiBkb2Vzbid0IGNyYXNoIHRoZSBicm93c2VyLgorICAgIDwvZGl2PgorPC9i b2R5PgorPC9odG1sPgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBjYTQ5OGJkLi5mMWJlYzIwIDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5n ZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEwLTAzLTE3 ICBKaWFuIExpICA8amlhbmxpQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBEcmFnZ2luZyBhIFBERiBpbWFnZSB0cmlnZ2VycyBh c3NlcnRpb24gaW4gRHJhZ0NvbnRyb2xsZXI6OnN0YXJ0RHJhZygpCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNjI0NworCisgICAgICAgIFRlc3Q6IGZh c3QvaW1hZ2VzL2RyYWctcGRmLWFzLWltYWdlLmh0bWwKKworICAgICAgICAqIHBsYXRmb3JtL2dy YXBoaWNzL2NnL1BERkRvY3VtZW50SW1hZ2UuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UERGRG9j dW1lbnRJbWFnZTo6ZmlsZW5hbWVFeHRlbnNpb24pOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBo aWNzL2NnL1BERkRvY3VtZW50SW1hZ2UuaDoKKwogMjAxMC0wMy0xNyAgS2VubmV0aCBSdXNzZWxs ICA8a2JyQGdvb2dsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gRmlzaGVyLgpk aWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jZy9QREZEb2N1bWVudEltYWdl LmNwcCBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2cvUERGRG9jdW1lbnRJbWFnZS5jcHAK aW5kZXggNDVhMjBiOS4uOGJmMDRmMSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9jZy9QREZEb2N1bWVudEltYWdlLmNwcAorKysgYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL2NnL1BERkRvY3VtZW50SW1hZ2UuY3BwCkBAIC01Niw2ICs1NiwxMSBAQCBQREZEb2N1bWVu dEltYWdlOjp+UERGRG9jdW1lbnRJbWFnZSgpCiAgICAgQ0dQREZEb2N1bWVudFJlbGVhc2UobV9k b2N1bWVudCk7CiB9CiAKK1N0cmluZyBQREZEb2N1bWVudEltYWdlOjpmaWxlbmFtZUV4dGVuc2lv bigpIGNvbnN0Cit7CisgICAgcmV0dXJuICJwZGYiOworfQorCiBJbnRTaXplIFBERkRvY3VtZW50 SW1hZ2U6OnNpemUoKSBjb25zdAogewogICAgIGNvbnN0IGZsb2F0IHNpbmEgPSBzaW5mKC1tX3Jv dGF0aW9uKTsKZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2cvUERGRG9j dW1lbnRJbWFnZS5oIGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jZy9QREZEb2N1bWVudElt YWdlLmgKaW5kZXggMTJhYjQ2Yy4uNzkwZDYyMCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9jZy9QREZEb2N1bWVudEltYWdlLmgKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9jZy9QREZEb2N1bWVudEltYWdlLmgKQEAgLTQ2LDYgKzQ2LDggQEAgbmFtZXNwYWNl IFdlYkNvcmUgewogICAgIHByaXZhdGU6CiAgICAgICAgIHZpcnR1YWwgflBERkRvY3VtZW50SW1h Z2UoKTsKIAorICAgICAgICB2aXJ0dWFsIFN0cmluZyBmaWxlbmFtZUV4dGVuc2lvbigpIGNvbnN0 OworCiAgICAgICAgIHZpcnR1YWwgYm9vbCBoYXNTaW5nbGVTZWN1cml0eU9yaWdpbigpIGNvbnN0 IHsgcmV0dXJuIHRydWU7IH0KIAogICAgICAgICB2aXJ0dWFsIGJvb2wgZGF0YUNoYW5nZWQoYm9v bCBhbGxEYXRhUmVjZWl2ZWQpOwo=