36230 2010-03-17 11:23:44 -0700 Image_diff.py for layout test is broken if no diff file specified 2010-03-17 15:21:21 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 1 victorw victorw dglazkov dpranke ojan oldest_to_newest 200877 0 victorw 2010-03-17 11:23:44 -0700 In webkitpy/port/base.py, the syntax of command image_diff is wrong if no diff_filename specified. This breaks rebaseline tool. 200884 1 50928 victorw 2010-03-17 11:36:23 -0700 Created attachment 50928 Proposed patch 200886 2 50928 dglazkov 2010-03-17 11:39:28 -0700 Comment on attachment 50928 Proposed patch yay! 200888 3 victorw 2010-03-17 11:45:39 -0700 Committed r56123: <http://trac.webkit.org/changeset/56123> 200965 4 50928 dpranke 2010-03-17 14:18:00 -0700 Comment on attachment 50928 Proposed patch I wonder if it would be better to split this into a different routine called compare_images() that compared them but didn't produce an actual diff, just like we have compare_text() and diff_text(). 200992 5 victorw 2010-03-17 15:21:21 -0700 Sounds fine to me. (In reply to comment #4) > (From update of attachment 50928 [details]) > I wonder if it would be better to split this into a different routine called > compare_images() that compared them but didn't produce an actual diff, just > like we have compare_text() and diff_text(). 50928 2010-03-17 11:36:23 -0700 2010-03-17 14:18:00 -0700 Proposed patch base.patch text/plain 1553 victorw SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDU2MTIyKQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMDMtMTcgIFZpY3RvciBXYW5nICA8dmlj dG9yd0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgRml4IGltYWdlX2RpZmYgc3ludGF4IGluIHdlYmtpdHB5L3BvcnQvYmFzZS5w eS4KKyAgICAgICAgVGhlIHN5bnRheCBpcyB3cm9uZyBpZiBkaWZmX2ZpbGVuYW1lIGlzIHNwZWNp ZmllZC4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MzYyMzAKKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvYmFz ZS5weToKKwogMjAxMC0wMy0xNiAgRGllZ28gR29uemFsZXogIDxkaWVnby5nb256YWxlekBvcGVu Ym9zc2Eub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEtlbm5ldGggQ2hyaXN0aWFuc2VuLgpJ bmRleDogV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9iYXNl LnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFdlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rl c3RzL3BvcnQvYmFzZS5weQkocmV2aXNpb24gNTYxMjIpCisrKyBXZWJLaXRUb29scy9TY3JpcHRz L3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2Jhc2UucHkJKHdvcmtpbmcgY29weSkKQEAgLTEw MCw5ICsxMDAsMTMgQEAgY2xhc3MgUG9ydChvYmplY3QpOgogICAgICAgICBXaGlsZSB0aGlzIGlz IGEgZ2VuZXJpYyByb3V0aW5lLCB3ZSBpbmNsdWRlIGl0IGluIHRoZSBQb3J0CiAgICAgICAgIGlu dGVyZmFjZSBzbyB0aGF0IGl0IGNhbiBiZSBvdmVycmlkZW4gZm9yIHRlc3RpbmcgcHVycG9zZXMu IiIiCiAgICAgICAgIGV4ZWN1dGFibGUgPSBzZWxmLl9wYXRoX3RvX2ltYWdlX2RpZmYoKQotICAg ICAgICBjbWQgPSBbZXhlY3V0YWJsZSwgJy0tZGlmZicsIGV4cGVjdGVkX2ZpbGVuYW1lLCBhY3R1 YWxfZmlsZW5hbWVdCisKICAgICAgICAgaWYgZGlmZl9maWxlbmFtZToKLSAgICAgICAgICAgIGNt ZC5hcHBlbmQoZGlmZl9maWxlbmFtZSkKKyAgICAgICAgICAgIGNtZCA9IFtleGVjdXRhYmxlLCAn LS1kaWZmJywgZXhwZWN0ZWRfZmlsZW5hbWUsIGFjdHVhbF9maWxlbmFtZSwKKyAgICAgICAgICAg ICAgICAgICBkaWZmX2ZpbGVuYW1lXQorICAgICAgICBlbHNlOgorICAgICAgICAgICAgY21kID0g W2V4ZWN1dGFibGUsIGV4cGVjdGVkX2ZpbGVuYW1lLCBhY3R1YWxfZmlsZW5hbWVdCisKICAgICAg ICAgcmVzdWx0ID0gMQogICAgICAgICB0cnk6CiAgICAgICAgICAgICByZXN1bHQgPSBzdWJwcm9j ZXNzLmNhbGwoY21kKQo=