36221 2010-03-17 07:57:28 -0700 [Android] V8 bindings lack ENABLE(WORKERS) guards 2010-03-17 08:26:30 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Android Android RESOLVED FIXED P2 Normal --- 1 steveblock webkit-unassigned android-webkit-unforking japhet steveblock oldest_to_newest 200783 0 steveblock 2010-03-17 07:57:28 -0700 The V8 bindings lack ENABLE(WORKERS) guards. This causes build errors on Android, which no longer enables workers. 200785 1 50907 steveblock 2010-03-17 08:01:03 -0700 Created attachment 50907 Patch 200788 2 50907 dglazkov 2010-03-17 08:06:09 -0700 Comment on attachment 50907 Patch ok. 200795 3 steveblock 2010-03-17 08:26:30 -0700 Committed r56112: <http://trac.webkit.org/changeset/56112> 50907 2010-03-17 08:01:03 -0700 2010-03-17 08:06:09 -0700 Patch bug-36221-20100317150101.patch text/plain 2706 steveblock SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1NjExMSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTcgQEAKKzIwMTAtMDMtMTcgIFN0ZXZlIEJsb2NrICA8c3RldmVibG9ja0Bnb29n bGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IEFkZHMgRU5BQkxFKFdPUktFUlMpIGd1YXJkcyB0byBWOCBiaW5kaW5ncworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzYyMjEKKworICAgICAgICBCdWls ZCBmaXggb25seSwgbm8gbmV3IHRlc3RzLgorCisgICAgICAgICogYmluZGluZ3MvdjgvVjhET01X cmFwcGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlY4RE9NV3JhcHBlcjo6aW5zdGFudGlhdGVW OE9iamVjdCk6CisgICAgICAgICogYmluZGluZ3MvdjgvVjhQcm94eS5jcHA6CisgICAgICAgIChX ZWJDb3JlOjp0b1Y4Q29udGV4dCk6CisKIDIwMTAtMDMtMTcgIFl1cnkgU2VtaWtoYXRza3kgIDx5 dXJ5c0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgUGF2ZWwgRmVsZG1hbi4K SW5kZXg6IFdlYkNvcmUvYmluZGluZ3MvdjgvVjhET01XcmFwcGVyLmNwcAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBXZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4RE9NV3JhcHBlci5jcHAJKHJldmlzaW9uIDU2MTExKQor KysgV2ViQ29yZS9iaW5kaW5ncy92OC9WOERPTVdyYXBwZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBA IC0xOTgsNiArMTk4LDcgQEAgdjg6OkxvY2FsPHY4OjpGdW5jdGlvbj4gVjhET01XcmFwcGVyOjpn ZQogICAgIHJldHVybiBnZXRDb25zdHJ1Y3RvckZvckNvbnRleHQodHlwZSwgY29udGV4dCk7CiB9 CiAKKyNpZiBFTkFCTEUoV09SS0VSUykKIHY4OjpMb2NhbDx2ODo6RnVuY3Rpb24+IFY4RE9NV3Jh cHBlcjo6Z2V0Q29uc3RydWN0b3IoV3JhcHBlclR5cGVJbmZvKiB0eXBlLCBXb3JrZXJDb250ZXh0 KikKIHsKICAgICBXb3JrZXJDb250ZXh0RXhlY3V0aW9uUHJveHkqIHByb3h5ID0gV29ya2VyQ29u dGV4dEV4ZWN1dGlvblByb3h5OjpyZXRyaWV2ZSgpOwpAQCAtMjEwLDYgKzIxMSw3IEBAIHY4OjpM b2NhbDx2ODo6RnVuY3Rpb24+IFY4RE9NV3JhcHBlcjo6Z2UKIAogICAgIHJldHVybiBnZXRDb25z dHJ1Y3RvckZvckNvbnRleHQodHlwZSwgY29udGV4dCk7CiB9CisjZW5kaWYKIAogdm9pZCBWOERP TVdyYXBwZXI6OnNldEhpZGRlbldpbmRvd1JlZmVyZW5jZShGcmFtZSogZnJhbWUsIGNvbnN0IGlu dCBpbnRlcm5hbEluZGV4LCB2ODo6SGFuZGxlPHY4OjpPYmplY3Q+IGpzT2JqZWN0KQogewpAQCAt MjgxLDggKzI4MywxMCBAQCB2ODo6TG9jYWw8djg6Ok9iamVjdD4gVjhET01XcmFwcGVyOjppbnN0 CiAgICAgICAgICAgICB2ODo6SGFuZGxlPHY4OjpPYmplY3Q+IGdsb2JhbFByb3RvdHlwZSA9IHY4 OjpIYW5kbGU8djg6Ok9iamVjdD46OkNhc3QoY29udGV4dC0+R2xvYmFsKCktPkdldFByb3RvdHlw ZSgpKTsKICAgICAgICAgICAgIGlmIChnbG9iYWxPYmplY3RQcm90b3R5cGVJc0RPTVdpbmRvdyhn bG9iYWxQcm90b3R5cGUpKQogICAgICAgICAgICAgICAgIHByb3h5ID0gVjhQcm94eTo6cmV0cmll dmUoVjhET01XaW5kb3c6OnRvTmF0aXZlKGdsb2JhbFByb3RvdHlwZSktPmZyYW1lKCkpOworI2lm IEVOQUJMRShXT1JLRVJTKQogICAgICAgICAgICAgZWxzZQogICAgICAgICAgICAgICAgIHdvcmtl ckNvbnRleHQgPSBWOFdvcmtlckNvbnRleHQ6OnRvTmF0aXZlKGxvb2t1cERPTVdyYXBwZXIoVjhX b3JrZXJDb250ZXh0OjpHZXRUZW1wbGF0ZSgpLCBjb250ZXh0LT5HbG9iYWwoKSkpOworI2VuZGlm CiAgICAgICAgIH0KICAgICB9CiAKSW5kZXg6IFdlYkNvcmUvYmluZGluZ3MvdjgvVjhQcm94eS5j cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9iaW5kaW5ncy92OC9WOFByb3h5LmNwcAkocmV2aXNp b24gNTYxMTEpCisrKyBXZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4UHJveHkuY3BwCSh3b3JraW5nIGNv cHkpCkBAIC04ODcsOSArODg3LDExIEBAIHY4OjpMb2NhbDx2ODo6Q29udGV4dD4gdG9WOENvbnRl eHQoU2NyaXAKICAgICBpZiAoY29udGV4dC0+aXNEb2N1bWVudCgpKSB7CiAgICAgICAgIGlmIChW OFByb3h5KiBwcm94eSA9IFY4UHJveHk6OnJldHJpZXZlKGNvbnRleHQpKQogICAgICAgICAgICAg cmV0dXJuIHdvcmxkQ29udGV4dC5hZGp1c3RlZENvbnRleHQocHJveHkpOworI2lmIEVOQUJMRShX T1JLRVJTKQogICAgIH0gZWxzZSBpZiAoY29udGV4dC0+aXNXb3JrZXJDb250ZXh0KCkpIHsKICAg ICAgICAgaWYgKFdvcmtlckNvbnRleHRFeGVjdXRpb25Qcm94eSogcHJveHkgPSBzdGF0aWNfY2Fz dDxXb3JrZXJDb250ZXh0Kj4oY29udGV4dCktPnNjcmlwdCgpLT5wcm94eSgpKQogICAgICAgICAg ICAgcmV0dXJuIHByb3h5LT5jb250ZXh0KCk7CisjZW5kaWYKICAgICB9CiAgICAgcmV0dXJuIHY4 OjpMb2NhbDx2ODo6Q29udGV4dD4oKTsKIH0K