36204 2010-03-16 17:28:31 -0700 [Chromium] Size the WebVector of forms after determining how many forms are valid and will be returned 2010-03-16 18:54:10 -0700 1 1 1 Unclassified WebKit WebKit API 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 0 jhawkins webkit-unassigned dglazkov fishd levin oldest_to_newest 200532 0 jhawkins 2010-03-16 17:28:31 -0700 Patch will follow. 200545 1 50861 jhawkins 2010-03-16 18:06:07 -0700 Created attachment 50861 Patch 200549 2 50861 levin 2010-03-16 18:16:51 -0700 Comment on attachment 50861 Patch Pls fix the indentation to be 4 spaces on checkin. 200550 3 50863 jhawkins 2010-03-16 18:18:05 -0700 Created attachment 50863 Patch 200551 4 50861 dglazkov 2010-03-16 18:18:33 -0700 Comment on attachment 50861 Patch I am surprised style-elf didn't see it, but indents are 2, not 4. And we really need a test with this. Something simple like PASS or CRASH would do. 200553 5 dglazkov 2010-03-16 18:19:08 -0700 Still would like a layout test to keep this from regressing. 200556 6 levin 2010-03-16 18:26:25 -0700 As discussed, please add info to the ChangeLog about why a test isn't possible. 200564 7 jhawkins 2010-03-16 18:54:10 -0700 Committed r56098: <http://trac.webkit.org/changeset/56098> 50861 2010-03-16 18:06:07 -0700 2010-03-16 18:18:33 -0700 Patch bug-36204-20100316180606.patch text/plain 1339 jhawkins SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gNTYwOTYpCisrKyBXZWJLaXQvY2hyb21pdW0vQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTAtMDMtMTYgIEphbWVz IEhhd2tpbnMgIDxqaGF3a2luc0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0Nocm9taXVtXSBTaXplIHRoZSBXZWJWZWN0b3Ig b2YgZm9ybXMgYWZ0ZXIgZGV0ZXJtaW5pbmcgaG93IG1hbnkKKyAgICAgICAgZm9ybXMgYXJlIHZh bGlkIGFuZCB3aWxsIGJlIHJldHVybmVkLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0zNjIwNAorCisgICAgICAgICogc3JjL1dlYkZyYW1lSW1wbC5j cHA6CisgICAgICAgIChXZWJLaXQ6OldlYkZyYW1lSW1wbDo6Zm9ybXMpOgorCiAyMDEwLTAzLTE2 ICBLZW5uZXRoIFJ1c3NlbGwgIDxrYnJAZ29vZ2xlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBi eSBEYXJpbiBGaXNoZXIuCkluZGV4OiBXZWJLaXQvY2hyb21pdW0vc3JjL1dlYkZyYW1lSW1wbC5j cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJGcmFtZUltcGwuY3BwCShy ZXZpc2lvbiA1NjA5NCkKKysrIFdlYktpdC9jaHJvbWl1bS9zcmMvV2ViRnJhbWVJbXBsLmNwcAko d29ya2luZyBjb3B5KQpAQCAtNjU3LDcgKzY1NywxMiBAQCB2b2lkIFdlYkZyYW1lSW1wbDo6Zm9y bXMoV2ViVmVjdG9yPFdlYkZvCiAgICAgICAgIHJldHVybjsKIAogICAgIFJlZlB0cjxIVE1MQ29s bGVjdGlvbj4gZm9ybXMgPSBtX2ZyYW1lLT5kb2N1bWVudCgpLT5mb3JtcygpOwotICAgIHNpemVf dCBmb3JtQ291bnQgPSBmb3Jtcy0+bGVuZ3RoKCk7CisgICAgc2l6ZV90IGZvcm1Db3VudCA9IDA7 CisgICAgZm9yIChzaXplX3QgaSA9IDA7IGkgPCBmb3Jtcy0+bGVuZ3RoKCk7ICsraSkgeworICAg ICAgTm9kZSogbm9kZSA9IGZvcm1zLT5pdGVtKGkpOworICAgICAgaWYgKG5vZGUgJiYgbm9kZS0+ aXNIVE1MRWxlbWVudCgpKQorICAgICAgICArK2Zvcm1Db3VudDsKKyAgICB9CiAKICAgICBXZWJW ZWN0b3I8V2ViRm9ybUVsZW1lbnQ+IHRlbXAoZm9ybUNvdW50KTsKICAgICBmb3IgKHNpemVfdCBp ID0gMDsgaSA8IGZvcm1Db3VudDsgKytpKSB7Cg== 50863 2010-03-16 18:18:05 -0700 2010-03-16 18:18:55 -0700 Patch bug-36204-20100316181804.patch text/plain 1347 jhawkins SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gNTYwOTYpCisrKyBXZWJLaXQvY2hyb21pdW0vQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTAtMDMtMTYgIEphbWVz IEhhd2tpbnMgIDxqaGF3a2luc0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0Nocm9taXVtXSBTaXplIHRoZSBXZWJWZWN0b3Ig b2YgZm9ybXMgYWZ0ZXIgZGV0ZXJtaW5pbmcgaG93IG1hbnkKKyAgICAgICAgZm9ybXMgYXJlIHZh bGlkIGFuZCB3aWxsIGJlIHJldHVybmVkLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0zNjIwNAorCisgICAgICAgICogc3JjL1dlYkZyYW1lSW1wbC5j cHA6CisgICAgICAgIChXZWJLaXQ6OldlYkZyYW1lSW1wbDo6Zm9ybXMpOgorCiAyMDEwLTAzLTE2 ICBLZW5uZXRoIFJ1c3NlbGwgIDxrYnJAZ29vZ2xlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBi eSBEYXJpbiBGaXNoZXIuCkluZGV4OiBXZWJLaXQvY2hyb21pdW0vc3JjL1dlYkZyYW1lSW1wbC5j cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJGcmFtZUltcGwuY3BwCShy ZXZpc2lvbiA1NjA5NCkKKysrIFdlYktpdC9jaHJvbWl1bS9zcmMvV2ViRnJhbWVJbXBsLmNwcAko d29ya2luZyBjb3B5KQpAQCAtNjU3LDcgKzY1NywxMiBAQCB2b2lkIFdlYkZyYW1lSW1wbDo6Zm9y bXMoV2ViVmVjdG9yPFdlYkZvCiAgICAgICAgIHJldHVybjsKIAogICAgIFJlZlB0cjxIVE1MQ29s bGVjdGlvbj4gZm9ybXMgPSBtX2ZyYW1lLT5kb2N1bWVudCgpLT5mb3JtcygpOwotICAgIHNpemVf dCBmb3JtQ291bnQgPSBmb3Jtcy0+bGVuZ3RoKCk7CisgICAgc2l6ZV90IGZvcm1Db3VudCA9IDA7 CisgICAgZm9yIChzaXplX3QgaSA9IDA7IGkgPCBmb3Jtcy0+bGVuZ3RoKCk7ICsraSkgeworICAg ICAgICBOb2RlKiBub2RlID0gZm9ybXMtPml0ZW0oaSk7CisgICAgICAgIGlmIChub2RlICYmIG5v ZGUtPmlzSFRNTEVsZW1lbnQoKSkKKyAgICAgICAgICAgICsrZm9ybUNvdW50OworICAgIH0KIAog ICAgIFdlYlZlY3RvcjxXZWJGb3JtRWxlbWVudD4gdGVtcChmb3JtQ291bnQpOwogICAgIGZvciAo c2l6ZV90IGkgPSAwOyBpIDwgZm9ybUNvdW50OyArK2kpIHsK