36203 2010-03-16 17:12:58 -0700 Add tests for "load shared worker in iframe" 2010-03-17 17:37:16 -0700 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) All OS X 10.5 RESOLVED FIXED P2 Normal --- 1 atwilson atwilson commit-queue oldest_to_newest 200525 0 atwilson 2010-03-16 17:12:58 -0700 We found a bug in downstream Chromium related to launching shared workers simultaneously in a top-level document and in an iframe. Turns out that we don't explicitly test this case in any of the WebKit layout tests, so we should add a test. 200526 1 50854 atwilson 2010-03-16 17:19:45 -0700 Created attachment 50854 Patch 200535 2 50854 levin 2010-03-16 17:34:29 -0700 Comment on attachment 50854 Patch This looks good. Thanks! r- for mild issue having two files wit the same name "shared-worker-iframe.html" but having different purposes. 200538 3 50857 atwilson 2010-03-16 17:37:18 -0700 Created attachment 50857 Patch 201073 4 50857 commit-queue 2010-03-17 17:37:12 -0700 Comment on attachment 50857 Patch Clearing flags on attachment: 50857 Committed r56136: <http://trac.webkit.org/changeset/56136> 201074 5 commit-queue 2010-03-17 17:37:16 -0700 All reviewed patches have been landed. Closing bug. 50854 2010-03-16 17:19:45 -0700 2010-03-16 17:37:16 -0700 Patch bug-36203-20100316171944.patch text/plain 3182 atwilson ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBiZGE3YmEzLi4yMTdjOGZlIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTAtMDMt MTYgIERyZXcgV2lsc29uICA8YXR3aWxzb25AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCB0ZXN0cyBmb3IgImxvYWQgc2hh cmVkIHdvcmtlciBpbiBpZnJhbWUiIGNhc2UuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0zNjIwMworCisgICAgICAgIE1ha2VzIHN1cmUgdGhhdCBjcmVh dGluZyBhIHdvcmtlciBzaW11bHRhbmVvdXNseSBpbiBhIGRvY3VtZW50IGFuZCBpbgorICAgICAg ICBhIGNoaWxkIGlmcmFtZSB3b3JrcyAoeW91IGVuZCB1cCB3aXRoIGEgc2luZ2xlIGluc3RhbmNl KS4KKworICAgICAgICAqIGZhc3Qvd29ya2Vycy9yZXNvdXJjZXMvc2hhcmVkLXdvcmtlci1jb3Vu dC1jb25uZWN0aW9ucy5qczogQWRkZWQuCisgICAgICAgICogZmFzdC93b3JrZXJzL3Jlc291cmNl cy9zaGFyZWQtd29ya2VyLWlmcmFtZS5odG1sOiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L3dvcmtl cnMvc2hhcmVkLXdvcmtlci1pZnJhbWUtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBm YXN0L3dvcmtlcnMvc2hhcmVkLXdvcmtlci1pZnJhbWUuaHRtbDogQWRkZWQuCisKIDIwMTAtMDMt MTYgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBi eSBEYXJpbiBBZGxlci4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3Qvd29ya2Vycy9yZXNv dXJjZXMvc2hhcmVkLXdvcmtlci1jb3VudC1jb25uZWN0aW9ucy5qcyBiL0xheW91dFRlc3RzL2Zh c3Qvd29ya2Vycy9yZXNvdXJjZXMvc2hhcmVkLXdvcmtlci1jb3VudC1jb25uZWN0aW9ucy5qcwpu ZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwLi4zNzFkMzEyCi0tLSAvZGV2L251bGwK KysrIGIvTGF5b3V0VGVzdHMvZmFzdC93b3JrZXJzL3Jlc291cmNlcy9zaGFyZWQtd29ya2VyLWNv dW50LWNvbm5lY3Rpb25zLmpzCkBAIC0wLDAgKzEsNyBAQAordmFyIHBvcnRzID0gW107CitvbmNv bm5lY3QgPSBmdW5jdGlvbihldmVudCkgeworICBwb3J0cy5wdXNoKGV2ZW50LnBvcnRzWzBdKTsK KyAgZm9yICh2YXIgaSA9IDAgOyBpIDwgcG9ydHMubGVuZ3RoIDsgaSsrKSB7CisgICAgcG9ydHNb aV0ucG9zdE1lc3NhZ2UocG9ydHMubGVuZ3RoKTsKKyAgfQorfTsKZGlmZiAtLWdpdCBhL0xheW91 dFRlc3RzL2Zhc3Qvd29ya2Vycy9yZXNvdXJjZXMvc2hhcmVkLXdvcmtlci1pZnJhbWUuaHRtbCBi L0xheW91dFRlc3RzL2Zhc3Qvd29ya2Vycy9yZXNvdXJjZXMvc2hhcmVkLXdvcmtlci1pZnJhbWUu aHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwLi4yNDBkNGJjCi0tLSAvZGV2 L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC93b3JrZXJzL3Jlc291cmNlcy9zaGFyZWQtd29y a2VyLWlmcmFtZS5odG1sCkBAIC0wLDAgKzEsNiBAQAorPGJvZHk+CitJZnJhbWUgd2hpY2ggbG9h ZHMgYSB3b3JrZXIuCis8c2NyaXB0PgordmFyIHdvcmtlciA9IG5ldyBTaGFyZWRXb3JrZXIoJ3No YXJlZC13b3JrZXItY291bnQtY29ubmVjdGlvbnMuanMnKTsKKzwvc2NyaXB0PgorPC9ib2R5Pgpk aWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC93b3JrZXJzL3NoYXJlZC13b3JrZXItaWZyYW1l LWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2Zhc3Qvd29ya2Vycy9zaGFyZWQtd29ya2VyLWlm cmFtZS1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uMGRh MzcxNQotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3Qvd29ya2Vycy9zaGFyZWQt d29ya2VyLWlmcmFtZS1leHBlY3RlZC50eHQKQEAgLTAsMCArMSw2IEBACitUZXN0IHNpbXVsdGFu ZW91cyBzaGFyZWQgd29ya2VyIGNvbnN0cnVjdGlvbiBjYXNlIChkb2N1bWVudCArIGlmcmFtZSku CisKK1ByaW50cyAiRE9ORSIgaWYgdGhlIHRlc3QgaXMgc3VjY2Vzc2Z1bAorCitET05FCisKZGlm ZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3Qvd29ya2Vycy9zaGFyZWQtd29ya2VyLWlmcmFtZS5o dG1sIGIvTGF5b3V0VGVzdHMvZmFzdC93b3JrZXJzL3NoYXJlZC13b3JrZXItaWZyYW1lLmh0bWwK bmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uY2NiMjI1NAotLS0gL2Rldi9udWxs CisrKyBiL0xheW91dFRlc3RzL2Zhc3Qvd29ya2Vycy9zaGFyZWQtd29ya2VyLWlmcmFtZS5odG1s CkBAIC0wLDAgKzEsMzEgQEAKKzxib2R5PgorPHA+VGVzdCBzaW11bHRhbmVvdXMgc2hhcmVkIHdv cmtlciBjb25zdHJ1Y3Rpb24gY2FzZSAoZG9jdW1lbnQgKyBpZnJhbWUpLjwvcD4KKzxwPlByaW50 cyAiRE9ORSIgaWYgdGhlIHRlc3QgaXMgc3VjY2Vzc2Z1bDwvcD4KKzxkaXYgaWQ9cmVzdWx0Pjwv ZGl2PgorPHNjcmlwdD4KK2Z1bmN0aW9uIGxvZyhtZXNzYWdlKQoreworICAgIGRvY3VtZW50Lmdl dEVsZW1lbnRCeUlkKCJyZXN1bHQiKS5pbm5lckhUTUwgKz0gbWVzc2FnZSArICI8YnI+IjsKK30K KworaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikgeworICAgIGxheW91dFRlc3RDb250 cm9sbGVyLmR1bXBBc1RleHQoKTsKKyAgICBsYXlvdXRUZXN0Q29udHJvbGxlci53YWl0VW50aWxE b25lKCk7Cit9CisKK3ZhciB3b3JrZXIgPSBuZXcgU2hhcmVkV29ya2VyKCdyZXNvdXJjZXMvc2hh cmVkLXdvcmtlci1jb3VudC1jb25uZWN0aW9ucy5qcycpOword29ya2VyLnBvcnQub25tZXNzYWdl ID0gZnVuY3Rpb24oZXZlbnQpIHsKKyAgaWYgKGV2ZW50LmRhdGEgPT0gMikgeworICAgIGRvbmUo KTsKKyAgfQorfTsKKworZnVuY3Rpb24gZG9uZSgpCit7CisgICAgbG9nKCJET05FIik7CisgICAg aWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikKKyAgICAgICAgbGF5b3V0VGVzdENvbnRy b2xsZXIubm90aWZ5RG9uZSgpOworfQorPC9zY3JpcHQ+Cis8aWZyYW1lIHNyYz0ncmVzb3VyY2Vz L3NoYXJlZC13b3JrZXItaWZyYW1lLmh0bWwnPjwvaWZyYW1lPgorPC9ib2R5Pgo= 50857 2010-03-16 17:37:18 -0700 2010-03-17 17:37:12 -0700 Patch bug-36203-20100316173717.patch text/plain 3206 atwilson ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBiZGE3YmEzLi4wZDdmOTlkIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTAtMDMt MTYgIERyZXcgV2lsc29uICA8YXR3aWxzb25AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCB0ZXN0cyBmb3IgImxvYWQgc2hh cmVkIHdvcmtlciBpbiBpZnJhbWUiIGNhc2UuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0zNjIwMworCisgICAgICAgIE1ha2VzIHN1cmUgdGhhdCBjcmVh dGluZyBhIHdvcmtlciBzaW11bHRhbmVvdXNseSBpbiBhIGRvY3VtZW50IGFuZCBpbgorICAgICAg ICBhIGNoaWxkIGlmcmFtZSB3b3JrcyAoeW91IGVuZCB1cCB3aXRoIGEgc2luZ2xlIGluc3RhbmNl KS4KKworICAgICAgICAqIGZhc3Qvd29ya2Vycy9yZXNvdXJjZXMvc2hhcmVkLXdvcmtlci1jb3Vu dC1jb25uZWN0aW9ucy5qczogQWRkZWQuCisgICAgICAgICogZmFzdC93b3JrZXJzL3Jlc291cmNl cy9zaGFyZWQtd29ya2VyLWlmcmFtZS5odG1sOiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L3dvcmtl cnMvc2hhcmVkLXdvcmtlci1pbi1pZnJhbWUtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAg KiBmYXN0L3dvcmtlcnMvc2hhcmVkLXdvcmtlci1pbi1pZnJhbWUuaHRtbDogQWRkZWQuCisKIDIw MTAtMDMtMTYgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZp ZXdlZCBieSBEYXJpbiBBZGxlci4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3Qvd29ya2Vy cy9yZXNvdXJjZXMvc2hhcmVkLXdvcmtlci1jb3VudC1jb25uZWN0aW9ucy5qcyBiL0xheW91dFRl c3RzL2Zhc3Qvd29ya2Vycy9yZXNvdXJjZXMvc2hhcmVkLXdvcmtlci1jb3VudC1jb25uZWN0aW9u cy5qcwpuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwLi4zNzFkMzEyCi0tLSAvZGV2 L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC93b3JrZXJzL3Jlc291cmNlcy9zaGFyZWQtd29y a2VyLWNvdW50LWNvbm5lY3Rpb25zLmpzCkBAIC0wLDAgKzEsNyBAQAordmFyIHBvcnRzID0gW107 CitvbmNvbm5lY3QgPSBmdW5jdGlvbihldmVudCkgeworICBwb3J0cy5wdXNoKGV2ZW50LnBvcnRz WzBdKTsKKyAgZm9yICh2YXIgaSA9IDAgOyBpIDwgcG9ydHMubGVuZ3RoIDsgaSsrKSB7CisgICAg cG9ydHNbaV0ucG9zdE1lc3NhZ2UocG9ydHMubGVuZ3RoKTsKKyAgfQorfTsKZGlmZiAtLWdpdCBh L0xheW91dFRlc3RzL2Zhc3Qvd29ya2Vycy9yZXNvdXJjZXMvc2hhcmVkLXdvcmtlci1pZnJhbWUu aHRtbCBiL0xheW91dFRlc3RzL2Zhc3Qvd29ya2Vycy9yZXNvdXJjZXMvc2hhcmVkLXdvcmtlci1p ZnJhbWUuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwLi4yNDBkNGJjCi0t LSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC93b3JrZXJzL3Jlc291cmNlcy9zaGFy ZWQtd29ya2VyLWlmcmFtZS5odG1sCkBAIC0wLDAgKzEsNiBAQAorPGJvZHk+CitJZnJhbWUgd2hp Y2ggbG9hZHMgYSB3b3JrZXIuCis8c2NyaXB0PgordmFyIHdvcmtlciA9IG5ldyBTaGFyZWRXb3Jr ZXIoJ3NoYXJlZC13b3JrZXItY291bnQtY29ubmVjdGlvbnMuanMnKTsKKzwvc2NyaXB0PgorPC9i b2R5PgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC93b3JrZXJzL3NoYXJlZC13b3JrZXIt aW4taWZyYW1lLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2Zhc3Qvd29ya2Vycy9zaGFyZWQt d29ya2VyLWluLWlmcmFtZS1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXgg MDAwMDAwMC4uMGRhMzcxNQotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3Qvd29y a2Vycy9zaGFyZWQtd29ya2VyLWluLWlmcmFtZS1leHBlY3RlZC50eHQKQEAgLTAsMCArMSw2IEBA CitUZXN0IHNpbXVsdGFuZW91cyBzaGFyZWQgd29ya2VyIGNvbnN0cnVjdGlvbiBjYXNlIChkb2N1 bWVudCArIGlmcmFtZSkuCisKK1ByaW50cyAiRE9ORSIgaWYgdGhlIHRlc3QgaXMgc3VjY2Vzc2Z1 bAorCitET05FCisKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3Qvd29ya2Vycy9zaGFyZWQt d29ya2VyLWluLWlmcmFtZS5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC93b3JrZXJzL3NoYXJlZC13 b3JrZXItaW4taWZyYW1lLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4u Y2NiMjI1NAotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3Qvd29ya2Vycy9zaGFy ZWQtd29ya2VyLWluLWlmcmFtZS5odG1sCkBAIC0wLDAgKzEsMzEgQEAKKzxib2R5PgorPHA+VGVz dCBzaW11bHRhbmVvdXMgc2hhcmVkIHdvcmtlciBjb25zdHJ1Y3Rpb24gY2FzZSAoZG9jdW1lbnQg KyBpZnJhbWUpLjwvcD4KKzxwPlByaW50cyAiRE9ORSIgaWYgdGhlIHRlc3QgaXMgc3VjY2Vzc2Z1 bDwvcD4KKzxkaXYgaWQ9cmVzdWx0PjwvZGl2PgorPHNjcmlwdD4KK2Z1bmN0aW9uIGxvZyhtZXNz YWdlKQoreworICAgIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJyZXN1bHQiKS5pbm5lckhUTUwg Kz0gbWVzc2FnZSArICI8YnI+IjsKK30KKworaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxl cikgeworICAgIGxheW91dFRlc3RDb250cm9sbGVyLmR1bXBBc1RleHQoKTsKKyAgICBsYXlvdXRU ZXN0Q29udHJvbGxlci53YWl0VW50aWxEb25lKCk7Cit9CisKK3ZhciB3b3JrZXIgPSBuZXcgU2hh cmVkV29ya2VyKCdyZXNvdXJjZXMvc2hhcmVkLXdvcmtlci1jb3VudC1jb25uZWN0aW9ucy5qcycp Oword29ya2VyLnBvcnQub25tZXNzYWdlID0gZnVuY3Rpb24oZXZlbnQpIHsKKyAgaWYgKGV2ZW50 LmRhdGEgPT0gMikgeworICAgIGRvbmUoKTsKKyAgfQorfTsKKworZnVuY3Rpb24gZG9uZSgpCit7 CisgICAgbG9nKCJET05FIik7CisgICAgaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikK KyAgICAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIubm90aWZ5RG9uZSgpOworfQorPC9zY3JpcHQ+ Cis8aWZyYW1lIHNyYz0ncmVzb3VyY2VzL3NoYXJlZC13b3JrZXItaWZyYW1lLmh0bWwnPjwvaWZy YW1lPgorPC9ib2R5Pgo=