36200 2010-03-16 16:17:49 -0700 Temporarily disable WebGL layout tests failing due to multisampling 2010-03-16 16:39:26 -0700 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) All All RESOLVED FIXED P1 Critical --- 1 kbr kbr cmarrin eric simon.fraser zmo oldest_to_newest 200494 0 kbr 2010-03-16 16:17:49 -0700 After the introduction of multisampling support for WebGL in https://bugs.webkit.org/show_bug.cgi?id=33416 , a few layout tests are failing on some of the commit bots. Detection of buggy OpenGL implementations and workarounds for them are being investigated under https://bugs.webkit.org/show_bug.cgi?id=36194 , but in the interim to unblock the commit queue we need to disable these tests. (The overall code changes in 33416 were blocking other work and it is highly undesirable to roll them back.) 200499 1 50850 kbr 2010-03-16 16:26:47 -0700 Created attachment 50850 Patch 200501 2 50850 eric 2010-03-16 16:28:28 -0700 Comment on attachment 50850 Patch I think Kenneth meant "build bots". I don't think the commit-bot is failing these tests, but one of the build bots certainly is: http://build.webkit.org/results/Leopard%20Intel%20Debug%20(Tests)/r56090%20(11512)/results.html Either way, I think this is OK. I would like to see the "fix it" bug instead of this bug listed in the Skipped list. The ChangeLog could list both if you like. r=me 200503 3 50852 kbr 2010-03-16 16:36:11 -0700 Created attachment 50852 Revised patch Revised patch mentioning the "real" bug for this fix (36194) rather than this one in the Skipped file. Leaving the ChangeLog to avoid confusing webkit-patch. 200504 4 50852 eric 2010-03-16 16:37:20 -0700 Comment on attachment 50852 Revised patch I shoudl have been more clear. no need to re-post. But still looks good! 200505 5 eric 2010-03-16 16:38:53 -0700 webkit-patch finds the "bug" for a diff by grepping the whole diff for bug numbers. The first one it finds is the winner. We might yet change that to only grep ChangeLogs, but for now that's how it works. http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/bugzilla.py#L51 200506 6 kbr 2010-03-16 16:39:26 -0700 Committed r56093: <http://trac.webkit.org/changeset/56093> 50850 2010-03-16 16:26:47 -0700 2010-03-16 16:36:11 -0700 Patch tests.patch text/plain 1364 kbr SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDU2MDkyKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTAtMDMtMTYgIEtlbm5ldGggUnVzc2VsbCAg PGtickBnb29nbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFRlbXBvcmFyaWx5IGRpc2FibGUgV2ViR0wgbGF5b3V0IHRlc3RzIGZhaWxpbmcg ZHVlIHRvIG11bHRpc2FtcGxpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTM2MjAwCisKKyAgICAgICAgKiBwbGF0Zm9ybS9tYWMvU2tpcHBlZDoKKwog MjAxMC0wMy0xNSAgT2phbiBWYWZhaSAgPG9qYW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJl dmlld2VkIGJ5IEFsZXhleSBQcm9za3VyeWFrb3YuCkluZGV4OiBMYXlvdXRUZXN0cy9wbGF0Zm9y bS9tYWMvU2tpcHBlZAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvU2tp cHBlZAkocmV2aXNpb24gNTYwOTIpCisrKyBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvU2tpcHBl ZAkod29ya2luZyBjb3B5KQpAQCAtMTM3LDMgKzEzNywxMCBAQCBmYXN0L2RvbS9IVE1MUHJvZ3Jl c3NFbGVtZW50L3NldC1wcm9ncmVzCiAjIGV2ZW50LmRhdGFUcmFuc2Zlci5zZXREYXRhKCd0ZXh0 L3VyaS1saXN0Jykgbm90IGNvcnJlY3RseSBpbXBsZW1lbnRlZCBvbiBNYWMKIGVkaXRpbmcvcGFz dGVib2FyZC9kYXRhVHJhbnNmZXItc2V0RGF0YS1nZXREYXRhLmh0bWwKIAorIyBUZW1wb3Jhcmls eSBjb21tZW50aW5nIG91dCBhIGZldyBXZWJHTCBsYXlvdXQgdGVzdHMgZmFpbGluZyBvbiBzb21l IG9mIHRoZSBib3RzLgorIyBTZWUgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTM2MjAwIC4KK2Zhc3QvY2FudmFzL3dlYmdsL2NvbnRleHQtYXR0cmlidXRlcy1hbHBoYS1k ZXB0aC1zdGVuY2lsLWFudGlhbGlhcy5odG1sCitmYXN0L2NhbnZhcy93ZWJnbC90ZXgtaW1hZ2Ut YW5kLXN1Yi1pbWFnZS0yZC13aXRoLWltYWdlLWRhdGEuaHRtbAorZmFzdC9jYW52YXMvd2ViZ2wv dGV4LXN1Yi1pbWFnZS0yZC5odG1sCitmYXN0L2NhbnZhcy93ZWJnbC90cmlhbmdsZS5odG1sCitm YXN0L2NhbnZhcy93ZWJnbC92aWV3cG9ydC11bmNoYW5nZWQtdXBvbi1yZXNpemUuaHRtbAo= 50852 2010-03-16 16:36:11 -0700 2010-03-16 16:37:20 -0700 Revised patch tests.patch text/plain 1364 kbr SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDU2MDkyKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTAtMDMtMTYgIEtlbm5ldGggUnVzc2VsbCAg PGtickBnb29nbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFRlbXBvcmFyaWx5IGRpc2FibGUgV2ViR0wgbGF5b3V0IHRlc3RzIGZhaWxpbmcg ZHVlIHRvIG11bHRpc2FtcGxpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTM2MjAwCisKKyAgICAgICAgKiBwbGF0Zm9ybS9tYWMvU2tpcHBlZDoKKwog MjAxMC0wMy0xNSAgT2phbiBWYWZhaSAgPG9qYW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJl dmlld2VkIGJ5IEFsZXhleSBQcm9za3VyeWFrb3YuCkluZGV4OiBMYXlvdXRUZXN0cy9wbGF0Zm9y bS9tYWMvU2tpcHBlZAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvU2tp cHBlZAkocmV2aXNpb24gNTYwOTIpCisrKyBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvU2tpcHBl ZAkod29ya2luZyBjb3B5KQpAQCAtMTM3LDMgKzEzNywxMCBAQCBmYXN0L2RvbS9IVE1MUHJvZ3Jl c3NFbGVtZW50L3NldC1wcm9ncmVzCiAjIGV2ZW50LmRhdGFUcmFuc2Zlci5zZXREYXRhKCd0ZXh0 L3VyaS1saXN0Jykgbm90IGNvcnJlY3RseSBpbXBsZW1lbnRlZCBvbiBNYWMKIGVkaXRpbmcvcGFz dGVib2FyZC9kYXRhVHJhbnNmZXItc2V0RGF0YS1nZXREYXRhLmh0bWwKIAorIyBUZW1wb3Jhcmls eSBjb21tZW50aW5nIG91dCBhIGZldyBXZWJHTCBsYXlvdXQgdGVzdHMgZmFpbGluZyBvbiBzb21l IG9mIHRoZSBib3RzLgorIyBTZWUgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTM2MTk0IC4KK2Zhc3QvY2FudmFzL3dlYmdsL2NvbnRleHQtYXR0cmlidXRlcy1hbHBoYS1k ZXB0aC1zdGVuY2lsLWFudGlhbGlhcy5odG1sCitmYXN0L2NhbnZhcy93ZWJnbC90ZXgtaW1hZ2Ut YW5kLXN1Yi1pbWFnZS0yZC13aXRoLWltYWdlLWRhdGEuaHRtbAorZmFzdC9jYW52YXMvd2ViZ2wv dGV4LXN1Yi1pbWFnZS0yZC5odG1sCitmYXN0L2NhbnZhcy93ZWJnbC90cmlhbmdsZS5odG1sCitm YXN0L2NhbnZhcy93ZWJnbC92aWV3cG9ydC11bmNoYW5nZWQtdXBvbi1yZXNpemUuaHRtbAo=