36199 2010-03-16 15:55:05 -0700 Canvas rgb() color parsing still slow 2010-03-18 10:08:53 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 senorblanco senorblanco commit-queue eric oliver oldest_to_newest 200484 0 senorblanco 2010-03-16 15:55:05 -0700 Canvas rgb() color parsing still slow 200863 1 50925 senorblanco 2010-03-17 10:57:21 -0700 Created attachment 50925 Patch 200915 2 50925 oliver 2010-03-17 12:57:42 -0700 Comment on attachment 50925 Patch r=me, what's your testcase? and what's the improvement? --Oliver 200928 3 senorblanco 2010-03-17 13:03:53 -0700 (In reply to comment #2) > (From update of attachment 50925 [details]) > r=me, what's your testcase? and what's the improvement? Test case is Peacekeeper "Complex Graphics". Yields ~8% gain in Chromium/Win. 201257 4 50925 commit-queue 2010-03-18 05:30:20 -0700 Comment on attachment 50925 Patch Clearing flags on attachment: 50925 Committed r56155: <http://trac.webkit.org/changeset/56155> 201258 5 commit-queue 2010-03-18 05:30:25 -0700 All reviewed patches have been landed. Closing bug. 201345 6 ap 2010-03-18 09:35:29 -0700 The committed patch didn't have reviewer name in ChangeLog. 201356 7 eric 2010-03-18 09:55:29 -0700 The commit bot looks for and replaces "Reviewed by NOBODY(OOPS!)" with the correct information. Given the recent reviewer parsing added in http://trac.webkit.org/changeset/56137 it would be possible to finally write a minimal fix for https://bugs.webkit.org/show_bug.cgi?id=26927 Until then, please dont' change the Reviewed by NOBODY line. 201364 8 senorblanco 2010-03-18 10:08:53 -0700 (In reply to comment #7) > The commit bot looks for and replaces "Reviewed by NOBODY(OOPS!)" with the > correct information. > > Given the recent reviewer parsing added in > http://trac.webkit.org/changeset/56137 > it would be possible to finally write a minimal fix for > https://bugs.webkit.org/show_bug.cgi?id=26927 > > Until then, please dont' change the Reviewed by NOBODY line. (In reply to comment #7) > The commit bot looks for and replaces "Reviewed by NOBODY(OOPS!)" with the > correct information. > > Given the recent reviewer parsing added in > http://trac.webkit.org/changeset/56137 > it would be possible to finally write a minimal fix for > https://bugs.webkit.org/show_bug.cgi?id=26927 > > Until then, please dont' change the Reviewed by NOBODY line. Sorry about that. I must've deleted it by mistake. Should I land a patch to fix the ChangeLog? 50925 2010-03-17 10:57:21 -0700 2010-03-18 05:30:20 -0700 Patch bug-36199-20100317135719.patch text/plain 4232 senorblanco SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1NjExNCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjUgQEAKKzIwMTAtMDMtMTYgIFN0ZXBoZW4gV2hpdGUgIDxzZW5vcmJsYW5jb0Bj aHJvbWl1bS5vcmc+CisKKyAgICAgICAgUGFyc2luZyBvZiByZ2IoKSBjb2xvcnMgaW4gSFRNTCBj YW52YXMgaXMgc3RpbGwgZmFpcmx5IHNsb3cuCisgICAgICAgIGZpbmROYW1lZENvbG9yKCkgd2Fz IHNob3dpbmcgdXAgYXMgaG90LCBzbyB0aGlzIHBhdGNoIGF0dGVtcHRzIHRvCisgICAgICAgIGF2 b2lkIGNhbGxpbmcgaXQgYnkgcHV0dGluZyB0aGUgcmdiKCkgY2hlY2sgYWhlYWQgb2YgdGhlIG5h bWVkCisgICAgICAgIGNvbG9ycy4gIEl0IGFsc28gcmVtb3ZlcyBhIGNhbGwgdG8gQ29sb3I6OkNv bG9yKCkgZnJvbQorICAgICAgICBDYW52YXNTdHlsZSwgd2hpY2ggd2FzIGRvaW5nIGEgcmVkdW5k YW50IGNoZWNrIGZvciB0aGUgaGV4CisgICAgICAgIGNvbG9yIGFuZCBuYW1lZCBjb2xvcnMsIHdo aWNoIENTU1BhcnNlciBhbHJlYWR5IGRvZXMuICBGaW5hbGx5LCBpdAorICAgICAgICBjaGFuZ2Vz IHRoZSBhZC1ob2MgcGFyc2VyIHRvIGNoZWNrIGZvciBuZWdhdGl2ZSB2YWx1ZXMsIGFuZCBjbGFt cHMgdGhlbQorICAgICAgICBhdCB6ZXJvLiAgVGhpcyBhdm9pZHMgdGhlIGxleC95YWNjIHBhdGgg Zm9yIHJnYigpIGNvbG9ycyB3aXRoCisgICAgICAgIG5lZ2F0aXZlIGNvbG9yIGNvbXBvbmVudHMu CisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM2MTk5 CisKKyAgICAgICAgQ292ZXJlZCBieSBmYXN0L2NhbnZhcy9zZXQtY29sb3JzLmh0bWwuCisKKyAg ICAgICAgKiBjc3MvQ1NTUGFyc2VyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OnBhcnNlSW50KToK KyAgICAgICAgKFdlYkNvcmU6OkNTU1BhcnNlcjo6cGFyc2VDb2xvcik6CisgICAgICAgICogaHRt bC9jYW52YXMvQ2FudmFzU3R5bGUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q2FudmFzU3R5bGU6 OmFwcGx5RmlsbENvbG9yKToKKwogMjAxMC0wMy0xNyAgTmF0ZSBDaGFwaW4gIDxqYXBoZXRAY2hy b21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERpbWl0cmkgR2xhemtvdi4KSW5kZXg6 IFdlYkNvcmUvY3NzL0NTU1BhcnNlci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9jc3MvQ1NT UGFyc2VyLmNwcAkocmV2aXNpb24gNTYxMTQpCisrKyBXZWJDb3JlL2Nzcy9DU1NQYXJzZXIuY3Bw CSh3b3JraW5nIGNvcHkpCkBAIC0zNTE1LDggKzM1MTUsMTMgQEAgc3RhdGljIGlubGluZSBib29s IHBhcnNlSW50KGNvbnN0IFVDaGFyKgogewogICAgIGNvbnN0IFVDaGFyKiBjdXJyZW50ID0gc3Ry aW5nOwogICAgIGludCBsb2NhbFZhbHVlID0gMDsKKyAgICBib29sIG5lZ2F0aXZlID0gZmFsc2U7 CiAgICAgd2hpbGUgKGN1cnJlbnQgIT0gZW5kICYmIGlzQ1NTV2hpdGVzcGFjZSgqY3VycmVudCkp IAogICAgICAgICBjdXJyZW50Kys7CisgICAgaWYgKGN1cnJlbnQgIT0gZW5kICYmICpjdXJyZW50 ID09ICctJykgeworICAgICAgICBuZWdhdGl2ZSA9IHRydWU7CisgICAgICAgIGN1cnJlbnQrKzsK KyAgICB9CiAgICAgaWYgKGN1cnJlbnQgPT0gZW5kIHx8ICFpc0FTQ0lJRGlnaXQoKmN1cnJlbnQp KQogICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAgd2hpbGUgKGN1cnJlbnQgIT0gZW5kICYmIGlz QVNDSUlEaWdpdCgqY3VycmVudCkpCkBAIC0zNTI1LDcgKzM1MzAsOCBAQCBzdGF0aWMgaW5saW5l IGJvb2wgcGFyc2VJbnQoY29uc3QgVUNoYXIqCiAgICAgICAgIGN1cnJlbnQrKzsKICAgICBpZiAo Y3VycmVudCA9PSBlbmQgfHwgKmN1cnJlbnQrKyAhPSB0ZXJtaW5hdG9yKQogICAgICAgICByZXR1 cm4gZmFsc2U7Ci0gICAgdmFsdWUgPSBsb2NhbFZhbHVlOworICAgIC8vIENsYW1wIG5lZ2F0aXZl IHZhbHVlcyBhdCB6ZXJvLgorICAgIHZhbHVlID0gbmVnYXRpdmUgPyAwIDogbG9jYWxWYWx1ZTsK ICAgICBzdHJpbmcgPSBjdXJyZW50OwogICAgIHJldHVybiB0cnVlOwogfQpAQCAtMzUzNSwxMyAr MzU0MSw3IEBAIGJvb2wgQ1NTUGFyc2VyOjpwYXJzZUNvbG9yKGNvbnN0IFN0cmluZyAKICAgICBp ZiAoIXN0cmljdCAmJiBDb2xvcjo6cGFyc2VIZXhDb2xvcihuYW1lLCByZ2IpKQogICAgICAgICBy ZXR1cm4gdHJ1ZTsKIAotICAgIC8vIHRyeSBhIGxpdHRsZSBoYXJkZXIKLSAgICBDb2xvciB0YzsK LSAgICB0Yy5zZXROYW1lZENvbG9yKG5hbWUpOwotICAgIGlmICh0Yy5pc1ZhbGlkKCkpIHsKLSAg ICAgICAgcmdiID0gdGMucmdiKCk7Ci0gICAgICAgIHJldHVybiB0cnVlOwotICAgIH0KKyAgICAv LyBUcnkgcmdiKCkgc3ludGF4LgogICAgIGlmIChuYW1lLnN0YXJ0c1dpdGgoInJnYigiKSkgewog ICAgICAgICBjb25zdCBVQ2hhciogY3VycmVudCA9IG5hbWUuY2hhcmFjdGVycygpICsgNDsKICAg ICAgICAgY29uc3QgVUNoYXIqIGVuZCA9IG5hbWUuY2hhcmFjdGVycygpICsgbmFtZS5sZW5ndGgo KTsKQEAgLTM1NTgsNiArMzU1OCwxMyBAQCBib29sIENTU1BhcnNlcjo6cGFyc2VDb2xvcihjb25z dCBTdHJpbmcgCiAgICAgICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAgICAgIHJnYiA9IG1ha2VS R0IocmVkLCBncmVlbiwgYmx1ZSk7CiAgICAgICAgIHJldHVybiB0cnVlOworICAgIH0gICAgICAg IAorICAgIC8vIFRyeSBuYW1lZCBjb2xvcnMuCisgICAgQ29sb3IgdGM7CisgICAgdGMuc2V0TmFt ZWRDb2xvcihuYW1lKTsKKyAgICBpZiAodGMuaXNWYWxpZCgpKSB7CisgICAgICAgIHJnYiA9IHRj LnJnYigpOworICAgICAgICByZXR1cm4gdHJ1ZTsKICAgICB9CiAgICAgcmV0dXJuIGZhbHNlOwog fQpJbmRleDogV2ViQ29yZS9odG1sL2NhbnZhcy9DYW52YXNTdHlsZS5jcHAKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gV2ViQ29yZS9odG1sL2NhbnZhcy9DYW52YXNTdHlsZS5jcHAJKHJldmlzaW9uIDU2MTE0KQor KysgV2ViQ29yZS9odG1sL2NhbnZhcy9DYW52YXNTdHlsZS5jcHAJKHdvcmtpbmcgY29weSkKQEAg LTE3MywyMiArMTczLDEyIEBAIHZvaWQgQ2FudmFzU3R5bGU6OmFwcGx5RmlsbENvbG9yKEdyYXBo aWMKICAgICAgICAgcmV0dXJuOwogICAgIHN3aXRjaCAobV90eXBlKSB7CiAgICAgICAgIGNhc2Ug Q29sb3JTdHJpbmc6IHsKLSAgICAgICAgICAgIENvbG9yIGMgPSBDb2xvcihtX2NvbG9yKTsKLSAg ICAgICAgICAgIGlmIChjLmlzVmFsaWQoKSkgewotICAgICAgICAgICAgICAgIGNvbnRleHQtPnNl dEZpbGxDb2xvcihjLnJnYigpLCBEZXZpY2VDb2xvclNwYWNlKTsKLSAgICAgICAgICAgICAgICBi cmVhazsKLSAgICAgICAgICAgIH0KICAgICAgICAgICAgIFJHQkEzMiByZ2JhID0gMDsgLy8gZGVm YXVsdCBpcyB0cmFuc3BhcmVudCBibGFjawogICAgICAgICAgICAgaWYgKENTU1BhcnNlcjo6cGFy c2VDb2xvcihyZ2JhLCBtX2NvbG9yKSkKICAgICAgICAgICAgICAgICBjb250ZXh0LT5zZXRGaWxs Q29sb3IocmdiYSwgRGV2aWNlQ29sb3JTcGFjZSk7CiAgICAgICAgICAgICBicmVhazsKICAgICAg ICAgfQogICAgICAgICBjYXNlIENvbG9yU3RyaW5nV2l0aEFscGhhOiB7Ci0gICAgICAgICAgICBD b2xvciBjID0gQ29sb3IobV9jb2xvcik7Ci0gICAgICAgICAgICBpZiAoYy5pc1ZhbGlkKCkpIHsK LSAgICAgICAgICAgICAgICBjb250ZXh0LT5zZXRGaWxsQ29sb3IoY29sb3JXaXRoT3ZlcnJpZGVB bHBoYShjLnJnYigpLCBtX2FscGhhKSwgRGV2aWNlQ29sb3JTcGFjZSk7Ci0gICAgICAgICAgICAg ICAgYnJlYWs7Ci0gICAgICAgICAgICB9CiAgICAgICAgICAgICBSR0JBMzIgY29sb3IgPSAwOyAv LyBkZWZhdWx0IGlzIHRyYW5zcGFyZW50IGJsYWNrCiAgICAgICAgICAgICBpZiAoQ1NTUGFyc2Vy OjpwYXJzZUNvbG9yKGNvbG9yLCBtX2NvbG9yKSkKICAgICAgICAgICAgICAgICBjb250ZXh0LT5z ZXRGaWxsQ29sb3IoY29sb3JXaXRoT3ZlcnJpZGVBbHBoYShjb2xvciwgbV9hbHBoYSksIERldmlj ZUNvbG9yU3BhY2UpOwo=