36186 2010-03-16 13:41:51 -0700 [Qt] Multiselect Popup - adjusting QtAbstractWebPopup 2010-03-25 03:05:46 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All CLOSED FIXED Qt P2 Normal --- 36178 36368 0 luiz webkit-unassigned commit-queue hausmann kenneth koivisto oldest_to_newest 200402 0 luiz 2010-03-16 13:41:51 -0700 QtAbstractWebPopup must provide new methods to be used by its descendants that wish to handle <select multiple> elements. 200419 1 50834 luiz 2010-03-16 14:02:32 -0700 Created attachment 50834 patch 1 201953 2 51174 luiz 2010-03-19 11:41:54 -0700 Created attachment 51174 patch 2 202171 3 51174 kenneth 2010-03-19 21:35:34 -0700 Comment on attachment 51174 patch 2 I assume this doesn't break normal non-multiple selects as valueChanged() is not never being called. Please confirm that before adding this to the cq. 202467 4 vestbo 2010-03-22 06:36:58 -0700 Bugs relating to the Qt port of WebKit should have the Qt keyword. See http://trac.webkit.org/wiki/QtWebKitBugs 202570 5 luiz 2010-03-22 10:15:15 -0700 (In reply to comment #3) > (From update of attachment 51174 [details]) > I assume this doesn't break normal non-multiple selects as valueChanged() is > not never being called. Please confirm that before adding this to the cq. It doesn't. :) 202589 6 51174 commit-queue 2010-03-22 10:38:53 -0700 Comment on attachment 51174 patch 2 Clearing flags on attachment: 51174 Committed r56341: <http://trac.webkit.org/changeset/56341> 202590 7 commit-queue 2010-03-22 10:38:58 -0700 All reviewed patches have been landed. Closing bug. 50834 2010-03-16 14:02:32 -0700 2010-03-19 11:41:54 -0700 patch 1 0001-Qt-Multiselect-Popup-adjusting-QtAbstractWebPopup.patch text/plain 3065 luiz RnJvbSBjNmI1NTAxNGQ0NDU0M2I1NzAwY2YwYjA2ZTlkYzMyNjQ5NWI5ZmU3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBMdWl6IEFnb3N0aW5pIDxsdWl6LmFnb3N0aW5pQG9wZW5ib3Nz YS5vcmc+CkRhdGU6IFR1ZSwgMTYgTWFyIDIwMTAgMTc6NDc6MjIgLTAzMDAKU3ViamVjdDogW1BB VENIXSBbUXRdIE11bHRpc2VsZWN0IFBvcHVwIC0gYWRqdXN0aW5nIFF0QWJzdHJhY3RXZWJQb3B1 cAogaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM2MTg2CgpSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KClF0QWJzdHJhY3RXZWJQb3B1cCBtdXN0IHByb3ZpZGUgbmV3 IG1ldGhvZHMgdG8gYmUgdXNlZCBieSBpdHMgZGVzY2VuZGFudHMgdGhhdAp3aXNoIHRvIGhhbmRs ZSA8c2VsZWN0IG11bHRpcGxlPiBlbGVtZW50cy4KCiogcGxhdGZvcm0vcXQvUXRBYnN0cmFjdFdl YlBvcHVwLmNwcDoKKFdlYkNvcmU6OlF0QWJzdHJhY3RXZWJQb3B1cDo6aXRlbUNsaWNrKToKKFdl YkNvcmU6OlF0QWJzdHJhY3RXZWJQb3B1cDo6bXVsdGlwbGUpOgoqIHBsYXRmb3JtL3F0L1F0QWJz dHJhY3RXZWJQb3B1cC5oOgotLS0KIFdlYkNvcmUvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAg ICAgICAgICB8ICAgMTUgKysrKysrKysrKysrKysrCiBXZWJDb3JlL3BsYXRmb3JtL3F0L1F0QWJz dHJhY3RXZWJQb3B1cC5jcHAgfCAgIDE2ICsrKysrKysrKysrKysrKysKIFdlYkNvcmUvcGxhdGZv cm0vcXQvUXRBYnN0cmFjdFdlYlBvcHVwLmggICB8ICAgIDQgKysrKwogMyBmaWxlcyBjaGFuZ2Vk LCAzNSBpbnNlcnRpb25zKCspLCAwIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1dlYkNvcmUv Q2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjlhMmIyZC4uNGRmYzBmOCAxMDA2 NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTIs NiArMiwyMSBAQAogCiAgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgogCisgICAg ICAgIFtRdF0gTXVsdGlzZWxlY3QgUG9wdXAgLSBhZGp1c3RpbmcgUXRBYnN0cmFjdFdlYlBvcHVw CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNjE4Ngor CisgICAgICAgIFF0QWJzdHJhY3RXZWJQb3B1cCBtdXN0IHByb3ZpZGUgbmV3IG1ldGhvZHMgdG8g YmUgdXNlZCBieSBpdHMgZGVzY2VuZGFudHMgdGhhdAorICAgICAgICB3aXNoIHRvIGhhbmRsZSA8 c2VsZWN0IG11bHRpcGxlPiBlbGVtZW50cy4KKworICAgICAgICAqIHBsYXRmb3JtL3F0L1F0QWJz dHJhY3RXZWJQb3B1cC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpRdEFic3RyYWN0V2ViUG9wdXA6 Oml0ZW1DbGljayk6CisgICAgICAgIChXZWJDb3JlOjpRdEFic3RyYWN0V2ViUG9wdXA6Om11bHRp cGxlKToKKyAgICAgICAgKiBwbGF0Zm9ybS9xdC9RdEFic3RyYWN0V2ViUG9wdXAuaDoKKworMjAx MC0wMy0xNiAgTHVpeiBBZ29zdGluaSAgPGx1aXouYWdvc3RpbmlAb3BlbmJvc3NhLm9yZz4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwogICAgICAgICBbUXRdIE11bHRp c2VsZWN0IHBvcHVwcyAtIHJlbmRlcmluZwogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MzYwMDYKIApkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9x dC9RdEFic3RyYWN0V2ViUG9wdXAuY3BwIGIvV2ViQ29yZS9wbGF0Zm9ybS9xdC9RdEFic3RyYWN0 V2ViUG9wdXAuY3BwCmluZGV4IGY2NDI4N2QuLjI0OTEwNzcgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUv cGxhdGZvcm0vcXQvUXRBYnN0cmFjdFdlYlBvcHVwLmNwcAorKysgYi9XZWJDb3JlL3BsYXRmb3Jt L3F0L1F0QWJzdHJhY3RXZWJQb3B1cC5jcHAKQEAgLTQ4LDYgKzQ4LDIyIEBAIHZvaWQgUXRBYnN0 cmFjdFdlYlBvcHVwOjp2YWx1ZUNoYW5nZWQoaW50IGluZGV4KQogICAgIG1fcG9wdXBDbGllbnQt PnZhbHVlQ2hhbmdlZChpbmRleCk7CiB9CiAKKwordm9pZCBRdEFic3RyYWN0V2ViUG9wdXA6Oml0 ZW1DbGljayhpbnQgaW5kZXgsIGJvb2wgbXVsdGksIGJvb2wgc2hpZnQpCit7CisgICAgTGlzdFBv cHVwQ2xpZW50KiBjbGllbnQgPSBzdGF0aWNfY2FzdDxMaXN0UG9wdXBDbGllbnQqPihtX3BvcHVw Q2xpZW50KTsKKyAgICBpZiAoY2xpZW50KQorICAgICAgICBjbGllbnQtPmxpc3Rib3hDbGljayhp bmRleCwgbXVsdGksIHNoaWZ0KTsKKyAgICBlbHNlCisgICAgICAgIHZhbHVlQ2hhbmdlZChpbmRl eCk7Cit9CisKK2Jvb2wgUXRBYnN0cmFjdFdlYlBvcHVwOjptdWx0aXBsZSgpCit7CisgICAgTGlz dFBvcHVwQ2xpZW50KiBjbGllbnQgPSBzdGF0aWNfY2FzdDxMaXN0UG9wdXBDbGllbnQqPihtX3Bv cHVwQ2xpZW50KTsKKyAgICByZXR1cm4gY2xpZW50ICYmIGNsaWVudC0+bXVsdGlwbGUoKTsKK30K KwogUXRBYnN0cmFjdFdlYlBvcHVwOjpJdGVtVHlwZSBRdEFic3RyYWN0V2ViUG9wdXA6Oml0ZW1U eXBlKGludCBpZHgpIGNvbnN0CiB7CiAgICAgaWYgKG1fcG9wdXBDbGllbnQtPml0ZW1Jc1NlcGFy YXRvcihpZHgpKQpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9xdC9RdEFic3RyYWN0V2Vi UG9wdXAuaCBiL1dlYkNvcmUvcGxhdGZvcm0vcXQvUXRBYnN0cmFjdFdlYlBvcHVwLmgKaW5kZXgg OTNiNDEyMi4uZmUyOWI2NSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9xdC9RdEFic3Ry YWN0V2ViUG9wdXAuaAorKysgYi9XZWJDb3JlL3BsYXRmb3JtL3F0L1F0QWJzdHJhY3RXZWJQb3B1 cC5oCkBAIC01NCw2ICs1NCwxMCBAQCBwdWJsaWM6CiAgICAgdm9pZCBwb3B1cERpZEhpZGUoKTsK ICAgICB2b2lkIHZhbHVlQ2hhbmdlZChpbnQgaW5kZXgpOwogCisgICAgdm9pZCBpdGVtQ2xpY2so aW50IGluZGV4LCBib29sIG11bHRpLCBib29sIHNoaWZ0KTsKKyAgICBib29sIG11bHRpcGxlKCk7 CisKKwogICAgIFFGb250IGZvbnQoKSB7IHJldHVybiBtX3BvcHVwQ2xpZW50LT5tZW51U3R5bGUo KS5mb250KCkuZm9udCgpOyB9CiAKIHByaXZhdGU6Ci0tIAoxLjYuMy4zCgo= 51174 2010-03-19 11:41:54 -0700 2010-03-22 10:38:53 -0700 patch 2 0001-Qt-Multiselect-Popup-adjusting-QtAbstractWebPopup.patch text/plain 3224 luiz RnJvbSA4Y2UyNjM5YTQ4ZDkzODkzYjM0NTMwNzJkZmM2MzRkNGU2OTYxNmQ5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBMdWl6IEFnb3N0aW5pIDxsdWl6LmFnb3N0aW5pQG9wZW5ib3Nz YS5vcmc+CkRhdGU6IEZyaSwgMTkgTWFyIDIwMTAgMTU6NDA6MDUgLTAzMDAKU3ViamVjdDogW1BB VENIXSBbUXRdIE11bHRpc2VsZWN0IFBvcHVwIC0gYWRqdXN0aW5nIFF0QWJzdHJhY3RXZWJQb3B1 cAogaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM2MTg2CgpSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KClF0QWJzdHJhY3RXZWJQb3B1cCBtdXN0IHByb3ZpZGUgbmV3 IG1ldGhvZHMgdG8gYmUgdXNlZCBieSBpdHMgZGVzY2VuZGFudHMgdGhhdAp3aXNoIHRvIGhhbmRs ZSA8c2VsZWN0IG11bHRpcGxlPiBlbGVtZW50cy4KCiogcGxhdGZvcm0vcXQvUXRBYnN0cmFjdFdl YlBvcHVwLmNwcDoKKFdlYkNvcmU6OlF0QWJzdHJhY3RXZWJQb3B1cDo6c2VsZWN0SXRlbSk6CihX ZWJDb3JlOjpRdEFic3RyYWN0V2ViUG9wdXA6Om11bHRpcGxlKToKKiBwbGF0Zm9ybS9xdC9RdEFi c3RyYWN0V2ViUG9wdXAuaDoKLS0tCiBXZWJDb3JlL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAg ICAgICAgICAgfCAgIDE1ICsrKysrKysrKysrKysrKwogV2ViQ29yZS9wbGF0Zm9ybS9xdC9RdEFi c3RyYWN0V2ViUG9wdXAuY3BwIHwgICAyMiArKysrKysrKysrKysrKysrKysrKysrCiBXZWJDb3Jl L3BsYXRmb3JtL3F0L1F0QWJzdHJhY3RXZWJQb3B1cC5oICAgfCAgICA0ICsrKysKIDMgZmlsZXMg Y2hhbmdlZCwgNDEgaW5zZXJ0aW9ucygrKSwgMCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9X ZWJDb3JlL0NoYW5nZUxvZyBiL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IGQyYWZhOWQuLjlhNDcw YWYgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1dlYkNvcmUvQ2hhbmdlTG9n CkBAIC0xLDMgKzEsMTggQEAKKzIwMTAtMDMtMTkgIEx1aXogQWdvc3RpbmkgIDxsdWl6LmFnb3N0 aW5pQG9wZW5ib3NzYS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgW1F0XSBNdWx0aXNlbGVjdCBQb3B1cCAtIGFkanVzdGluZyBRdEFic3RyYWN0 V2ViUG9wdXAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTM2MTg2CisKKyAgICAgICAgUXRBYnN0cmFjdFdlYlBvcHVwIG11c3QgcHJvdmlkZSBuZXcgbWV0 aG9kcyB0byBiZSB1c2VkIGJ5IGl0cyBkZXNjZW5kYW50cyB0aGF0CisgICAgICAgIHdpc2ggdG8g aGFuZGxlIDxzZWxlY3QgbXVsdGlwbGU+IGVsZW1lbnRzLgorCisgICAgICAgICogcGxhdGZvcm0v cXQvUXRBYnN0cmFjdFdlYlBvcHVwLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlF0QWJzdHJhY3RX ZWJQb3B1cDo6c2VsZWN0SXRlbSk6CisgICAgICAgIChXZWJDb3JlOjpRdEFic3RyYWN0V2ViUG9w dXA6Om11bHRpcGxlKToKKyAgICAgICAgKiBwbGF0Zm9ybS9xdC9RdEFic3RyYWN0V2ViUG9wdXAu aDoKKwogMjAxMC0wMy0xOCAgTHVpeiBBZ29zdGluaSAgPGx1aXouYWdvc3RpbmlAb3BlbmJvc3Nh Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KZGlmZiAtLWdpdCBh L1dlYkNvcmUvcGxhdGZvcm0vcXQvUXRBYnN0cmFjdFdlYlBvcHVwLmNwcCBiL1dlYkNvcmUvcGxh dGZvcm0vcXQvUXRBYnN0cmFjdFdlYlBvcHVwLmNwcAppbmRleCBmNjQyODdkLi4zMWFiMjhkIDEw MDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL3F0L1F0QWJzdHJhY3RXZWJQb3B1cC5jcHAKKysr IGIvV2ViQ29yZS9wbGF0Zm9ybS9xdC9RdEFic3RyYWN0V2ViUG9wdXAuY3BwCkBAIC00OCw2ICs0 OCwyOCBAQCB2b2lkIFF0QWJzdHJhY3RXZWJQb3B1cDo6dmFsdWVDaGFuZ2VkKGludCBpbmRleCkK ICAgICBtX3BvcHVwQ2xpZW50LT52YWx1ZUNoYW5nZWQoaW5kZXgpOwogfQogCit2b2lkIFF0QWJz dHJhY3RXZWJQb3B1cDo6c2VsZWN0SXRlbShpbnQgaW5kZXgsIGJvb2wgYWxsb3dNdWx0aXBseVNl bGVjdGlvbnMsIGJvb2wgc2hpZnQpCit7CisjaWYgRU5BQkxFKE5PX0xJU1RCT1hfUkVOREVSSU5H KQorICAgIExpc3RQb3B1cE1lbnVDbGllbnQqIGNsaWVudCA9IHN0YXRpY19jYXN0PExpc3RQb3B1 cE1lbnVDbGllbnQqPihtX3BvcHVwQ2xpZW50KTsKKyAgICBpZiAoY2xpZW50KSB7CisgICAgICAg IGNsaWVudC0+bGlzdEJveFNlbGVjdEl0ZW0oaW5kZXgsIGFsbG93TXVsdGlwbHlTZWxlY3Rpb25z LCBzaGlmdCk7CisgICAgICAgIHJldHVybjsKKyAgICB9CisjZW5kaWYKKyAgICB2YWx1ZUNoYW5n ZWQoaW5kZXgpOworfQorCitib29sIFF0QWJzdHJhY3RXZWJQb3B1cDo6bXVsdGlwbGUoKQorewor I2lmIEVOQUJMRShOT19MSVNUQk9YX1JFTkRFUklORykKKyAgICBMaXN0UG9wdXBNZW51Q2xpZW50 KiBjbGllbnQgPSBzdGF0aWNfY2FzdDxMaXN0UG9wdXBNZW51Q2xpZW50Kj4obV9wb3B1cENsaWVu dCk7CisgICAgcmV0dXJuIGNsaWVudCAmJiBjbGllbnQtPm11bHRpcGxlKCk7CisjZWxzZQorICAg IHJldHVybiBmYWxzZTsKKyNlbmRpZgorfQorCiBRdEFic3RyYWN0V2ViUG9wdXA6Okl0ZW1UeXBl IFF0QWJzdHJhY3RXZWJQb3B1cDo6aXRlbVR5cGUoaW50IGlkeCkgY29uc3QKIHsKICAgICBpZiAo bV9wb3B1cENsaWVudC0+aXRlbUlzU2VwYXJhdG9yKGlkeCkpCmRpZmYgLS1naXQgYS9XZWJDb3Jl L3BsYXRmb3JtL3F0L1F0QWJzdHJhY3RXZWJQb3B1cC5oIGIvV2ViQ29yZS9wbGF0Zm9ybS9xdC9R dEFic3RyYWN0V2ViUG9wdXAuaAppbmRleCA5M2I0MTIyLi5mMTBkZTA2IDEwMDY0NAotLS0gYS9X ZWJDb3JlL3BsYXRmb3JtL3F0L1F0QWJzdHJhY3RXZWJQb3B1cC5oCisrKyBiL1dlYkNvcmUvcGxh dGZvcm0vcXQvUXRBYnN0cmFjdFdlYlBvcHVwLmgKQEAgLTU0LDYgKzU0LDEwIEBAIHB1YmxpYzoK ICAgICB2b2lkIHBvcHVwRGlkSGlkZSgpOwogICAgIHZvaWQgdmFsdWVDaGFuZ2VkKGludCBpbmRl eCk7CiAKKyAgICB2b2lkIHNlbGVjdEl0ZW0oaW50IGluZGV4LCBib29sIGFsbG93TXVsdGlwbHlT ZWxlY3Rpb25zLCBib29sIHNoaWZ0KTsKKyAgICBib29sIG11bHRpcGxlKCk7CisKKwogICAgIFFG b250IGZvbnQoKSB7IHJldHVybiBtX3BvcHVwQ2xpZW50LT5tZW51U3R5bGUoKS5mb250KCkuZm9u dCgpOyB9CiAKIHByaXZhdGU6Ci0tIAoxLjYuMy4zCgo=