3618 2005-06-20 06:44:56 -0700 RTL runs drawn by CG not reversed properly 2005-11-04 00:29:57 -0800 1 1 1 Unclassified WebKit Layout and Rendering 412 Mac OS X 10.4 CLOSED FIXED P2 Normal --- 1 mitz darin bugs.mano nirs xslf oldest_to_newest 12681 0 mitz 2005-06-20 06:44:56 -0700 Summary: In the rare case that CG gets to draw an RTL run, it applies order-swapping to all but the last glyph in the run. To reproduce: make sure "Use ATSUI For All Text" is off and open the testcase. Expected: to see ?!* on the second line. (To get expected behavior, switch on Use ATSUI and reload, or open in Firefox). Actual: see !*? on the second line. Analysis: the order-swapping loops in _CG_drawRun:style:geometry start with the next-to-last glyph instead of the last one, so the last glyph doesn't move to the beginning as it should. 12682 1 2499 mitz 2005-06-20 06:46:17 -0700 Created attachment 2499 testcase 12683 2 2500 mitz 2005-06-20 06:52:54 -0700 Created attachment 2500 Proposed fix Just changed (actually restored) the initial value of end in those three loops. 12687 3 2500 darin 2005-06-20 08:32:54 -0700 Comment on attachment 2500 Proposed fix r=me 2499 2005-06-20 06:46:17 -0700 2005-06-20 06:46:17 -0700 testcase CGRTLSwapping.html text/html 295 mitz PCFET0NUWVBFIEhUTUwgUFVCTElDICItLy9XM0MvL0RURCBIVE1MIDQuMDEgVHJhbnNpdGlvbmFs Ly9FTiIgCiJodHRwOi8vd3d3LnczLm9yZy9UUi9odG1sNC9sb29zZS5kdGQiPgo8aHRtbD4NCjxo ZWFkPg0KPHRpdGxlPlJldmVyc2luZyBSVEwgcnVucyBpbiBfQ0dfZHJhd1J1bjpzdHlsZTpnZW9t ZXRyeTo8L3RpdGxlPg0KPC9oZWFkPg0KPGJvZHk+CjxwPlRoZSBuZXh0IGxpbmUgc2hvdWxkIGxv b2sgbGlrZSA/ISo8L3A+CjxwIGRpcj0icnRsIiBhbGlnbj0ibGVmdCI+CiohPwo8L3A+CjwvYm9k eT4KPC9odG1sPg== 2500 2005-06-20 06:52:54 -0700 2005-06-20 08:32:54 -0700 Proposed fix 3618_patch_r1.txt text/plain 1334 mitz SW5kZXg6IFdlYlRleHRSZW5kZXJlci5tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9jdnMvcm9vdC9X ZWJLaXQvV2ViQ29yZVN1cHBvcnQuc3VicHJvai9XZWJUZXh0UmVuZGVyZXIubSx2CnJldHJpZXZp bmcgcmV2aXNpb24gMS4xNzQKZGlmZiAtcCAtdSAtcjEuMTc0IFdlYlRleHRSZW5kZXJlci5tCi0t LSBXZWJUZXh0UmVuZGVyZXIubQkyMDA1LzA2LzIwIDAxOjIwOjAxCTEuMTc0CisrKyBXZWJUZXh0 UmVuZGVyZXIubQkyMDA1LzA2LzIwIDEzOjQ4OjM0CkBAIC0xMTAyLDE5ICsxMTAyLDE5IEBAIHN0 YXRpYyB2b2lkIF9kcmF3R2x5cGhzKE5TRm9udCAqZm9udCwgTlMKICAgICAgICAgQ0dTaXplIGFz d2FwMSwgYXN3YXAyOwogICAgICAgICBOU0ZvbnQgKmZzd2FwMSwgKmZzd2FwMjsKICAgICAgICAg Ci0gICAgICAgIGZvciAoaSA9IHBvcywgZW5kID0gbnVtR2x5cGhzLTE7IGkgPCAobnVtR2x5cGhz IC0gcG9zKS8yOyBpKyspeworICAgICAgICBmb3IgKGkgPSBwb3MsIGVuZCA9IG51bUdseXBoczsg aSA8IChudW1HbHlwaHMgLSBwb3MpLzI7IGkrKyl7CiAgICAgICAgICAgICBnc3dhcDEgPSBnbHlw aEJ1ZmZlcltpXTsKICAgICAgICAgICAgIGdzd2FwMiA9IGdseXBoQnVmZmVyWy0tZW5kXTsKICAg ICAgICAgICAgIGdseXBoQnVmZmVyW2ldID0gZ3N3YXAyOwogICAgICAgICAgICAgZ2x5cGhCdWZm ZXJbZW5kXSA9IGdzd2FwMTsKICAgICAgICAgfQotICAgICAgICBmb3IgKGkgPSBwb3MsIGVuZCA9 IG51bUdseXBocyAtIDE7IGkgPCAobnVtR2x5cGhzIC0gcG9zKS8yOyBpKyspeworICAgICAgICBm b3IgKGkgPSBwb3MsIGVuZCA9IG51bUdseXBoczsgaSA8IChudW1HbHlwaHMgLSBwb3MpLzI7IGkr Kyl7CiAgICAgICAgICAgICBhc3dhcDEgPSBhZHZhbmNlc1tpXTsKICAgICAgICAgICAgIGFzd2Fw MiA9IGFkdmFuY2VzWy0tZW5kXTsKICAgICAgICAgICAgIGFkdmFuY2VzW2ldID0gYXN3YXAyOwog ICAgICAgICAgICAgYWR2YW5jZXNbZW5kXSA9IGFzd2FwMTsKICAgICAgICAgfQotICAgICAgICBm b3IgKGkgPSBwb3MsIGVuZCA9IG51bUdseXBocyAtIDE7IGkgPCAobnVtR2x5cGhzIC0gcG9zKS8y OyBpKyspeworICAgICAgICBmb3IgKGkgPSBwb3MsIGVuZCA9IG51bUdseXBoczsgaSA8IChudW1H bHlwaHMgLSBwb3MpLzI7IGkrKyl7CiAgICAgICAgICAgICBmc3dhcDEgPSBmb250QnVmZmVyW2ld OwogICAgICAgICAgICAgZnN3YXAyID0gZm9udEJ1ZmZlclstLWVuZF07CiAgICAgICAgICAgICBm b250QnVmZmVyW2ldID0gZnN3YXAyOwo=