<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>36169</bug_id>
          
          <creation_ts>2010-03-16 09:16:43 -0700</creation_ts>
          <short_desc>CCommit queue should ignore (probably red) builders when landing rollouts</short_desc>
          <delta_ts>2010-03-17 20:24:58 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Other</rep_platform>
          <op_sys>OS X 10.5</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Adam Barth">abarth</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>commit-queue</cc>
    
    <cc>eric</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>200239</commentid>
    <comment_count>0</comment_count>
    <who name="Adam Barth">abarth</who>
    <bug_when>2010-03-16 09:16:43 -0700</bug_when>
    <thetext>CCommit queue should ignore (probably red) builders when landing rollouts</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>200241</commentid>
    <comment_count>1</comment_count>
      <attachid>50800</attachid>
    <who name="Adam Barth">abarth</who>
    <bug_when>2010-03-16 09:18:43 -0700</bug_when>
    <thetext>Created attachment 50800
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>200903</commentid>
    <comment_count>2</comment_count>
      <attachid>50800</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2010-03-17 12:46:55 -0700</bug_when>
    <thetext>Comment on attachment 50800
Patch

 213                 # We pass --no-update here because we&apos;ve already validated

should say &quot;in the normal case&quot; or something instead of &quot;here&quot; to designate that it&apos;s the commit-queue case instead of the rollout case.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>200931</commentid>
    <comment_count>3</comment_count>
      <attachid>50946</attachid>
    <who name="Adam Barth">abarth</who>
    <bug_when>2010-03-17 13:05:54 -0700</bug_when>
    <thetext>Created attachment 50946
Patch for landing</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>201164</commentid>
    <comment_count>4</comment_count>
      <attachid>50946</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2010-03-17 20:24:54 -0700</bug_when>
    <thetext>Comment on attachment 50946
Patch for landing

Clearing flags on attachment: 50946

Committed r56145: &lt;http://trac.webkit.org/changeset/56145&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>201165</commentid>
    <comment_count>5</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2010-03-17 20:24:58 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>50800</attachid>
            <date>2010-03-16 09:18:43 -0700</date>
            <delta_ts>2010-03-17 13:05:51 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-36169-20100316091841.patch</filename>
            <type>text/plain</type>
            <size>2792</size>
            <attacher name="Adam Barth">abarth</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv
ZwppbmRleCA5MTgyMWU0Li44NjAzZGExIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM
b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTAtMDMt
MTYgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBi
eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDb21taXQgcXVldWUgc2hvdWxkIGlnbm9yZSAo
cHJvYmFibHkgcmVkKSBidWlsZGVycyB3aGVuIGxhbmRpbmcgcm9sbG91dHMKKyAgICAgICAgaHR0
cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM2MTY5CisKKyAgICAgICAgV2hl
biBsYW5kaW5nIGEgcm9sbG91dCwgdGhlIGJ1aWxkZXJzIGFyZSBwcm9iYWJseSByZWQsIHNvIHdl
IG5lZWQgdG8KKyAgICAgICAgaWdub3JlIHRoZW0gaW4gdGhlIHN1YnByb2Nlc3MgdG9vLiAgQWxz
bywgd2UgbWlnaHQgYXMgd2VsbCB1cGRhdGUgdGhlCisgICAgICAgIHdvcmtpbmcgY29weSBiZWNh
dXNlIHdlIGhhdmVuJ3QgdmFsaWRhdGVkIGFueXRoaW5nIGFib3V0IHRoZSBjdXJyZW50CisgICAg
ICAgIHJldmlzaW9uIHByaW9yIHRvIHRyeWluZyB0byBsYW5kLgorCisgICAgICAgIFRoaXMgY2hh
bmdlIGlzIHRlc3RhYmxlLCBidXQgaXQgcmVxdWlyZXMgY2hhbmdpbmcgdGhlIG1vY2sgZXhlY3V0
aXZlIHRvCisgICAgICAgIGxvZyBpdHMgYXJndW1lbnRzLiAgVGhhdCB3aWxsIGdlbmVyYXRlIGEg
bG90IG9mIGV4cGVjdGF0aW9uIGNoYW5nZXMsIHNvCisgICAgICAgIEknZCBsaWtlIHRvIGRvIHRo
YXQgaW4gYSBzZXBhcmF0ZSBwYXRjaC4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvY29t
bWFuZHMvcXVldWVzLnB5OgorCiAyMDEwLTAzLTE1ICBFcmljIFNlaWRlbCAgPGVyaWNAd2Via2l0
Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBBZGFtIEJhcnRoLgpkaWZmIC0tZ2l0IGEvV2Vi
S2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tYW5kcy9xdWV1ZXMucHkgYi9XZWJLaXRUb29s
cy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1hbmRzL3F1ZXVlcy5weQppbmRleCAwZWM3YWIzLi5iNWU5
ZjhjIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1hbmRzL3F1
ZXVlcy5weQorKysgYi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1hbmRzL3F1ZXVl
cy5weQpAQCAtMTk2LDEwICsxOTYsMjUgQEAgY2xhc3MgQ29tbWl0UXVldWUoQWJzdHJhY3RRdWV1
ZSwgU3RlcFNlcXVlbmNlRXJyb3JIYW5kbGVyKToKICAgICBkZWYgcHJvY2Vzc193b3JrX2l0ZW0o
c2VsZiwgcGF0Y2gpOgogICAgICAgICB0cnk6CiAgICAgICAgICAgICBzZWxmLl9jY193YXRjaGVy
cyhwYXRjaC5idWdfaWQoKSkKLSAgICAgICAgICAgICMgV2UgcGFzcyAtLW5vLXVwZGF0ZSBoZXJl
IGJlY2F1c2Ugd2UndmUgYWxyZWFkeSB2YWxpZGF0ZWQKLSAgICAgICAgICAgICMgdGhhdCB0aGUg
Y3VycmVudCByZXZpc2lvbiBhY3R1YWxseSBidWlsZHMgYW5kIHBhc3NlcyB0aGUgdGVzdHMuCi0g
ICAgICAgICAgICAjIElmIHdlIHVwZGF0ZSwgd2UgcmlzayBtb3ZpbmcgdG8gYSByZXZpc2lvbiB0
aGF0IGRvZXNuJ3QhCi0gICAgICAgICAgICBzZWxmLnJ1bl93ZWJraXRfcGF0Y2goWyJsYW5kLWF0
dGFjaG1lbnQiLCAiLS1mb3JjZS1jbGVhbiIsICItLW5vbi1pbnRlcmFjdGl2ZSIsICItLW5vLXVw
ZGF0ZSIsICItLXBhcmVudC1jb21tYW5kPWNvbW1pdC1xdWV1ZSIsICItLWJ1aWxkLXN0eWxlPWJv
dGgiLCAiLS1xdWlldCIsIHBhdGNoLmlkKCldKQorICAgICAgICAgICAgYXJncyA9IFsKKyAgICAg
ICAgICAgICAgICAibGFuZC1hdHRhY2htZW50IiwKKyAgICAgICAgICAgICAgICAiLS1mb3JjZS1j
bGVhbiIsCisgICAgICAgICAgICAgICAgIi0tbm9uLWludGVyYWN0aXZlIiwKKyAgICAgICAgICAg
ICAgICAiLS1wYXJlbnQtY29tbWFuZD1jb21taXQtcXVldWUiLAorICAgICAgICAgICAgICAgICIt
LWJ1aWxkLXN0eWxlPWJvdGgiLAorICAgICAgICAgICAgICAgICItLXF1aWV0IiwKKyAgICAgICAg
ICAgICAgICBwYXRjaC5pZCgpCisgICAgICAgICAgICBdCisgICAgICAgICAgICBpZiBwYXRjaC5p
c19yb2xsb3V0KCk6CisgICAgICAgICAgICAgICAgIyBXZSBuZWVkIHRvIGlnbm9yZSB0aGUgYnVp
bGRlcnMgd2hlbiBsYW5kaW5nIGEgcm9sbG91dAorICAgICAgICAgICAgICAgICMgYmVjYXVzZSB0
aGV5J3JlIHByb2JhYmx5IHJlZC4KKyAgICAgICAgICAgICAgICBhcmdzLmFwcGVuZCgiLS1pZ25v
cmUtYnVpbGRlcnMiKQorICAgICAgICAgICAgZWxzZToKKyAgICAgICAgICAgICAgICAjIFdlIHBh
c3MgLS1uby11cGRhdGUgaGVyZSBiZWNhdXNlIHdlJ3ZlIGFscmVhZHkgdmFsaWRhdGVkCisgICAg
ICAgICAgICAgICAgIyB0aGF0IHRoZSBjdXJyZW50IHJldmlzaW9uIGFjdHVhbGx5IGJ1aWxkcyBh
bmQgcGFzc2VzIHRoZSB0ZXN0cy4KKyAgICAgICAgICAgICAgICAjIElmIHdlIHVwZGF0ZSwgd2Ug
cmlzayBtb3ZpbmcgdG8gYSByZXZpc2lvbiB0aGF0IGRvZXNuJ3QhCisgICAgICAgICAgICAgICAg
YXJncy5hcHBlbmQoIi0tbm8tdXBkYXRlIikKKyAgICAgICAgICAgIHNlbGYucnVuX3dlYmtpdF9w
YXRjaChhcmdzKQogICAgICAgICAgICAgc2VsZi5fZGlkX3Bhc3MocGF0Y2gpCiAgICAgICAgIGV4
Y2VwdCBTY3JpcHRFcnJvciwgZToKICAgICAgICAgICAgIHNlbGYuX2RpZF9mYWlsKHBhdGNoKQo=
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>50946</attachid>
            <date>2010-03-17 13:05:54 -0700</date>
            <delta_ts>2010-03-17 20:24:54 -0700</delta_ts>
            <desc>Patch for landing</desc>
            <filename>bug-36169-20100317130553.patch</filename>
            <type>text/plain</type>
            <size>2847</size>
            <attacher name="Adam Barth">abarth</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv
ZwppbmRleCAyMTIwNzNiLi43OTA5NzIwIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM
b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTAtMDMt
MTcgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBi
eSBFcmljIFNlaWRlbC4KKworICAgICAgICBDb21taXQgcXVldWUgc2hvdWxkIGlnbm9yZSAocHJv
YmFibHkgcmVkKSBidWlsZGVycyB3aGVuIGxhbmRpbmcgcm9sbG91dHMKKyAgICAgICAgaHR0cHM6
Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM2MTY5CisKKyAgICAgICAgV2hlbiBs
YW5kaW5nIGEgcm9sbG91dCwgdGhlIGJ1aWxkZXJzIGFyZSBwcm9iYWJseSByZWQsIHNvIHdlIG5l
ZWQgdG8KKyAgICAgICAgaWdub3JlIHRoZW0gaW4gdGhlIHN1YnByb2Nlc3MgdG9vLiAgQWxzbywg
d2UgbWlnaHQgYXMgd2VsbCB1cGRhdGUgdGhlCisgICAgICAgIHdvcmtpbmcgY29weSBiZWNhdXNl
IHdlIGhhdmVuJ3QgdmFsaWRhdGVkIGFueXRoaW5nIGFib3V0IHRoZSBjdXJyZW50CisgICAgICAg
IHJldmlzaW9uIHByaW9yIHRvIHRyeWluZyB0byBsYW5kLgorCisgICAgICAgIFRoaXMgY2hhbmdl
IGlzIHRlc3RhYmxlLCBidXQgaXQgcmVxdWlyZXMgY2hhbmdpbmcgdGhlIG1vY2sgZXhlY3V0aXZl
IHRvCisgICAgICAgIGxvZyBpdHMgYXJndW1lbnRzLiAgVGhhdCB3aWxsIGdlbmVyYXRlIGEgbG90
IG9mIGV4cGVjdGF0aW9uIGNoYW5nZXMsIHNvCisgICAgICAgIEknZCBsaWtlIHRvIGRvIHRoYXQg
aW4gYSBzZXBhcmF0ZSBwYXRjaC4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvY29tbWFu
ZHMvcXVldWVzLnB5OgorCiAyMDEwLTAzLTE3ICBWaWN0b3IgV2FuZyAgPHZpY3RvcndAY2hyb21p
dW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERpbWl0cmkgR2xhemtvdi4KZGlmZiAtLWdp
dCBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbWFuZHMvcXVldWVzLnB5IGIvV2Vi
S2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tYW5kcy9xdWV1ZXMucHkKaW5kZXggMGVjN2Fi
My4uODFlNDUxMSAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21t
YW5kcy9xdWV1ZXMucHkKKysrIGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tYW5k
cy9xdWV1ZXMucHkKQEAgLTE5NiwxMCArMTk2LDI2IEBAIGNsYXNzIENvbW1pdFF1ZXVlKEFic3Ry
YWN0UXVldWUsIFN0ZXBTZXF1ZW5jZUVycm9ySGFuZGxlcik6CiAgICAgZGVmIHByb2Nlc3Nfd29y
a19pdGVtKHNlbGYsIHBhdGNoKToKICAgICAgICAgdHJ5OgogICAgICAgICAgICAgc2VsZi5fY2Nf
d2F0Y2hlcnMocGF0Y2guYnVnX2lkKCkpCi0gICAgICAgICAgICAjIFdlIHBhc3MgLS1uby11cGRh
dGUgaGVyZSBiZWNhdXNlIHdlJ3ZlIGFscmVhZHkgdmFsaWRhdGVkCi0gICAgICAgICAgICAjIHRo
YXQgdGhlIGN1cnJlbnQgcmV2aXNpb24gYWN0dWFsbHkgYnVpbGRzIGFuZCBwYXNzZXMgdGhlIHRl
c3RzLgotICAgICAgICAgICAgIyBJZiB3ZSB1cGRhdGUsIHdlIHJpc2sgbW92aW5nIHRvIGEgcmV2
aXNpb24gdGhhdCBkb2Vzbid0IQotICAgICAgICAgICAgc2VsZi5ydW5fd2Via2l0X3BhdGNoKFsi
bGFuZC1hdHRhY2htZW50IiwgIi0tZm9yY2UtY2xlYW4iLCAiLS1ub24taW50ZXJhY3RpdmUiLCAi
LS1uby11cGRhdGUiLCAiLS1wYXJlbnQtY29tbWFuZD1jb21taXQtcXVldWUiLCAiLS1idWlsZC1z
dHlsZT1ib3RoIiwgIi0tcXVpZXQiLCBwYXRjaC5pZCgpXSkKKyAgICAgICAgICAgIGFyZ3MgPSBb
CisgICAgICAgICAgICAgICAgImxhbmQtYXR0YWNobWVudCIsCisgICAgICAgICAgICAgICAgIi0t
Zm9yY2UtY2xlYW4iLAorICAgICAgICAgICAgICAgICItLW5vbi1pbnRlcmFjdGl2ZSIsCisgICAg
ICAgICAgICAgICAgIi0tcGFyZW50LWNvbW1hbmQ9Y29tbWl0LXF1ZXVlIiwKKyAgICAgICAgICAg
ICAgICAiLS1idWlsZC1zdHlsZT1ib3RoIiwKKyAgICAgICAgICAgICAgICAiLS1xdWlldCIsCisg
ICAgICAgICAgICAgICAgcGF0Y2guaWQoKQorICAgICAgICAgICAgXQorICAgICAgICAgICAgaWYg
cGF0Y2guaXNfcm9sbG91dCgpOgorICAgICAgICAgICAgICAgICMgV2UgbmVlZCB0byBpZ25vcmUg
dGhlIGJ1aWxkZXJzIHdoZW4gbGFuZGluZyBhIHJvbGxvdXQKKyAgICAgICAgICAgICAgICAjIGJl
Y2F1c2UgdGhleSdyZSBwcm9iYWJseSByZWQuCisgICAgICAgICAgICAgICAgYXJncy5hcHBlbmQo
Ii0taWdub3JlLWJ1aWxkZXJzIikKKyAgICAgICAgICAgIGVsc2U6CisgICAgICAgICAgICAgICAg
IyBXZSBwYXNzIC0tbm8tdXBkYXRlIGluIHRoZSBub3JtYWwgKG5vbi1yb2xsb3V0KSBjYXNlCisg
ICAgICAgICAgICAgICAgIyBiZWNhdXNlIHdlJ3ZlIGFscmVhZHkgdmFsaWRhdGVkIHRoYXQgdGhl
IGN1cnJlbnQgcmV2aXNpb24KKyAgICAgICAgICAgICAgICAjIGFjdHVhbGx5IGJ1aWxkcyBhbmQg
cGFzc2VzIHRoZSB0ZXN0cy4gIElmIHdlIHVwZGF0ZSwgd2UgcmlzaworICAgICAgICAgICAgICAg
ICMgbW92aW5nIHRvIGEgcmV2aXNpb24gdGhhdCBkb2Vzbid0IQorICAgICAgICAgICAgICAgIGFy
Z3MuYXBwZW5kKCItLW5vLXVwZGF0ZSIpCisgICAgICAgICAgICBzZWxmLnJ1bl93ZWJraXRfcGF0
Y2goYXJncykKICAgICAgICAgICAgIHNlbGYuX2RpZF9wYXNzKHBhdGNoKQogICAgICAgICBleGNl
cHQgU2NyaXB0RXJyb3IsIGU6CiAgICAgICAgICAgICBzZWxmLl9kaWRfZmFpbChwYXRjaCkK
</data>

          </attachment>
      

    </bug>

</bugzilla>