36167 2010-03-16 08:08:13 -0700 Spatial Navigation: Add isNull and document convenient methods to FocusCandidate 2010-04-20 13:25:34 -0700 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) PC All CLOSED FIXED P2 Normal --- 36168 1 tonikitoo tonikitoo gustavo hausmann simon.fraser webkit.review.bot oldest_to_newest 200189 0 tonikitoo 2010-03-16 08:08:13 -0700 It turns out that Spatial Navigation related code (in FocusController.cpp for instance) can be simplified and look better if FocusCandidate class offers some convinient method. This patch introduces a couple of them (isNull and a Document* getter). patch comming ... 200195 1 50793 tonikitoo 2010-03-16 08:18:01 -0700 Created attachment 50793 patch 0.1 - adds isNull() and document() to FocusCandidate 200893 2 50793 gustavo 2010-03-17 12:07:10 -0700 Comment on attachment 50793 patch 0.1 - adds isNull() and document() to FocusCandidate > It turns out that Spatial Navigation related code (in FocusController.cpp for > instance) can be simplified and look better if FocusCandidate class offer some > convinient method. This patch introduces a couple of them (isNull and a Document > getter). convenience methods sounds better. > A followup refactory patch will be making use of these helper methods. refactoring 93  FocusCandidate() 94  : node(0)  93 FocusCandidate(Node* n = 0)  94 : node(n) Having a default value in a constructor doesn't look very idiomatic to me. I may be wrong, given my small experience with C++, but then again, most code I've touched in WebKit have two separate constructors for this kind of case - one for when you don't want to give it a node, one for when you have to give it a node. Otherwise, the patch is fine, but I think it would be preferable if we have at least some code refactored to use the new methods in the same patch. r- for the constructor problem. 200897 3 50933 tonikitoo 2010-03-17 12:37:32 -0700 Created attachment 50933 patch 0.2 - addressed kov's suggestions thx for reviewing Gustavo. > convenience methods sounds better. Changed. >> A followup refactory patch will be making use of these helper methods. >refactoring Changed. > Having a default value in a constructor doesn't > look very idiomatic to me. I may be wrong, given my > small experience with C++, but then again, most code > I've touched in WebKit have two separate constructors > for this kind of case - one for when you don't want to > give it a node, one for when you have to give it a node. Done. I added an additional constructor as suggested, as well as a private |init| method that assigns default values to all other class member data commonly initiated by both class construtors. > Otherwise, the patch is fine, but I think it would be > preferable if we have at least some code refactored to > use the new methods in the same patch. r- for the > constructor problem. bug 36168 is all about this new refactored code :-) 200899 4 50935 tonikitoo 2010-03-17 12:41:36 -0700 Created attachment 50935 patch 0.2.1 - addressed kov's suggestions Same as patch 0.2, but w/ the correct ChangeLog entry. 200900 5 webkit.review.bot 2010-03-17 12:42:39 -0700 Attachment 50935 did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebCore/page/SpatialNavigation.h:115: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 200904 6 50935 gustavo 2010-03-17 12:48:18 -0700 Comment on attachment 50935 patch 0.2.1 - addressed kov's suggestions I think you should be good repeating the initialization in both constructors, I think that's preferable. Having an additional function seems unnecessary here. Also, I just noticed you're using inline for the small functions. This is usually frowned upon unless you have a reason to do it. The compiler should be smart enough to do the optimization otherwise. 200912 7 50940 tonikitoo 2010-03-17 12:54:40 -0700 Created attachment 50940 (committed in r56159) patch 0.3 - addressed kov's suggestions > I think you should be good repeating the initialization in both constructors, I > think that's preferable. Having an additional function seems unnecessary here. Done > Also, I just noticed you're using inline for the small functions. This is > usually frowned upon unless you have a reason to do it. The compiler should be > smart enough to do the optimization otherwise. Done. 201173 8 tonikitoo 2010-03-17 20:44:31 -0700 kov, one more time? 201269 9 50940 gustavo 2010-03-18 06:51:50 -0700 Comment on attachment 50940 (committed in r56159) patch 0.3 - addressed kov's suggestions You could also make the methods const (bool isNull() const { return !node; }), but otherwise looks good to me. 201289 10 tonikitoo 2010-03-18 07:50:41 -0700 thx kov 211515 11 50940 tonikitoo 2010-04-11 20:02:08 -0700 Comment on attachment 50940 (committed in r56159) patch 0.3 - addressed kov's suggestions Clearing flags on attachment: 50940 Committed r56159: <http://trac.webkit.org/changeset/56159> 50793 2010-03-16 08:18:01 -0700 2010-03-17 12:37:32 -0700 patch 0.1 - adds isNull() and document() to FocusCandidate 0001-Spatial-Navigation-Add-isNull-and-document-convenie.patch text/plain 3785 tonikitoo RnJvbSA5MTRmMDA1NTVlOTk2MDdiNzE0ZjM3OWYwNWYzNTA5M2ViYTE3MTI0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbnRvbmlvIEdvbWVzIDx0b25pa2l0b29Ad2Via2l0Lm9yZz4K RGF0ZTogTW9uLCAxNSBNYXIgMjAxMCAxNToxNTowNyAtMDQwMApTdWJqZWN0OiBbUEFUQ0hdIFNw YXRpYWwgTmF2aWdhdGlvbjogQWRkIGlzTnVsbCBhbmQgZG9jdW1lbnQgY29udmVuaWVudCBtZXRo b2RzIHRvIEZvY3VzQ2FuZGlkYXRlCiBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MzYxNjcKClJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgpQYXRjaCBieSBBbnRvbmlv IEdvbWVzIDx0b25pa2l0b29Ad2Via2l0Lm9yZz4KCkl0IHR1cm5zIG91dCB0aGF0IFNwYXRpYWwg TmF2aWdhdGlvbiByZWxhdGVkIGNvZGUgKGluIEZvY3VzQ29udHJvbGxlci5jcHAgZm9yCmluc3Rh bmNlKSBjYW4gYmUgc2ltcGxpZmllZCBhbmQgbG9vayBiZXR0ZXIgaWYgRm9jdXNDYW5kaWRhdGUg Y2xhc3Mgb2ZmZXIgc29tZQpjb252aW5pZW50IG1ldGhvZC4gVGhpcyBwYXRjaCBpbnRyb2R1Y2Vz IGEgY291cGxlIG9mIHRoZW0gKGlzTnVsbCBhbmQgYSBEb2N1bWVudApnZXR0ZXIpLgoKQSBmb2xs b3d1cCByZWZhY3RvcnkgcGF0Y2ggd2lsbCBiZSBtYWtpbmcgdXNlIG9mIHRoZXNlIGhlbHBlciBt ZXRob2RzLgoKKiBwYWdlL1NwYXRpYWxOYXZpZ2F0aW9uLmg6CihXZWJDb3JlOjpGb2N1c0NhbmRp ZGF0ZTo6Rm9jdXNDYW5kaWRhdGUpOiBBZGRlZCBhICJOb2RlKiIgcGFyYW1ldGVyCnRvIEZvY3Vz Q2FuZGlkYXRlJ3MgY29uc3RydWN0b3IuIEl0IGlzIG9wdGlvbmFsLCBhbmQgaWYgbm8gdmFsdWUg aXMgcGFzc2VkLAppdCBkZWZhdWx0cyB0byAnMCcuCihXZWJDb3JlOjpGb2N1c0NhbmRpZGF0ZTo6 aXNOdWxsKTogSW4gdGhlIFNwYXRpYWwgTmF2aWdhdGlvbiBsb2dpYywgYSBOVUxMCkZvY3VzQ2Fu ZGlkYXRlIG9iamVjdCBpcyBvbmUgdGhhdCBkb2VzIG5vdCBob2xkIGEgdmFsaWQgcmVmZXJlbmNl IHRvIGEgIk5vZGUqIi4KKFdlYkNvcmU6OkZvY3VzQ2FuZGlkYXRlOjpkb2N1bWVudCk6IFRoaXMg bWV0aG9kIHJldHVybnMgYSBwb2ludGVyIGZvciB0aGUgRm9jdXNDYW5kaWRhdGUKbm9kZSdzIGRv Y3VtZW50LCBpZiB8bm9kZXwgaXMgYSB2YWxpZCBwb2ludGVyLgotLS0KIFdlYkNvcmUvQ2hhbmdl TG9nICAgICAgICAgICAgICAgIHwgICAyNCArKysrKysrKysrKysrKysrKysrKysrKysKIFdlYkNv cmUvcGFnZS9TcGF0aWFsTmF2aWdhdGlvbi5oIHwgICAxMCArKysrKysrLS0tCiAyIGZpbGVzIGNo YW5nZWQsIDMxIGluc2VydGlvbnMoKyksIDMgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvV2Vi Q29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAwZjUzN2NlLi5jNWUyZDBj IDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpA QCAtMSwzICsxLDI3IEBACisyMDEwLTAzLTE1ICBBbnRvbmlvIEdvbWVzICA8dG9uaWtpdG9vQHdl YmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisgICAgICAg IFBhdGNoIGJ5IEFudG9uaW8gR29tZXMgPHRvbmlraXRvb0B3ZWJraXQub3JnPgorCisgICAgICAg IFNwYXRpYWwgTmF2aWdhdGlvbjogQWRkIGlzTnVsbCgpIGFuZCBkb2N1bWVudCgpIGNvbnZlbmll bnQgbWV0aG9kcyB0byBGb2N1c0NhbmRpZGF0ZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTM2MTY3CisKKyAgICAgICAgSXQgdHVybnMgb3V0IHRoYXQg U3BhdGlhbCBOYXZpZ2F0aW9uIHJlbGF0ZWQgY29kZSAoaW4gRm9jdXNDb250cm9sbGVyLmNwcCBm b3IKKyAgICAgICAgaW5zdGFuY2UpIGNhbiBiZSBzaW1wbGlmaWVkIGFuZCBsb29rIGJldHRlciBp ZiBGb2N1c0NhbmRpZGF0ZSBjbGFzcyBvZmZlciBzb21lCisgICAgICAgIGNvbnZpbmllbnQgbWV0 aG9kLiBUaGlzIHBhdGNoIGludHJvZHVjZXMgYSBjb3VwbGUgb2YgdGhlbSAoaXNOdWxsIGFuZCBh IERvY3VtZW50CisgICAgICAgIGdldHRlcikuCisKKyAgICAgICAgQSBmb2xsb3d1cCByZWZhY3Rv cnkgcGF0Y2ggd2lsbCBiZSBtYWtpbmcgdXNlIG9mIHRoZXNlIGhlbHBlciBtZXRob2RzLgorCisg ICAgICAgICogcGFnZS9TcGF0aWFsTmF2aWdhdGlvbi5oOgorICAgICAgICAoV2ViQ29yZTo6Rm9j dXNDYW5kaWRhdGU6OkZvY3VzQ2FuZGlkYXRlKTogQWRkZWQgYSAiTm9kZSoiIHBhcmFtZXRlcgor ICAgICAgICB0byBGb2N1c0NhbmRpZGF0ZSdzIGNvbnN0cnVjdG9yLiBJdCBpcyBvcHRpb25hbCwg YW5kIGlmIG5vIHZhbHVlIGlzIHBhc3NlZCwKKyAgICAgICAgaXQgZGVmYXVsdHMgdG8gJzAnLgor ICAgICAgICAoV2ViQ29yZTo6Rm9jdXNDYW5kaWRhdGU6OmlzTnVsbCk6IEluIHRoZSBTcGF0aWFs IE5hdmlnYXRpb24gbG9naWMsIGEgTlVMTAorICAgICAgICBGb2N1c0NhbmRpZGF0ZSBvYmplY3Qg aXMgb25lIHRoYXQgZG9lcyBub3QgaG9sZCBhIHZhbGlkIHJlZmVyZW5jZSB0byBhICJOb2RlKiIu CisgICAgICAgIChXZWJDb3JlOjpGb2N1c0NhbmRpZGF0ZTo6ZG9jdW1lbnQpOiBUaGlzIG1ldGhv ZCByZXR1cm5zIGEgcG9pbnRlciBmb3IgdGhlIEZvY3VzQ2FuZGlkYXRlCisgICAgICAgIG5vZGUn cyBkb2N1bWVudCwgaWYgfG5vZGV8IGlzIGEgdmFsaWQgcG9pbnRlci4KKwogMjAxMC0wMy0xMiAg QW50b25pbyBHb21lcyAgPHRvbmlraXRvb0B3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2Vk IGJ5IFNpbW9uIEZyYXNlci4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGFnZS9TcGF0aWFsTmF2aWdh dGlvbi5oIGIvV2ViQ29yZS9wYWdlL1NwYXRpYWxOYXZpZ2F0aW9uLmgKaW5kZXggZDU0NTU0ZC4u MDM2NDUxYSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wYWdlL1NwYXRpYWxOYXZpZ2F0aW9uLmgKKysr IGIvV2ViQ29yZS9wYWdlL1NwYXRpYWxOYXZpZ2F0aW9uLmgKQEAgLTIyLDYgKzIyLDcgQEAKICNk ZWZpbmUgU3BhdGlhbE5hdmlnYXRpb25faAogCiAjaW5jbHVkZSAiRm9jdXNEaXJlY3Rpb24uaCIK KyNpbmNsdWRlICJOb2RlLmgiCiAKICNpbmNsdWRlIDxsaW1pdHM+CiAKQEAgLTMwLDcgKzMxLDYg QEAgbmFtZXNwYWNlIFdlYkNvcmUgewogY2xhc3MgRWxlbWVudDsKIGNsYXNzIEZyYW1lOwogY2xh c3MgSW50UmVjdDsKLWNsYXNzIE5vZGU7CiBjbGFzcyBSZW5kZXJPYmplY3Q7CiAKIHVzaW5nIG5h bWVzcGFjZSBzdGQ7CkBAIC05MCwxNCArOTAsMTggQEAgZW51bSBSZWN0c0FsaWdubWVudCB7CiB9 OwogCiBzdHJ1Y3QgRm9jdXNDYW5kaWRhdGUgewotICAgIEZvY3VzQ2FuZGlkYXRlKCkKLSAgICAg ICAgOiBub2RlKDApCisgICAgRm9jdXNDYW5kaWRhdGUoTm9kZSogbiA9IDApCisgICAgICAgIDog bm9kZShuKQogICAgICAgICAsIGRpc3RhbmNlKG1heERpc3RhbmNlKCkpCiAgICAgICAgICwgcGFy ZW50RGlzdGFuY2UobWF4RGlzdGFuY2UoKSkKICAgICAgICAgLCBhbGlnbm1lbnQoTm9uZSkKICAg ICAgICAgLCBwYXJlbnRBbGlnbm1lbnQoTm9uZSkKICAgICB7CiAgICAgfQorCisgICAgaW5saW5l IGJvb2wgaXNOdWxsKCkgeyByZXR1cm4gIW5vZGU7IH0KKyAgICBpbmxpbmUgRG9jdW1lbnQqIGRv Y3VtZW50KCkgeyByZXR1cm4gbm9kZSA/IG5vZGUtPmRvY3VtZW50KCkgOiAwOyB9CisKICAgICBO b2RlKiBub2RlOwogICAgIGxvbmcgbG9uZyBkaXN0YW5jZTsKICAgICBsb25nIGxvbmcgcGFyZW50 RGlzdGFuY2U7Ci0tIAoxLjYuMC40Cgo= 50933 2010-03-17 12:37:32 -0700 2010-03-17 12:41:36 -0700 patch 0.2 - addressed kov's suggestions 0001-Spatial-Navigation-Add-isNull-and-document-convenie.patch text/plain 6019 tonikitoo RnJvbSAwMDg1NmQyNjVhZjlmZWVhZmQzMTFhOWFjZTgyNGQzMjJmMTFkZDZiIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbnRvbmlvIEdvbWVzIDx0b25pa2l0b29Ad2Via2l0Lm9yZz4K RGF0ZTogTW9uLCAxNSBNYXIgMjAxMCAxNToxNTowNyAtMDQwMApTdWJqZWN0OiBbUEFUQ0hdIFNw YXRpYWwgTmF2aWdhdGlvbjogQWRkIGlzTnVsbCBhbmQgZG9jdW1lbnQgY29udmVuaWVuY2UgbWV0 aG9kcyB0byBGb2N1c0NhbmRpZGF0ZQogaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTM2MTY3CgpSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KUGF0Y2ggYnkgQW50b25p byBHb21lcyA8dG9uaWtpdG9vQHdlYmtpdC5vcmc+CgpJdCB0dXJucyBvdXQgdGhhdCBTcGF0aWFs IE5hdmlnYXRpb24gcmVsYXRlZCBjb2RlIChpbiBGb2N1c0NvbnRyb2xsZXIuY3BwIGZvcgppbnN0 YW5jZSkgY2FuIGJlIHNpbXBsaWZpZWQgYW5kIGxvb2sgYmV0dGVyIGlmIEZvY3VzQ2FuZGlkYXRl IGNsYXNzIG9mZmVyIHNvbWUKY29udmluaWVuY2UgbWV0aG9kLiBUaGlzIHBhdGNoIGludHJvZHVj ZXMgYSBjb3VwbGUgb2YgdGhlbSAoaXNOdWxsIGFuZCBhIERvY3VtZW50CmdldHRlciksIGFzIHdl bGwgYXMgYW4gYWRkaXRpb25hbCBjb25zdHJ1Y3RvciByZWNlaXZpbmcgYSBOb2RlIHBvaW50ZXIu CgpBIGZvbGxvd3VwIHJlZmFjdG9yaW5nIHBhdGNoIHdpbGwgYmUgbWFraW5nIHVzZSBvZiB0aGVz ZSBoZWxwZXIgbWV0aG9kcy4KCiogcGFnZS9TcGF0aWFsTmF2aWdhdGlvbi5oOgooV2ViQ29yZTo6 Rm9jdXNDYW5kaWRhdGU6OkZvY3VzQ2FuZGlkYXRlKTogQWRkZWQgYSAiTm9kZSoiIHBhcmFtZXRl cgp0byBGb2N1c0NhbmRpZGF0ZSdzIGNvbnN0cnVjdG9yLgooV2ViQ29yZTo6Rm9jdXNDYW5kaWRh dGU6OmlzTnVsbCk6IEluIHRoZSBTcGF0aWFsIE5hdmlnYXRpb24gbG9naWMsIGEgTlVMTApGb2N1 c0NhbmRpZGF0ZSBvYmplY3QgaXMgb25lIHRoYXQgZG9lcyBub3QgaG9sZCBhIHZhbGlkIHJlZmVy ZW5jZSB0byBhICJOb2RlKiIuCihXZWJDb3JlOjpGb2N1c0NhbmRpZGF0ZTo6ZG9jdW1lbnQpOiBU aGlzIG1ldGhvZCByZXR1cm5zIGEgcG9pbnRlciBmb3IgdGhlIEZvY3VzQ2FuZGlkYXRlCm5vZGUn cyBkb2N1bWVudCwgaWYgfG5vZGV8IGlzIGEgdmFsaWQgcG9pbnRlci4KKFdlYkNvcmU6OkZvY3Vz Q2FuZGlkYXRlOjppbml0KTogQSBwcml2YXRlIG1ldGhvZCB0aGF0IGFzc2lnbnMgYSBkZWZhdWx0 IHZhbHVlIHRvIGFsbApjbGFzcyBtZW1iZXIgZGF0YSBjb21tb25seSBpbml0aWF0ZWQgYnkgYm90 aCBjbGFzcyBjb25zdHJ1dG9ycy4KLS0tCiBXZWJDb3JlL0NoYW5nZUxvZyAgICAgICAgICAgICAg ICB8ICAgNTUgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysKIFdlYkNvcmUv cGFnZS9TcGF0aWFsTmF2aWdhdGlvbi5oIHwgICAyMyArKysrKysrKysrKystLS0KIDIgZmlsZXMg Y2hhbmdlZCwgNzMgaW5zZXJ0aW9ucygrKSwgNSBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9X ZWJDb3JlL0NoYW5nZUxvZyBiL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDBjNGNkMGYuLjM1ZjAy ZDUgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1dlYkNvcmUvQ2hhbmdlTG9n CkBAIC0xLDMgKzEsNTggQEAKKzIwMTAtMDMtMTUgIEFudG9uaW8gR29tZXMgIDx0b25pa2l0b29A d2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKyAgICAg ICAgUGF0Y2ggYnkgQW50b25pbyBHb21lcyA8dG9uaWtpdG9vQHdlYmtpdC5vcmc+CisKKyAgICAg ICAgU3BhdGlhbCBOYXZpZ2F0aW9uOiBJbml0aWFsIGNvZGUgc2ltcGxpZmljYXRpb24gaW4gRm9j dXNDb250cm9sbGVyLmNwcCBhbmQgU3BhdGlhbE5hdmlnYXRpb24uY3BwCisKKyAgICAgICAgV2Vi Q29yZTo6ZGlzdGFuY2VJbkRpcmVjdGlvbiBtZXRob2Qgd2FzIGhhbmRsaW5nIG11Y2ggb2YgdGhl IGxvZ2ljIG5vdCBzdHJpY3RseSByZWxhdGVkCisgICAgICAgIG9ubHkgdG8gdGhlIGRpc3RhbmNl IGJldHdlZW4gbm9kZXMgYWNxdWlzaXRpb24gaXRzZWxmLiBUaGlzIG1ldGhvZCB3YXMgc2ltcGxp ZmllZCBhbmQKKyAgICAgICAgcmVuYW1lZCB0byAnV2ViQ29yZTo6ZGlzdGFuY2VEYXRhRm9yTm9k ZScuIEl0IG5vdyBpcyByZXNwb25zaWJsZSBmb3Igbm90IG9ubHkgZ2V0dGluZyB0aGUKKyAgICAg ICAgZGlzdGFuY2UsIGJ1dCBhbHNvIHBhcmVudCBkb2N1bWVudCBkaXN0YW5jZSwgYWxpZ25tZW50 IGFuZCBwYXJlbnQgZG9jdW1lbnQgYWxpZ25tZW50IHRvIHRoZQorICAgICAgICBjdXJyZW50IGZv Y3VzZWQgbm9kZS4gQWxsIGFzc2lnbmVtZW50IGxvZ2ljIHByZXZpb3VzbHkgdGhlcmUgd2FzIG1v dmVkIHRvIHVwZGF0ZUZvY3VzQ2FuZGlkYXRlSWZDbG9zZXIuCisKKyAgICAgICAgZmluZEZvY3Vz YWJsZU5vZGVJbkRpcmVjdGlvbiBhbmQgZGVlcEZpbmRGb2N1c2FibGVOb2RlSW5EaXJlY3Rpb24g bWV0aG9kIGhhZCB0aGVpciBsb2dpYworICAgICAgICBhbHNvIHNpbXBsaWZpZWQgYmFzZWQgb24g dGhlIGNoYW5nZXMgYWJvdmUuCisKKyAgICAgICAgTm8gYmVoYXZpb3VyIGNoYW5nZSBhdCB0aGlz IHBvaW50LiBNb3N0bHkgbW92aW5nIGNvZGUgYXJvdW5kIHRvIHRoZSBwbGFjZQorICAgICAgICB3 aGVyZSBpdCBzaG91bGQgbGl2ZSBpbi4KKworICAgICAgICAqIHBhZ2UvRm9jdXNDb250cm9sbGVy LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkZvY3VzQ29udHJvbGxlcjo6YWR2YW5jZUZvY3VzRGly ZWN0aW9uYWxseSk6CisgICAgICAgIChXZWJDb3JlOjp1cGRhdGVGb2N1c0NhbmRpZGF0ZUlmQ2xv c2VyKToKKyAgICAgICAgKFdlYkNvcmU6OkZvY3VzQ29udHJvbGxlcjo6ZmluZEZvY3VzYWJsZU5v ZGVJbkRpcmVjdGlvbik6CisgICAgICAgIChXZWJDb3JlOjpGb2N1c0NvbnRyb2xsZXI6OmRlZXBG aW5kRm9jdXNhYmxlTm9kZUluRGlyZWN0aW9uKToKKyAgICAgICAgKiBwYWdlL0ZvY3VzQ29udHJv bGxlci5oOgorICAgICAgICAqIHBhZ2UvU3BhdGlhbE5hdmlnYXRpb24uY3BwOgorICAgICAgICAo V2ViQ29yZTo6ZGlzdGFuY2VEYXRhRm9yTm9kZSk6CisgICAgICAgIChXZWJDb3JlOjpyZW5kZXJS ZWN0UmVsYXRpdmVUb1Jvb3REb2N1bWVudCk6CisgICAgICAgICogcGFnZS9TcGF0aWFsTmF2aWdh dGlvbi5oOgorCisyMDEwLTAzLTE1ICBBbnRvbmlvIEdvbWVzICA8dG9uaWtpdG9vQHdlYmtpdC5v cmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisgICAgICAgIFBhdGNo IGJ5IEFudG9uaW8gR29tZXMgPHRvbmlraXRvb0B3ZWJraXQub3JnPgorCisgICAgICAgIFNwYXRp YWwgTmF2aWdhdGlvbjogQWRkIGlzTnVsbCgpIGFuZCBkb2N1bWVudCgpIGNvbnZlbmllbmNlIG1l dGhvZHMgdG8gRm9jdXNDYW5kaWRhdGUuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0zNjE2NworCisgICAgICAgIEl0IHR1cm5zIG91dCB0aGF0IFNwYXRp YWwgTmF2aWdhdGlvbiByZWxhdGVkIGNvZGUgKGluIEZvY3VzQ29udHJvbGxlci5jcHAgZm9yCisg ICAgICAgIGluc3RhbmNlKSBjYW4gYmUgc2ltcGxpZmllZCBhbmQgbG9vayBiZXR0ZXIgaWYgRm9j dXNDYW5kaWRhdGUgY2xhc3Mgb2ZmZXIgc29tZQorICAgICAgICBjb252ZW5pZW5jZSBtZXRob2Qu IFRoaXMgcGF0Y2ggaW50cm9kdWNlcyBhIGNvdXBsZSBvZiB0aGVtIChpc051bGwgYW5kIGEgRG9j dW1lbnQKKyAgICAgICAgZ2V0dGVyKS4gSXQgYWxzbyBhZGRzIGFub3RoZXIgY29uc3RydWN0b3Ig dGhhdCByZWNlaXZlcyBhIE5vZGUgYXMgcGFyYW1ldGVyLgorCisgICAgICAgIEEgZm9sbG93dXAg cmVmYWN0b3JpbmcgcGF0Y2ggd2lsbCBiZSBtYWtpbmcgdXNlIG9mIHRoZXNlIGhlbHBlciBtZXRo b2RzLgorCisgICAgICAgICogcGFnZS9TcGF0aWFsTmF2aWdhdGlvbi5oOgorICAgICAgICAoV2Vi Q29yZTo6Rm9jdXNDYW5kaWRhdGU6OkZvY3VzQ2FuZGlkYXRlKTogQWRkZWQgYSAiTm9kZSoiIHBh cmFtZXRlcgorICAgICAgICB0byBGb2N1c0NhbmRpZGF0ZSdzIGNvbnN0cnVjdG9yLgorICAgICAg ICAoV2ViQ29yZTo6Rm9jdXNDYW5kaWRhdGU6OmlzTnVsbCk6IEluIHRoZSBTcGF0aWFsIE5hdmln YXRpb24gbG9naWMsIGEgTlVMTAorICAgICAgICBGb2N1c0NhbmRpZGF0ZSBvYmplY3QgaXMgb25l IHRoYXQgZG9lcyBub3QgaG9sZCBhIHZhbGlkIHJlZmVyZW5jZSB0byBhICJOb2RlKiIuCisgICAg ICAgIChXZWJDb3JlOjpGb2N1c0NhbmRpZGF0ZTo6ZG9jdW1lbnQpOiBUaGlzIG1ldGhvZCByZXR1 cm5zIGEgcG9pbnRlciBmb3IgdGhlIEZvY3VzQ2FuZGlkYXRlCisgICAgICAgIG5vZGUncyBkb2N1 bWVudCwgaWYgfG5vZGV8IGlzIGEgdmFsaWQgcG9pbnRlci4KKyAgICAgICAgKFdlYkNvcmU6OkZv Y3VzQ2FuZGlkYXRlOjppbml0KTogQSBwcml2YXRlIG1ldGhvZCB0aGF0IGFzc2lnbnMgYSBkZWZh dWx0IHZhbHVlIHRvIGFsbAorICAgICAgICBjbGFzcyBtZW1iZXIgZGF0YSBjb21tb25seSBpbml0 aWF0ZWQgYnkgYm90aCBjbGFzcyBjb25zdHJ1dG9ycy4KKwogMjAxMC0wMy0xNyAgQW50b25pbyBH b21lcyAgPHRvbmlraXRvb0B3ZWJraXQub3JnPgogCiAgICAgICAgIE1hYyBCdWlsZGZpeDogVXNp bmcgQVNTRVJUX1VOVVNFRCBpbnN0ZWFkIG9mIEFTU0VSVC4KZGlmZiAtLWdpdCBhL1dlYkNvcmUv cGFnZS9TcGF0aWFsTmF2aWdhdGlvbi5oIGIvV2ViQ29yZS9wYWdlL1NwYXRpYWxOYXZpZ2F0aW9u LmgKaW5kZXggZDU0NTU0ZC4uOWUxOTkwOCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wYWdlL1NwYXRp YWxOYXZpZ2F0aW9uLmgKKysrIGIvV2ViQ29yZS9wYWdlL1NwYXRpYWxOYXZpZ2F0aW9uLmgKQEAg LTIyLDYgKzIyLDcgQEAKICNkZWZpbmUgU3BhdGlhbE5hdmlnYXRpb25faAogCiAjaW5jbHVkZSAi Rm9jdXNEaXJlY3Rpb24uaCIKKyNpbmNsdWRlICJOb2RlLmgiCiAKICNpbmNsdWRlIDxsaW1pdHM+ CiAKQEAgLTMwLDcgKzMxLDYgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogY2xhc3MgRWxlbWVudDsK IGNsYXNzIEZyYW1lOwogY2xhc3MgSW50UmVjdDsKLWNsYXNzIE5vZGU7CiBjbGFzcyBSZW5kZXJP YmplY3Q7CiAKIHVzaW5nIG5hbWVzcGFjZSBzdGQ7CkBAIC05MiwxNyArOTIsMzAgQEAgZW51bSBS ZWN0c0FsaWdubWVudCB7CiBzdHJ1Y3QgRm9jdXNDYW5kaWRhdGUgewogICAgIEZvY3VzQ2FuZGlk YXRlKCkKICAgICAgICAgOiBub2RlKDApCi0gICAgICAgICwgZGlzdGFuY2UobWF4RGlzdGFuY2Uo KSkKLSAgICAgICAgLCBwYXJlbnREaXN0YW5jZShtYXhEaXN0YW5jZSgpKQotICAgICAgICAsIGFs aWdubWVudChOb25lKQotICAgICAgICAsIHBhcmVudEFsaWdubWVudChOb25lKQogICAgIHsKKyAg ICAgICAgaW5pdCgpOwogICAgIH0KKworICAgIEZvY3VzQ2FuZGlkYXRlKE5vZGUqIG4pCisgICAg ICAgIDogbm9kZShuKQorICAgIHsKKyAgICAgICAgaW5pdCgpOworICAgIH0KKworICAgIGlubGlu ZSBib29sIGlzTnVsbCgpIHsgcmV0dXJuICFub2RlOyB9CisgICAgaW5saW5lIERvY3VtZW50KiBk b2N1bWVudCgpIHsgcmV0dXJuIG5vZGUgPyBub2RlLT5kb2N1bWVudCgpIDogMDsgfQorCiAgICAg Tm9kZSogbm9kZTsKICAgICBsb25nIGxvbmcgZGlzdGFuY2U7CiAgICAgbG9uZyBsb25nIHBhcmVu dERpc3RhbmNlOwogICAgIFJlY3RzQWxpZ25tZW50IGFsaWdubWVudDsKICAgICBSZWN0c0FsaWdu bWVudCBwYXJlbnRBbGlnbm1lbnQ7CisKK3ByaXZhdGU6CisgICAgaW5saW5lIHZvaWQgaW5pdCgp IHsKKyAgICAgICAgZGlzdGFuY2UgPSBwYXJlbnREaXN0YW5jZSA9IG1heERpc3RhbmNlKCk7Cisg ICAgICAgIGFsaWdubWVudCA9IHBhcmVudEFsaWdubWVudCA9IE5vbmU7CisgICAgfQogfTsKIAog bG9uZyBsb25nIGRpc3RhbmNlSW5EaXJlY3Rpb24oTm9kZSosIE5vZGUqLCBGb2N1c0RpcmVjdGlv biwgRm9jdXNDYW5kaWRhdGUmKTsKLS0gCjEuNi4wLjQKCg== 50935 2010-03-17 12:41:36 -0700 2010-03-17 12:54:40 -0700 patch 0.2.1 - addressed kov's suggestions 0001-Spatial-Navigation-Add-isNull-and-document-convenie.patch text/plain 4420 tonikitoo RnJvbSBkMzhkMTFhY2U5MWJlZjJiZjY2MWMwY2RkNmIzN2YyYmE5MDkyMDI5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbnRvbmlvIEdvbWVzIDx0b25pa2l0b29Ad2Via2l0Lm9yZz4K RGF0ZTogTW9uLCAxNSBNYXIgMjAxMCAxNToxNTowNyAtMDQwMApTdWJqZWN0OiBbUEFUQ0hdIFNw YXRpYWwgTmF2aWdhdGlvbjogQWRkIGlzTnVsbCBhbmQgZG9jdW1lbnQgY29udmVuaWVuY2UgbWV0 aG9kcyB0byBGb2N1c0NhbmRpZGF0ZQogaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTM2MTY3CgpSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KUGF0Y2ggYnkgQW50b25p byBHb21lcyA8dG9uaWtpdG9vQHdlYmtpdC5vcmc+CgpJdCB0dXJucyBvdXQgdGhhdCBTcGF0aWFs IE5hdmlnYXRpb24gcmVsYXRlZCBjb2RlIChpbiBGb2N1c0NvbnRyb2xsZXIuY3BwIGZvcgppbnN0 YW5jZSkgY2FuIGJlIHNpbXBsaWZpZWQgYW5kIGxvb2sgYmV0dGVyIGlmIEZvY3VzQ2FuZGlkYXRl IGNsYXNzIG9mZmVyIHNvbWUKY29udmluaWVuY2UgbWV0aG9kLiBUaGlzIHBhdGNoIGludHJvZHVj ZXMgYSBjb3VwbGUgb2YgdGhlbSAoaXNOdWxsIGFuZCBhIERvY3VtZW50CmdldHRlcikuCgpBIGZv bGxvd3VwIHJlZmFjdG9yaW5nIHBhdGNoIHdpbGwgYmUgbWFraW5nIHVzZSBvZiB0aGVzZSBoZWxw ZXIgbWV0aG9kcy4KCiogcGFnZS9TcGF0aWFsTmF2aWdhdGlvbi5oOgooV2ViQ29yZTo6Rm9jdXND YW5kaWRhdGU6OkZvY3VzQ2FuZGlkYXRlKTogQWRkZWQgYSAiTm9kZSoiIHBhcmFtZXRlcgp0byBG b2N1c0NhbmRpZGF0ZSdzIGNvbnN0cnVjdG9yLgooV2ViQ29yZTo6Rm9jdXNDYW5kaWRhdGU6Omlz TnVsbCk6IEluIHRoZSBTcGF0aWFsIE5hdmlnYXRpb24gbG9naWMsIGEgTlVMTApGb2N1c0NhbmRp ZGF0ZSBvYmplY3QgaXMgb25lIHRoYXQgZG9lcyBub3QgaG9sZCBhIHZhbGlkIHJlZmVyZW5jZSB0 byBhICJOb2RlKiIuCihXZWJDb3JlOjpGb2N1c0NhbmRpZGF0ZTo6ZG9jdW1lbnQpOiBUaGlzIG1l dGhvZCByZXR1cm5zIGEgcG9pbnRlciBmb3IgdGhlIEZvY3VzQ2FuZGlkYXRlCm5vZGUncyBkb2N1 bWVudCwgaWYgfG5vZGV8IGlzIGEgdmFsaWQgcG9pbnRlci4KKFdlYkNvcmU6OkZvY3VzQ2FuZGlk YXRlOjppbml0KTogQSBwcml2YXRlIG1ldGhvZCB0aGF0IGFzc2lnbnMgYSBkZWZhdWx0IHZhbHVl IHRvIGFsbApjbGFzcyBtZW1iZXIgZGF0YSBjb21tb25seSBpbml0aWF0ZWQgYnkgYm90aCBjbGFz cyBjb25zdHJ1dG9ycy4KLS0tCiBXZWJDb3JlL0NoYW5nZUxvZyAgICAgICAgICAgICAgICB8ICAg MjUgKysrKysrKysrKysrKysrKysrKysrKysrKwogV2ViQ29yZS9wYWdlL1NwYXRpYWxOYXZpZ2F0 aW9uLmggfCAgIDIzICsrKysrKysrKysrKysrKysrKy0tLS0tCiAyIGZpbGVzIGNoYW5nZWQsIDQz IGluc2VydGlvbnMoKyksIDUgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9DaGFu Z2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAwYzRjZDBmLi4zZTY1MDk1IDEwMDY0NAot LS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsx LDI4IEBACisyMDEwLTAzLTE1ICBBbnRvbmlvIEdvbWVzICA8dG9uaWtpdG9vQHdlYmtpdC5vcmc+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisgICAgICAgIFBhdGNoIGJ5 IEFudG9uaW8gR29tZXMgPHRvbmlraXRvb0B3ZWJraXQub3JnPgorCisgICAgICAgIFNwYXRpYWwg TmF2aWdhdGlvbjogQWRkIGlzTnVsbCgpIGFuZCBkb2N1bWVudCgpIGNvbnZlbmllbmNlIG1ldGhv ZHMgdG8gRm9jdXNDYW5kaWRhdGUuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0zNjE2NworCisgICAgICAgIEl0IHR1cm5zIG91dCB0aGF0IFNwYXRpYWwg TmF2aWdhdGlvbiByZWxhdGVkIGNvZGUgKGluIEZvY3VzQ29udHJvbGxlci5jcHAgZm9yCisgICAg ICAgIGluc3RhbmNlKSBjYW4gYmUgc2ltcGxpZmllZCBhbmQgbG9vayBiZXR0ZXIgaWYgRm9jdXND YW5kaWRhdGUgY2xhc3Mgb2ZmZXIgc29tZQorICAgICAgICBjb252ZW5pZW5jZSBtZXRob2QuIFRo aXMgcGF0Y2ggaW50cm9kdWNlcyBhIGNvdXBsZSBvZiB0aGVtIChpc051bGwgYW5kIGEgRG9jdW1l bnQKKyAgICAgICAgZ2V0dGVyKS4gSXQgYWxzbyBhZGRzIGFub3RoZXIgY29uc3RydWN0b3IgdGhh dCByZWNlaXZlcyBhIE5vZGUgYXMgcGFyYW1ldGVyLgorCisgICAgICAgIEEgZm9sbG93dXAgcmVm YWN0b3JpbmcgcGF0Y2ggd2lsbCBiZSBtYWtpbmcgdXNlIG9mIHRoZXNlIGhlbHBlciBtZXRob2Rz LgorCisgICAgICAgICogcGFnZS9TcGF0aWFsTmF2aWdhdGlvbi5oOgorICAgICAgICAoV2ViQ29y ZTo6Rm9jdXNDYW5kaWRhdGU6OkZvY3VzQ2FuZGlkYXRlKTogQWRkZWQgYSAiTm9kZSoiIHBhcmFt ZXRlcgorICAgICAgICB0byBGb2N1c0NhbmRpZGF0ZSdzIGNvbnN0cnVjdG9yLgorICAgICAgICAo V2ViQ29yZTo6Rm9jdXNDYW5kaWRhdGU6OmlzTnVsbCk6IEluIHRoZSBTcGF0aWFsIE5hdmlnYXRp b24gbG9naWMsIGEgTlVMTAorICAgICAgICBGb2N1c0NhbmRpZGF0ZSBvYmplY3QgaXMgb25lIHRo YXQgZG9lcyBub3QgaG9sZCBhIHZhbGlkIHJlZmVyZW5jZSB0byBhICJOb2RlKiIuCisgICAgICAg IChXZWJDb3JlOjpGb2N1c0NhbmRpZGF0ZTo6ZG9jdW1lbnQpOiBUaGlzIG1ldGhvZCByZXR1cm5z IGEgcG9pbnRlciBmb3IgdGhlIEZvY3VzQ2FuZGlkYXRlCisgICAgICAgIG5vZGUncyBkb2N1bWVu dCwgaWYgfG5vZGV8IGlzIGEgdmFsaWQgcG9pbnRlci4KKyAgICAgICAgKFdlYkNvcmU6OkZvY3Vz Q2FuZGlkYXRlOjppbml0KTogQSBwcml2YXRlIG1ldGhvZCB0aGF0IGFzc2lnbnMgYSBkZWZhdWx0 IHZhbHVlIHRvIGFsbAorICAgICAgICBjbGFzcyBtZW1iZXIgZGF0YSBjb21tb25seSBpbml0aWF0 ZWQgYnkgYm90aCBjbGFzcyBjb25zdHJ1dG9ycy4KKwogMjAxMC0wMy0xNyAgQW50b25pbyBHb21l cyAgPHRvbmlraXRvb0B3ZWJraXQub3JnPgogCiAgICAgICAgIE1hYyBCdWlsZGZpeDogVXNpbmcg QVNTRVJUX1VOVVNFRCBpbnN0ZWFkIG9mIEFTU0VSVC4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGFn ZS9TcGF0aWFsTmF2aWdhdGlvbi5oIGIvV2ViQ29yZS9wYWdlL1NwYXRpYWxOYXZpZ2F0aW9uLmgK aW5kZXggZDU0NTU0ZC4uOWUxOTkwOCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wYWdlL1NwYXRpYWxO YXZpZ2F0aW9uLmgKKysrIGIvV2ViQ29yZS9wYWdlL1NwYXRpYWxOYXZpZ2F0aW9uLmgKQEAgLTIy LDYgKzIyLDcgQEAKICNkZWZpbmUgU3BhdGlhbE5hdmlnYXRpb25faAogCiAjaW5jbHVkZSAiRm9j dXNEaXJlY3Rpb24uaCIKKyNpbmNsdWRlICJOb2RlLmgiCiAKICNpbmNsdWRlIDxsaW1pdHM+CiAK QEAgLTMwLDcgKzMxLDYgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogY2xhc3MgRWxlbWVudDsKIGNs YXNzIEZyYW1lOwogY2xhc3MgSW50UmVjdDsKLWNsYXNzIE5vZGU7CiBjbGFzcyBSZW5kZXJPYmpl Y3Q7CiAKIHVzaW5nIG5hbWVzcGFjZSBzdGQ7CkBAIC05MiwxNyArOTIsMzAgQEAgZW51bSBSZWN0 c0FsaWdubWVudCB7CiBzdHJ1Y3QgRm9jdXNDYW5kaWRhdGUgewogICAgIEZvY3VzQ2FuZGlkYXRl KCkKICAgICAgICAgOiBub2RlKDApCi0gICAgICAgICwgZGlzdGFuY2UobWF4RGlzdGFuY2UoKSkK LSAgICAgICAgLCBwYXJlbnREaXN0YW5jZShtYXhEaXN0YW5jZSgpKQotICAgICAgICAsIGFsaWdu bWVudChOb25lKQotICAgICAgICAsIHBhcmVudEFsaWdubWVudChOb25lKQogICAgIHsKKyAgICAg ICAgaW5pdCgpOwogICAgIH0KKworICAgIEZvY3VzQ2FuZGlkYXRlKE5vZGUqIG4pCisgICAgICAg IDogbm9kZShuKQorICAgIHsKKyAgICAgICAgaW5pdCgpOworICAgIH0KKworICAgIGlubGluZSBi b29sIGlzTnVsbCgpIHsgcmV0dXJuICFub2RlOyB9CisgICAgaW5saW5lIERvY3VtZW50KiBkb2N1 bWVudCgpIHsgcmV0dXJuIG5vZGUgPyBub2RlLT5kb2N1bWVudCgpIDogMDsgfQorCiAgICAgTm9k ZSogbm9kZTsKICAgICBsb25nIGxvbmcgZGlzdGFuY2U7CiAgICAgbG9uZyBsb25nIHBhcmVudERp c3RhbmNlOwogICAgIFJlY3RzQWxpZ25tZW50IGFsaWdubWVudDsKICAgICBSZWN0c0FsaWdubWVu dCBwYXJlbnRBbGlnbm1lbnQ7CisKK3ByaXZhdGU6CisgICAgaW5saW5lIHZvaWQgaW5pdCgpIHsK KyAgICAgICAgZGlzdGFuY2UgPSBwYXJlbnREaXN0YW5jZSA9IG1heERpc3RhbmNlKCk7CisgICAg ICAgIGFsaWdubWVudCA9IHBhcmVudEFsaWdubWVudCA9IE5vbmU7CisgICAgfQogfTsKIAogbG9u ZyBsb25nIGRpc3RhbmNlSW5EaXJlY3Rpb24oTm9kZSosIE5vZGUqLCBGb2N1c0RpcmVjdGlvbiwg Rm9jdXNDYW5kaWRhdGUmKTsKLS0gCjEuNi4wLjQKCg== 50940 2010-03-17 12:54:40 -0700 2010-04-11 20:02:08 -0700 (committed in r56159) patch 0.3 - addressed kov's suggestions 0001-Spatial-Navigation-Add-isNull-and-document-convenie.patch text/plain 3717 tonikitoo RnJvbSBiZGM2YWYzZDBjN2UyNzY2NTZkN2RkOTRiMDg2ZTg3OTc4N2QzNDU5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbnRvbmlvIEdvbWVzIDx0b25pa2l0b29Ad2Via2l0Lm9yZz4K RGF0ZTogTW9uLCAxNSBNYXIgMjAxMCAxNToxNTowNyAtMDQwMApTdWJqZWN0OiBbUEFUQ0hdIFNw YXRpYWwgTmF2aWdhdGlvbjogQWRkIGlzTnVsbCBhbmQgZG9jdW1lbnQgY29udmVuaWVuY2UgbWV0 aG9kcyB0byBGb2N1c0NhbmRpZGF0ZQogaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTM2MTY3CgpSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KUGF0Y2ggYnkgQW50b25p byBHb21lcyA8dG9uaWtpdG9vQHdlYmtpdC5vcmc+CgpJdCB0dXJucyBvdXQgdGhhdCBTcGF0aWFs IE5hdmlnYXRpb24gcmVsYXRlZCBjb2RlIChpbiBGb2N1c0NvbnRyb2xsZXIuY3BwIGZvcgppbnN0 YW5jZSkgY2FuIGJlIHNpbXBsaWZpZWQgYW5kIGxvb2sgYmV0dGVyIGlmIEZvY3VzQ2FuZGlkYXRl IGNsYXNzIG9mZmVyIHNvbWUKY29udmluaWVuY2UgbWV0aG9kLiBUaGlzIHBhdGNoIGludHJvZHVj ZXMgYSBjb3VwbGUgb2YgdGhlbSAoaXNOdWxsIGFuZCBhIERvY3VtZW50CmdldHRlcikuCgpBIGZv bGxvd3VwIHJlZmFjdG9yaW5nIHBhdGNoIHdpbGwgYmUgbWFraW5nIHVzZSBvZiB0aGVzZSBoZWxw ZXIgbWV0aG9kcy4KCiogcGFnZS9TcGF0aWFsTmF2aWdhdGlvbi5oOgooV2ViQ29yZTo6Rm9jdXND YW5kaWRhdGU6OkZvY3VzQ2FuZGlkYXRlKTogQWRkZWQgYSAiTm9kZSoiIHBhcmFtZXRlcgp0byBG b2N1c0NhbmRpZGF0ZSdzIGNvbnN0cnVjdG9yLgooV2ViQ29yZTo6Rm9jdXNDYW5kaWRhdGU6Omlz TnVsbCk6IEluIHRoZSBTcGF0aWFsIE5hdmlnYXRpb24gbG9naWMsIGEgTlVMTApGb2N1c0NhbmRp ZGF0ZSBvYmplY3QgaXMgb25lIHRoYXQgZG9lcyBub3QgaG9sZCBhIHZhbGlkIHJlZmVyZW5jZSB0 byBhICJOb2RlKiIuCihXZWJDb3JlOjpGb2N1c0NhbmRpZGF0ZTo6ZG9jdW1lbnQpOiBUaGlzIG1l dGhvZCByZXR1cm5zIGEgcG9pbnRlciBmb3IgdGhlIEZvY3VzQ2FuZGlkYXRlCm5vZGUncyBkb2N1 bWVudCwgaWYgfG5vZGV8IGlzIGEgdmFsaWQgcG9pbnRlci4KLS0tCiBXZWJDb3JlL0NoYW5nZUxv ZyAgICAgICAgICAgICAgICB8ICAgMjMgKysrKysrKysrKysrKysrKysrKysrKysKIFdlYkNvcmUv cGFnZS9TcGF0aWFsTmF2aWdhdGlvbi5oIHwgICAxNSArKysrKysrKysrKysrKy0KIDIgZmlsZXMg Y2hhbmdlZCwgMzcgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9X ZWJDb3JlL0NoYW5nZUxvZyBiL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDBjNGNkMGYuLmJmMzRk ODggMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1dlYkNvcmUvQ2hhbmdlTG9n CkBAIC0xLDMgKzEsMjYgQEAKKzIwMTAtMDMtMTUgIEFudG9uaW8gR29tZXMgIDx0b25pa2l0b29A d2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKyAgICAg ICAgUGF0Y2ggYnkgQW50b25pbyBHb21lcyA8dG9uaWtpdG9vQHdlYmtpdC5vcmc+CisKKyAgICAg ICAgU3BhdGlhbCBOYXZpZ2F0aW9uOiBBZGQgaXNOdWxsKCkgYW5kIGRvY3VtZW50KCkgY29udmVu aWVuY2UgbWV0aG9kcyB0byBGb2N1c0NhbmRpZGF0ZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM2MTY3CisKKyAgICAgICAgSXQgdHVybnMgb3V0IHRo YXQgU3BhdGlhbCBOYXZpZ2F0aW9uIHJlbGF0ZWQgY29kZSAoaW4gRm9jdXNDb250cm9sbGVyLmNw cCBmb3IKKyAgICAgICAgaW5zdGFuY2UpIGNhbiBiZSBzaW1wbGlmaWVkIGFuZCBsb29rIGJldHRl ciBpZiBGb2N1c0NhbmRpZGF0ZSBjbGFzcyBvZmZlciBzb21lCisgICAgICAgIGNvbnZlbmllbmNl IG1ldGhvZC4gVGhpcyBwYXRjaCBpbnRyb2R1Y2VzIGEgY291cGxlIG9mIHRoZW0gKGlzTnVsbCBh bmQgYSBEb2N1bWVudAorICAgICAgICBnZXR0ZXIpLiBJdCBhbHNvIGFkZHMgYW5vdGhlciBjb25z dHJ1Y3RvciB0aGF0IHJlY2VpdmVzIGEgTm9kZSBhcyBwYXJhbWV0ZXIuCisKKyAgICAgICAgQSBm b2xsb3d1cCByZWZhY3RvcmluZyBwYXRjaCB3aWxsIGJlIG1ha2luZyB1c2Ugb2YgdGhlc2UgaGVs cGVyIG1ldGhvZHMuCisKKyAgICAgICAgKiBwYWdlL1NwYXRpYWxOYXZpZ2F0aW9uLmg6CisgICAg ICAgIChXZWJDb3JlOjpGb2N1c0NhbmRpZGF0ZTo6Rm9jdXNDYW5kaWRhdGUpOiBBZGRlZCBhICJO b2RlKiIgcGFyYW1ldGVyCisgICAgICAgIHRvIEZvY3VzQ2FuZGlkYXRlJ3MgY29uc3RydWN0b3Iu CisgICAgICAgIChXZWJDb3JlOjpGb2N1c0NhbmRpZGF0ZTo6aXNOdWxsKTogSW4gdGhlIFNwYXRp YWwgTmF2aWdhdGlvbiBsb2dpYywgYSBOVUxMCisgICAgICAgIEZvY3VzQ2FuZGlkYXRlIG9iamVj dCBpcyBvbmUgdGhhdCBkb2VzIG5vdCBob2xkIGEgdmFsaWQgcmVmZXJlbmNlIHRvIGEgIk5vZGUq Ii4KKyAgICAgICAgKFdlYkNvcmU6OkZvY3VzQ2FuZGlkYXRlOjpkb2N1bWVudCk6IFRoaXMgbWV0 aG9kIHJldHVybnMgYSBwb2ludGVyIGZvciB0aGUgRm9jdXNDYW5kaWRhdGUKKyAgICAgICAgbm9k ZSdzIGRvY3VtZW50LCBpZiB8bm9kZXwgaXMgYSB2YWxpZCBwb2ludGVyLgorCiAyMDEwLTAzLTE3 ICBBbnRvbmlvIEdvbWVzICA8dG9uaWtpdG9vQHdlYmtpdC5vcmc+CiAKICAgICAgICAgTWFjIEJ1 aWxkZml4OiBVc2luZyBBU1NFUlRfVU5VU0VEIGluc3RlYWQgb2YgQVNTRVJULgpkaWZmIC0tZ2l0 IGEvV2ViQ29yZS9wYWdlL1NwYXRpYWxOYXZpZ2F0aW9uLmggYi9XZWJDb3JlL3BhZ2UvU3BhdGlh bE5hdmlnYXRpb24uaAppbmRleCBkNTQ1NTRkLi5hN2ZjOThlIDEwMDY0NAotLS0gYS9XZWJDb3Jl L3BhZ2UvU3BhdGlhbE5hdmlnYXRpb24uaAorKysgYi9XZWJDb3JlL3BhZ2UvU3BhdGlhbE5hdmln YXRpb24uaApAQCAtMjIsNiArMjIsNyBAQAogI2RlZmluZSBTcGF0aWFsTmF2aWdhdGlvbl9oCiAK ICNpbmNsdWRlICJGb2N1c0RpcmVjdGlvbi5oIgorI2luY2x1ZGUgIk5vZGUuaCIKIAogI2luY2x1 ZGUgPGxpbWl0cz4KIApAQCAtMzAsNyArMzEsNiBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiBjbGFz cyBFbGVtZW50OwogY2xhc3MgRnJhbWU7CiBjbGFzcyBJbnRSZWN0OwotY2xhc3MgTm9kZTsKIGNs YXNzIFJlbmRlck9iamVjdDsKIAogdXNpbmcgbmFtZXNwYWNlIHN0ZDsKQEAgLTk4LDYgKzk4LDE5 IEBAIHN0cnVjdCBGb2N1c0NhbmRpZGF0ZSB7CiAgICAgICAgICwgcGFyZW50QWxpZ25tZW50KE5v bmUpCiAgICAgewogICAgIH0KKworICAgIEZvY3VzQ2FuZGlkYXRlKE5vZGUqIG4pCisgICAgICAg IDogbm9kZShuKQorICAgICAgICAsIGRpc3RhbmNlKG1heERpc3RhbmNlKCkpCisgICAgICAgICwg cGFyZW50RGlzdGFuY2UobWF4RGlzdGFuY2UoKSkKKyAgICAgICAgLCBhbGlnbm1lbnQoTm9uZSkK KyAgICAgICAgLCBwYXJlbnRBbGlnbm1lbnQoTm9uZSkKKyAgICB7CisgICAgfQorCisgICAgYm9v bCBpc051bGwoKSB7IHJldHVybiAhbm9kZTsgfQorICAgIERvY3VtZW50KiBkb2N1bWVudCgpIHsg cmV0dXJuIG5vZGUgPyBub2RlLT5kb2N1bWVudCgpIDogMDsgfQorCiAgICAgTm9kZSogbm9kZTsK ICAgICBsb25nIGxvbmcgZGlzdGFuY2U7CiAgICAgbG9uZyBsb25nIHBhcmVudERpc3RhbmNlOwot LSAKMS42LjAuNAoK