36149 2010-03-15 19:06:14 -0700 webkit-patch upload includes "delete" characters in bug description 2010-03-23 13:52:03 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 eric webkit-unassigned abarth cjerdonek dbates oldest_to_newest 199955 0 eric 2010-03-15 19:06:14 -0700 webkit-patch upload includes "delete" characters in bug description I suspect it's a question of using readline instead of rawinput in our user.py module. https://bugs.webkit.org/show_bug.cgi?id=36147#c0 203170 1 51448 dbates 2010-03-23 13:32:46 -0700 Created attachment 51448 Patch From my understanding of <http://docs.python.org/library/functions.html#raw_input> and <http://docs.python.org/library/readline.html#module-readline> it should be sufficient to import the GNU readline module. I am not sure how to write a unit test for this patch since it seems we need to be able simulate an interactive terminal session. I am open to suggestions. 203181 2 51448 abarth 2010-03-23 13:45:48 -0700 Comment on attachment 51448 Patch Awesome! Yeah, user.py is hard to unit test because it exists to abstract out the bits that are hard to unit test. :) 203187 3 51448 dbates 2010-03-23 13:51:54 -0700 Comment on attachment 51448 Patch Clearing flags on attachment: 51448 Committed r56413: <http://trac.webkit.org/changeset/56413> 203188 4 dbates 2010-03-23 13:52:03 -0700 All reviewed patches have been landed. Closing bug. 51448 2010-03-23 13:32:46 -0700 2010-03-23 13:51:53 -0700 Patch Bug36149.patch text/plain 1144 dbates SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDU2NDExKQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTAtMDMtMjMgIERhbmllbCBCYXRlcyAgPGRi YXRlc0ByaW0uY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNjE0OQorCisg ICAgICAgIEltcG9ydCB0aGUgR05VIHJlYWRsaW5lIGludGVyZmFjZSB0byBtb2RpZnkgdGhlIGJl aGF2aW9yCisgICAgICAgIG9mIHJhd19pbnB1dCBzbyBhcyB0byBwcm92aWRlIGxpbmUgZWRpdGlu ZyBzdXBwb3J0LiBJbgorICAgICAgICBwYXJ0aWN1bGFyIHRoaXMgd2lsbCBwcmV2ZW50ICJkZWxl dGUiIGNoYXJhY3RlcnMgZnJvbQorICAgICAgICBhcHBlYXJpbmcgaW4gdGhlIHJldHVybmVkIHZh bHVlIGZvciBmdW5jdGlvbiByYXdfaW5wdXQuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5 L3VzZXIucHk6CisKIDIwMTAtMDMtMjMgIExhc3psbyBHb21ib3MgIDxsYXN6bG8uMS5nb21ib3NA bm9raWEuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEtlbm5ldGggUm9oZGUgQ2hyaXN0aWFu c2VuLgpJbmRleDogV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS91c2VyLnB5Cj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFdlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvdXNlci5weQkocmV2aXNpb24gNTY0 MTApCisrKyBXZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L3VzZXIucHkJKHdvcmtpbmcgY29w eSkKQEAgLTI3LDYgKzI3LDcgQEAKICMgT0YgVEhJUyBTT0ZUV0FSRSwgRVZFTiBJRiBBRFZJU0VE IE9GIFRIRSBQT1NTSUJJTElUWSBPRiBTVUNIIERBTUFHRS4KIAogaW1wb3J0IG9zCitpbXBvcnQg cmVhZGxpbmUKIGltcG9ydCBzaGxleAogaW1wb3J0IHN1YnByb2Nlc3MKIGltcG9ydCB3ZWJicm93 c2VyCg==