36146 2010-03-15 16:49:23 -0700 GTK: AX: implement press in DRT 2010-11-30 14:07:49 -0800 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 25678 1 cfleizach webkit-unassigned mario oldest_to_newest 199927 0 cfleizach 2010-03-15 16:49:23 -0700 DRT needs to be updated to correctly implement the press action so that accessibility/label-element-press.html can be uncommented in the skip list and run 314420 1 75027 mario 2010-11-29 08:22:36 -0800 Created attachment 75027 Patch proposal Attaching -really simple- patch proposal: just delegate on the AtkAction interface's do_action() method. 314421 2 mario 2010-11-29 08:25:36 -0800 Marked as dependant on bug 25678 as current patch actualy needs the (currently r+) patch there to be applied first to work fine. However, that patch can't be applied yet due to bug 50062, so we need to wait for that one to be fixed, and therefore 25678 as well, before actually integrating this one. 315304 3 mario 2010-11-30 14:07:49 -0800 Committed r72963: <http://trac.webkit.org/changeset/72963> 75027 2010-11-29 08:22:36 -0800 2010-11-29 15:21:48 -0800 Patch proposal 0001-2010-11-29-Mario-Sanchez-Prada-msanchez-igalia.com.patch text/plain 3651 mario RnJvbSA4MzI5ZjFlOTY5ZjI4MWJjYjVkYTUwODNhNTFiNmJjNDEyZTBhZGJhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJpbyBTYW5jaGV6IFByYWRhIDxtc2FuY2hlekBpZ2FsaWEu Y29tPgpEYXRlOiBNb24sIDI5IE5vdiAyMDEwIDE2OjQ2OjUzICswMTAwClN1YmplY3Q6IFtQQVRD SF0gMjAxMC0xMS0yOSAgTWFyaW8gU2FuY2hleiBQcmFkYSAgPG1zYW5jaGV6QGlnYWxpYS5jb20+ CgogICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgoKICAgICAgICBHVEs6IEFYOiBp bXBsZW1lbnQgcHJlc3MgaW4gRFJUCiAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTM2MTQ2CgogICAgICAgIEltcGxlbWVudCBBY2Nlc3NpYmlsaXR5VUlFbGVt ZW50OjpwcmVzcygpIGZvciBHVEsuCgogICAgICAgICogRHVtcFJlbmRlclRyZWUvZ3RrL0FjY2Vz c2liaWxpdHlVSUVsZW1lbnRHdGsuY3BwOgogICAgICAgIChBY2Nlc3NpYmlsaXR5VUlFbGVtZW50 OjpwcmVzcyk6IEltcGxlbWVudGVkLgoKMjAxMC0xMS0yOSAgTWFyaW8gU2FuY2hleiBQcmFkYSAg PG1zYW5jaGV6QGlnYWxpYS5jb20+CgogICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgoKICAgICAgICBHVEs6IEFYOiBpbXBsZW1lbnQgcHJlc3MgaW4gRFJUCiAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM2MTQ2CgogICAgICAgIFVuc2tpcHBl ZCB0ZXN0IGFjY2Vzc2liaWxpdHkvbGFiZWwtZWxlbWVudC1wcmVzcy5odG1sLgoKICAgICAgICAq IHBsYXRmb3JtL2d0ay9Ta2lwcGVkOiBVbnNraXAgcGFzc2luZyB0ZXN0LgotLS0KIExheW91dFRl c3RzL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgICAxMSArKysrKysr KysrKwogTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1NraXBwZWQgICAgICAgICAgICAgICAgICAg fCAgICAzIC0tLQogV2ViS2l0VG9vbHMvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgfCAgIDEyICsrKysrKysrKysrKwogLi4uL2d0ay9BY2Nlc3NpYmlsaXR5VUlFbGVtZW50 R3RrLmNwcCAgICAgICAgICAgICAgfCAgIDExICsrKysrKysrKystCiA0IGZpbGVzIGNoYW5nZWQs IDMzIGluc2VydGlvbnMoKyksIDQgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVz dHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDVjY2VhZDcuLjQyNzUx NzYgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9D aGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMC0xMS0yOSAgTWFyaW8gU2FuY2hleiBQcmFk YSAgPG1zYW5jaGV6QGlnYWxpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgR1RLOiBBWDogaW1wbGVtZW50IHByZXNzIGluIERSVAorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzYxNDYKKworICAgICAg ICBVbnNraXBwZWQgdGVzdCBhY2Nlc3NpYmlsaXR5L2xhYmVsLWVsZW1lbnQtcHJlc3MuaHRtbC4K KworICAgICAgICAqIHBsYXRmb3JtL2d0ay9Ta2lwcGVkOiBVbnNraXAgcGFzc2luZyB0ZXN0Lgor CiAyMDEwLTExLTI0ICBBbGV4YW5kZXIgUGF2bG92ICA8YXBhdmxvdkBjaHJvbWl1bS5vcmc+CiAK ICAgICAgICAgUmV2aWV3ZWQgYnkgUGF2ZWwgRmVsZG1hbi4KZGlmZiAtLWdpdCBhL0xheW91dFRl c3RzL3BsYXRmb3JtL2d0ay9Ta2lwcGVkIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1NraXBw ZWQKaW5kZXggMGZiNjFlMy4uMjFjY2QzMCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZv cm0vZ3RrL1NraXBwZWQKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1NraXBwZWQKQEAg LTEyMSw5ICsxMjEsNiBAQCBhY2Nlc3NpYmlsaXR5L3RhYmxlLXdpdGgtYXJpYS1yb2xlLmh0bWwK IGFjY2Vzc2liaWxpdHkvdGFibGUtd2l0aC1ydWxlcy5odG1sCiBhY2Nlc3NpYmlsaXR5L2FyaWEt bGlzdC1hbmQtbGlzdGl0ZW0uaHRtbAogCi0jIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0zNjE0NiAtIEdUSzogQVg6IGltcGxlbWVudCBwcmVzcyBpbiBEUlQgCi1hY2Nl c3NpYmlsaXR5L2xhYmVsLWVsZW1lbnQtcHJlc3MuaHRtbAotCiAjIFRlc3RzIGluIGNzczIuMS8g ZGlyZWN0b3J5CiAjICAgVGVzdHMgZ2VuZXJhdGluZyBuZXcgcmVzdWx0cwogY3NzMi4xL3QwOS1j NTUyNmMtZGlzcGxheS0wMC1lLmh0bWwKZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxv ZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxvZwppbmRleCAxNDEyZWUyLi4yYmE5ODc3IDEwMDY0NAot LS0gYS9XZWJLaXRUb29scy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTAtMTEtMjkgIE1hcmlvIFNhbmNoZXogUHJhZGEgIDxtc2FuY2hl ekBpZ2FsaWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIEdUSzogQVg6IGltcGxlbWVudCBwcmVzcyBpbiBEUlQKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM2MTQ2CisKKyAgICAgICAgSW1wbGVtZW50 IEFjY2Vzc2liaWxpdHlVSUVsZW1lbnQ6OnByZXNzKCkgZm9yIEdUSy4KKworICAgICAgICAqIER1 bXBSZW5kZXJUcmVlL2d0ay9BY2Nlc3NpYmlsaXR5VUlFbGVtZW50R3RrLmNwcDoKKyAgICAgICAg KEFjY2Vzc2liaWxpdHlVSUVsZW1lbnQ6OnByZXNzKTogSW1wbGVtZW50ZWQuCisKIDIwMTAtMTEt MjQgIEFuZHJhcyBCZWNzaSAgPGFiZWNzaUBpbmYudS1zemVnZWQuaHU+CiAKICAgICAgICAgVW5y ZXZpZXdlZC4KZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL2d0ay9BY2Nl c3NpYmlsaXR5VUlFbGVtZW50R3RrLmNwcCBiL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL2d0 ay9BY2Nlc3NpYmlsaXR5VUlFbGVtZW50R3RrLmNwcAppbmRleCA4NDkzZjFhLi5mOGZlNTM1IDEw MDY0NAotLS0gYS9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9ndGsvQWNjZXNzaWJpbGl0eVVJ RWxlbWVudEd0ay5jcHAKKysrIGIvV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvZ3RrL0FjY2Vz c2liaWxpdHlVSUVsZW1lbnRHdGsuY3BwCkBAIC01NjYsNyArNTY2LDE2IEBAIHZvaWQgQWNjZXNz aWJpbGl0eVVJRWxlbWVudDo6ZGVjcmVtZW50KCkKIAogdm9pZCBBY2Nlc3NpYmlsaXR5VUlFbGVt ZW50OjpwcmVzcygpCiB7Ci0gICAgLy8gRklYTUU6IGltcGxlbWVudAorICAgIGlmICghbV9lbGVt ZW50KQorICAgICAgICByZXR1cm47CisKKyAgICBBU1NFUlQoQVRLX0lTX09CSkVDVChtX2VsZW1l bnQpKTsKKworICAgIGlmICghQVRLX0lTX0FDVElPTihtX2VsZW1lbnQpKQorICAgICAgICByZXR1 cm47CisKKyAgICAvLyBPbmx5IG9uZSBhY3Rpb24gcGVyIG9iamVjdCBpcyBzdXBwb3J0ZWQgc28g ZmFyLgorICAgIGF0a19hY3Rpb25fZG9fYWN0aW9uKEFUS19BQ1RJT04obV9lbGVtZW50KSwgMCk7 CiB9CiAKIHZvaWQgQWNjZXNzaWJpbGl0eVVJRWxlbWVudDo6c2hvd01lbnUoKQotLSAKMS43LjMu MgoK