36144 2010-03-15 15:33:12 -0700 NULL pointer access in webkit_web_window_features_equal() 2010-03-18 23:46:54 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Major --- 0 philip.chimento webkit-unassigned commit-queue webkit.review.bot oldest_to_newest 199867 0 50747 philip.chimento 2010-03-15 15:33:12 -0700 Created attachment 50747 Patch against svn trunk If you try to set the 'window-features' GObject property to NULL, then webkit-gtk crashes. You may ask, why would I want to set that property to NULL? Well, if I use the Glade application to construct a user interface containing WebKitWebViews, then it happens. I have attached a patch. 199871 1 webkit.review.bot 2010-03-15 15:34:55 -0700 Attachment 50747 did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 Total errors found: 0 in 0 files If any of these errors are false positives, please file a bug against check-webkit-style. 199952 2 50747 eric 2010-03-15 19:03:33 -0700 Comment on attachment 50747 Patch against svn trunk All changes require ChangeLog entries and test cases. See http://webkit.org/coding/contributing.html 201557 3 51092 philip.chimento 2010-03-18 14:20:57 -0700 Created attachment 51092 Updated patch that conforms to guidelines Okayyyy, here's another patch. 201561 4 webkit.review.bot 2010-03-18 14:28:59 -0700 Attachment 51092 did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebKit/gtk/webkit/webkitwebview.cpp:3018: Missing space before ( in if( [whitespace/parens] [5] WebKit/gtk/webkit/webkitwebview.cpp:3018: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] WARNING: File exempt from style guide. Skipping: "WebKit/gtk/tests/testwebview.c" WebKit/gtk/webkit/webkitwebwindowfeatures.cpp:427: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Total errors found: 3 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 201567 5 51096 philip.chimento 2010-03-18 14:38:31 -0700 Created attachment 51096 Another patch Whatever 201570 6 webkit.review.bot 2010-03-18 14:41:08 -0700 Attachment 51096 did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WARNING: File exempt from style guide. Skipping: "WebKit/gtk/tests/testwebview.c" WebKit/gtk/webkit/webkitwebwindowfeatures.cpp:433: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] WebKit/gtk/webkit/webkitwebwindowfeatures.cpp:434: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] WebKit/gtk/webkit/webkitwebwindowfeatures.cpp:435: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] WebKit/gtk/webkit/webkitwebwindowfeatures.cpp:436: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] WebKit/gtk/webkit/webkitwebwindowfeatures.cpp:437: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] WebKit/gtk/webkit/webkitwebwindowfeatures.cpp:438: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] WebKit/gtk/webkit/webkitwebwindowfeatures.cpp:439: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] WebKit/gtk/webkit/webkitwebwindowfeatures.cpp:440: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] WebKit/gtk/webkit/webkitwebwindowfeatures.cpp:441: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] Total errors found: 9 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 201573 7 51098 philip.chimento 2010-03-18 14:47:18 -0700 Created attachment 51098 Another patch Now I'm correcting style transgressions that weren't even mine! 201690 8 51098 oliver 2010-03-18 21:29:02 -0700 Comment on attachment 51098 Another patch r=me 201732 9 51098 commit-queue 2010-03-18 23:46:49 -0700 Comment on attachment 51098 Another patch Clearing flags on attachment: 51098 Committed r56217: <http://trac.webkit.org/changeset/56217> 201733 10 commit-queue 2010-03-18 23:46:54 -0700 All reviewed patches have been landed. Closing bug. 50747 2010-03-15 15:33:12 -0700 2010-03-18 14:20:57 -0700 Patch against svn trunk webkitwebwindowfeatures.cpp.diff text/plain 538 philip.chimento LS0tIHdlYmtpdHdlYndpbmRvd2ZlYXR1cmVzLmNwcC5vcmlnCTIwMTAtMDMtMTUgMjM6MzA6NDMu MDAwMDAwMDAwICswMTAwCisrKyB3ZWJraXR3ZWJ3aW5kb3dmZWF0dXJlcy5jcHAJMjAxMC0wMy0x NSAyMzozMTo1NS4wMDAwMDAwMDAgKzAxMDAKQEAgLTQyMiw2ICs0MjIsMTEgQEAKICAqLwogZ2Jv b2xlYW4gd2Via2l0X3dlYl93aW5kb3dfZmVhdHVyZXNfZXF1YWwoV2ViS2l0V2ViV2luZG93RmVh dHVyZXMqIGZlYXR1cmVzMSwgV2ViS2l0V2ViV2luZG93RmVhdHVyZXMqIGZlYXR1cmVzMikKIHsK KyAgICBpZihmZWF0dXJlczEgPT0gZmVhdHVyZXMyKQorICAgICAgICByZXR1cm4gVFJVRTsKKyAg ICBpZihmZWF0dXJlczEgPT0gTlVMTCB8fCBmZWF0dXJlczIgPT0gTlVMTCkKKyAgICAgICAgcmV0 dXJuIEZBTFNFOworCiAgICAgV2ViS2l0V2ViV2luZG93RmVhdHVyZXNQcml2YXRlKiBwcml2MSA9 IGZlYXR1cmVzMS0+cHJpdjsKICAgICBXZWJLaXRXZWJXaW5kb3dGZWF0dXJlc1ByaXZhdGUqIHBy aXYyID0gZmVhdHVyZXMyLT5wcml2OwogCg== 51092 2010-03-18 14:20:57 -0700 2010-03-18 14:39:16 -0700 Updated patch that conforms to guidelines WindowFeaturesBug.txt text/plain 3758 philip.chimento SW5kZXg6IFdlYktpdC9ndGsvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9ndGsvQ2hh bmdlTG9nCShyZXZpc2lvbiA1NjE5MCkKKysrIFdlYktpdC9ndGsvQ2hhbmdlTG9nCSh3b3JraW5n IGNvcHkpCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTAtMDMtMTggIFBoaWxpcCBDaGltZW50byAgPHBo aWxpcC5jaGltZW50b0BnbWFpbC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgU2V0dGluZyB0aGUgR09iamVjdCBXZWJLaXRXZWJWaWV3IHByb3Bl cnR5ICd3aW5kb3ctZmVhdHVyZXMnIHRvIE5VTEwKKyAgICAgICAgY2F1c2VzIGEgY3Jhc2guIAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzYxNDQKKwor ICAgICAgICAqIHRlc3RzL3Rlc3R3ZWJ2aWV3LmM6IEFkZCB1bml0IHRlc3QgZm9yIHRoaXMgYnVn LgorICAgICAgICAqIHdlYmtpdC93ZWJraXR3ZWJ2aWV3LmNwcDogRG9uJ3QgYWxsb3cgdGhlICd3 aW5kb3ctZmVhdHVyZXMnIHByb3BlcnR5CisgICAgICAgIHRvIGJlIHNldCB0byBOVUxMLgorICAg ICAgICAqIHdlYmtpdC93ZWJraXR3ZWJ3aW5kb3dmZWF0dXJlcy5jcHA6IAorICAgICAgICAod2Vi a2l0X3dlYl93aW5kb3dfZmVhdHVyZXNfZXF1YWwpOiBEb24ndCBleGFtaW5lIHRoZSBtZW1iZXJz IG9mIGVpdGhlcgorICAgICAgICB3ZWJfd2luZG93X2ZlYXR1cmVzIGFyZ3VtZW50IGlmIGVpdGhl ciBpcyBOVUxMLCBqdXN0IHJldHVybiB0aGF0IHRoZXkKKyAgICAgICAgYXJlIG5vdCBlcXVhbC4g QWRkaXRpb25hbGx5LCBpZiB0aGV5IGFyZSB0aGUgc2FtZSBvYmplY3QsIHJldHVybiB0aGF0IAor ICAgICAgICB0aGV5IGFyZSBlcXVhbC4KKwogMjAxMC0wMy0xNiAgWGFuIExvcGV6ICA8eGxvcGV6 QGlnYWxpYS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgR3VzdGF2byBOb3JvbmhhLgpJbmRl eDogV2ViS2l0L2d0ay90ZXN0cy90ZXN0d2Vidmlldy5jCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9n dGsvdGVzdHMvdGVzdHdlYnZpZXcuYwkocmV2aXNpb24gNTYxODIpCisrKyBXZWJLaXQvZ3RrL3Rl c3RzL3Rlc3R3ZWJ2aWV3LmMJKHdvcmtpbmcgY29weSkKQEAgLTMxMiw2ICszMTIsMzAgQEAgc3Rh dGljIHZvaWQgdGVzdF93ZWJraXRfd2ViX3ZpZXdfZGVzdHJveQogICAgIGd0a193aWRnZXRfZGVz dHJveSh3aW5kb3cpOwogfQogCitzdGF0aWMgdm9pZCB0ZXN0X3dlYmtpdF93ZWJfdmlld193aW5k b3dfZmVhdHVyZXMoKQoreworICAgIEd0a1dpZGdldCogd2luZG93OworICAgIEd0a1dpZGdldCog d2ViX3ZpZXc7CisgICAgCisgICAgd2luZG93ID0gZ3RrX3dpbmRvd19uZXcoR1RLX1dJTkRPV19U T1BMRVZFTCk7CisgICAgd2ViX3ZpZXcgPSB3ZWJraXRfd2ViX3ZpZXdfbmV3KCk7CisgICAgCisg ICAgZ3RrX2NvbnRhaW5lcl9hZGQoR1RLX0NPTlRBSU5FUih3aW5kb3cpLCB3ZWJfdmlldyk7Cisg ICAgCisgICAgZ3RrX3dpZGdldF9zaG93X2FsbCh3aW5kb3cpOworICAgIAorICAgIGxvb3AgPSBn X21haW5fbG9vcF9uZXcoTlVMTCwgVFJVRSk7CisKKyAgICBnX3NpZ25hbF9jb25uZWN0KHdpbmRv dywgIm1hcC1ldmVudCIsCisgICAgICAgICAgICAgICAgICAgICBHX0NBTExCQUNLKG1hcF9ldmVu dF9jYiksIGxvb3ApOworICAgIGdfbWFpbl9sb29wX3J1bihsb29wKTsKKyAgICAKKyAgICAvKiBC dWcgIzM2MTQ0ICovCisgICAgZ19vYmplY3Rfc2V0KEdfT0JKRUNUKHdlYl92aWV3KSwgIndpbmRv dy1mZWF0dXJlcyIsIE5VTEwsIE5VTEwpOworICAgIAorICAgIGd0a193aWRnZXRfZGVzdHJveSh3 aW5kb3cpOworfSAgICAKKwogaW50IG1haW4oaW50IGFyZ2MsIGNoYXIqKiBhcmd2KQogewogICAg IFNvdXBTZXJ2ZXIqIHNlcnZlcjsKQEAgLTMzOSw2ICszNjMsNyBAQCBpbnQgbWFpbihpbnQgYXJn YywgY2hhcioqIGFyZ3YpCiAgICAgZ190ZXN0X2FkZF9mdW5jKCIvd2Via2l0L3dlYnZpZXcvYWRq dXN0bWVudHMiLCB0ZXN0X3dlYmtpdF93ZWJfdmlld19hZGp1c3RtZW50cyk7CiAgICAgZ190ZXN0 X2FkZF9mdW5jKCIvd2Via2l0L3dlYnZpZXcvZGVzdHJveSIsIHRlc3Rfd2Via2l0X3dlYl92aWV3 X2Rlc3Ryb3kpOwogICAgIGdfdGVzdF9hZGRfZnVuYygiL3dlYmtpdC93ZWJ2aWV3L2dyYWJfZm9j dXMiLCB0ZXN0X3dlYmtpdF93ZWJfdmlld19ncmFiX2ZvY3VzKTsKKyAgICBnX3Rlc3RfYWRkX2Z1 bmMoIi93ZWJraXQvd2Vidmlldy93aW5kb3ctZmVhdHVyZXMiLCB0ZXN0X3dlYmtpdF93ZWJfdmll d193aW5kb3dfZmVhdHVyZXMpOwogCiAgICAgcmV0dXJuIGdfdGVzdF9ydW4gKCk7CiB9CkluZGV4 OiBXZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJ2aWV3LmNwcAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJL aXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJ2aWV3LmNwcAkocmV2aXNpb24gNTYxODIpCisrKyBXZWJL aXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJ2aWV3LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzAxNCw2 ICszMDE0LDkgQEAgV2ViS2l0V2ViSW5zcGVjdG9yKiB3ZWJraXRfd2ViX3ZpZXdfZ2V0Xwogc3Rh dGljIHZvaWQgd2Via2l0X3dlYl92aWV3X3NldF93aW5kb3dfZmVhdHVyZXMoV2ViS2l0V2ViVmll dyogd2ViVmlldywgV2ViS2l0V2ViV2luZG93RmVhdHVyZXMqIHdlYldpbmRvd0ZlYXR1cmVzKQog ewogICAgIFdlYktpdFdlYlZpZXdQcml2YXRlKiBwcml2ID0gd2ViVmlldy0+cHJpdjsKKyAgICAK KyAgICBpZih3ZWJXaW5kb3dGZWF0dXJlcyA9PSBOVUxMKQorICAgICAgcmV0dXJuOwogCiAgICAg aWYod2Via2l0X3dlYl93aW5kb3dfZmVhdHVyZXNfZXF1YWwocHJpdi0+d2ViV2luZG93RmVhdHVy ZXMsIHdlYldpbmRvd0ZlYXR1cmVzKSkKICAgICAgIHJldHVybjsKSW5kZXg6IFdlYktpdC9ndGsv d2Via2l0L3dlYmtpdHdlYndpbmRvd2ZlYXR1cmVzLmNwcAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXQv Z3RrL3dlYmtpdC93ZWJraXR3ZWJ3aW5kb3dmZWF0dXJlcy5jcHAJKHJldmlzaW9uIDU2MTgyKQor KysgV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vid2luZG93ZmVhdHVyZXMuY3BwCSh3b3JraW5n IGNvcHkpCkBAIC00MjIsNiArNDIyLDExIEBAIFdlYktpdFdlYldpbmRvd0ZlYXR1cmVzKiB3ZWJr aXRfd2ViX3dpbmQKICAqLwogZ2Jvb2xlYW4gd2Via2l0X3dlYl93aW5kb3dfZmVhdHVyZXNfZXF1 YWwoV2ViS2l0V2ViV2luZG93RmVhdHVyZXMqIGZlYXR1cmVzMSwgV2ViS2l0V2ViV2luZG93RmVh dHVyZXMqIGZlYXR1cmVzMikKIHsKKyAgICBpZiAoZmVhdHVyZXMxID09IGZlYXR1cmVzMikKKyAg ICAgICAgcmV0dXJuIFRSVUU7CisgICAgaWYgKGZlYXR1cmVzMSA9PSBOVUxMIHx8IGZlYXR1cmVz MiA9PSBOVUxMKQorICAgICAgICByZXR1cm4gRkFMU0U7IAorICAgIAogICAgIFdlYktpdFdlYldp bmRvd0ZlYXR1cmVzUHJpdmF0ZSogcHJpdjEgPSBmZWF0dXJlczEtPnByaXY7CiAgICAgV2ViS2l0 V2ViV2luZG93RmVhdHVyZXNQcml2YXRlKiBwcml2MiA9IGZlYXR1cmVzMi0+cHJpdjsKIAo= 51096 2010-03-18 14:38:31 -0700 2010-03-18 14:47:18 -0700 Another patch WindowFeaturesBug.txt text/plain 4989 philip.chimento SW5kZXg6IFdlYktpdC9ndGsvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9ndGsvQ2hh bmdlTG9nCShyZXZpc2lvbiA1NjE5MCkKKysrIFdlYktpdC9ndGsvQ2hhbmdlTG9nCSh3b3JraW5n IGNvcHkpCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTAtMDMtMTggIFBoaWxpcCBDaGltZW50byAgPHBo aWxpcC5jaGltZW50b0BnbWFpbC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgU2V0dGluZyB0aGUgR09iamVjdCBXZWJLaXRXZWJWaWV3IHByb3Bl cnR5ICd3aW5kb3ctZmVhdHVyZXMnIHRvIE5VTEwKKyAgICAgICAgY2F1c2VzIGEgY3Jhc2guIAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzYxNDQKKwor ICAgICAgICAqIHRlc3RzL3Rlc3R3ZWJ2aWV3LmM6IEFkZCB1bml0IHRlc3QgZm9yIHRoaXMgYnVn LgorICAgICAgICAqIHdlYmtpdC93ZWJraXR3ZWJ2aWV3LmNwcDogRG9uJ3QgYWxsb3cgdGhlICd3 aW5kb3ctZmVhdHVyZXMnIHByb3BlcnR5CisgICAgICAgIHRvIGJlIHNldCB0byBOVUxMLgorICAg ICAgICAqIHdlYmtpdC93ZWJraXR3ZWJ3aW5kb3dmZWF0dXJlcy5jcHA6IAorICAgICAgICAod2Vi a2l0X3dlYl93aW5kb3dfZmVhdHVyZXNfZXF1YWwpOiBEb24ndCBleGFtaW5lIHRoZSBtZW1iZXJz IG9mIGVpdGhlcgorICAgICAgICB3ZWJfd2luZG93X2ZlYXR1cmVzIGFyZ3VtZW50IGlmIGVpdGhl ciBpcyBOVUxMLCBqdXN0IHJldHVybiB0aGF0IHRoZXkKKyAgICAgICAgYXJlIG5vdCBlcXVhbC4g QWRkaXRpb25hbGx5LCBpZiB0aGV5IGFyZSB0aGUgc2FtZSBvYmplY3QsIHJldHVybiB0aGF0IAor ICAgICAgICB0aGV5IGFyZSBlcXVhbC4KKwogMjAxMC0wMy0xNiAgWGFuIExvcGV6ICA8eGxvcGV6 QGlnYWxpYS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgR3VzdGF2byBOb3JvbmhhLgpJbmRl eDogV2ViS2l0L2d0ay90ZXN0cy90ZXN0d2Vidmlldy5jCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9n dGsvdGVzdHMvdGVzdHdlYnZpZXcuYwkocmV2aXNpb24gNTYxODIpCisrKyBXZWJLaXQvZ3RrL3Rl c3RzL3Rlc3R3ZWJ2aWV3LmMJKHdvcmtpbmcgY29weSkKQEAgLTMxMiw2ICszMTIsMzAgQEAgc3Rh dGljIHZvaWQgdGVzdF93ZWJraXRfd2ViX3ZpZXdfZGVzdHJveQogICAgIGd0a193aWRnZXRfZGVz dHJveSh3aW5kb3cpOwogfQogCitzdGF0aWMgdm9pZCB0ZXN0X3dlYmtpdF93ZWJfdmlld193aW5k b3dfZmVhdHVyZXMoKQoreworICAgIEd0a1dpZGdldCogd2luZG93OworICAgIEd0a1dpZGdldCog d2ViX3ZpZXc7CisgICAgCisgICAgd2luZG93ID0gZ3RrX3dpbmRvd19uZXcoR1RLX1dJTkRPV19U T1BMRVZFTCk7CisgICAgd2ViX3ZpZXcgPSB3ZWJraXRfd2ViX3ZpZXdfbmV3KCk7CisgICAgCisg ICAgZ3RrX2NvbnRhaW5lcl9hZGQoR1RLX0NPTlRBSU5FUih3aW5kb3cpLCB3ZWJfdmlldyk7Cisg ICAgCisgICAgZ3RrX3dpZGdldF9zaG93X2FsbCh3aW5kb3cpOworICAgIAorICAgIGxvb3AgPSBn X21haW5fbG9vcF9uZXcoTlVMTCwgVFJVRSk7CisKKyAgICBnX3NpZ25hbF9jb25uZWN0KHdpbmRv dywgIm1hcC1ldmVudCIsCisgICAgICAgICAgICAgICAgICAgICBHX0NBTExCQUNLKG1hcF9ldmVu dF9jYiksIGxvb3ApOworICAgIGdfbWFpbl9sb29wX3J1bihsb29wKTsKKyAgICAKKyAgICAvKiBC dWcgIzM2MTQ0ICovCisgICAgZ19vYmplY3Rfc2V0KEdfT0JKRUNUKHdlYl92aWV3KSwgIndpbmRv dy1mZWF0dXJlcyIsIE5VTEwsIE5VTEwpOworICAgIAorICAgIGd0a193aWRnZXRfZGVzdHJveSh3 aW5kb3cpOworfSAgICAKKwogaW50IG1haW4oaW50IGFyZ2MsIGNoYXIqKiBhcmd2KQogewogICAg IFNvdXBTZXJ2ZXIqIHNlcnZlcjsKQEAgLTMzOSw2ICszNjMsNyBAQCBpbnQgbWFpbihpbnQgYXJn YywgY2hhcioqIGFyZ3YpCiAgICAgZ190ZXN0X2FkZF9mdW5jKCIvd2Via2l0L3dlYnZpZXcvYWRq dXN0bWVudHMiLCB0ZXN0X3dlYmtpdF93ZWJfdmlld19hZGp1c3RtZW50cyk7CiAgICAgZ190ZXN0 X2FkZF9mdW5jKCIvd2Via2l0L3dlYnZpZXcvZGVzdHJveSIsIHRlc3Rfd2Via2l0X3dlYl92aWV3 X2Rlc3Ryb3kpOwogICAgIGdfdGVzdF9hZGRfZnVuYygiL3dlYmtpdC93ZWJ2aWV3L2dyYWJfZm9j dXMiLCB0ZXN0X3dlYmtpdF93ZWJfdmlld19ncmFiX2ZvY3VzKTsKKyAgICBnX3Rlc3RfYWRkX2Z1 bmMoIi93ZWJraXQvd2Vidmlldy93aW5kb3ctZmVhdHVyZXMiLCB0ZXN0X3dlYmtpdF93ZWJfdmll d193aW5kb3dfZmVhdHVyZXMpOwogCiAgICAgcmV0dXJuIGdfdGVzdF9ydW4gKCk7CiB9CkluZGV4 OiBXZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJ2aWV3LmNwcAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJL aXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJ2aWV3LmNwcAkocmV2aXNpb24gNTYxODIpCisrKyBXZWJL aXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJ2aWV3LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzAxNCw4 ICszMDE0LDExIEBAIFdlYktpdFdlYkluc3BlY3Rvciogd2Via2l0X3dlYl92aWV3X2dldF8KIHN0 YXRpYyB2b2lkIHdlYmtpdF93ZWJfdmlld19zZXRfd2luZG93X2ZlYXR1cmVzKFdlYktpdFdlYlZp ZXcqIHdlYlZpZXcsIFdlYktpdFdlYldpbmRvd0ZlYXR1cmVzKiB3ZWJXaW5kb3dGZWF0dXJlcykK IHsKICAgICBXZWJLaXRXZWJWaWV3UHJpdmF0ZSogcHJpdiA9IHdlYlZpZXctPnByaXY7CisgICAg CisgICAgaWYgKCF3ZWJXaW5kb3dGZWF0dXJlcykKKyAgICAgIHJldHVybjsKIAotICAgIGlmKHdl YmtpdF93ZWJfd2luZG93X2ZlYXR1cmVzX2VxdWFsKHByaXYtPndlYldpbmRvd0ZlYXR1cmVzLCB3 ZWJXaW5kb3dGZWF0dXJlcykpCisgICAgaWYgKHdlYmtpdF93ZWJfd2luZG93X2ZlYXR1cmVzX2Vx dWFsKHByaXYtPndlYldpbmRvd0ZlYXR1cmVzLCB3ZWJXaW5kb3dGZWF0dXJlcykpCiAgICAgICBy ZXR1cm47CiAKICAgICBnX29iamVjdF91bnJlZihwcml2LT53ZWJXaW5kb3dGZWF0dXJlcyk7Cklu ZGV4OiBXZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJ3aW5kb3dmZWF0dXJlcy5jcHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vid2luZG93ZmVhdHVyZXMuY3BwCShy ZXZpc2lvbiA1NjE4MikKKysrIFdlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYndpbmRvd2ZlYXR1 cmVzLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNDIyLDE5ICs0MjIsMjQgQEAgV2ViS2l0V2ViV2lu ZG93RmVhdHVyZXMqIHdlYmtpdF93ZWJfd2luZAogICovCiBnYm9vbGVhbiB3ZWJraXRfd2ViX3dp bmRvd19mZWF0dXJlc19lcXVhbChXZWJLaXRXZWJXaW5kb3dGZWF0dXJlcyogZmVhdHVyZXMxLCBX ZWJLaXRXZWJXaW5kb3dGZWF0dXJlcyogZmVhdHVyZXMyKQogeworICAgIGlmIChmZWF0dXJlczEg PT0gZmVhdHVyZXMyKQorICAgICAgICByZXR1cm4gVFJVRTsKKyAgICBpZiAoIWZlYXR1cmVzMSB8 fCAhZmVhdHVyZXMyKQorICAgICAgICByZXR1cm4gRkFMU0U7IAorICAgIAogICAgIFdlYktpdFdl YldpbmRvd0ZlYXR1cmVzUHJpdmF0ZSogcHJpdjEgPSBmZWF0dXJlczEtPnByaXY7CiAgICAgV2Vi S2l0V2ViV2luZG93RmVhdHVyZXNQcml2YXRlKiBwcml2MiA9IGZlYXR1cmVzMi0+cHJpdjsKIAot ICAgIGlmKChwcml2MS0+eCA9PSBwcml2Mi0+eCkgJiYKLSAgICAgICAocHJpdjEtPnkgPT0gcHJp djItPnkpICYmCi0gICAgICAgKHByaXYxLT53aWR0aCA9PSBwcml2Mi0+d2lkdGgpICYmCi0gICAg ICAgKHByaXYxLT5oZWlnaHQgPT0gcHJpdjItPmhlaWdodCkgJiYKLSAgICAgICAocHJpdjEtPnRv b2xiYXJfdmlzaWJsZSA9PSBwcml2Mi0+dG9vbGJhcl92aXNpYmxlKSAmJgotICAgICAgIChwcml2 MS0+c3RhdHVzYmFyX3Zpc2libGUgPT0gcHJpdjItPnN0YXR1c2Jhcl92aXNpYmxlKSAmJgotICAg ICAgIChwcml2MS0+c2Nyb2xsYmFyX3Zpc2libGUgPT0gcHJpdjItPnNjcm9sbGJhcl92aXNpYmxl KSAmJgotICAgICAgIChwcml2MS0+bWVudWJhcl92aXNpYmxlID09IHByaXYyLT5tZW51YmFyX3Zp c2libGUpICYmCi0gICAgICAgKHByaXYxLT5sb2NhdGlvbmJhcl92aXNpYmxlID09IHByaXYyLT5s b2NhdGlvbmJhcl92aXNpYmxlKSAmJgotICAgICAgIChwcml2MS0+ZnVsbHNjcmVlbiA9PSBwcml2 Mi0+ZnVsbHNjcmVlbikpCisgICAgaWYgKChwcml2MS0+eCA9PSBwcml2Mi0+eCkgJiYKKyAgICAg ICAgKHByaXYxLT55ID09IHByaXYyLT55KSAmJgorICAgICAgICAocHJpdjEtPndpZHRoID09IHBy aXYyLT53aWR0aCkgJiYKKyAgICAgICAgKHByaXYxLT5oZWlnaHQgPT0gcHJpdjItPmhlaWdodCkg JiYKKyAgICAgICAgKHByaXYxLT50b29sYmFyX3Zpc2libGUgPT0gcHJpdjItPnRvb2xiYXJfdmlz aWJsZSkgJiYKKyAgICAgICAgKHByaXYxLT5zdGF0dXNiYXJfdmlzaWJsZSA9PSBwcml2Mi0+c3Rh dHVzYmFyX3Zpc2libGUpICYmCisgICAgICAgIChwcml2MS0+c2Nyb2xsYmFyX3Zpc2libGUgPT0g cHJpdjItPnNjcm9sbGJhcl92aXNpYmxlKSAmJgorICAgICAgICAocHJpdjEtPm1lbnViYXJfdmlz aWJsZSA9PSBwcml2Mi0+bWVudWJhcl92aXNpYmxlKSAmJgorICAgICAgICAocHJpdjEtPmxvY2F0 aW9uYmFyX3Zpc2libGUgPT0gcHJpdjItPmxvY2F0aW9uYmFyX3Zpc2libGUpICYmCisgICAgICAg IChwcml2MS0+ZnVsbHNjcmVlbiA9PSBwcml2Mi0+ZnVsbHNjcmVlbikpCiAgICAgICAgIHJldHVy biBUUlVFOwogICAgIHJldHVybiBGQUxTRTsKIH0K 51098 2010-03-18 14:47:18 -0700 2010-03-18 23:46:49 -0700 Another patch WindowFeaturesBug.txt text/plain 4989 philip.chimento SW5kZXg6IFdlYktpdC9ndGsvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9ndGsvQ2hh bmdlTG9nCShyZXZpc2lvbiA1NjE5MCkKKysrIFdlYktpdC9ndGsvQ2hhbmdlTG9nCSh3b3JraW5n IGNvcHkpCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTAtMDMtMTggIFBoaWxpcCBDaGltZW50byAgPHBo aWxpcC5jaGltZW50b0BnbWFpbC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgU2V0dGluZyB0aGUgR09iamVjdCBXZWJLaXRXZWJWaWV3IHByb3Bl cnR5ICd3aW5kb3ctZmVhdHVyZXMnIHRvIE5VTEwKKyAgICAgICAgY2F1c2VzIGEgY3Jhc2guIAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzYxNDQKKwor ICAgICAgICAqIHRlc3RzL3Rlc3R3ZWJ2aWV3LmM6IEFkZCB1bml0IHRlc3QgZm9yIHRoaXMgYnVn LgorICAgICAgICAqIHdlYmtpdC93ZWJraXR3ZWJ2aWV3LmNwcDogRG9uJ3QgYWxsb3cgdGhlICd3 aW5kb3ctZmVhdHVyZXMnIHByb3BlcnR5CisgICAgICAgIHRvIGJlIHNldCB0byBOVUxMLgorICAg ICAgICAqIHdlYmtpdC93ZWJraXR3ZWJ3aW5kb3dmZWF0dXJlcy5jcHA6IAorICAgICAgICAod2Vi a2l0X3dlYl93aW5kb3dfZmVhdHVyZXNfZXF1YWwpOiBEb24ndCBleGFtaW5lIHRoZSBtZW1iZXJz IG9mIGVpdGhlcgorICAgICAgICB3ZWJfd2luZG93X2ZlYXR1cmVzIGFyZ3VtZW50IGlmIGVpdGhl ciBpcyBOVUxMLCBqdXN0IHJldHVybiB0aGF0IHRoZXkKKyAgICAgICAgYXJlIG5vdCBlcXVhbC4g QWRkaXRpb25hbGx5LCBpZiB0aGV5IGFyZSB0aGUgc2FtZSBvYmplY3QsIHJldHVybiB0aGF0IAor ICAgICAgICB0aGV5IGFyZSBlcXVhbC4KKwogMjAxMC0wMy0xNiAgWGFuIExvcGV6ICA8eGxvcGV6 QGlnYWxpYS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgR3VzdGF2byBOb3JvbmhhLgpJbmRl eDogV2ViS2l0L2d0ay90ZXN0cy90ZXN0d2Vidmlldy5jCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9n dGsvdGVzdHMvdGVzdHdlYnZpZXcuYwkocmV2aXNpb24gNTYxODIpCisrKyBXZWJLaXQvZ3RrL3Rl c3RzL3Rlc3R3ZWJ2aWV3LmMJKHdvcmtpbmcgY29weSkKQEAgLTMxMiw2ICszMTIsMzAgQEAgc3Rh dGljIHZvaWQgdGVzdF93ZWJraXRfd2ViX3ZpZXdfZGVzdHJveQogICAgIGd0a193aWRnZXRfZGVz dHJveSh3aW5kb3cpOwogfQogCitzdGF0aWMgdm9pZCB0ZXN0X3dlYmtpdF93ZWJfdmlld193aW5k b3dfZmVhdHVyZXMoKQoreworICAgIEd0a1dpZGdldCogd2luZG93OworICAgIEd0a1dpZGdldCog d2ViX3ZpZXc7CisgICAgCisgICAgd2luZG93ID0gZ3RrX3dpbmRvd19uZXcoR1RLX1dJTkRPV19U T1BMRVZFTCk7CisgICAgd2ViX3ZpZXcgPSB3ZWJraXRfd2ViX3ZpZXdfbmV3KCk7CisgICAgCisg ICAgZ3RrX2NvbnRhaW5lcl9hZGQoR1RLX0NPTlRBSU5FUih3aW5kb3cpLCB3ZWJfdmlldyk7Cisg ICAgCisgICAgZ3RrX3dpZGdldF9zaG93X2FsbCh3aW5kb3cpOworICAgIAorICAgIGxvb3AgPSBn X21haW5fbG9vcF9uZXcoTlVMTCwgVFJVRSk7CisKKyAgICBnX3NpZ25hbF9jb25uZWN0KHdpbmRv dywgIm1hcC1ldmVudCIsCisgICAgICAgICAgICAgICAgICAgICBHX0NBTExCQUNLKG1hcF9ldmVu dF9jYiksIGxvb3ApOworICAgIGdfbWFpbl9sb29wX3J1bihsb29wKTsKKyAgICAKKyAgICAvKiBC dWcgIzM2MTQ0ICovCisgICAgZ19vYmplY3Rfc2V0KEdfT0JKRUNUKHdlYl92aWV3KSwgIndpbmRv dy1mZWF0dXJlcyIsIE5VTEwsIE5VTEwpOworICAgIAorICAgIGd0a193aWRnZXRfZGVzdHJveSh3 aW5kb3cpOworfSAgICAKKwogaW50IG1haW4oaW50IGFyZ2MsIGNoYXIqKiBhcmd2KQogewogICAg IFNvdXBTZXJ2ZXIqIHNlcnZlcjsKQEAgLTMzOSw2ICszNjMsNyBAQCBpbnQgbWFpbihpbnQgYXJn YywgY2hhcioqIGFyZ3YpCiAgICAgZ190ZXN0X2FkZF9mdW5jKCIvd2Via2l0L3dlYnZpZXcvYWRq dXN0bWVudHMiLCB0ZXN0X3dlYmtpdF93ZWJfdmlld19hZGp1c3RtZW50cyk7CiAgICAgZ190ZXN0 X2FkZF9mdW5jKCIvd2Via2l0L3dlYnZpZXcvZGVzdHJveSIsIHRlc3Rfd2Via2l0X3dlYl92aWV3 X2Rlc3Ryb3kpOwogICAgIGdfdGVzdF9hZGRfZnVuYygiL3dlYmtpdC93ZWJ2aWV3L2dyYWJfZm9j dXMiLCB0ZXN0X3dlYmtpdF93ZWJfdmlld19ncmFiX2ZvY3VzKTsKKyAgICBnX3Rlc3RfYWRkX2Z1 bmMoIi93ZWJraXQvd2Vidmlldy93aW5kb3ctZmVhdHVyZXMiLCB0ZXN0X3dlYmtpdF93ZWJfdmll d193aW5kb3dfZmVhdHVyZXMpOwogCiAgICAgcmV0dXJuIGdfdGVzdF9ydW4gKCk7CiB9CkluZGV4 OiBXZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJ2aWV3LmNwcAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJL aXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJ2aWV3LmNwcAkocmV2aXNpb24gNTYxODIpCisrKyBXZWJL aXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJ2aWV3LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzAxNCw4 ICszMDE0LDExIEBAIFdlYktpdFdlYkluc3BlY3Rvciogd2Via2l0X3dlYl92aWV3X2dldF8KIHN0 YXRpYyB2b2lkIHdlYmtpdF93ZWJfdmlld19zZXRfd2luZG93X2ZlYXR1cmVzKFdlYktpdFdlYlZp ZXcqIHdlYlZpZXcsIFdlYktpdFdlYldpbmRvd0ZlYXR1cmVzKiB3ZWJXaW5kb3dGZWF0dXJlcykK IHsKICAgICBXZWJLaXRXZWJWaWV3UHJpdmF0ZSogcHJpdiA9IHdlYlZpZXctPnByaXY7CisgICAg CisgICAgaWYgKCF3ZWJXaW5kb3dGZWF0dXJlcykKKyAgICAgIHJldHVybjsKIAotICAgIGlmKHdl YmtpdF93ZWJfd2luZG93X2ZlYXR1cmVzX2VxdWFsKHByaXYtPndlYldpbmRvd0ZlYXR1cmVzLCB3 ZWJXaW5kb3dGZWF0dXJlcykpCisgICAgaWYgKHdlYmtpdF93ZWJfd2luZG93X2ZlYXR1cmVzX2Vx dWFsKHByaXYtPndlYldpbmRvd0ZlYXR1cmVzLCB3ZWJXaW5kb3dGZWF0dXJlcykpCiAgICAgICBy ZXR1cm47CiAKICAgICBnX29iamVjdF91bnJlZihwcml2LT53ZWJXaW5kb3dGZWF0dXJlcyk7Cklu ZGV4OiBXZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJ3aW5kb3dmZWF0dXJlcy5jcHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vid2luZG93ZmVhdHVyZXMuY3BwCShy ZXZpc2lvbiA1NjE4MikKKysrIFdlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYndpbmRvd2ZlYXR1 cmVzLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNDIyLDE5ICs0MjIsMjQgQEAgV2ViS2l0V2ViV2lu ZG93RmVhdHVyZXMqIHdlYmtpdF93ZWJfd2luZAogICovCiBnYm9vbGVhbiB3ZWJraXRfd2ViX3dp bmRvd19mZWF0dXJlc19lcXVhbChXZWJLaXRXZWJXaW5kb3dGZWF0dXJlcyogZmVhdHVyZXMxLCBX ZWJLaXRXZWJXaW5kb3dGZWF0dXJlcyogZmVhdHVyZXMyKQogeworICAgIGlmIChmZWF0dXJlczEg PT0gZmVhdHVyZXMyKQorICAgICAgICByZXR1cm4gVFJVRTsKKyAgICBpZiAoIWZlYXR1cmVzMSB8 fCAhZmVhdHVyZXMyKQorICAgICAgICByZXR1cm4gRkFMU0U7IAorICAgIAogICAgIFdlYktpdFdl YldpbmRvd0ZlYXR1cmVzUHJpdmF0ZSogcHJpdjEgPSBmZWF0dXJlczEtPnByaXY7CiAgICAgV2Vi S2l0V2ViV2luZG93RmVhdHVyZXNQcml2YXRlKiBwcml2MiA9IGZlYXR1cmVzMi0+cHJpdjsKIAot ICAgIGlmKChwcml2MS0+eCA9PSBwcml2Mi0+eCkgJiYKLSAgICAgICAocHJpdjEtPnkgPT0gcHJp djItPnkpICYmCi0gICAgICAgKHByaXYxLT53aWR0aCA9PSBwcml2Mi0+d2lkdGgpICYmCi0gICAg ICAgKHByaXYxLT5oZWlnaHQgPT0gcHJpdjItPmhlaWdodCkgJiYKLSAgICAgICAocHJpdjEtPnRv b2xiYXJfdmlzaWJsZSA9PSBwcml2Mi0+dG9vbGJhcl92aXNpYmxlKSAmJgotICAgICAgIChwcml2 MS0+c3RhdHVzYmFyX3Zpc2libGUgPT0gcHJpdjItPnN0YXR1c2Jhcl92aXNpYmxlKSAmJgotICAg ICAgIChwcml2MS0+c2Nyb2xsYmFyX3Zpc2libGUgPT0gcHJpdjItPnNjcm9sbGJhcl92aXNpYmxl KSAmJgotICAgICAgIChwcml2MS0+bWVudWJhcl92aXNpYmxlID09IHByaXYyLT5tZW51YmFyX3Zp c2libGUpICYmCi0gICAgICAgKHByaXYxLT5sb2NhdGlvbmJhcl92aXNpYmxlID09IHByaXYyLT5s b2NhdGlvbmJhcl92aXNpYmxlKSAmJgotICAgICAgIChwcml2MS0+ZnVsbHNjcmVlbiA9PSBwcml2 Mi0+ZnVsbHNjcmVlbikpCisgICAgaWYgKChwcml2MS0+eCA9PSBwcml2Mi0+eCkKKyAgICAgICAg JiYgKHByaXYxLT55ID09IHByaXYyLT55KQorICAgICAgICAmJiAocHJpdjEtPndpZHRoID09IHBy aXYyLT53aWR0aCkKKyAgICAgICAgJiYgKHByaXYxLT5oZWlnaHQgPT0gcHJpdjItPmhlaWdodCkK KyAgICAgICAgJiYgKHByaXYxLT50b29sYmFyX3Zpc2libGUgPT0gcHJpdjItPnRvb2xiYXJfdmlz aWJsZSkKKyAgICAgICAgJiYgKHByaXYxLT5zdGF0dXNiYXJfdmlzaWJsZSA9PSBwcml2Mi0+c3Rh dHVzYmFyX3Zpc2libGUpCisgICAgICAgICYmIChwcml2MS0+c2Nyb2xsYmFyX3Zpc2libGUgPT0g cHJpdjItPnNjcm9sbGJhcl92aXNpYmxlKQorICAgICAgICAmJiAocHJpdjEtPm1lbnViYXJfdmlz aWJsZSA9PSBwcml2Mi0+bWVudWJhcl92aXNpYmxlKQorICAgICAgICAmJiAocHJpdjEtPmxvY2F0 aW9uYmFyX3Zpc2libGUgPT0gcHJpdjItPmxvY2F0aW9uYmFyX3Zpc2libGUpCisgICAgICAgICYm IChwcml2MS0+ZnVsbHNjcmVlbiA9PSBwcml2Mi0+ZnVsbHNjcmVlbikpCiAgICAgICAgIHJldHVy biBUUlVFOwogICAgIHJldHVybiBGQUxTRTsKIH0K