36137 2010-03-15 14:12:07 -0700 [Qt] tst_qwebpage does not pass 2010-03-16 08:36:55 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED Qt P2 Normal --- 1 robert webkit-qt-unassigned jwieczorek oldest_to_newest 199822 0 robert 2010-03-15 14:12:07 -0700 Remove calls to setPage(0) - these were causing tst_qwebpage to segfault at acceptNavigationRequest() and errorPageExtension*(). 199826 1 50737 robert 2010-03-15 14:20:17 -0700 Created attachment 50737 Patch 199849 2 jwieczorek 2010-03-15 14:54:43 -0700 Fixing unstable tests is always a good thing but usually it is better to fix the reason of a failure, I think. Here is the interesting bit of the crash: Program received signal SIGSEGV, Segmentation fault. 0x00007ffff7022dc2 in QWebView::setPage (this=0x71f3a0, page=0x0) at WebKit/qt/Api/qwebview.cpp:401 401 d->page->d->page->settings()->setAcceleratedCompositingEnabled(false); (gdb) bt full #0 0x00007ffff7022dc2 in QWebView::setPage (this=0x71f3a0, page=0x0) at WebKit/qt/Api/qwebview.cpp:401 199856 3 50746 robert 2010-03-15 15:16:00 -0700 Created attachment 50746 Patch Actually fix the bug per Jakub's kind suggestion! 199950 4 50746 eric 2010-03-15 19:02:20 -0700 Comment on attachment 50746 Patch Why the indent change? 200205 5 robert 2010-03-16 08:36:26 -0700 Manually committed: http://trac.webkit.org/changeset/56060 200206 6 robert 2010-03-16 08:36:55 -0700 (In reply to comment #4) > (From update of attachment 50746 [details]) > Why the indent change? It's moved into an if block. 50737 2010-03-15 14:20:17 -0700 2010-03-15 15:16:00 -0700 Patch 0001-2010-03-15-Robert-Hogan-robert-webkit.org.patch text/plain 3254 robert RnJvbSAwNWNkZGQyYWM3NDYzMmU4OGJjOGRkZDVmOWJmZjgyNWMwZDJiYjE0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBSb2JlcnQgSG9nYW4gPHJvYmVydEB3ZWJraXQub3JnPgpEYXRl OiBNb24sIDE1IE1hciAyMDEwIDIxOjAwOjIxICswMDAwClN1YmplY3Q6IFtQQVRDSF0gMjAxMC0w My0xNSAgUm9iZXJ0IEhvZ2FuICA8cm9iZXJ0QHdlYmtpdC5vcmc+CgogICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgoKICAgICAgICBbUXRdIEdldCB0c3RfcXdlYnBhZ2UgcGFzc2lu ZyBhZ2Fpbi4KCiAgICAgICAgUmVtb3ZlIGNhbGxzIHRvIHNldFBhZ2UoMCkgLSB0aGVzZSB3ZXJl IGNhdXNpbmcgdHN0X3F3ZWJwYWdlIHRvCiAgICAgICAgc2VnZmF1bHQgYXQgYWNjZXB0TmF2aWdh dGlvblJlcXVlc3QoKSBhbmQgZXJyb3JQYWdlRXh0ZW5zaW9uKigpLgoKICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzYxMzcKCiAgICAgICAgKiB0ZXN0cy9x d2VicGFnZS90c3RfcXdlYnBhZ2UuY3BwOgogICAgICAgICh0c3RfUVdlYlBhZ2U6OmFjY2VwdE5h dmlnYXRpb25SZXF1ZXN0KToKICAgICAgICAodHN0X1FXZWJQYWdlOjplcnJvclBhZ2VFeHRlbnNp b24pOgogICAgICAgICh0c3RfUVdlYlBhZ2U6OmVycm9yUGFnZUV4dGVuc2lvbkluSUZyYW1lcyk6 CiAgICAgICAgKHRzdF9RV2ViUGFnZTo6ZXJyb3JQYWdlRXh0ZW5zaW9uSW5GcmFtZXNldCk6Ci0t LQogV2ViS2l0L3F0L0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAgICAgfCAgIDE3ICsrKysr KysrKysrKysrKysrCiBXZWJLaXQvcXQvdGVzdHMvcXdlYnBhZ2UvdHN0X3F3ZWJwYWdlLmNwcCB8 ICAgIDggLS0tLS0tLS0KIDIgZmlsZXMgY2hhbmdlZCwgMTcgaW5zZXJ0aW9ucygrKSwgOCBkZWxl dGlvbnMoLSkKCmRpZmYgLS1naXQgYS9XZWJLaXQvcXQvQ2hhbmdlTG9nIGIvV2ViS2l0L3F0L0No YW5nZUxvZwppbmRleCA5OGVkMzlhLi4wMDQ1ZTJmIDEwMDY0NAotLS0gYS9XZWJLaXQvcXQvQ2hh bmdlTG9nCisrKyBiL1dlYktpdC9xdC9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMCBAQAorMjAxMC0w My0xNSAgUm9iZXJ0IEhvZ2FuICA8cm9iZXJ0QHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0XSBHZXQgdHN0X3F3ZWJwYWdlIHBh c3NpbmcgYWdhaW4uCisKKyAgICAgICAgUmVtb3ZlIGNhbGxzIHRvIHNldFBhZ2UoMCkgLSB0aGVz ZSB3ZXJlIGNhdXNpbmcgdHN0X3F3ZWJwYWdlIHRvCisgICAgICAgIHNlZ2ZhdWx0IGF0IGFjY2Vw dE5hdmlnYXRpb25SZXF1ZXN0KCkgYW5kIGVycm9yUGFnZUV4dGVuc2lvbiooKS4KKworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzYxMzcKKworICAgICAg ICAqIHRlc3RzL3F3ZWJwYWdlL3RzdF9xd2VicGFnZS5jcHA6CisgICAgICAgICh0c3RfUVdlYlBh Z2U6OmFjY2VwdE5hdmlnYXRpb25SZXF1ZXN0KToKKyAgICAgICAgKHRzdF9RV2ViUGFnZTo6ZXJy b3JQYWdlRXh0ZW5zaW9uKToKKyAgICAgICAgKHRzdF9RV2ViUGFnZTo6ZXJyb3JQYWdlRXh0ZW5z aW9uSW5JRnJhbWVzKToKKyAgICAgICAgKHRzdF9RV2ViUGFnZTo6ZXJyb3JQYWdlRXh0ZW5zaW9u SW5GcmFtZXNldCk6CisKIDIwMTAtMDMtMTUgIExhc3psbyBHb21ib3MgIDxsYXN6bG8uMS5nb21i b3NAbm9raWEuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQuCmRpZmYgLS1naXQgYS9XZWJLaXQv cXQvdGVzdHMvcXdlYnBhZ2UvdHN0X3F3ZWJwYWdlLmNwcCBiL1dlYktpdC9xdC90ZXN0cy9xd2Vi cGFnZS90c3RfcXdlYnBhZ2UuY3BwCmluZGV4IGJhN2E4N2UuLjQ4OGNkMzggMTAwNjQ0Ci0tLSBh L1dlYktpdC9xdC90ZXN0cy9xd2VicGFnZS90c3RfcXdlYnBhZ2UuY3BwCisrKyBiL1dlYktpdC9x dC90ZXN0cy9xd2VicGFnZS90c3RfcXdlYnBhZ2UuY3BwCkBAIC0xODgsOCArMTg4LDYgQEAgdm9p ZCB0c3RfUVdlYlBhZ2U6OmFjY2VwdE5hdmlnYXRpb25SZXF1ZXN0KCkKIAogICAgIFFDT01QQVJF KG1fdmlldy0+cGFnZSgpLT5tYWluRnJhbWUoKS0+dG9QbGFpblRleHQoKSwgUVN0cmluZygiZm9v PyIpKTsKIAotICAgIC8vIFJlc3RvcmUgZGVmYXVsdCBwYWdlCi0gICAgbV92aWV3LT5zZXRQYWdl KDApOwogfQogCiBjbGFzcyBKU1Rlc3RQYWdlIDogcHVibGljIFFXZWJQYWdlCkBAIC0xNjM4LDgg KzE2MzYsNiBAQCB2b2lkIHRzdF9RV2ViUGFnZTo6ZXJyb3JQYWdlRXh0ZW5zaW9uKCkKICAgICBR VFJZX0NPTVBBUkUocGFnZS0+aGlzdG9yeSgpLT5jYW5Hb0JhY2soKSwgZmFsc2UpOwogICAgIFFU UllfQ09NUEFSRShwYWdlLT5oaXN0b3J5KCktPmNhbkdvRm9yd2FyZCgpLCB0cnVlKTsKICAgICBR VFJZX0NPTVBBUkUocGFnZS0+aGlzdG9yeSgpLT5jdXJyZW50SXRlbSgpLnVybCgpLCBRVXJsKCJk YXRhOnRleHQvaHRtbCxmb28iKSk7Ci0KLSAgICBtX3ZpZXctPnNldFBhZ2UoMCk7CiB9CiAKIHZv aWQgdHN0X1FXZWJQYWdlOjplcnJvclBhZ2VFeHRlbnNpb25JbklGcmFtZXMoKQpAQCAtMTY1NSw4 ICsxNjUxLDYgQEAgdm9pZCB0c3RfUVdlYlBhZ2U6OmVycm9yUGFnZUV4dGVuc2lvbkluSUZyYW1l cygpCiAgICAgUVRSWV9DT01QQVJFKHNweUxvYWRGaW5pc2hlZC5jb3VudCgpLCAxKTsKIAogICAg IFFDT01QQVJFKHBhZ2UtPm1haW5GcmFtZSgpLT5jaGlsZEZyYW1lcygpWzFdLT50b1BsYWluVGV4 dCgpLCBRU3RyaW5nKCJkYXRhOnRleHQvaHRtbCxlcnJvciIpKTsKLQotICAgIG1fdmlldy0+c2V0 UGFnZSgwKTsKIH0KIAogdm9pZCB0c3RfUVdlYlBhZ2U6OmVycm9yUGFnZUV4dGVuc2lvbkluRnJh bWVzZXQoKQpAQCAtMTY2OSw4ICsxNjYzLDYgQEAgdm9pZCB0c3RfUVdlYlBhZ2U6OmVycm9yUGFn ZUV4dGVuc2lvbkluRnJhbWVzZXQoKQogICAgIFFTaWduYWxTcHkgc3B5TG9hZEZpbmlzaGVkKG1f dmlldywgU0lHTkFMKGxvYWRGaW5pc2hlZChib29sKSkpOwogICAgIFFUUllfQ09NUEFSRShzcHlM b2FkRmluaXNoZWQuY291bnQoKSwgMSk7CiAgICAgUUNPTVBBUkUocGFnZS0+bWFpbkZyYW1lKCkt PmNoaWxkRnJhbWVzKClbMV0tPnRvUGxhaW5UZXh0KCksIFFTdHJpbmcoImRhdGE6dGV4dC9odG1s LGVycm9yIikpOwotCi0gICAgbV92aWV3LT5zZXRQYWdlKDApOwogfQogCiB2b2lkIHRzdF9RV2Vi UGFnZTo6Y3Jhc2hUZXN0c19MYXp5SW5pdGlhbGl6YXRpb25PZk1haW5GcmFtZSgpCi0tIAoxLjYu My4zCgo= 50746 2010-03-15 15:16:00 -0700 2010-03-16 03:07:58 -0700 Patch 0001-2010-03-15-Robert-Hogan-robert-webkit.org.patch text/plain 1867 robert RnJvbSBhODZiODQ5YzE4ZmMyMzUyMzIzZmZmM2MzZGJhNzQ2YmU1OTYxMmM2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBSb2JlcnQgSG9nYW4gPHJvYmVydEB3ZWJraXQub3JnPgpEYXRl OiBNb24sIDE1IE1hciAyMDEwIDIyOjExOjEzICswMDAwClN1YmplY3Q6IFtQQVRDSF0gMjAxMC0w My0xNSAgUm9iZXJ0IEhvZ2FuICA8cm9iZXJ0QHdlYmtpdC5vcmc+CgogICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgoKICAgICAgICBbUXRdIEZpeCBjcmFzaCBpbiBRV2ViVmlldzo7 c2V0UGFnZSgpCgogICAgICAgIHRzdF9xd2VicGFnZSB3YXMgY3Jhc2hpbmcgb24gc2V0UGFnZSgw KQoKICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzYxMzcK CiAgICAgICAgKiBBcGkvcXdlYnZpZXcuY3BwOgogICAgICAgIChRV2ViVmlldzo6c2V0UGFnZSk6 Ci0tLQogV2ViS2l0L3F0L0FwaS9xd2Vidmlldy5jcHAgfCAgICA2ICsrKy0tLQogV2ViS2l0L3F0 L0NoYW5nZUxvZyAgICAgICAgfCAgIDEzICsrKysrKysrKysrKysKIDIgZmlsZXMgY2hhbmdlZCwg MTYgaW5zZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9XZWJLaXQvcXQv QXBpL3F3ZWJ2aWV3LmNwcCBiL1dlYktpdC9xdC9BcGkvcXdlYnZpZXcuY3BwCmluZGV4IDc5YzE2 YzcuLjE1NTMyNDQgMTAwNjQ0Ci0tLSBhL1dlYktpdC9xdC9BcGkvcXdlYnZpZXcuY3BwCisrKyBi L1dlYktpdC9xdC9BcGkvcXdlYnZpZXcuY3BwCkBAIC0zOTUsMTEgKzM5NSwxMSBAQCB2b2lkIFFX ZWJWaWV3OjpzZXRQYWdlKFFXZWJQYWdlKiBwYWdlKQogICAgICAgICAgICAgICAgIHRoaXMsIFNM T1QodXBkYXRlTWljcm9Gb2N1cygpKSk7CiAgICAgICAgIGNvbm5lY3QoZC0+cGFnZSwgU0lHTkFM KGRlc3Ryb3llZCgpKSwKICAgICAgICAgICAgICAgICB0aGlzLCBTTE9UKF9xX3BhZ2VEZXN0cm95 ZWQoKSkpOwotICAgIH0KLSAgICBzZXRBdHRyaWJ1dGUoUXQ6OldBX09wYXF1ZVBhaW50RXZlbnQs IGQtPnBhZ2UpOwogI2lmIFVTRShBQ0NFTEVSQVRFRF9DT01QT1NJVElORykKLSAgICBkLT5wYWdl LT5kLT5wYWdlLT5zZXR0aW5ncygpLT5zZXRBY2NlbGVyYXRlZENvbXBvc2l0aW5nRW5hYmxlZChm YWxzZSk7CisgICAgICAgIGQtPnBhZ2UtPmQtPnBhZ2UtPnNldHRpbmdzKCktPnNldEFjY2VsZXJh dGVkQ29tcG9zaXRpbmdFbmFibGVkKGZhbHNlKTsKICNlbmRpZgorICAgIH0KKyAgICBzZXRBdHRy aWJ1dGUoUXQ6OldBX09wYXF1ZVBhaW50RXZlbnQsIGQtPnBhZ2UpOwogICAgIHVwZGF0ZSgpOwog fQogCmRpZmYgLS1naXQgYS9XZWJLaXQvcXQvQ2hhbmdlTG9nIGIvV2ViS2l0L3F0L0NoYW5nZUxv ZwppbmRleCA5OGVkMzlhLi5jZDJhY2U2IDEwMDY0NAotLS0gYS9XZWJLaXQvcXQvQ2hhbmdlTG9n CisrKyBiL1dlYktpdC9xdC9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMC0wMy0xNSAg Um9iZXJ0IEhvZ2FuICA8cm9iZXJ0QHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0XSBGaXggY3Jhc2ggaW4gUVdlYlZpZXc6O3Nl dFBhZ2UoKQorCisgICAgICAgIHRzdF9xd2VicGFnZSB3YXMgY3Jhc2hpbmcgb24gc2V0UGFnZSgw KQorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNjEz NworCisgICAgICAgICogQXBpL3F3ZWJ2aWV3LmNwcDoKKyAgICAgICAgKFFXZWJWaWV3OjpzZXRQ YWdlKToKKwogMjAxMC0wMy0xNSAgTGFzemxvIEdvbWJvcyAgPGxhc3psby4xLmdvbWJvc0Bub2tp YS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZC4KLS0gCjEuNi4zLjMKCg==