36132 2010-03-15 13:25:22 -0700 VO not able to perform a VO-spacebar on facebook links 2010-03-15 16:20:27 -0700 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 cfleizach cfleizach bdakin oldest_to_newest 199796 0 cfleizach 2010-03-15 13:25:22 -0700 There are links on facebook that clearly should except a AXPress, but seem to do nothing when using VO-spacebar. SOme links include: • "click here to comment" 199808 1 50732 cfleizach 2010-03-15 13:37:34 -0700 Created attachment 50732 patch 199810 2 cfleizach 2010-03-15 13:39:14 -0700 the w3 specs say that label element should pass its access key action to its corresponding control, but it doesn't say what happens when there is no corresponding control. it seems like it should handle it itself an alternative to do this is for accessibility code to stop using accessKeyAction for the "press" action, and instead use dispatchSimulatedClick the downside to that is that there is a bunhc of logic in subclasses using accessKeyAction on whether the element should take focus first or not 199854 3 cfleizach 2010-03-15 15:07:39 -0700 http://trac.webkit.org/changeset/56019 199857 4 cfleizach 2010-03-15 15:17:44 -0700 for some reason test is failing 199866 5 cfleizach 2010-03-15 15:32:55 -0700 forgot to commit webkit tools changelog 199891 6 cfleizach 2010-03-15 15:55:33 -0700 got mac layout tests working. now to see if i can implement the press action for gtk and windows 199919 7 cfleizach 2010-03-15 16:20:27 -0700 looked like the windows press action did not work. i will skip that test and i filed https://bugs.webkit.org/show_bug.cgi?id=36145 waiting to see what happens on GTK 50732 2010-03-15 13:37:34 -0700 2010-03-15 14:20:19 -0700 patch patch.txt text/plain 3904 cfleizach SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1NjAxMikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTggQEAKKzIwMTAtMDMtMTUgIENocmlzIEZsZWl6YWNoICA8Y2ZsZWl6YWNoQGFw cGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBWTyBub3QgYWJsZSB0byBwZXJmb3JtIGEgVk8tc3BhY2ViYXIgb24gZmFjZWJvb2sgbGlua3MK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM2MTMyCisK KyAgICAgICAgV2hlbiBhIGxhYmVsIGVsZW1lbnQgaXMgdXNlZCBhcyBhIGNsaWNrIGV2ZW50IGhh bmRsZXIsIGFuZCBpdCBkb2Vzbid0IGhhdmUgYW55CisgICAgICAgIGNvcnJlc3BvbmRpbmcgY29u dHJvbCwgaXQgc2hvdWxkIGhhbmRsZSB0aGUgYWN0aW9uIGl0c2VsZi4KKworICAgICAgICBUZXN0 OiBhY2Nlc3NpYmlsaXR5L2xhYmVsLWVsZW1lbnQtcHJlc3MuaHRtbAorCisgICAgICAgICogaHRt bC9IVE1MTGFiZWxFbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxMYWJlbEVsZW1l bnQ6OmFjY2Vzc0tleUFjdGlvbik6CisKIDIwMTAtMDMtMTUgIEFuZHkgRXN0ZXMgIDxhZXN0ZXNA YXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEpvaG4gU3VsbGl2YW4uCkluZGV4OiBM YXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiA1NjAxMikKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5 KQpAQCAtMSwzICsxLDEzIEBACisyMDEwLTAzLTE1ICBDaHJpcyBGbGVpemFjaCAgPGNmbGVpemFj aEBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgVk8gbm90IGFibGUgdG8gcGVyZm9ybSBhIFZPLXNwYWNlYmFyIG9uIGZhY2Vib29rIGxp bmtzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNjEz MgorCisgICAgICAgICogYWNjZXNzaWJpbGl0eS9sYWJlbC1lbGVtZW50LXByZXNzLWV4cGVjdGVk LnR4dDogQWRkZWQuCisgICAgICAgICogYWNjZXNzaWJpbGl0eS9sYWJlbC1lbGVtZW50LXByZXNz Lmh0bWw6IEFkZGVkLgorCiAyMDEwLTAzLTE1ICBBbmR5IEVzdGVzICA8YWVzdGVzQGFwcGxlLmNv bT4KIAogICAgICAgICBSZXZpZXdlZCBieSBKb2huIFN1bGxpdmFuLgpJbmRleDogV2ViQ29yZS9o dG1sL0hUTUxMYWJlbEVsZW1lbnQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvaHRtbC9IVE1M TGFiZWxFbGVtZW50LmNwcAkocmV2aXNpb24gNTYwMDQpCisrKyBXZWJDb3JlL2h0bWwvSFRNTExh YmVsRWxlbWVudC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTEzOSw2ICsxMzksOCBAQAogewogICAg IGlmIChIVE1MRWxlbWVudCogZWxlbWVudCA9IGNvcnJlc3BvbmRpbmdDb250cm9sKCkpCiAgICAg ICAgIGVsZW1lbnQtPmFjY2Vzc0tleUFjdGlvbihzZW5kVG9BbnlFbGVtZW50KTsKKyAgICBlbHNl CisgICAgICAgIEhUTUxFbGVtZW50OjphY2Nlc3NLZXlBY3Rpb24oc2VuZFRvQW55RWxlbWVudCk7 CiB9CiAKIFN0cmluZyBIVE1MTGFiZWxFbGVtZW50OjphY2Nlc3NLZXkoKSBjb25zdApJbmRleDog TGF5b3V0VGVzdHMvYWNjZXNzaWJpbGl0eS9sYWJlbC1lbGVtZW50LXByZXNzLWV4cGVjdGVkLnR4 dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9hY2Nlc3NpYmlsaXR5L2xhYmVsLWVsZW1lbnQt cHJlc3MtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvYWNjZXNzaWJp bGl0eS9sYWJlbC1lbGVtZW50LXByZXNzLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKQEAgLTAs MCArMSwxMCBAQAorbGFiZWwKK1RoaXMgdGVzdHMgdGhhdCBhIGxhYmVsIGVsZW1lbnQgd2l0aG91 dCBhIGNvcnJlc3BvbmRpbmcgY29udHJvbCB3aWxsIHBlcmZvcm0gYSBwcmVzcyBhY3Rpb24gb24g aXRzZWxmIGluc3RlYWQgb2Ygbm90aGluZy4KKworT24gc3VjY2VzcywgeW91IHdpbGwgc2VlIGEg c2VyaWVzIG9mICJQQVNTIiBtZXNzYWdlcywgZm9sbG93ZWQgYnkgIlRFU1QgQ09NUExFVEUiLgor CisKK1BBU1Mgc3VjY2Vzc2Z1bGx5UGFyc2VkIGlzIHRydWUKKworVEVTVCBDT01QTEVURQorCklu ZGV4OiBMYXlvdXRUZXN0cy9hY2Nlc3NpYmlsaXR5L2xhYmVsLWVsZW1lbnQtcHJlc3MuaHRtbAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9hY2Nlc3NpYmlsaXR5L2xhYmVsLWVsZW1lbnQtcHJl c3MuaHRtbAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2FjY2Vzc2liaWxpdHkvbGFiZWwt ZWxlbWVudC1wcmVzcy5odG1sCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDQyIEBACis8IURPQ1RZ UEUgSFRNTCBQVUJMSUMgIi0vL0lFVEYvL0RURCBIVE1MLy9FTiI+Cis8aHRtbD4KKzxoZWFkPgor PGxpbmsgcmVsPSJzdHlsZXNoZWV0IiBocmVmPSIuLi9mYXN0L2pzL3Jlc291cmNlcy9qcy10ZXN0 LXN0eWxlLmNzcyI+Cis8c2NyaXB0PgordmFyIHN1Y2Nlc3NmdWxseVBhcnNlZCA9IGZhbHNlOwor PC9zY3JpcHQ+Cis8c2NyaXB0IHNyYz0iLi4vZmFzdC9qcy9yZXNvdXJjZXMvanMtdGVzdC1wcmUu anMiPjwvc2NyaXB0PgorPC9oZWFkPgorCis8Ym9keSBpZD0iYm9keSI+CisKKzxsYWJlbCB0YWJp bmRleD0wIG9uY2xpY2s9InBlcmZvcm1FdmVudCgpOyIgaWQ9ImxhYmVsRWxlbWVudCI+bGFiZWw8 L2xhYmVsPgorCis8cCBpZD0iZGVzY3JpcHRpb24iPjwvcD4KKzxkaXYgaWQ9ImNvbnNvbGUiPjwv ZGl2PgorCis8c2NyaXB0PgorCisgICAgZGVzY3JpcHRpb24oIlRoaXMgdGVzdHMgdGhhdCBhIGxh YmVsIGVsZW1lbnQgd2l0aG91dCBhIGNvcnJlc3BvbmRpbmcgY29udHJvbCB3aWxsIHBlcmZvcm0g YSBwcmVzcyBhY3Rpb24gb24gaXRzZWxmIGluc3RlYWQgb2Ygbm90aGluZy4iKTsKKyAKKyAgICBm dW5jdGlvbiBwZXJmb3JtRXZlbnQoKSB7CisgICAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIubm90 aWZ5RG9uZSgpOworICAgIH0KKworICAgIGlmICh3aW5kb3cuYWNjZXNzaWJpbGl0eUNvbnRyb2xs ZXIpIHsKKyAKKyAgICAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIud2FpdFVudGlsRG9uZSgpOwor ICAgICAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgiYm9keSIpLmZvY3VzKCk7CisgICAgICAg IHZhciBib2R5ID0gYWNjZXNzaWJpbGl0eUNvbnRyb2xsZXIuZm9jdXNlZEVsZW1lbnQ7CisgICAg ICAgIHZhciBsYWJlbCA9IGJvZHkuY2hpbGRBdEluZGV4KDApLmNoaWxkQXRJbmRleCgwKTsKKyAg ICAKKyAgICAgICAgLy8gaWYgc3VjY2Vzc2Z1bCwgcGVyZm9ybUV2ZW50KCkgd2lsbCBiZSBjYWxs ZWQgYW5kIHdlJ2xsIHN1Y2Nlc3NmdWxseSBwYXJzZS4gICAgICAgIAorICAgICAgICBsYWJlbC5w cmVzcygpOworICAgIH0KKworICAgIHN1Y2Nlc3NmdWxseVBhcnNlZCA9IHRydWU7Cis8L3Njcmlw dD4KKworPHNjcmlwdCBzcmM9Ii4uL2Zhc3QvanMvcmVzb3VyY2VzL2pzLXRlc3QtcG9zdC5qcyI+ PC9zY3JpcHQ+Cis8L2JvZHk+Cis8L2h0bWw+Cg==