<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>36131</bug_id>
          
          <creation_ts>2010-03-15 13:13:16 -0700</creation_ts>
          <short_desc>[chromium] update includes for rect.h, point.h, and size.h</short_desc>
          <delta_ts>2010-03-15 19:00:26 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit API</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Darin Fisher (:fishd, Google)">fishd</reporter>
          <assigned_to name="Darin Fisher (:fishd, Google)">fishd</assigned_to>
          <cc>beng</cc>
    
    <cc>dglazkov</cc>
    
    <cc>eric</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>199786</commentid>
    <comment_count>0</comment_count>
    <who name="Darin Fisher (:fishd, Google)">fishd</who>
    <bug_when>2010-03-15 13:13:16 -0700</bug_when>
    <thetext>[chromium] update includes for rect.h, point.h, and size.h

These moved on the chromium side from base/gfx/ to gfx/.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>199787</commentid>
    <comment_count>1</comment_count>
      <attachid>50730</attachid>
    <who name="Darin Fisher (:fishd, Google)">fishd</who>
    <bug_when>2010-03-15 13:14:06 -0700</bug_when>
    <thetext>Created attachment 50730
v1 patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>199793</commentid>
    <comment_count>2</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2010-03-15 13:20:10 -0700</bug_when>
    <thetext>Attachment 50730 did not build on chromium:
Build output: http://webkit-commit-queue.appspot.com/results/850007</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>199818</commentid>
    <comment_count>3</comment_count>
      <attachid>50735</attachid>
    <who name="Darin Fisher (:fishd, Google)">fishd</who>
    <bug_when>2010-03-15 14:08:10 -0700</bug_when>
    <thetext>Created attachment 50735
v2 patch

And update the chromium repository pulled by our standalone webkit build.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>199821</commentid>
    <comment_count>4</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2010-03-15 14:11:19 -0700</bug_when>
    <thetext>Attachment 50735 did not build on chromium:
Build output: http://webkit-commit-queue.appspot.com/results/838013</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>199881</commentid>
    <comment_count>5</comment_count>
      <attachid>50735</attachid>
    <who name="David Levin">levin</who>
    <bug_when>2010-03-15 15:48:15 -0700</bug_when>
    <thetext>Comment on attachment 50735
v2 patch

r=me if the build issue for chromium is fixed :)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>199893</commentid>
    <comment_count>6</comment_count>
    <who name="Darin Fisher (:fishd, Google)">fishd</who>
    <bug_when>2010-03-15 15:57:20 -0700</bug_when>
    <thetext>Thanks David.  Yeah, that one is surprising.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>199924</commentid>
    <comment_count>7</comment_count>
    <who name="Darin Fisher (:fishd, Google)">fishd</who>
    <bug_when>2010-03-15 16:29:00 -0700</bug_when>
    <thetext>Landed as http://trac.webkit.org/changeset/56024

Eric says they&apos;ll just have to kick the EWS bot manually to pick up the DEPS change.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>199949</commentid>
    <comment_count>8</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2010-03-15 19:00:26 -0700</bug_when>
    <thetext>This appears to have broken two of the chromium builders at http://build.webkit.org/console</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>50730</attachid>
            <date>2010-03-15 13:14:06 -0700</date>
            <delta_ts>2010-03-15 14:08:10 -0700</delta_ts>
            <desc>v1 patch</desc>
            <filename>gfx_1.txt</filename>
            <type>text/plain</type>
            <size>1735</size>
            <attacher name="Darin Fisher (:fishd, Google)">fishd</attacher>
            
              <data encoding="base64">SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cNCj09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NCi0tLSBXZWJLaXQv
Y2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiA1NjAwOCkKKysrIFdlYktpdC9jaHJvbWl1bS9D
aGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNCBAQAorMjAxMC0wMy0xNSAgRGFy
aW4gRmlzaGVyICA8ZGFyaW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P
Qk9EWSAoT09QUyEpLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn
LmNnaT9pZD0zNjEzMQorICAgICAgICBVcGRhdGUgaW5jbHVkZSBwYXRocyBmb3IgY2hyb21pdW0g
UmVjdCwgUG9pbnQsIGFuZCBTaXplIHR5cGVzLgorCisgICAgICAgICogcHVibGljL1dlYlBvaW50
Lmg6CisgICAgICAgICogcHVibGljL1dlYlJlY3QuaDoKKyAgICAgICAgKiBwdWJsaWMvV2ViU2l6
ZS5oOgorCiAyMDEwLTAzLTE1ICBQYXRyaWsgUGVyc3NvbiAgPHBhdHJpay5qLnBlcnNzb25AZXJp
Y3Nzb24uY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgpJbmRleDogV2Vi
S2l0L2Nocm9taXVtL3B1YmxpYy9XZWJQb2ludC5oDQo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQotLS0gV2ViS2l0L2No
cm9taXVtL3B1YmxpYy9XZWJQb2ludC5oCShyZXZpc2lvbiA1NjAwOCkKKysrIFdlYktpdC9jaHJv
bWl1bS9wdWJsaWMvV2ViUG9pbnQuaAkod29ya2luZyBjb3B5KQpAQCAtMzYsNyArMzYsNyBAQAog
I2lmIFdFQktJVF9JTVBMRU1FTlRBVElPTgogI2luY2x1ZGUgIkludFBvaW50LmgiCiAjZWxzZQot
I2luY2x1ZGUgPGJhc2UvZ2Z4L3JlY3QuaD4KKyNpbmNsdWRlIDxnZngvcG9pbnQuaD4KICNlbmRp
ZgogCiBuYW1lc3BhY2UgV2ViS2l0IHsKSW5kZXg6IFdlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2Vi
UmVjdC5oDQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09DQotLS0gV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJSZWN0LmgJ
KHJldmlzaW9uIDU2MDA4KQorKysgV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJSZWN0LmgJKHdv
cmtpbmcgY29weSkKQEAgLTM2LDcgKzM2LDcgQEAKICNpZiBXRUJLSVRfSU1QTEVNRU5UQVRJT04K
ICNpbmNsdWRlICJJbnRSZWN0LmgiCiAjZWxzZQotI2luY2x1ZGUgPGJhc2UvZ2Z4L3JlY3QuaD4K
KyNpbmNsdWRlIDxnZngvcmVjdC5oPgogI2VuZGlmCiAKIG5hbWVzcGFjZSBXZWJLaXQgewpJbmRl
eDogV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJTaXplLmgNCj09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NCi0tLSBXZWJL
aXQvY2hyb21pdW0vcHVibGljL1dlYlNpemUuaAkocmV2aXNpb24gNTYwMDgpCisrKyBXZWJLaXQv
Y2hyb21pdW0vcHVibGljL1dlYlNpemUuaAkod29ya2luZyBjb3B5KQpAQCAtMzYsNyArMzYsNyBA
QAogI2lmIFdFQktJVF9JTVBMRU1FTlRBVElPTgogI2luY2x1ZGUgIkludFNpemUuaCIKICNlbHNl
Ci0jaW5jbHVkZSA8YmFzZS9nZngvcmVjdC5oPgorI2luY2x1ZGUgPGdmeC9zaXplLmg+CiAjZW5k
aWYKIAogbmFtZXNwYWNlIFdlYktpdCB7Cg==
</data>
<flag name="commit-queue"
          id="33897"
          type_id="3"
          status="-"
          setter="fishd"
    />
          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>50735</attachid>
            <date>2010-03-15 14:08:10 -0700</date>
            <delta_ts>2010-03-15 15:48:15 -0700</delta_ts>
            <desc>v2 patch</desc>
            <filename>gfx_2.txt</filename>
            <type>text/plain</type>
            <size>2304</size>
            <attacher name="Darin Fisher (:fishd, Google)">fishd</attacher>
            
              <data encoding="base64">SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cNCj09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NCi0tLSBXZWJLaXQv
Y2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiA1NjAxNCkKKysrIFdlYktpdC9jaHJvbWl1bS9D
aGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxOCBAQAorMjAxMC0wMy0xNSAgRGFy
aW4gRmlzaGVyICA8ZGFyaW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P
Qk9EWSAoT09QUyEpLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn
LmNnaT9pZD0zNjEzMQorICAgICAgICBVcGRhdGUgaW5jbHVkZSBwYXRocyBmb3IgY2hyb21pdW0g
UmVjdCwgUG9pbnQsIGFuZCBTaXplIHR5cGVzLgorCisgICAgICAgIFVwZGF0ZSBERVBTIHRvIHB1
bGwgbGF0ZXN0IGNocm9taXVtIGNvZGUgdGhhdCByZWZsZWN0cyB0aGUKKyAgICAgICAgbmV3IGxv
Y2F0aW9uIG9mIHRoZXNlIGhlYWRlcnMuCisKKyAgICAgICAgKiBERVBTOgorICAgICAgICAqIHB1
YmxpYy9XZWJQb2ludC5oOgorICAgICAgICAqIHB1YmxpYy9XZWJSZWN0Lmg6CisgICAgICAgICog
cHVibGljL1dlYlNpemUuaDoKKwogMjAxMC0wMy0xNSAgTWFyY3VzIEJ1bGFjaCAgPGJ1bGFjaEBj
aHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgSmVyZW15IE9ybG93LgpJbmRleDog
V2ViS2l0L2Nocm9taXVtL0RFUFMNCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NCi0tLSBXZWJLaXQvY2hyb21pdW0vREVQ
UwkocmV2aXNpb24gNTYwMTQpCisrKyBXZWJLaXQvY2hyb21pdW0vREVQUwkod29ya2luZyBjb3B5
KQpAQCAtMzUsNyArMzUsNyBAQCB2YXJzID0gewogICAnY2hyb21pdW1fZGVwc19zdm4nOiAnaHR0
cDovL3NyYy5jaHJvbWl1bS5vcmcvc3ZuL3RydW5rL2RlcHMvdGhpcmRfcGFydHknLAogCiAgICMg
RGVwZW5kZW5jaWVzJyByZXZpc2lvbnMgdG8gdXNlOgotICAnY2hyb21pdW1fcmV2JzogJzM4NTgw
JywKKyAgJ2Nocm9taXVtX3Jldic6ICc0MTYyMScsCiAgICdnb29nbGUtdXJsX3Jldic6ICcxMjUn
LAogICAnZ3Rlc3RfcmV2JzogJzM1OScsCiAgICdneXBfcmV2JzogJzc5MCcsCkluZGV4OiBXZWJL
aXQvY2hyb21pdW0vcHVibGljL1dlYlBvaW50LmgNCj09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NCi0tLSBXZWJLaXQvY2hy
b21pdW0vcHVibGljL1dlYlBvaW50LmgJKHJldmlzaW9uIDU2MDE0KQorKysgV2ViS2l0L2Nocm9t
aXVtL3B1YmxpYy9XZWJQb2ludC5oCSh3b3JraW5nIGNvcHkpCkBAIC0zNiw3ICszNiw3IEBACiAj
aWYgV0VCS0lUX0lNUExFTUVOVEFUSU9OCiAjaW5jbHVkZSAiSW50UG9pbnQuaCIKICNlbHNlCi0j
aW5jbHVkZSA8YmFzZS9nZngvcmVjdC5oPgorI2luY2x1ZGUgPGdmeC9wb2ludC5oPgogI2VuZGlm
CiAKIG5hbWVzcGFjZSBXZWJLaXQgewpJbmRleDogV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJS
ZWN0LmgNCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT0NCi0tLSBXZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYlJlY3QuaAko
cmV2aXNpb24gNTYwMTQpCisrKyBXZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYlJlY3QuaAkod29y
a2luZyBjb3B5KQpAQCAtMzYsNyArMzYsNyBAQAogI2lmIFdFQktJVF9JTVBMRU1FTlRBVElPTgog
I2luY2x1ZGUgIkludFJlY3QuaCIKICNlbHNlCi0jaW5jbHVkZSA8YmFzZS9nZngvcmVjdC5oPgor
I2luY2x1ZGUgPGdmeC9yZWN0Lmg+CiAjZW5kaWYKIAogbmFtZXNwYWNlIFdlYktpdCB7CkluZGV4
OiBXZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYlNpemUuaA0KPT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KLS0tIFdlYktp
dC9jaHJvbWl1bS9wdWJsaWMvV2ViU2l6ZS5oCShyZXZpc2lvbiA1NjAxNCkKKysrIFdlYktpdC9j
aHJvbWl1bS9wdWJsaWMvV2ViU2l6ZS5oCSh3b3JraW5nIGNvcHkpCkBAIC0zNiw3ICszNiw3IEBA
CiAjaWYgV0VCS0lUX0lNUExFTUVOVEFUSU9OCiAjaW5jbHVkZSAiSW50U2l6ZS5oIgogI2Vsc2UK
LSNpbmNsdWRlIDxiYXNlL2dmeC9yZWN0Lmg+CisjaW5jbHVkZSA8Z2Z4L3NpemUuaD4KICNlbmRp
ZgogCiBuYW1lc3BhY2UgV2ViS2l0IHsK
</data>
<flag name="review"
          id="33902"
          type_id="1"
          status="+"
          setter="levin"
    />
    <flag name="commit-queue"
          id="33903"
          type_id="3"
          status="-"
          setter="fishd"
    />
          </attachment>
      

    </bug>

</bugzilla>