36116 2010-03-15 08:06:59 -0700 [GStreamer] duration query optimizations 2010-03-15 13:19:31 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 pnormand webkit-unassigned gustavo oldest_to_newest 199647 0 pnormand 2010-03-15 08:06:59 -0700 If the duration of the media is unknown we always attempt to query it again. Instead, we should re-attempt the query only when we receive duration-changed messages. 199663 1 50709 pnormand 2010-03-15 08:22:24 -0700 Created attachment 50709 proposed patch 199730 2 50709 gustavo 2010-03-15 11:44:17 -0700 Comment on attachment 50709 proposed patch Looks sane to me. 199792 3 pnormand 2010-03-15 13:19:31 -0700 Landed in r56010 50709 2010-03-15 08:22:24 -0700 2010-03-15 11:44:17 -0700 proposed patch proposed-patch.patch text/plain 4041 pnormand RnJvbSBkMTVjZDY5ZWRjMTZjMGY3NmFjYjc4ZjNlNzcxYjZmMTljM2QzOTI4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBNb24sIDE1IE1hciAyMDEwIDE2OjIyOjAxICswMTAwClN1YmplY3Q6IFtQQVRDSF0g cHJvcG9zZWQgcGF0Y2gKCi0tLQogV2ViQ29yZS9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgfCAgIDE3ICsrKysrKysrKysrKysrCiAuLi4vZ3N0cmVhbWVyL01lZGlh UGxheWVyUHJpdmF0ZUdTdHJlYW1lci5jcHAgICAgICB8ICAgMjMgKysrKysrKysrKysrKysrKysr Ky0KIC4uLi9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyLmggICAgICAgIHwg ICAgMSArCiAzIGZpbGVzIGNoYW5nZWQsIDQwIGluc2VydGlvbnMoKyksIDEgZGVsZXRpb25zKC0p CgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRl eCA0YjcxOTEwLi4xZWZkMTY4IDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9X ZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEwLTAzLTE1ICBQaGlsaXBwZSBO b3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBbR1N0cmVhbWVyXSBkdXJhdGlvbiBxdWVyeSBvcHRpbWl6 YXRpb25zCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0z NjExNgorCisgICAgICAgIERvbid0IHJlYXR0ZW1wdCBkdXJhdGlvbiBxdWVyaWVzIHRoYXQgcHJl dmlvdXNseSBmYWlsZWQgYW5kIGNhY2hlCisgICAgICAgIG1lZGlhIGR1cmF0aW9uIG9ubHkgaWYg aXQncyBrbm93bi4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRp YVBsYXllclByaXZhdGVHU3RyZWFtZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6TWVkaWFQbGF5 ZXJQcml2YXRlOjpNZWRpYVBsYXllclByaXZhdGUpOgorICAgICAgICAoV2ViQ29yZTo6TWVkaWFQ bGF5ZXJQcml2YXRlOjpkdXJhdGlvbik6CisgICAgICAgIChXZWJDb3JlOjpNZWRpYVBsYXllclBy aXZhdGU6OnVwZGF0ZVN0YXRlcyk6CisgICAgICAgIChXZWJDb3JlOjpNZWRpYVBsYXllclByaXZh dGU6OmR1cmF0aW9uQ2hhbmdlZCk6CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVh bWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lci5oOgorCiAyMDEwLTAzLTExICBBbnRvbmlv IEdvbWVzICA8dG9uaWtpdG9vQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUnViYmVyLXN0YW1wZWQg YnkgSG9sZ2VyIEZyZXl0aGVyLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyLmNwcCBiL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lci5jcHAK aW5kZXggZDA3ZTQzYS4uNTNjMmI0NCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyLmNwcAorKysgYi9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFt ZXIuY3BwCkBAIC0zMTQsNiArMzE0LDcgQEAgTWVkaWFQbGF5ZXJQcml2YXRlOjpNZWRpYVBsYXll clByaXZhdGUoTWVkaWFQbGF5ZXIqIHBsYXllcikKICAgICAsIG1fZmlsbFRpbWVvdXRJZCgwKQog ICAgICwgbV9tYXhUaW1lTG9hZGVkKDApCiAgICAgLCBtX2J1ZmZlcmluZ1BlcmNlbnRhZ2UoMCkK KyAgICAsIG1fbWVkaWFEdXJhdGlvbktub3duKHRydWUpCiB7CiAgICAgaWYgKGRvR3N0SW5pdCgp KQogICAgICAgICBjcmVhdGVHU1RQbGF5QmluKCk7CkBAIC00MjQsNiArNDI1LDEwIEBAIGZsb2F0 IE1lZGlhUGxheWVyUHJpdmF0ZTo6ZHVyYXRpb24oKSBjb25zdAogICAgIGlmIChtX2Vycm9yT2Nj dXJlZCkKICAgICAgICAgcmV0dXJuIDAuMDsKIAorICAgIC8vIE1lZGlhIGR1cmF0aW9uIHF1ZXJ5 IGZhaWxlZCBhbHJlYWR5LCBkb24ndCBhdHRlbXB0IG5ldyB1c2VsZXNzIHF1ZXJpZXMuCisgICAg aWYgKCFtX21lZGlhRHVyYXRpb25Lbm93bikKKyAgICAgICAgcmV0dXJuIG51bWVyaWNfbGltaXRz PGZsb2F0Pjo6aW5maW5pdHkoKTsKKwogICAgIGlmIChtX21lZGlhRHVyYXRpb24pCiAgICAgICAg IHJldHVybiBtX21lZGlhRHVyYXRpb247CiAKQEAgLTg4NCw3ICs4ODksOCBAQCB2b2lkIE1lZGlh UGxheWVyUHJpdmF0ZTo6dXBkYXRlU3RhdGVzKCkKIAogICAgICAgICAgICAgaWYgKCFtX21lZGlh RHVyYXRpb24pIHsKICAgICAgICAgICAgICAgICBmbG9hdCBuZXdEdXJhdGlvbiA9IGR1cmF0aW9u KCk7Ci0gICAgICAgICAgICAgICAgaWYgKCFpc2luZihuZXdEdXJhdGlvbikpCisgICAgICAgICAg ICAgICAgbV9tZWRpYUR1cmF0aW9uS25vd24gPSAhaXNpbmYobmV3RHVyYXRpb24pOworICAgICAg ICAgICAgICAgIGlmIChtX21lZGlhRHVyYXRpb25Lbm93bikKICAgICAgICAgICAgICAgICAgICAg bV9tZWRpYUR1cmF0aW9uID0gbmV3RHVyYXRpb247CiAgICAgICAgICAgICB9CiAKQEAgLTExMjMs NyArMTEyOSwyMiBAQCB2b2lkIE1lZGlhUGxheWVyUHJpdmF0ZTo6ZHVyYXRpb25DaGFuZ2VkKCkK ICAgICBtX21lZGlhRHVyYXRpb24gPSAwOwogCiAgICAgLy8gQW5kIHJlLWNhY2hlIGl0IGlmIHBv c3NpYmxlLgorICAgIEdzdFN0YXRlIHN0YXRlOworICAgIGdzdF9lbGVtZW50X2dldF9zdGF0ZSht X3BsYXlCaW4sICZzdGF0ZSwgMCwgMCk7CiAgICAgZmxvYXQgbmV3RHVyYXRpb24gPSBkdXJhdGlv bigpOworCisgICAgaWYgKHN0YXRlIDw9IEdTVF9TVEFURV9SRUFEWSkgeworICAgICAgICAvLyBE b24ndCBzZXQgbV9tZWRpYUR1cmF0aW9uS25vd24geWV0IGlmIHRoZSBwaXBlbGluZSBpcyBub3QK KyAgICAgICAgLy8gcGF1c2VkLiBUaGlzIGFsbG93cyBkdXJhdGlvbigpIHF1ZXJ5IHRvIGZhaWwg YXQgbGVhc3Qgb25jZQorICAgICAgICAvLyBiZWZvcmUgcGxheWJhY2sgc3RhcnRzIGFuZCBkdXJh dGlvbiBiZWNvbWVzIGtub3duLgorICAgICAgICBpZiAoIWlzaW5mKG5ld0R1cmF0aW9uKSkKKyAg ICAgICAgICAgIG1fbWVkaWFEdXJhdGlvbiA9IG5ld0R1cmF0aW9uOworICAgIH0gZWxzZSB7Cisg ICAgICAgIG1fbWVkaWFEdXJhdGlvbktub3duID0gIWlzaW5mKG5ld0R1cmF0aW9uKTsKKyAgICAg ICAgaWYgKG1fbWVkaWFEdXJhdGlvbktub3duKQorICAgICAgICAgICAgbV9tZWRpYUR1cmF0aW9u ID0gbmV3RHVyYXRpb247CisgICAgfQorCiAgICAgaWYgKCFpc2luZihuZXdEdXJhdGlvbikpCiAg ICAgICAgIG1fbWVkaWFEdXJhdGlvbiA9IG5ld0R1cmF0aW9uOwogCmRpZmYgLS1naXQgYS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFt ZXIuaCBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJp dmF0ZUdTdHJlYW1lci5oCmluZGV4IDhmMzE2NmUuLjg5OWU1NzQgMTAwNjQ0Ci0tLSBhL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1l ci5oCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVy UHJpdmF0ZUdTdHJlYW1lci5oCkBAIC0xNjcsNiArMTY3LDcgQEAgY2xhc3MgTWVkaWFQbGF5ZXJQ cml2YXRlIDogcHVibGljIE1lZGlhUGxheWVyUHJpdmF0ZUludGVyZmFjZSB7CiAgICAgICAgICAg ICBndWludCBtX2ZpbGxUaW1lb3V0SWQ7CiAgICAgICAgICAgICBmbG9hdCBtX21heFRpbWVMb2Fk ZWQ7CiAgICAgICAgICAgICBpbnQgbV9idWZmZXJpbmdQZXJjZW50YWdlOworICAgICAgICAgICAg Ym9vbCBtX21lZGlhRHVyYXRpb25Lbm93bjsKICAgICB9OwogfQogCi0tIAoxLjYuMy4z