36108 2010-03-15 01:37:02 -0700 option-pageup/down should move cursor on chromium mac 2010-03-15 08:54:50 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 tony webkit-unassigned commit-queue ojan oldest_to_newest 199575 0 tony 2010-03-15 01:37:02 -0700 option-pageup/down should move cursor on chromium mac 199576 1 50691 tony 2010-03-15 01:38:52 -0700 Created attachment 50691 Patch 199595 2 50697 tony 2010-03-15 02:34:11 -0700 Created attachment 50697 Patch 199596 3 50697 tony 2010-03-15 02:34:57 -0700 Comment on attachment 50697 Patch Update to disable pageup/pagedown on mac from moving the cursor. This shouldn't be handled in the editing code and is handled by the scroll code that happens first. 199597 4 tony 2010-03-15 02:40:35 -0700 Ojan, want to do a non-reviewer review? 199660 5 50697 darin 2010-03-15 08:18:55 -0700 Comment on attachment 50697 Patch > +#if !OS(DARWIN) > { VKEY_PRIOR, 0, "MovePageUp" }, > { VKEY_NEXT, 0, "MovePageDown" }, > +#endif Long term this is not the right way to conditional user-interface differences between platforms. But I suppose Chromium does this consistently for Mac-specific user interface choices, and cleaning that up can wait for the changes Maciej proposed to clean up the platform conditionals to be deployed. And I care more about the way this is done in shared code than in Chromium-specific code. r=me 199676 6 50697 commit-queue 2010-03-15 08:54:45 -0700 Comment on attachment 50697 Patch Clearing flags on attachment: 50697 Committed r55998: <http://trac.webkit.org/changeset/55998> 199677 7 commit-queue 2010-03-15 08:54:50 -0700 All reviewed patches have been landed. Closing bug. 50691 2010-03-15 01:38:52 -0700 2010-03-15 02:34:06 -0700 Patch bug-36108-20100315173850.patch text/plain 2652 tony ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBlMGNmMjZiLi4wMjY4YzU3IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTAtMDMt MTUgIFRvbnkgQ2hhbmcgIDx0b255QGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBvcHRpb24tcGFnZXVwL2Rvd24gc2hvdWxkIG1v dmUgY3Vyc29yIG9uIGNocm9taXVtIG1hYworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MzYxMDgKKworICAgICAgICBSZW1vdmUgd2FpdFVudGlsRG9uZS9u b3RpZnlEb25lIGZyb20gdGhlIGxheW91dCB0ZXN0LCBpdCdzIG5vdCBuZWVkZWQKKyAgICAgICAg YW5kIGNhdXNlcyB0aW1lb3V0cyBvbiBmYWlsdXJlLgorCisgICAgICAgICogZWRpdGluZy9pbnB1 dC9vcHRpb24tcGFnZS11cC1kb3duLmh0bWw6CisKIDIwMTAtMDMtMTQgIFlhZWwgQWhhcm9uICA8 eWFlbC5haGFyb25Abm9raWEuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVy LgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZWRpdGluZy9pbnB1dC9vcHRpb24tcGFnZS11cC1k b3duLmh0bWwgYi9MYXlvdXRUZXN0cy9lZGl0aW5nL2lucHV0L29wdGlvbi1wYWdlLXVwLWRvd24u aHRtbAppbmRleCA2NTU2YTNhLi44NmU1NGVhIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9lZGl0 aW5nL2lucHV0L29wdGlvbi1wYWdlLXVwLWRvd24uaHRtbAorKysgYi9MYXlvdXRUZXN0cy9lZGl0 aW5nL2lucHV0L29wdGlvbi1wYWdlLXVwLWRvd24uaHRtbApAQCAtMSw4ICsxLDYgQEAKIDxzY3Jp cHQ+Ci1pZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKSB7CitpZiAod2luZG93LmxheW91 dFRlc3RDb250cm9sbGVyKQogICAgIGxheW91dFRlc3RDb250cm9sbGVyLmR1bXBBc1RleHQoKTsK LSAgICBsYXlvdXRUZXN0Q29udHJvbGxlci53YWl0VW50aWxEb25lKCk7Ci19CiAKIGZ1bmN0aW9u IHJ1blRlc3QoKQogewpAQCAtMzYsOSArMzQsNiBAQCBmdW5jdGlvbiBydW5UZXN0KCkKICAgICAg ICAgdGhyb3cgImN1cnNvciBzaG91bGQgYmUgYXQgbGluZSAxLCBub3QgIiArIGxpbmU7CiAKICAg ICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgicmVzdWx0cyIpLmlubmVyVGV4dCA9ICJQQVNTIjsK LQotICAgIGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpCi0gICAgICAgIHdpbmRvdy5s YXlvdXRUZXN0Q29udHJvbGxlci5ub3RpZnlEb25lKCk7CiB9CiA8L3NjcmlwdD4KIApkaWZmIC0t Z2l0IGEvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZyBiL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VM b2cKaW5kZXggZDkyOWNmMS4uMjc2YzZlNSAxMDA2NDQKLS0tIGEvV2ViS2l0L2Nocm9taXVtL0No YW5nZUxvZworKysgYi9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAK KzIwMTAtMDMtMTUgIFRvbnkgQ2hhbmcgIDx0b255QGNocm9taXVtLm9yZz4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBvcHRpb24tcGFnZXVwL2Rvd24g c2hvdWxkIG1vdmUgY3Vyc29yIG9uIGNocm9taXVtIG1hYworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzYxMDgKKworICAgICAgICAqIHNyYy9FZGl0b3JD bGllbnRJbXBsLmNwcDoKKyAgICAgICAgKFdlYktpdDo6KToKKwogMjAxMC0wMy0xMyAgRXJpYyBS b21hbiAgPGVyb21hbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQWRhbSBC YXJ0aC4KZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9zcmMvRWRpdG9yQ2xpZW50SW1wbC5j cHAgYi9XZWJLaXQvY2hyb21pdW0vc3JjL0VkaXRvckNsaWVudEltcGwuY3BwCmluZGV4IGRmZjFl ZGMuLmFmN2I4NGYgMTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJvbWl1bS9zcmMvRWRpdG9yQ2xpZW50 SW1wbC5jcHAKKysrIGIvV2ViS2l0L2Nocm9taXVtL3NyYy9FZGl0b3JDbGllbnRJbXBsLmNwcApA QCAtNDIyLDYgKzQyMiw4IEBAIHN0YXRpYyBjb25zdCBLZXlEb3duRW50cnkga2V5RG93bkVudHJp ZXNbXSA9IHsKICAgICB7IFZLRVlfTEVGVCwgICBDb21tYW5kS2V5LCAgICAgICAgICJNb3ZlVG9C ZWdpbm5pbmdPZkxpbmUiICAgICAgICAgICAgICAgIH0sCiAgICAgeyBWS0VZX0xFRlQsICAgQ29t bWFuZEtleSB8IFNoaWZ0S2V5LAogICAgICAgIk1vdmVUb0JlZ2lubmluZ09mTGluZUFuZE1vZGlm eVNlbGVjdGlvbiIgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfSwKKyAgICB7IFZLRVlf UFJJT1IsICBPcHRpb25LZXksICAgICAgICAgICJNb3ZlUGFnZVVwIiAgICAgICAgICAgICAgICAg ICAgICAgICAgIH0sCisgICAgeyBWS0VZX05FWFQsICAgT3B0aW9uS2V5LCAgICAgICAgICAiTW92 ZVBhZ2VEb3duIiAgICAgICAgICAgICAgICAgICAgICAgICB9LAogI2VuZGlmCiAjaWYgT1MoREFS V0lOKQogICAgIHsgVktFWV9VUCwgICAgIENvbW1hbmRLZXksICAgICAgICAgIk1vdmVUb0JlZ2lu bmluZ09mRG9jdW1lbnQiICAgICAgICAgICAgfSwK 50697 2010-03-15 02:34:11 -0700 2010-03-15 08:54:45 -0700 Patch bug-36108-20100315183409.patch text/plain 3349 tony ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBlMGNmMjZiLi4wMjY4YzU3IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTAtMDMt MTUgIFRvbnkgQ2hhbmcgIDx0b255QGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBvcHRpb24tcGFnZXVwL2Rvd24gc2hvdWxkIG1v dmUgY3Vyc29yIG9uIGNocm9taXVtIG1hYworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MzYxMDgKKworICAgICAgICBSZW1vdmUgd2FpdFVudGlsRG9uZS9u b3RpZnlEb25lIGZyb20gdGhlIGxheW91dCB0ZXN0LCBpdCdzIG5vdCBuZWVkZWQKKyAgICAgICAg YW5kIGNhdXNlcyB0aW1lb3V0cyBvbiBmYWlsdXJlLgorCisgICAgICAgICogZWRpdGluZy9pbnB1 dC9vcHRpb24tcGFnZS11cC1kb3duLmh0bWw6CisKIDIwMTAtMDMtMTQgIFlhZWwgQWhhcm9uICA8 eWFlbC5haGFyb25Abm9raWEuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVy LgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZWRpdGluZy9pbnB1dC9vcHRpb24tcGFnZS11cC1k b3duLmh0bWwgYi9MYXlvdXRUZXN0cy9lZGl0aW5nL2lucHV0L29wdGlvbi1wYWdlLXVwLWRvd24u aHRtbAppbmRleCA2NTU2YTNhLi44NmU1NGVhIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9lZGl0 aW5nL2lucHV0L29wdGlvbi1wYWdlLXVwLWRvd24uaHRtbAorKysgYi9MYXlvdXRUZXN0cy9lZGl0 aW5nL2lucHV0L29wdGlvbi1wYWdlLXVwLWRvd24uaHRtbApAQCAtMSw4ICsxLDYgQEAKIDxzY3Jp cHQ+Ci1pZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKSB7CitpZiAod2luZG93LmxheW91 dFRlc3RDb250cm9sbGVyKQogICAgIGxheW91dFRlc3RDb250cm9sbGVyLmR1bXBBc1RleHQoKTsK LSAgICBsYXlvdXRUZXN0Q29udHJvbGxlci53YWl0VW50aWxEb25lKCk7Ci19CiAKIGZ1bmN0aW9u IHJ1blRlc3QoKQogewpAQCAtMzYsOSArMzQsNiBAQCBmdW5jdGlvbiBydW5UZXN0KCkKICAgICAg ICAgdGhyb3cgImN1cnNvciBzaG91bGQgYmUgYXQgbGluZSAxLCBub3QgIiArIGxpbmU7CiAKICAg ICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgicmVzdWx0cyIpLmlubmVyVGV4dCA9ICJQQVNTIjsK LQotICAgIGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpCi0gICAgICAgIHdpbmRvdy5s YXlvdXRUZXN0Q29udHJvbGxlci5ub3RpZnlEb25lKCk7CiB9CiA8L3NjcmlwdD4KIApkaWZmIC0t Z2l0IGEvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZyBiL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VM b2cKaW5kZXggZDkyOWNmMS4uMjc2YzZlNSAxMDA2NDQKLS0tIGEvV2ViS2l0L2Nocm9taXVtL0No YW5nZUxvZworKysgYi9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAK KzIwMTAtMDMtMTUgIFRvbnkgQ2hhbmcgIDx0b255QGNocm9taXVtLm9yZz4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBvcHRpb24tcGFnZXVwL2Rvd24g c2hvdWxkIG1vdmUgY3Vyc29yIG9uIGNocm9taXVtIG1hYworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzYxMDgKKworICAgICAgICAqIHNyYy9FZGl0b3JD bGllbnRJbXBsLmNwcDoKKyAgICAgICAgKFdlYktpdDo6KToKKwogMjAxMC0wMy0xMyAgRXJpYyBS b21hbiAgPGVyb21hbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQWRhbSBC YXJ0aC4KZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9zcmMvRWRpdG9yQ2xpZW50SW1wbC5j cHAgYi9XZWJLaXQvY2hyb21pdW0vc3JjL0VkaXRvckNsaWVudEltcGwuY3BwCmluZGV4IGRmZjFl ZGMuLjRlY2RjZjcgMTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJvbWl1bS9zcmMvRWRpdG9yQ2xpZW50 SW1wbC5jcHAKKysrIGIvV2ViS2l0L2Nocm9taXVtL3NyYy9FZGl0b3JDbGllbnRJbXBsLmNwcApA QCAtNDEzLDggKzQxMywxMCBAQCBzdGF0aWMgY29uc3QgS2V5RG93bkVudHJ5IGtleURvd25FbnRy aWVzW10gPSB7CiAgICAgeyBWS0VZX0RPV04sICAgMCwgICAgICAgICAgICAgICAgICAiTW92ZURv d24iICAgICAgICAgICAgICAgICAgICAgICAgICAgICB9LAogICAgIHsgVktFWV9ET1dOLCAgIFNo aWZ0S2V5LCAgICAgICAgICAgIk1vdmVEb3duQW5kTW9kaWZ5U2VsZWN0aW9uIiAgICAgICAgICAg fSwKICAgICB7IFZLRVlfTkVYVCwgICBTaGlmdEtleSwgICAgICAgICAgICJNb3ZlUGFnZURvd25B bmRNb2RpZnlTZWxlY3Rpb24iICAgICAgIH0sCisjaWYgIU9TKERBUldJTikKICAgICB7IFZLRVlf UFJJT1IsICAwLCAgICAgICAgICAgICAgICAgICJNb3ZlUGFnZVVwIiAgICAgICAgICAgICAgICAg ICAgICAgICAgIH0sCiAgICAgeyBWS0VZX05FWFQsICAgMCwgICAgICAgICAgICAgICAgICAiTW92 ZVBhZ2VEb3duIiAgICAgICAgICAgICAgICAgICAgICAgICB9LAorI2VuZGlmCiAgICAgeyBWS0VZ X0hPTUUsICAgMCwgICAgICAgICAgICAgICAgICAiTW92ZVRvQmVnaW5uaW5nT2ZMaW5lIiAgICAg ICAgICAgICAgICB9LAogICAgIHsgVktFWV9IT01FLCAgIFNoaWZ0S2V5LAogICAgICAgICAiTW92 ZVRvQmVnaW5uaW5nT2ZMaW5lQW5kTW9kaWZ5U2VsZWN0aW9uIiAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgfSwKQEAgLTQyMiw2ICs0MjQsOCBAQCBzdGF0aWMgY29uc3QgS2V5RG93bkVudHJ5 IGtleURvd25FbnRyaWVzW10gPSB7CiAgICAgeyBWS0VZX0xFRlQsICAgQ29tbWFuZEtleSwgICAg ICAgICAiTW92ZVRvQmVnaW5uaW5nT2ZMaW5lIiAgICAgICAgICAgICAgICB9LAogICAgIHsgVktF WV9MRUZULCAgIENvbW1hbmRLZXkgfCBTaGlmdEtleSwKICAgICAgICJNb3ZlVG9CZWdpbm5pbmdP ZkxpbmVBbmRNb2RpZnlTZWxlY3Rpb24iICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIH0s CisgICAgeyBWS0VZX1BSSU9SLCAgT3B0aW9uS2V5LCAgICAgICAgICAiTW92ZVBhZ2VVcCIgICAg ICAgICAgICAgICAgICAgICAgICAgICB9LAorICAgIHsgVktFWV9ORVhULCAgIE9wdGlvbktleSwg ICAgICAgICAgIk1vdmVQYWdlRG93biIgICAgICAgICAgICAgICAgICAgICAgICAgfSwKICNlbmRp ZgogI2lmIE9TKERBUldJTikKICAgICB7IFZLRVlfVVAsICAgICBDb21tYW5kS2V5LCAgICAgICAg ICJNb3ZlVG9CZWdpbm5pbmdPZkRvY3VtZW50IiAgICAgICAgICAgIH0sCg==