36105 2010-03-14 21:56:36 -0700 Unevenly distributed space in justified text 2010-06-14 12:22:52 -0700 1 1 1 Unclassified WebKit Text 528+ (Nightly build) All All RESOLVED FIXED data:text/html,<div style="font-family: ahem; text-align: justify; width: 290px; border: solid blue; font-size: 10px;">l l l l l l l l l l l l <span style="visibility: hidden;">llllll InRadar P2 Normal --- 1 mitz webkit-unassigned abarth eric webkit.review.bot oldest_to_newest 199538 0 mitz 2010-03-14 21:56:36 -0700 When extra spacing needs to be added between words for text justification, WidthIterator (and the complex text implementations) distribute the extra space very unevenly: all word spaces but the last get the same number of pixels added to them, and the last space takes the remainder. See the URL for an example where all spaces are 16 pixels wide except the last one, which is only 10 pixels wide. This may even be a regression (but a very old one). 199539 1 mitz 2010-03-14 21:57:54 -0700 <rdar://problem/7752961> 199546 2 50684 mitz 2010-03-14 23:23:41 -0700 Created attachment 50684 Sketch of fix Need to do this in the complex text code paths. Can save one roundf() per space by caching the result. 237716 3 58622 mitz 2010-06-13 22:27:56 -0700 Created attachment 58622 Distribute justification padding more evenly 237829 4 58622 simon.fraser 2010-06-14 08:14:15 -0700 Comment on attachment 58622 Distribute justification padding more evenly r=me. I would, however, prefer at sentence independent from the file listing in the changelog that gives the gist of the change. 237883 5 mitz 2010-06-14 10:07:52 -0700 Fixed in <http://trac.webkit.org/projects/webkit/changeset/61128>. 237896 6 webkit.review.bot 2010-06-14 10:30:13 -0700 http://trac.webkit.org/changeset/61128 might have broken Qt Linux Release 237980 7 eric 2010-06-14 12:22:52 -0700 Yup. Looks like the test fails on Qt. 50684 2010-03-14 23:23:41 -0700 2010-06-13 22:27:56 -0700 Sketch of fix 36105_r0.diff text/plain 1244 mitz SW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvV2lkdGhJdGVyYXRvci5jcHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9XaWR0aEl0ZXJhdG9yLmNwcAkocmV2 aXNpb24gNTU5NzQpCisrKyBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL1dpZHRoSXRlcmF0b3Iu Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC01NCwxNSArNTQsMTUgQEAgV2lkdGhJdGVyYXRvcjo6V2lk dGhJdGVyYXRvcihjb25zdCBGb250KgogICAgIGlmICghbV9wYWRkaW5nKQogICAgICAgICBtX3Bh ZFBlclNwYWNlID0gMDsKICAgICBlbHNlIHsKLSAgICAgICAgZmxvYXQgbnVtU3BhY2VzID0gMDsK KyAgICAgICAgaW50IG51bVNwYWNlcyA9IDA7CiAgICAgICAgIGZvciAoaW50IGkgPSAwOyBpIDwg cnVuLmxlbmd0aCgpOyBpKyspCiAgICAgICAgICAgICBpZiAoRm9udDo6dHJlYXRBc1NwYWNlKG1f cnVuW2ldKSkKICAgICAgICAgICAgICAgICBudW1TcGFjZXMrKzsKIAotICAgICAgICBpZiAobnVt U3BhY2VzID09IDApCisgICAgICAgIGlmICghbnVtU3BhY2VzKQogICAgICAgICAgICAgbV9wYWRQ ZXJTcGFjZSA9IDA7CiAgICAgICAgIGVsc2UKLSAgICAgICAgICAgIG1fcGFkUGVyU3BhY2UgPSBj ZWlsZihtX3J1bi5wYWRkaW5nKCkgLyBudW1TcGFjZXMpOworICAgICAgICAgICAgbV9wYWRQZXJT cGFjZSA9IG1fcGFkZGluZyAvIG51bVNwYWNlczsKICAgICB9CiB9CiAKQEAgLTE2Myw4ICsxNjMs OSBAQCB2b2lkIFdpZHRoSXRlcmF0b3I6OmFkdmFuY2UoaW50IG9mZnNldCwgCiAgICAgICAgICAg ICAgICAgICAgICAgICB3aWR0aCArPSBtX3BhZGRpbmc7CiAgICAgICAgICAgICAgICAgICAgICAg ICBtX3BhZGRpbmcgPSAwOwogICAgICAgICAgICAgICAgICAgICB9IGVsc2UgewotICAgICAgICAg ICAgICAgICAgICAgICAgd2lkdGggKz0gbV9wYWRQZXJTcGFjZTsKKyAgICAgICAgICAgICAgICAg ICAgICAgIGZsb2F0IHByZXZpb3VzUGFkZGluZyA9IG1fcGFkZGluZzsKICAgICAgICAgICAgICAg ICAgICAgICAgIG1fcGFkZGluZyAtPSBtX3BhZFBlclNwYWNlOworICAgICAgICAgICAgICAgICAg ICAgICAgd2lkdGggKz0gcm91bmRmKHByZXZpb3VzUGFkZGluZykgLSByb3VuZGYobV9wYWRkaW5n KTsKICAgICAgICAgICAgICAgICAgICAgfQogICAgICAgICAgICAgICAgIH0KIAo= 58622 2010-06-13 22:27:56 -0700 2010-06-14 08:14:15 -0700 Distribute justification padding more evenly 36105_r1.diff text/plain 0 mitz