<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>36096</bug_id>
          
          <creation_ts>2010-03-14 05:28:37 -0700</creation_ts>
          <short_desc>[Qt] Do not use QBuffer in ImageDecoderQt.cpp</short_desc>
          <delta_ts>2014-02-03 03:16:17 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Images</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>INVALID</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>Qt, QtTriaged</keywords>
          <priority>P3</priority>
          <bug_severity>Enhancement</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>50082</dependson>
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Holger Freyther">zecke</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>cmarcelo</cc>
    
    <cc>kent.hansen</cc>
    
    <cc>markus</cc>
    
    <cc>menard</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>199465</commentid>
    <comment_count>0</comment_count>
    <who name="Holger Freyther">zecke</who>
    <bug_when>2010-03-14 05:28:37 -0700</bug_when>
    <thetext>Recently WebCore::SharedBuffer was changed to work on segments. In our current ImageDecoderQt we are creating a QBuffer on top of the result of WebCore::SharedBuffer::data. The ::data method is now focred to create a linear buffer from the list of segments which will increase our memory usage.

We should build a QIODevice on top of the WebCore::SharedBuffer and we might be able to reuse the class we are using for Forms inside QNetworkReply.cpp... or at least this one is properly debugged and is known to work.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>210195</commentid>
    <comment_count>1</comment_count>
    <who name="Markus Goetz">markus</who>
    <bug_when>2010-04-08 08:04:02 -0700</bug_when>
    <thetext>Related read:
http://bugreports.qt.nokia.com/browse/QTBUG-9095</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>385637</commentid>
    <comment_count>2</comment_count>
    <who name="Markus Goetz">markus</who>
    <bug_when>2011-04-14 04:28:14 -0700</bug_when>
    <thetext>It makes most sense to make this depend on 50082.
That way (in most cases) we can avoid having a QBuffer but directly wrap the QSharedPointer&lt;char&gt; into a custom QIODevice and we have only 1 memcpy (the one from the OS read() network syscall).
For the cases that the zerocopy in 50082 does not work we still have to use the QBuffer. (or a solution similar to what Holger suggested).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>975116</commentid>
    <comment_count>3</comment_count>
    <who name="Jocelyn Turcotte">jturcotte</who>
    <bug_when>2014-02-03 03:16:17 -0800</bug_when>
    <thetext>=== Bulk closing of Qt bugs ===

If you believe that this bug report is still relevant for a non-Qt port of webkit.org, please re-open it and remove [Qt] from the summary.

If you believe that this is still an important QtWebKit bug, please fill a new report at https://bugreports.qt-project.org and add a link to this issue. See http://qt-project.org/wiki/ReportingBugsInQt for additional guidelines.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>