36082 2010-03-12 17:58:20 -0800 GIF animates much more slowly in Safari than Firefox 2010-04-04 12:36:48 -0700 1 1 1 Unclassified WebKit Images 528+ (Nightly build) PC OS X 10.5 RESOLVED DUPLICATE 26455 http://i135.photobucket.com/albums/q156/HITHAR/1438ch-1.gif InRadar P2 Normal --- 1 mrowe mrowe ap darin pkasting oldest_to_newest 199272 0 mrowe 2010-03-12 17:58:20 -0800 The animated GIF at <http://i135.photobucket.com/albums/q156/HITHAR/1438ch-1.gif> appears to play at half-speed in Safari when compared to Firefox. This animated GIF requests 40ms per frame (25fps). Firefox is clamping the frame delay on animated GIFs to 100ms if the requested delay is less than 10ms. WebKit is clamping to 100ms if the requested delay is less than 50ms We're playing this back at 10fps while Firefox plays it back at the expected 25fps. <rdar://problem/7689300> 199273 1 50647 mrowe 2010-03-12 18:01:56 -0800 Created attachment 50647 Patch v1 199280 2 ap 2010-03-12 18:57:56 -0800 Note that this is basically reverting what we did in bug 14413. It may still be appropriate to revisit the decisions made in 2007, although there is no evidence that the Web landscape changed much since then (in this regard, anyway). + ImageIO currently implements its own clamping of frame durations (<rdar://problem/7689297>) + which will result in this change having no observable effect on platforms where it is used + until an updated version of ImageIO becomes available. It's extremely unfortunate that we'll have different behavior across OS X versions if this patch goes in. 199282 3 mrowe 2010-03-12 19:20:18 -0800 (In reply to comment #2) > Note that this is basically reverting what we did in bug 14413. It may still be > appropriate to revisit the decisions made in 2007, although there is no > evidence that the Web landscape changed much since then (in this regard, > anyway). It’s nearly 3 years later and Firefox is still using their lower clamping threshold. If there were compelling compatibility reasons for matching Internet Explorer I would expect that Firefox would have seen them and taken action. Opera has also since switched from matching Internet Explorer on this issue to matching Firefox. > + ImageIO currently implements its own clamping of frame durations > (<rdar://problem/7689297>) > + which will result in this change having no observable effect on > platforms where it is used > + until an updated version of ImageIO becomes available. > > It's extremely unfortunate that we'll have different behavior across OS X > versions if this patch goes in. We already have different behavior across Mac OS X versions. ImageIO in Tiger has no clamping, so it gets whatever behavior WebKit implements. ImageIO on Leopard clamps to 100ms. ImageIO on SnowLeopard currently clamps at 50ms. Future versions of ImageIO will not clamp at all, so it will be up to WebKit’s clamping. This means that once an updated version of ImageIO is available there will be no more difference between Mac OS X versions than we currently have. 199285 4 ap 2010-03-12 19:55:17 -0800 (In reply to comment #3) > It’s nearly 3 years later and Firefox is still using their lower clamping > threshold. If there were compelling compatibility reasons for matching > Internet Explorer I would expect that Firefox would have seen them and taken > action. The action seems to have been WONTFIX, see <https://bugzilla.mozilla.org/show_bug.cgi?id=232769> and its many duplicates (some of them are duplicates of duplicates). The newest I could find was filed last month, <https://bugzilla.mozilla.org/show_bug.cgi?id=544077>. 199372 5 ap 2010-03-13 10:18:05 -0800 I made a couple experiments. First, it was very easy to find examples of animated gifs that were obviously too fast in Firefox. I could find such intentionally, and I also encountered them on sites I browse daily. This was all in a few minutes of testing. Second, I searched the Web for "IE animates gif too slow" and "Firefox animates gif too fast". The number of complaints was roughly the same. This tells me that on the grounds of Web compatibility, we shouldn't be making any sudden movements. Replacing a number of old bugs with an equal number of regressions is a loss. 199415 6 pkasting 2010-03-13 14:38:03 -0800 I've done extensive research on this issue. Please see bug 26455, especially comment 0. The most relevant Mozilla bug, noted there, is https://bugzilla.mozilla.org/show_bug.cgi?id=440882 . As noted above, I believe the one factual update since I filed that bug is that Opera has changed (yet again) back to matching Firefox. My personal preference is to change to match Firefox' behavior, which I think is much more sensible. As ap notes, there are GIFs on the web that are broken no matter what you do, and the linked bug points out examples of both kinds (as well as images where the right speed is unclear). Given this, the fact that it is impossible to do standard-frame-rate animations with the IE clamp, and the fact that the IE clamp is a larger deviation from "no clamp", are what swing my opinion. Authors can conceivably update images that are too fast in Firefox to look right everywhere, but they can't make a similar change to make images too slow in IE look right everywhere. Another point: if we're going to look wrong on some images, I'd rather look like we're too fast than too slow, since the latter makes people think we're underperformant. To be honest, I think even better would be to clamp <= 10 ms to 10 ms, instead of 100. This is closer to what setTimeout() does. I suspect that we might be able to get the Mozilla folks to agree to this if we change to match them in the meantime. So, in short: I suggest duping against bug 26455 (or the other way around), landing this patch + changing any other similar instances in other graphics backends' code, and noting on the Mozilla bug that now all the browsers are united in the Firefox way except for IE. I asked Hixie at one point if this kind of thing could be specced in HTML5 and he suggested it wasn't a very great fit there, but perhaps we would still have the opportunity then to drop a note to the folks at Microsoft to suggest changing IE 9+. 199475 7 50647 ap 2010-03-14 11:40:19 -0700 Comment on attachment 50647 Patch v1 The discussion seems to have dried up, so I'm saying r- to avoid it going in rounds. We certainly have a significant Web compatibility problem to solve, but as indicated by the research above, this particular solution will introduce an equal number of regressions, which is simply not how the WebKit project rolls. Perhaps - and hopefully - there is a clever heuristic we could come up with that would make it a clear win for existing Web content. > Authors can conceivably update images that are too fast in Firefox to > look right everywhere, but they can't make a similar change to make images too > slow in IE look right everywhere. Animated GIFs are a legacy technology, and making it learn new tricks is not the main concern - especially since these tricks won't be available for general Web content unless MS decides to make the same change, and until the versions of IE with the old behavior can be disregarded. There are many other ways to display animations on the Web. 199476 8 ap 2010-03-14 11:43:00 -0700 These bugs have comparable amount of comments and insight, so I'm duping to the old one. *** This bug has been marked as a duplicate of bug 26455 *** 208335 9 darin 2010-04-03 23:18:26 -0700 (In reply to comment #6) > To be honest, I think even better would be to clamp <= 10 ms to 10 ms, instead > of 100. But then a delay of 0 becomes 100 fps but in the past it has always been 10 fps in all browsers, right? 208371 10 pkasting 2010-04-04 12:36:48 -0700 (In reply to comment #9) > (In reply to comment #6) > > To be honest, I think even better would be to clamp <= 10 ms to 10 ms, instead > > of 100. > > But then a delay of 0 becomes 100 fps but in the past it has always been 10 fps > in all browsers, right? Yes. The goal of that proposal would be sane behavior over backwards compatibility. I don't expect it to happen because I don't expect enough other people to agree with me. 50647 2010-03-12 18:01:56 -0800 2010-03-14 11:40:19 -0700 Patch v1 0001-Animated-GIF-animates-much-more-slowly-in-Safari-tha.patch text/plain 4788 mrowe RnJvbSBhNzg0ZGY2YmNmZDhhNDQ5ZTk2YzI0ZTM2NjZmNzUyZTIwMWJlNmQyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJrIFJvd2UgPG1yb3dlQGFwcGxlLmNvbT4KRGF0ZTogVHVl LCA5IE1hciAyMDEwIDIzOjQ1OjUxIC0wODAwClN1YmplY3Q6IFtQQVRDSF0gQW5pbWF0ZWQgR0lG IGFuaW1hdGVzIG11Y2ggbW9yZSBzbG93bHkgaW4gU2FmYXJpIHRoYW4gRmlyZWZveAogPHJkYXI6 Ly9wcm9ibGVtLzc2ODkzMDA+IC8gPGh0dHA6Ly93ZWJraXQub3JnL2IvMzYwODI+CgpSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KCkFkb3B0IEZpcmVmb3gncyBiZWhhdmlvciBmb3IgZnJhbWUg ZHVyYXRpb24gY2xhbXBpbmcuIEltYWdlcyB0aGF0IHNwZWNpZnkgYSBmcmFtZSBkdXJhdGlvbgpv ZiA8PSAxMG1zIGFyZSB0cmVhdGVkIGFzIGhhdmluZyBhIGZyYW1lIGR1cmF0aW9uIG9mIDEwMG1z LCB3aGlsZSBhbGwgb3RoZXIgaW1hZ2VzIHVzZSB0aGUKZnJhbWUgZHVyYXRpb24gdGhhdCB0aGV5 IHNwZWNpZnkuCgpJbWFnZUlPIGN1cnJlbnRseSBpbXBsZW1lbnRzIGl0cyBvd24gY2xhbXBpbmcg b2YgZnJhbWUgZHVyYXRpb25zICg8cmRhcjovL3Byb2JsZW0vNzY4OTI5Nz4pCndoaWNoIHdpbGwg cmVzdWx0IGluIHRoaXMgY2hhbmdlIGhhdmluZyBubyBvYnNlcnZhYmxlIGVmZmVjdCBvbiBwbGF0 Zm9ybXMgd2hlcmUgaXQgaXMgdXNlZAp1bnRpbCBhbiB1cGRhdGVkIHZlcnNpb24gb2YgSW1hZ2VJ TyBiZWNvbWVzIGF2YWlsYWJsZS4KCiogcGxhdGZvcm0vZ3JhcGhpY3MvSW1hZ2VTb3VyY2UuY3Bw OgooV2ViQ29yZTo6SW1hZ2VTb3VyY2U6OmZyYW1lRHVyYXRpb25BdEluZGV4KTogVXBkYXRlIHRo ZSBmb3JtYXR0aW5nIG9mIHRoZSBjb21tZW50IGFuZCBzdHlsZQpvZiB0aGUgY29kZSB0byBtYXRj aCB0aGF0IGluIEltYWdlU291cmNlQ0cuCiogcGxhdGZvcm0vZ3JhcGhpY3MvY2cvSW1hZ2VTb3Vy Y2VDRy5jcHA6CihXZWJDb3JlOjpJbWFnZVNvdXJjZTo6ZnJhbWVEdXJhdGlvbkF0SW5kZXgpOgot LS0KIFdlYkNvcmUvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAgIDIx ICsrKysrKysrKysrKysrKysrKysrKwogV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9JbWFnZVNv dXJjZS5jcHAgICAgICB8ICAgMTMgKysrKysrKy0tLS0tLQogV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9jZy9JbWFnZVNvdXJjZUNHLmNwcCB8ICAgIDcgKysrKy0tLQogMyBmaWxlcyBjaGFuZ2Vk LCAzMiBpbnNlcnRpb25zKCspLCA5IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1dlYkNvcmUv Q2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzE1OGUxYy4uMTBjY2M4MiAxMDA2 NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyNCBAQAorMjAxMC0wMy0xMiAgTWFyayBSb3dlICA8bXJvd2VAYXBwbGUuY29tPgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFuaW1hdGVkIEdJ RiBhbmltYXRlcyBtdWNoIG1vcmUgc2xvd2x5IGluIFNhZmFyaSB0aGFuIEZpcmVmb3gKKyAgICAg ICAgPHJkYXI6Ly9wcm9ibGVtLzc2ODkzMDA+IC8gPGh0dHA6Ly93ZWJraXQub3JnL2IvMzYwODI+ CisKKyAgICAgICAgQWRvcHQgRmlyZWZveCdzIGJlaGF2aW9yIGZvciBmcmFtZSBkdXJhdGlvbiBj bGFtcGluZy4gSW1hZ2VzIHRoYXQgc3BlY2lmeSBhIGZyYW1lIGR1cmF0aW9uCisgICAgICAgIG9m IDw9IDEwbXMgYXJlIHRyZWF0ZWQgYXMgaGF2aW5nIGEgZnJhbWUgZHVyYXRpb24gb2YgMTAwbXMs IHdoaWxlIGFsbCBvdGhlciBpbWFnZXMgdXNlIHRoZQorICAgICAgICBmcmFtZSBkdXJhdGlvbiB0 aGF0IHRoZXkgc3BlY2lmeS4KKworICAgICAgICBJbWFnZUlPIGN1cnJlbnRseSBpbXBsZW1lbnRz IGl0cyBvd24gY2xhbXBpbmcgb2YgZnJhbWUgZHVyYXRpb25zICg8cmRhcjovL3Byb2JsZW0vNzY4 OTI5Nz4pCisgICAgICAgIHdoaWNoIHdpbGwgcmVzdWx0IGluIHRoaXMgY2hhbmdlIGhhdmluZyBu byBvYnNlcnZhYmxlIGVmZmVjdCBvbiBwbGF0Zm9ybXMgd2hlcmUgaXQgaXMgdXNlZAorICAgICAg ICB1bnRpbCBhbiB1cGRhdGVkIHZlcnNpb24gb2YgSW1hZ2VJTyBiZWNvbWVzIGF2YWlsYWJsZS4K KworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL0ltYWdlU291cmNlLmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OkltYWdlU291cmNlOjpmcmFtZUR1cmF0aW9uQXRJbmRleCk6IFVwZGF0ZSB0aGUg Zm9ybWF0dGluZyBvZiB0aGUgY29tbWVudCBhbmQgc3R5bGUKKyAgICAgICAgb2YgdGhlIGNvZGUg dG8gbWF0Y2ggdGhhdCBpbiBJbWFnZVNvdXJjZUNHLgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBo aWNzL2NnL0ltYWdlU291cmNlQ0cuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SW1hZ2VTb3VyY2U6 OmZyYW1lRHVyYXRpb25BdEluZGV4KToKKwogMjAxMC0wMy0xMiAgQmV0aCBEYWtpbiAgPGJkYWtp bkBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgU2ltb24gRnJhc2VyLgpkaWZmIC0t Z2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9JbWFnZVNvdXJjZS5jcHAgYi9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL0ltYWdlU291cmNlLmNwcAppbmRleCBjMjM2NmMxLi4xNDQwMTY1 IDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0ltYWdlU291cmNlLmNwcAor KysgYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0ltYWdlU291cmNlLmNwcApAQCAtMTQ1LDEz ICsxNDUsMTQgQEAgZmxvYXQgSW1hZ2VTb3VyY2U6OmZyYW1lRHVyYXRpb25BdEluZGV4KHNpemVf dCBpbmRleCkKICAgICBpZiAoIWJ1ZmZlciB8fCBidWZmZXItPnN0YXR1cygpID09IFJHQkEzMkJ1 ZmZlcjo6RnJhbWVFbXB0eSkKICAgICAgICAgcmV0dXJuIDA7CiAKLSAgICAvLyBNYW55IGFubm95 aW5nIGFkcyBzcGVjaWZ5IGEgMCBkdXJhdGlvbiB0byBtYWtlIGFuIGltYWdlIGZsYXNoIGFzIHF1 aWNrbHkKLSAgICAvLyBhcyBwb3NzaWJsZS4gIFdlIGZvbGxvdyBXaW5JRSdzIGJlaGF2aW9yIGFu ZCB1c2UgYSBkdXJhdGlvbiBvZiAxMDAgbXMKLSAgICAvLyBmb3IgYW55IGZyYW1lcyB0aGF0IHNw ZWNpZnkgYSBkdXJhdGlvbiBvZiA8PSA1MCBtcy4gIFNlZQotICAgIC8vIDxodHRwOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDQxMz4gb3IgUmFkYXIgNDA1MTM4OSBmb3IKLSAg ICAvLyBtb3JlLgorICAgIC8vIE1hbnkgYW5ub3lpbmcgYWRzIHNwZWNpZnkgYSAwIGR1cmF0aW9u IHRvIG1ha2UgYW4gaW1hZ2UgZmxhc2ggYXMgcXVpY2tseSBhcyBwb3NzaWJsZS4KKyAgICAvLyBX ZSBmb2xsb3cgRmlyZWZveCdzIGJlaGF2aW9yIGFuZCB1c2UgYSBkdXJhdGlvbiBvZiAxMDAgbXMg Zm9yIGFueSBmcmFtZXMgdGhhdCBzcGVjaWZ5CisgICAgLy8gYSBkdXJhdGlvbiBvZiA8PSAxMCBt cy4gU2VlIDxyZGFyOi8vcHJvYmxlbS83Njg5MzAwPiBhbmQgPGh0dHA6Ly93ZWJraXQub3JnL2Iv MzYwODI+CisgICAgLy8gZm9yIG1vcmUgaW5mb3JtYXRpb24uCiAgICAgY29uc3QgZmxvYXQgZHVy YXRpb24gPSBidWZmZXItPmR1cmF0aW9uKCkgLyAxMDAwLjBmOwotICAgIHJldHVybiAoZHVyYXRp b24gPCAwLjA1MWYpID8gMC4xMDBmIDogZHVyYXRpb247CisgICAgaWYgKGR1cmF0aW9uIDwgMC4w MTFmKQorICAgICAgICByZXR1cm4gMC4xMDBmOworICAgIHJldHVybiBkdXJhdGlvbjsKIH0KIAog Ym9vbCBJbWFnZVNvdXJjZTo6ZnJhbWVIYXNBbHBoYUF0SW5kZXgoc2l6ZV90IGluZGV4KQpkaWZm IC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jZy9JbWFnZVNvdXJjZUNHLmNwcCBi L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2cvSW1hZ2VTb3VyY2VDRy5jcHAKaW5kZXggYTkx NzliYy4uMDgwODQyYSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jZy9J bWFnZVNvdXJjZUNHLmNwcAorKysgYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NnL0ltYWdl U291cmNlQ0cuY3BwCkBAIC0yNjksOSArMjY5LDEwIEBAIGZsb2F0IEltYWdlU291cmNlOjpmcmFt ZUR1cmF0aW9uQXRJbmRleChzaXplX3QgaW5kZXgpCiAgICAgfQogCiAgICAgLy8gTWFueSBhbm5v eWluZyBhZHMgc3BlY2lmeSBhIDAgZHVyYXRpb24gdG8gbWFrZSBhbiBpbWFnZSBmbGFzaCBhcyBx dWlja2x5IGFzIHBvc3NpYmxlLgotICAgIC8vIFdlIGZvbGxvdyBXaW5JRSdzIGJlaGF2aW9yIGFu ZCB1c2UgYSBkdXJhdGlvbiBvZiAxMDAgbXMgZm9yIGFueSBmcmFtZXMgdGhhdCBzcGVjaWZ5Ci0g ICAgLy8gYSBkdXJhdGlvbiBvZiA8PSA1MCBtcy4gU2VlIDxodHRwOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xNDQxMz4gb3IgUmFkYXIgNDA1MTM4OSBmb3IgbW9yZS4KLSAgICBp ZiAoZHVyYXRpb24gPCAwLjA1MWYpCisgICAgLy8gV2UgZm9sbG93IEZpcmVmb3gncyBiZWhhdmlv ciBhbmQgdXNlIGEgZHVyYXRpb24gb2YgMTAwIG1zIGZvciBhbnkgZnJhbWVzIHRoYXQgc3BlY2lm eQorICAgIC8vIGEgZHVyYXRpb24gb2YgPD0gMTAgbXMuIFNlZSA8cmRhcjovL3Byb2JsZW0vNzY4 OTMwMD4gYW5kIDxodHRwOi8vd2Via2l0Lm9yZy9iLzM2MDgyPgorICAgIC8vIGZvciBtb3JlIGlu Zm9ybWF0aW9uLgorICAgIGlmIChkdXJhdGlvbiA8IDAuMDExZikKICAgICAgICAgcmV0dXJuIDAu MTAwZjsKICAgICByZXR1cm4gZHVyYXRpb247CiB9Ci0tIAoxLjcuMC4yLjE5OS5nOTBhMmJmOQoK