36078 2010-03-12 17:06:47 -0800 new-run-webkit-tests fails java/lc3 on a clean checkout 2010-03-29 15:21:05 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 dpranke eric abarth ap cjerdonek commit-queue eric oldest_to_newest 199257 0 dpranke 2010-03-12 17:06:47 -0800 Apparently someone recently introduced a java class for some tests and run-webkit-tests compiles this class as part of the test setup, but new-run-webkit-tests does not. So, all of the tests under java/lc3 will fail. 199306 1 ap 2010-03-12 22:45:09 -0800 Do only java/lc3 tests fail? Other ones in java directory also need to compile java sources. 204707 2 eric 2010-03-26 12:16:39 -0700 I ran new-run-webkit-tests again last night. Wow. Very impressive. But I ran into this bug. if (isAppleMacWebKit()) { print STDERR "Compiling Java tests\n"; my $javaTestsDirectory = catdir($testDirectory, "java"); if (system("/usr/bin/make", "-C", "$javaTestsDirectory")) { exit 1; } } Seems to be the perl code used for the fix. I'll prepare a patch. 204743 3 51774 eric 2010-03-26 13:12:32 -0700 Created attachment 51774 Patch 204744 4 51774 eric 2010-03-26 13:13:27 -0700 Comment on attachment 51774 Patch I did not do a full new-run-webkit-tests run with this change. My laptop takes an hour to build webkit. I did however verify that the build part seems to be working. :) 204746 5 51774 dpranke 2010-03-26 13:16:57 -0700 Comment on attachment 51774 Patch LGTM (although I'm not a reviewer). 204750 6 51774 abarth 2010-03-26 13:23:02 -0700 Comment on attachment 51774 Patch ok 204754 7 ap 2010-03-26 13:29:03 -0700 You didn't port this though: print STDERR "Compiling Java tests\n"; Does new-run-webkit-tests build quietly? 204761 8 eric 2010-03-26 13:35:40 -0700 new-run-webkit-tests in its default mode does everything quietly. (Using one line which overwrites itself until it finally spits out results.) I expect we'll eventually customize the logging to the greater webkit's whims and desires. :) I don't know enough about all the various logging modes to know how to spit that part out in only the right modes. Dirk would know more. 204768 9 dpranke 2010-03-26 14:00:33 -0700 new-run-webkit-tests uses the "MeteredStream" class to provide the one-line status updates. The Port class doesn't actually get passed the handle to the meter, but it would be a good enhancement if it did. I'll add that and add separate lines for the build steps in a different patch. The general rule of thumbs I'm trying to follow for output are: (1) By default, if everything works, we produce one line of output ("all tests completed successfully") (2) Status updates are provided for every step that takes more than a second or two to run (so that you at least know what stage we're in). Only the current stage is displayed. (3) Where possible, long-running stages actually produce a progress-bar style update (which is what meter.update() implements), so that you can tell that things aren't hung. Where possible, updates happen every few seconds or more frequently, up to ~10 times per second for a smooth animation). Currently only the actual running of the tests does this. (I should probably document some of this stuff somewhere ...) 204928 10 51774 commit-queue 2010-03-26 21:13:12 -0700 Comment on attachment 51774 Patch Rejecting patch 51774 from commit-queue. Failed to run "['/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', '--reviewer', 'Adam Barth', '--force']" exit_code: 1 patching file WebKitTools/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file WebKitTools/Scripts/webkitpy/layout_tests/port/mac.py Hunk #1 succeeded at 77 (offset 1 line). Hunk #2 FAILED at 85. 1 out of 2 hunks FAILED -- saving rejects to file WebKitTools/Scripts/webkitpy/layout_tests/port/mac.py.rej Full output: http://webkit-commit-queue.appspot.com/results/1578005 205576 11 eric 2010-03-29 11:39:47 -0700 Attachment 51774 was posted by a committer and has review+, assigning to Eric Seidel for commit. 205692 12 eric 2010-03-29 15:21:05 -0700 Committed r56743: <http://trac.webkit.org/changeset/56743> 51774 2010-03-26 13:12:32 -0700 2010-03-26 21:13:12 -0700 Patch bug-36078-20100326131230.patch text/plain 2001 eric ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBiZDBkZDMyLi42ZTM0ZGMwIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTYgQEAKIDIwMTAtMDMt MjYgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgogCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIG5ldy1ydW4td2Via2l0LXRlc3RzIGZhaWxzIGph dmEvbGMzIG9uIGEgY2xlYW4gY2hlY2tvdXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTM2MDc4CisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xh eW91dF90ZXN0cy9wb3J0L21hYy5weToKKyAgICAgICAgIC0gQnVpbGQgdGhlIGphdmEgc3VwcG9y dCBmaWxlcyBpbiBjaGVja19idWlsZAorICAgICAgICAgLSBVbndyYXAgYSBsaW5lIHdoaWNoIHdv dWxkIHN0aWxsIGZpdCB1bmRlciA4MGNvbAorCisyMDEwLTAzLTI2ICBFcmljIFNlaWRlbCAgPGVy aWNAd2Via2l0Lm9yZz4KKwogICAgICAgICBSZXZpZXdlZCBieSBBZGFtIEJhcnRoLgogCiAgICAg ICAgIE1vdmUgY29tbWl0X21lc3NhZ2VfZm9yX3RoaXNfY29tbWl0IGZyb20gc2NtIHRvIGNoZWNr b3V0CmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0 cy9wb3J0L21hYy5weSBiL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3Rz L3BvcnQvbWFjLnB5CmluZGV4IDMwZDJhYjguLjJlNmQ2MjcgMTAwNjQ0Ci0tLSBhL1dlYktpdFRv b2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvbWFjLnB5CisrKyBiL1dlYktp dFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvbWFjLnB5CkBAIC03Niw4 ICs3Niw3IEBAIGNsYXNzIE1hY1BvcnQoYmFzZS5Qb3J0KToKICAgICAgICAgYnVpbGRfZHJ0X2Nv bW1hbmQgPSBbc2VsZi5zY3JpcHRfcGF0aCgiYnVpbGQtZHVtcHJlbmRlcnRyZWUiKV0KICAgICAg ICAgaWYgc2VsZi5fb3B0aW9ucy50YXJnZXQgPT0gIkRlYnVnIjoKICAgICAgICAgICAgIGJ1aWxk X2RydF9jb21tYW5kLmFwcGVuZCgnLS1kZWJ1ZycpCi0gICAgICAgIGlmIGV4ZWN1dGl2ZS5ydW5f Y29tbWFuZChidWlsZF9kcnRfY29tbWFuZCwKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIHJldHVybl9leGl0X2NvZGU9VHJ1ZSk6CisgICAgICAgIGlmIGV4ZWN1dGl2ZS5ydW5fY29t bWFuZChidWlsZF9kcnRfY29tbWFuZCwgcmV0dXJuX2V4aXRfY29kZT1UcnVlKToKICAgICAgICAg ICAgIHJldHVybiBGYWxzZQogCiAgICAgICAgIGRyaXZlcl9wYXRoID0gc2VsZi5fcGF0aF90b19k cml2ZXIoKQpAQCAtODUsNiArODQsMTEgQEAgY2xhc3MgTWFjUG9ydChiYXNlLlBvcnQpOgogICAg ICAgICAgICAgX2xvZy5lcnJvcigiRHVtcFJlbmRlclRyZWUgd2FzIG5vdCBmb3VuZCBhdCAlcyIg JSBkcml2ZXJfcGF0aCkKICAgICAgICAgICAgIHJldHVybiBGYWxzZQogCisgICAgICAgIGphdmFf dGVzdHNfcGF0aCA9IG9zLnBhdGguam9pbihzZWxmLmxheW91dF90ZXN0c19kaXIoKSwgImphdmEi KQorICAgICAgICBidWlsZF9qYXZhID0gWyIvdXNyL2Jpbi9tYWtlIiwgIi1DIiwgamF2YV90ZXN0 c19wYXRoXQorICAgICAgICBpZiBleGVjdXRpdmUucnVuX2NvbW1hbmQoYnVpbGRfamF2YSwgcmV0 dXJuX2V4aXRfY29kZT1UcnVlKToKKyAgICAgICAgICAgIHJldHVybiBGYWxzZQorCiAgICAgICAg ICMgVGhpcyBzaG91bGQgYWxzbyB2YWxpZGF0ZSB0aGF0IHRoZSBJbWFnZURpZmYgcGF0aCBpcyB2 YWxpZAogICAgICAgICAjIChvbmNlIHRoaXMgc2NyaXB0IGtub3dzIGhvdyB0byB1c2UgSW1hZ2VE aWZmKS4KICAgICAgICAgIyBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MzQ4MjYK