36077 2010-03-12 16:47:58 -0800 v8 DOMWrapperWorld needs virtual dtor 2010-03-12 17:03:07 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 jamesr webkit-unassigned oldest_to_newest 199248 0 jamesr 2010-03-12 16:47:58 -0800 v8 DOMWrapperWorld needs virtual dtor 199249 1 50641 jamesr 2010-03-12 16:49:04 -0800 Created attachment 50641 Patch 199250 2 50641 abarth 2010-03-12 16:52:54 -0800 Comment on attachment 50641 Patch Nice find! + RefCounted<DOMWrapperWorld should be + RefCounted<DOMWrapperWorld> Also, we usually wrap ChangeLogs at 80 chars. 199251 3 jamesr 2010-03-12 16:54:53 -0800 Without this patch the following happens: V8Proxy::resetIsolatedWorlds() is calling the destructor of each V8IsolatedContext, which each have a RefPtr<IsolatedWorld> member variable. Since IsolatedWorld inherits from DOMWrapperWorld, which is declared as RefCounted<DOMWrapperWorld>, the deref() call is doing delete static_cast<DOMWrapperWorld*>(m_ptr). Since DOMWrapperWorld has no members and does not have a virtual destructor, it just does a free(). This means the IsolatedWorld's member variable, a DOMDataStoreHandle, is never destroyed and so the associated DOMDataStore is leaked and stays in the DOMDataStoreList. 199252 4 50642 jamesr 2010-03-12 16:56:19 -0800 Created attachment 50642 Patch 199253 5 50642 abarth 2010-03-12 16:57:10 -0800 Comment on attachment 50642 Patch ok 199254 6 50642 jamesr 2010-03-12 17:03:03 -0800 Comment on attachment 50642 Patch Clearing flags on attachment: 50642 Committed r55945: <http://trac.webkit.org/changeset/55945> 199255 7 jamesr 2010-03-12 17:03:07 -0800 All reviewed patches have been landed. Closing bug. 50641 2010-03-12 16:49:04 -0800 2010-03-12 16:56:16 -0800 Patch bug-36077-20100312164902.patch text/plain 1361 jamesr ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg M2FlYmY4Zi4uOWZhMTljNSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMCBAQAorMjAxMC0wMy0xMiAgSmFtZXMgUm9iaW5z b24gIDxqYW1lc3JAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIEFkZCB2aXJ0dWFsIGRlc3RydWN0b3IgdG8gRE9NV3JhcHBlcldv cmxkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNjA3 NworCisgICAgICAgIERPTVdyYXBwZXJXb3JsZCBpcyBSZWZDb3VudGVkPERPTVdyYXBwZXJXb3Js ZC4gIElzb2xhdGVkV29ybGQgaW5oZXJpdHMgZnJvbSBET01XcmFwcGVyV29ybGQgYW5kIGhhcyBt ZW1iZXIgdmFyaWFibGVzCisgICAgICAgIHdpdGggZGVzdHJ1Y3RvcnMsIHNvIERPTVdyYXBwZXJX b3JsZCBuZWVkcyB0byBoYXZlIGEgZGVjbGFyZWQgdmlydHVhbCBkJ3RvciB0byBlbnN1cmUgdGhh dCBpdHMgZGVyaXZlZCBjbGFzcydzIGRlc3RydWN0b3JzCisgICAgICAgIGFyZSBjYWxsZWQuCisK KyAgICAgICAgTm8gbmV3IHRlc3RzLCBubyBjaGFuZ2UgaW4gYmVoYXZpb3IKKworICAgICAgICAq IGJpbmRpbmdzL3Y4L0RPTVdyYXBwZXJXb3JsZC5oOgorICAgICAgICAoV2ViQ29yZTo6RE9NV3Jh cHBlcldvcmxkOjp+RE9NV3JhcHBlcldvcmxkKToKKworCiAyMDEwLTAzLTEwICBJbHlhIFRpa2hv bm92c2t5ICA8bG9pc2xvQGxvaXNsby1tYWNib29rcHJvLmxvY2FsPgogCiAgICAgICAgIFJldmll d2VkIGJ5IFBhdmVsIEZlbGRtYW4uCmRpZmYgLS1naXQgYS9XZWJDb3JlL2JpbmRpbmdzL3Y4L0RP TVdyYXBwZXJXb3JsZC5oIGIvV2ViQ29yZS9iaW5kaW5ncy92OC9ET01XcmFwcGVyV29ybGQuaApp bmRleCBmNTRjZDRlLi4yYTlkZjMwIDEwMDY0NAotLS0gYS9XZWJDb3JlL2JpbmRpbmdzL3Y4L0RP TVdyYXBwZXJXb3JsZC5oCisrKyBiL1dlYkNvcmUvYmluZGluZ3MvdjgvRE9NV3JhcHBlcldvcmxk LmgKQEAgLTQzLDYgKzQzLDcgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogY2xhc3MgRE9NV3JhcHBl cldvcmxkIDogcHVibGljIFJlZkNvdW50ZWQ8RE9NV3JhcHBlcldvcmxkPiB7CiBwdWJsaWM6CiAg ICAgc3RhdGljIFBhc3NSZWZQdHI8RE9NV3JhcHBlcldvcmxkPiBjcmVhdGUoKSB7IHJldHVybiBh ZG9wdFJlZihuZXcgRE9NV3JhcHBlcldvcmxkKCkpOyB9CisgICAgdmlydHVhbCB+RE9NV3JhcHBl cldvcmxkKCkge30KIAogcHJvdGVjdGVkOgogICAgIERPTVdyYXBwZXJXb3JsZCgpOwo= 50642 2010-03-12 16:56:19 -0800 2010-03-12 17:03:02 -0800 Patch bug-36077-20100312165617.patch text/plain 1371 jamesr ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg M2FlYmY4Zi4uYTZjOWVkNyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMSBAQAorMjAxMC0wMy0xMiAgSmFtZXMgUm9iaW5z b24gIDxqYW1lc3JAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIEFkZCB2aXJ0dWFsIGRlc3RydWN0b3IgdG8gRE9NV3JhcHBlcldv cmxkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNjA3 NworCisgICAgICAgIERPTVdyYXBwZXJXb3JsZCBpcyBSZWZDb3VudGVkPERPTVdyYXBwZXJXb3Js ZD4uICBJc29sYXRlZFdvcmxkCisgICAgICAgIGluaGVyaXRzIGZyb20gRE9NV3JhcHBlcldvcmxk IGFuZCBoYXMgbWVtYmVyIHZhcmlhYmxlcworICAgICAgICB3aXRoIGRlc3RydWN0b3JzLCBzbyBE T01XcmFwcGVyV29ybGQgbmVlZHMgdG8gaGF2ZSBhIGRlY2xhcmVkIHZpcnR1YWwKKyAgICAgICAg ZCd0b3IgdG8gZW5zdXJlIHRoYXQgaXRzIGRlcml2ZWQgY2xhc3MncyBkZXN0cnVjdG9ycyBhcmUg Y2FsbGVkLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgbm8gY2hhbmdlIGluIGJlaGF2aW9yCisK KyAgICAgICAgKiBiaW5kaW5ncy92OC9ET01XcmFwcGVyV29ybGQuaDoKKyAgICAgICAgKFdlYkNv cmU6OkRPTVdyYXBwZXJXb3JsZDo6fkRPTVdyYXBwZXJXb3JsZCk6CisKKwogMjAxMC0wMy0xMCAg SWx5YSBUaWtob25vdnNreSAgPGxvaXNsb0Bsb2lzbG8tbWFjYm9va3Byby5sb2NhbD4KIAogICAg ICAgICBSZXZpZXdlZCBieSBQYXZlbCBGZWxkbWFuLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9iaW5k aW5ncy92OC9ET01XcmFwcGVyV29ybGQuaCBiL1dlYkNvcmUvYmluZGluZ3MvdjgvRE9NV3JhcHBl cldvcmxkLmgKaW5kZXggZjU0Y2Q0ZS4uMmE5ZGYzMCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9iaW5k aW5ncy92OC9ET01XcmFwcGVyV29ybGQuaAorKysgYi9XZWJDb3JlL2JpbmRpbmdzL3Y4L0RPTVdy YXBwZXJXb3JsZC5oCkBAIC00Myw2ICs0Myw3IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKIGNsYXNz IERPTVdyYXBwZXJXb3JsZCA6IHB1YmxpYyBSZWZDb3VudGVkPERPTVdyYXBwZXJXb3JsZD4gewog cHVibGljOgogICAgIHN0YXRpYyBQYXNzUmVmUHRyPERPTVdyYXBwZXJXb3JsZD4gY3JlYXRlKCkg eyByZXR1cm4gYWRvcHRSZWYobmV3IERPTVdyYXBwZXJXb3JsZCgpKTsgfQorICAgIHZpcnR1YWwg fkRPTVdyYXBwZXJXb3JsZCgpIHt9CiAKIHByb3RlY3RlZDoKICAgICBET01XcmFwcGVyV29ybGQo KTsK