36050 2010-03-12 00:21:11 -0800 Add the possibility for a head and footer section to create_jit_stubs 2010-06-25 00:30:32 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Other Other RESOLVED FIXED P2 Normal --- 34953 0 paroga webkit-unassigned barraclough commit-queue eric laszlo.gombos oliver oldest_to_newest 198952 0 paroga 2010-03-12 00:21:11 -0800 see patch 198953 1 50580 paroga 2010-03-12 00:22:30 -0800 Created attachment 50580 The patch 198987 2 laszlo.gombos 2010-03-12 05:37:52 -0800 Patrick, can you describe the motivation behind this change ? Which port will use this feature and how will this feature will be used ? Thanks. 198988 3 paroga 2010-03-12 05:41:25 -0800 (In reply to comment #2) > Patrick, can you describe the motivation behind this change ? Which port will > use this feature and how will this feature will be used? Thanks. It's for bug 34953. I need to insert sth before and sth after the DEFINE_STUB_FUNCTION. 199860 4 50580 eric 2010-03-15 15:22:04 -0700 Comment on attachment 50580 The patch The ChangeLog should really explain the "why". Comments in the bug are nice, but not as accessible during reviews or during later svn annotates. 203913 5 eric 2010-03-25 01:43:30 -0700 CCing the JIT ninjas. 223091 6 50580 eric 2010-05-09 14:54:48 -0700 Comment on attachment 50580 The patch Is this used for anything? How can this be tested, or at least proven to do something useful. :) 223095 7 paroga 2010-05-09 15:05:27 -0700 (In reply to comment #6) > (From update of attachment 50580 [details]) > Is this used for anything? How can this be tested, or at least proven to do something useful. :) This is only necessary for bug 34953. The assembler file for WinCE ARM JIT needs a part before (at least " AREA Trampoline, CODE") and a part after the "DEFINE_STUB_FUNCTION implementations" (" END"). Maybe you have a better solution for this?? Otherwise it can be useful ;-) 242871 8 50580 commit-queue 2010-06-25 00:30:27 -0700 Comment on attachment 50580 The patch Clearing flags on attachment: 50580 Committed r61838: <http://trac.webkit.org/changeset/61838> 242872 9 commit-queue 2010-06-25 00:30:32 -0700 All reviewed patches have been landed. Closing bug. 50580 2010-03-12 00:22:30 -0800 2010-06-25 00:30:27 -0700 The patch bug-36050.patch text/plain 1570 paroga SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDU1ODkxKQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTAtMDMtMTIgIFBhdHJpY2sg R2Fuc3RlcmVyICA8cGFyb2dhQHBhcm9nYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIHRoZSBwb3NzaWJpbGl0eSBmb3IgYSBoZWFkIGFu ZCBmb290ZXIgc2VjdGlvbiB0byBjcmVhdGVfaml0X3N0dWJzLgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzYwNTAKKworICAgICAgICAqIGNyZWF0ZV9q aXRfc3R1YnM6CisKIDIwMTAtMDMtMTEgIEtlbnQgSGFuc2VuICA8a2VudC5oYW5zZW5Abm9raWEu Y29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFNpbW9uIEhhdXNtYW5uLgpJbmRleDogSmF2YVNj cmlwdENvcmUvY3JlYXRlX2ppdF9zdHVicwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0Q29yZS9j cmVhdGVfaml0X3N0dWJzCShyZXZpc2lvbiA1NTg5MSkKKysrIEphdmFTY3JpcHRDb3JlL2NyZWF0 ZV9qaXRfc3R1YnMJKHdvcmtpbmcgY29weSkKQEAgLTQyLDYgKzQyLDcgQEAgJGZpbGUgPSAkQVJH VlswXTsKIGRpZSAiJHVzYWdlXG4iIHVubGVzcyAoJHByZWZpeCBhbmQgJGZpbGUpOwogCiBteSAk c3R1Yl90ZW1wbGF0ZSA9ICIiOworbXkgJG91dHB1dF9lbmQgPSAiIjsKIG15ICRzdHViID0gIiI7 CiAKIG15ICRydHlwZSA9ICIiOwpAQCAtNTEsOSArNTIsMTcgQEAgcHJpbnQgU1RERVJSICJDcmVh dGluZyBKSVQgc3R1YnMgZm9yICRmaQogb3BlbihJTiwgJGZpbGUpIG9yIGRpZSAiTm8gc3VjaCBm aWxlICRmaWxlIjsKIAogd2hpbGUgKCAkXyA9IDxJTj4gKSB7CisgICAgaWYgKCAvXiRwcmVmaXhc X0JFR0lOXCgoLiopXCkvICkgeworICAgICAgICAkc3R1YiA9ICQxOworICAgICAgICAkc3R1YiA9 fiBzLyRvZmZzZXRfdGVtcGxhdGUvJG9mZnNldC9nOworICAgICAgICBwcmludCAkc3R1YiAuICJc biI7CisgICAgfQogICAgIGlmICggL14kcHJlZml4XCgoLiopXCkvICkgewogICAgICAgICAkc3R1 Yl90ZW1wbGF0ZSAuPSAkMSAuICJcbiI7CiAgICAgfQorICAgIGlmICggL14kcHJlZml4XF9FTkRc KCguKilcKS8gKSB7CisgICAgICAgICRvdXRwdXRfZW5kIC49ICQxIC4gIlxuIjsKKyAgICB9CiAg ICAgaWYgKCAvXkRFRklORV9TVFVCX0ZVTkNUSU9OXCgoLiopLCAoLiopXCkvICkgewogICAgICAg ICAkc3R1YiA9ICRzdHViX3RlbXBsYXRlOwogICAgICAgICAkcnR5cGUgPSBxdW90ZW1ldGEoJDEp OwpAQCAtNjYsNCArNzUsNiBAQCB3aGlsZSAoICRfID0gPElOPiApIHsKICAgICB9CiB9CiAKK3By aW50ICRvdXRwdXRfZW5kOworCiBjbG9zZShJTik7Cg==