36034 2010-03-11 14:33:57 -0800 [Qt] GraphicsLayer: Opacity change from zero to non-zero doesn't always have effect with AC 2010-03-22 08:47:09 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 kim.1.gronholm webkit-unassigned commit-queue hausmann kenneth noam oldest_to_newest 198781 0 50541 kim.1.gronholm 2010-03-11 14:33:57 -0800 Created attachment 50541 Opacity transition from 0 to 1 in 5s When a web page has only an element which opacity is zero and the opacity is changed to non-zero, the element doesn't become visible. If the mouse cursor is moved outside the window area and back in, the element redraws with correct opacity. After the element has been drawn once with non-zero opacity, the subsequent opacity changes affect immediately. The bug doesn't occur without AC. Attached a test case to demonstrate the issue. 198789 1 50544 kim.1.gronholm 2010-03-11 14:44:06 -0800 Created attachment 50544 patch for the bug #36034 The issue seems to be a bug in QGraphicsScene/QGraphicsItem. Attached a patch which introduces a workaround for it. 199367 2 50544 kenneth 2010-03-13 10:10:42 -0800 Comment on attachment 50544 patch for the bug #36034 Seems sensible. Have you reported the bug to Qt DF? 199383 3 50544 commit-queue 2010-03-13 11:28:51 -0800 Comment on attachment 50544 patch for the bug #36034 Clearing flags on attachment: 50544 Committed r55967: <http://trac.webkit.org/changeset/55967> 199384 4 commit-queue 2010-03-13 11:28:55 -0800 All reviewed patches have been landed. Closing bug. 199421 5 50544 hausmann 2010-03-13 15:49:24 -0800 Comment on attachment 50544 patch for the bug #36034 > - m_layer.data()->setOpacity(qMin<qreal>(qMax<qreal>(fromValue + (toValue-fromValue)*progress, 0), 1)); > + qreal opacity = qBound(qreal(0), fromValue + (toValue-fromValue)*progress, qreal(1)); > + > + // FIXME: this is a hack, due to a probable QGraphicsScene bug. > + // Without this the opacity change doesn't always have immediate effect. > + if (!m_layer.data()->opacity() && opacity) > + m_layer.data()->scene()->update(); > + > + m_layer.data()->setOpacity(opacity); It would be good to get a sign-off from Noam on this one and also add a comment here with a link to the bugreport at http://bugreports.qt.nokia.com/ . Updating the entire scene is obviously a very expensive operation, so it would be good to know when we can remove this workaround in the future. 199435 6 noam 2010-03-13 17:43:47 -0800 I did a smoke test to this - signed off! 199437 7 noam 2010-03-13 17:47:23 -0800 I intend to collect Qt bugs that we needed to work-around to try to look at them deeply with Qt R&D. 199456 8 hausmann 2010-03-14 00:56:35 -0800 (In reply to comment #7) > I intend to collect Qt bugs that we needed to work-around to try to look at > them deeply with Qt R&D. Excellent, thanks! 200230 9 noam 2010-03-16 09:05:00 -0700 Apparently http://bugreports.qt.nokia.com/browse/QTBUG-7714 was already reported and being worked on. 201872 10 hausmann 2010-03-19 09:01:48 -0700 (In reply to comment #9) > Apparently http://bugreports.qt.nokia.com/browse/QTBUG-7714 was already > reported and being worked on. Excellent, looks like the fix is in Qt 4.6.2, which is released. I think we should place an #ifdef around the update at least, to take the faster code path without the expensive update for Qt versions >= 4.6.2. 202477 11 51282 kim.1.gronholm 2010-03-22 07:32:50 -0700 Created attachment 51282 ifdef the QTBUG-7714 workaround for qt versions lower than 4.6.2 Added the Qt version check as Simon suggested. 202513 12 hausmann 2010-03-22 08:47:09 -0700 Thanks Kim and Kenneth :) 50541 2010-03-11 14:33:57 -0800 2010-03-11 14:33:57 -0800 Opacity transition from 0 to 1 in 5s opacity-anim-from-zero.html text/html 533 kim.1.gronholm PCFET0NUWVBFIEhUTUwgUFVCTElDICItLy9XM0MvL0RURCBIVE1MIDQuMDEvL0VOIj4KPGh0bWw+ CiAgPGhlYWQ+CiAgICA8dGl0bGU+T3BhY2l0eSB0cmFuc2l0aW9uIHRlc3Q8L3RpdGxlPgogICAg PHN0eWxlPgpkaXYgewogd2lkdGg6IDIwMHB4OwogaGVpZ2h0OiAyMDBweDsKIG9wYWNpdHk6IDA7 CiBiYWNrZ3JvdW5kLWNvbG9yOiMwMDA7CiAtd2Via2l0LXRyYW5zZm9ybTogcm90YXRlWCgwZGVn KTsKIC13ZWJraXQtdHJhbnNpdGlvbi1wcm9wZXJ0eTogb3BhY2l0eTsKIC13ZWJraXQtdHJhbnNp dGlvbi1kdXJhdGlvbjogMTBzOwp9CiAgICA8L3N0eWxlPgoKICAgIDxzY3JpcHQ+CnNldFRpbWVv dXQoImRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdkMScpLnN0eWxlLm9wYWNpdHkgPSAnMSc7Iiwg MTAwKTsKICAgIDwvc2NyaXB0PgoKICA8L2hlYWQ+CiAgPGJvZHk+CiAgICBPcGFjaXR5IHRyYW5z aXRpb24gZnJvbSAwIHRvIDEuMCBpbiBvbmUgc2Vjb25kOgogICAgPGRpdiBpZD0iZDEiPjwvZGl2 PgogIDwvYm9keT4KPC9odG1sPgo= 50544 2010-03-11 14:44:06 -0800 2010-03-13 15:49:24 -0800 patch for the bug #36034 patch-36034.diff text/plain 1600 kim.1.gronholm ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ODJmNjdmZi4uZjk4NDI4YyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMC0wMy0xMSAgS2ltIEdyw7ZuaG9s bSAgPGtpbS5ncm9uaG9sbUBub21vdm9rLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdIEdyYXBoaWNzTGF5ZXI6IE9wYWNpdHkgY2hhbmdl IGZyb20gemVybyB0byBub24temVybyBkb2Vzbid0IGFsd2F5cyBoYXZlIGVmZmVjdCB3aXRoIEFD CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNjAzNAor CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvcXQvR3JhcGhpY3NMYXllclF0LmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6Ok9wYWNpdHlBbmltYXRpb25RdDo6YXBwbHlGcmFtZSk6CisKIDIwMTAt MDMtMTEgIEtlbm5ldGggUnVzc2VsbCAgPGtickBnb29nbGUuY29tPgogCiAgICAgICAgIFJldmll d2VkIGJ5IERpbWl0cmkgR2xhemtvdi4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvcXQvR3JhcGhpY3NMYXllclF0LmNwcCBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv cXQvR3JhcGhpY3NMYXllclF0LmNwcAppbmRleCA5YTJlOTMyLi43MzcyMzRiIDEwMDY0NAotLS0g YS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L0dyYXBoaWNzTGF5ZXJRdC5jcHAKKysrIGIv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9HcmFwaGljc0xheWVyUXQuY3BwCkBAIC0xMTM0 LDcgKzExMzQsMTQgQEAgcHVibGljOgogCiAgICAgdmlydHVhbCB2b2lkIGFwcGx5RnJhbWUoY29u c3QgcXJlYWwmIGZyb21WYWx1ZSwgY29uc3QgcXJlYWwmIHRvVmFsdWUsIHFyZWFsIHByb2dyZXNz KQogICAgIHsKLSAgICAgICAgbV9sYXllci5kYXRhKCktPnNldE9wYWNpdHkocU1pbjxxcmVhbD4o cU1heDxxcmVhbD4oZnJvbVZhbHVlICsgKHRvVmFsdWUtZnJvbVZhbHVlKSpwcm9ncmVzcywgMCks IDEpKTsKKyAgICAgICAgcXJlYWwgb3BhY2l0eSA9IHFCb3VuZChxcmVhbCgwKSwgZnJvbVZhbHVl ICsgKHRvVmFsdWUtZnJvbVZhbHVlKSpwcm9ncmVzcywgcXJlYWwoMSkpOworCisgICAgICAgIC8v IEZJWE1FOiB0aGlzIGlzIGEgaGFjaywgZHVlIHRvIGEgcHJvYmFibGUgUUdyYXBoaWNzU2NlbmUg YnVnLgorICAgICAgICAvLyBXaXRob3V0IHRoaXMgdGhlIG9wYWNpdHkgY2hhbmdlIGRvZXNuJ3Qg YWx3YXlzIGhhdmUgaW1tZWRpYXRlIGVmZmVjdC4KKyAgICAgICAgaWYgKCFtX2xheWVyLmRhdGEo KS0+b3BhY2l0eSgpICYmIG9wYWNpdHkpCisgICAgICAgICAgICBtX2xheWVyLmRhdGEoKS0+c2Nl bmUoKS0+dXBkYXRlKCk7CisKKyAgICAgICAgbV9sYXllci5kYXRhKCktPnNldE9wYWNpdHkob3Bh Y2l0eSk7CiAgICAgfQogCiAgICAgdmlydHVhbCB2b2lkIHVwZGF0ZVN0YXRlKFFBYnN0cmFjdEFu aW1hdGlvbjo6U3RhdGUgbmV3U3RhdGUsIFFBYnN0cmFjdEFuaW1hdGlvbjo6U3RhdGUgb2xkU3Rh dGUpCg== 51282 2010-03-22 07:32:50 -0700 2010-03-22 07:35:44 -0700 ifdef the QTBUG-7714 workaround for qt versions lower than 4.6.2 opacity-workaround-ifdef text/plain 1723 kim.1.gronholm ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZTFjMmI3NS4uMDEwODg0NiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxMC0wMy0yMiAgS2ltIEdyw7ZuaG9s bSAgPGtpbS5ncm9uaG9sbUBub21vdm9rLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdIEdyYXBoaWNzTGF5ZXI6IE9wYWNpdHkgY2hhbmdl IGZyb20gemVybyB0byBub24temVybyBkb2Vzbid0IGFsd2F5cyBoYXZlIGVmZmVjdCB3aXRoIEFD CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNjAzNAor CisgICAgICAgIFRoZSBRdCBidWcgKFFUQlVHLTc3MTQpIGNhdXNpbmcgdGhlIGlzc3VlIHdhcyBm aXhlZCBpbiBRdCA0LjYuMiwKKyAgICAgICAgc2VlOiBodHRwOi8vYnVncmVwb3J0cy5xdC5ub2tp YS5jb20vYnJvd3NlL1FUQlVHLTc3MTQKKyAgICAgICAgVGhlcmVmb3JlIHRoZSBjdXJyZW50IHdv cmthcm91bmQgaXMgbm90IG5lZWRlZCB3aXRoIFF0IHZlcnNpb25zIAorICAgICAgICA0LjYuMiBh bmQgaGlnaGVyIGFuZCBpdCdzIGJldHRlciBub3QgdG8gd2FzdGUgdGltZSBvbiBzY2VuZSgpLT51 cGRhdGUoKS4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL3F0L0dyYXBoaWNzTGF5ZXJR dC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpPcGFjaXR5QW5pbWF0aW9uUXQ6OmFwcGx5RnJhbWUp OgorCiAyMDEwLTAzLTIxICBLaW0gR3LDtm5ob2xtICA8a2ltLmdyb25ob2xtQG5vbW92b2suY29t PgogCiAgICAgICAgIFJldmlld2VkIGJ5IFNpbW9uIEhhdXNtYW5uLgpkaWZmIC0tZ2l0IGEvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9HcmFwaGljc0xheWVyUXQuY3BwIGIvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9xdC9HcmFwaGljc0xheWVyUXQuY3BwCmluZGV4IDY1YzUxZjkuLmZm MmY2MmUgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvR3JhcGhpY3NM YXllclF0LmNwcAorKysgYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L0dyYXBoaWNzTGF5 ZXJRdC5jcHAKQEAgLTExODksMTAgKzExODksMTEgQEAgcHVibGljOgogICAgIHsKICAgICAgICAg cXJlYWwgb3BhY2l0eSA9IHFCb3VuZChxcmVhbCgwKSwgZnJvbVZhbHVlICsgKHRvVmFsdWUtZnJv bVZhbHVlKSpwcm9ncmVzcywgcXJlYWwoMSkpOwogCi0gICAgICAgIC8vIEZJWE1FOiB0aGlzIGlz IGEgaGFjaywgZHVlIHRvIGEgcHJvYmFibGUgUUdyYXBoaWNzU2NlbmUgYnVnLgotICAgICAgICAv LyBXaXRob3V0IHRoaXMgdGhlIG9wYWNpdHkgY2hhbmdlIGRvZXNuJ3QgYWx3YXlzIGhhdmUgaW1t ZWRpYXRlIGVmZmVjdC4KKyNpZiBRVF9WRVJTSU9OIDwgUVRfVkVSU0lPTl9DSEVDSyg0LCA2LCAy KQorICAgICAgICAvLyBUaGlzIGlzIGEgd29ya2Fyb3VuZCBmb3IgUVRCVUctNzcxNCB3aGljaCB3 YXMgZml4ZWQgaW4gUXQgNC42LjIKICAgICAgICAgaWYgKCFtX2xheWVyLmRhdGEoKS0+b3BhY2l0 eSgpICYmIG9wYWNpdHkpCiAgICAgICAgICAgICBtX2xheWVyLmRhdGEoKS0+c2NlbmUoKS0+dXBk YXRlKCk7CisjZW5kaWYKIAogICAgICAgICBtX2xheWVyLmRhdGEoKS0+c2V0T3BhY2l0eShvcGFj aXR5KTsKICAgICB9Cg==