36032 2010-03-11 14:20:16 -0800 rebaseline_chromium_webkit_tests doesn't handle port correctly 2010-03-11 16:51:36 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 1 victorw victorw dglazkov dpranke hamaji ojan oldest_to_newest 198772 0 victorw 2010-03-11 14:20:16 -0800 Rebaseline_chromium_webkit_tests does not handle port correctly. It needs to have two ports in Rebaseliner: one is the port the script is running on and another one for the port to be rebaselined. For more details, see comments in https://bugs.webkit.org/show_bug.cgi?id=35982. 198794 1 50547 victorw 2010-03-11 14:54:03 -0800 Created attachment 50547 Proposed patch 198795 2 50548 victorw 2010-03-11 14:56:16 -0800 Created attachment 50548 Fixed tab in ChangeLog 198826 3 victorw 2010-03-11 16:12:37 -0800 Hi Dirk, Could you take a look at this patch? Thanks! 198829 4 50548 dpranke 2010-03-11 16:31:55 -0800 Comment on attachment 50548 Fixed tab in ChangeLog Looks more or less correct. Assuming you've tested this, LGTM. 198831 5 50548 dglazkov 2010-03-11 16:32:57 -0800 Comment on attachment 50548 Fixed tab in ChangeLog ok! 198847 6 victorw 2010-03-11 16:51:36 -0800 Committed r55868: <http://trac.webkit.org/changeset/55868> 50547 2010-03-11 14:54:03 -0800 2010-03-11 14:56:16 -0800 Proposed patch rebaseline.patch text/plain 3695 victorw SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDU1ODU2KQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTAtMDMtMTEgIFZpY3RvciBXYW5nICA8dmlj dG9yd0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgcmViYXNlbGluZV9jaHJvbWl1bV93ZWJraXRfdGVzdHMgY2FuIGdlbmVyYXRl IG5ldyBiYXNlbGluZXMgZm9yCisgICAgICAgIGFsbCBwbGF0Zm9ybXMgc28gaXQgbmVlZHMgdG8g a25vdyB0d28gcG9ydHMgaW4gb3JkZXIgdG8gd29yayBjb3JyZWN0bHk6CisgICAgICAgIHRoZSBw b3J0IHRoYXQgdGhlIHNjcmlwdCBpcyBydW5uaW5nIG9uIGFuZCB0aGUgcG9ydCB0aGF0IGl0IGdl bmVyYXRlcworICAgICAgICBuZXcgYmFzZWxpbmVzIGZvci4gVXBkYXRlIHJlYmFzZWxpbmluZyB0 b29sIHRvIGhhbmRsZSBib3RoIHBvcnQgY29ycmVjdGx5LgorCisJaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTM2MDMyCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5 L2xheW91dF90ZXN0cy9yZWJhc2VsaW5lX2Nocm9taXVtX3dlYmtpdF90ZXN0cy5weToKKwogMjAx MC0wMy0xMCAgRGlyayBQcmFua2UgIDxkcHJhbmtlQGNocm9taXVtLm9yZz4KIAogICAgICAgICBS ZXZpZXdlZCBieSBEaW1pdHJpIEdsYXprb3YuCkluZGV4OiBXZWJLaXRUb29scy9TY3JpcHRzL3dl YmtpdHB5L2xheW91dF90ZXN0cy9yZWJhc2VsaW5lX2Nocm9taXVtX3dlYmtpdF90ZXN0cy5weQo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9y ZWJhc2VsaW5lX2Nocm9taXVtX3dlYmtpdF90ZXN0cy5weQkocmV2aXNpb24gNTU4NTUpCisrKyBX ZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9yZWJhc2VsaW5lX2Nocm9t aXVtX3dlYmtpdF90ZXN0cy5weQkod29ya2luZyBjb3B5KQpAQCAtMjAzLDEyICsyMDMsMTYgQEAg Y2xhc3MgUmViYXNlbGluZXIob2JqZWN0KToKIAogICAgIFJFVklTSU9OX1JFR0VYID0gcic8YSBo cmVmPVwiKFxkKykvXCI+JwogCi0gICAgZGVmIF9faW5pdF9fKHNlbGYsIHBvcnQsIHBsYXRmb3Jt LCBvcHRpb25zKToKLSAgICAgICAgc2VsZi5fZmlsZV9kaXIgPSBwb3J0LnBhdGhfZnJvbV9jaHJv bWl1bV9iYXNlKCd3ZWJraXQnLCAndG9vbHMnLAotICAgICAgICAgICAgJ2xheW91dF90ZXN0cycp Ci0gICAgICAgIHNlbGYuX3BvcnQgPSBwb3J0CisgICAgZGVmIF9faW5pdF9fKHNlbGYsIHJ1bm5p bmdfcG9ydCwgcGxhdGZvcm0sIG9wdGlvbnMpOgorICAgICAgICBzZWxmLl9maWxlX2RpciA9IHJ1 bm5pbmdfcG9ydC5wYXRoX2Zyb21fY2hyb21pdW1fYmFzZSgKKyAgICAgICAgICAgICd3ZWJraXQn LCAndG9vbHMnLCAnbGF5b3V0X3Rlc3RzJykKICAgICAgICAgc2VsZi5fcGxhdGZvcm0gPSBwbGF0 Zm9ybQogICAgICAgICBzZWxmLl9vcHRpb25zID0gb3B0aW9ucworICAgICAgICAjIFRoaXMgaXMg dGhlIHBvcnQgdGhhdCB0aGUgc2NyaXB0IGlzIHJ1bm5pbmcgb24uCisgICAgICAgIHNlbGYuX3Bv cnQgPSBydW5uaW5nX3BvcnQKKyAgICAgICAgIyBUaGlzIGlzIHRoZSBwb3J0IHRoYXQgdGhlIHJl YmFzZWxpbmluZyB0b29sIGNyZWF0ZXMgbmV3IGJhc2VsaW5lcyBmb3IuCisgICAgICAgIHNlbGYu X3JlYmFzZWxpbmVfcG9ydCA9IHBvcnQuZ2V0KAorICAgICAgICAgICAgc2VsZi5fcG9ydC50ZXN0 X3BsYXRmb3JtX25hbWVfdG9fbmFtZShwbGF0Zm9ybSksIG9wdGlvbnMpCiAgICAgICAgIHNlbGYu X3JlYmFzZWxpbmluZ190ZXN0cyA9IFtdCiAgICAgICAgIHNlbGYuX3JlYmFzZWxpbmVkX3Rlc3Rz ID0gW10KIApAQCAtMjE2LDkgKzIyMCw5IEBAIGNsYXNzIFJlYmFzZWxpbmVyKG9iamVjdCk6CiAg ICAgICAgICMgICAtLiBjb21waWxlIGxpc3Qgb2YgdGVzdHMgdGhhdCBuZWVkIHJlYmFzZWxpbmlu Zy4KICAgICAgICAgIyAgIC0uIHVwZGF0ZSB0aGUgdGVzdHMgaW4gdGVzdF9leHBlY3RhdGlvbnMg ZmlsZSBhZnRlciByZWJhc2VsaW5lCiAgICAgICAgICMgICAgICBpcyBkb25lLgotICAgICAgICBl eHBlY3RhdGlvbnNfc3RyID0gc2VsZi5fcG9ydC50ZXN0X2V4cGVjdGF0aW9ucygpCisgICAgICAg IGV4cGVjdGF0aW9uc19zdHIgPSBzZWxmLl9yZWJhc2VsaW5lX3BvcnQudGVzdF9leHBlY3RhdGlv bnMoKQogICAgICAgICBzZWxmLl90ZXN0X2V4cGVjdGF0aW9ucyA9IFwKLSAgICAgICAgICAgIHRl c3RfZXhwZWN0YXRpb25zLlRlc3RFeHBlY3RhdGlvbnMoc2VsZi5fcG9ydCwKKyAgICAgICAgICAg IHRlc3RfZXhwZWN0YXRpb25zLlRlc3RFeHBlY3RhdGlvbnMoc2VsZi5fcmViYXNlbGluZV9wb3J0 LAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBOb25lLAog ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBleHBlY3RhdGlv bnNfc3RyLAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBz ZWxmLl9wbGF0Zm9ybSwKQEAgLTQwNCw3ICs0MDgsOCBAQCBjbGFzcyBSZWJhc2VsaW5lcihvYmpl Y3QpOgogICAgICAgICBmb3IgbmFtZSBpbiB6aXBfbmFtZWxpc3Q6CiAgICAgICAgICAgICBfbG9n LmRlYnVnKCcgICcgKyBuYW1lKQogCi0gICAgICAgIHBsYXRmb3JtID0gc2VsZi5fcG9ydC50ZXN0 X3BsYXRmb3JtX25hbWVfdG9fbmFtZShzZWxmLl9wbGF0Zm9ybSkKKyAgICAgICAgcGxhdGZvcm0g PSBzZWxmLl9yZWJhc2VsaW5lX3BvcnQudGVzdF9wbGF0Zm9ybV9uYW1lX3RvX25hbWUoCisgICAg ICAgICAgICBzZWxmLl9wbGF0Zm9ybSkKICAgICAgICAgX2xvZy5kZWJ1ZygnUGxhdGZvcm0gZGly OiAiJXMiJywgcGxhdGZvcm0pCiAKICAgICAgICAgdGVzdF9ubyA9IDEKQEAgLTUwMyw4ICs1MDgs OCBAQCBjbGFzcyBSZWJhc2VsaW5lcihvYmplY3QpOgogICAgICAgICAgIEZhbHNlIG90aGVyd2lz ZS4KICAgICAgICAgIiIiCiAgICAgICAgIHRlc3RfZmlsZXBhdGggPSBvcy5wYXRoLmpvaW4oc2Vs Zi5fcG9ydC5sYXlvdXRfdGVzdHNfZGlyKCksIHRlc3QpCi0gICAgICAgIGFsbF9iYXNlbGluZXMg PSBzZWxmLl9wb3J0LmV4cGVjdGVkX2Jhc2VsaW5lcyh0ZXN0X2ZpbGVwYXRoLAotICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgc3VmZml4LCBUcnVl KQorICAgICAgICBhbGxfYmFzZWxpbmVzID0gc2VsZi5fcmViYXNlbGluZV9wb3J0LmV4cGVjdGVk X2Jhc2VsaW5lcygKKyAgICAgICAgICAgIHRlc3RfZmlsZXBhdGgsIHN1ZmZpeCwgVHJ1ZSkKICAg ICAgICAgZm9yIChmYWxsYmFja19kaXIsIGZhbGxiYWNrX2ZpbGUpIGluIGFsbF9iYXNlbGluZXM6 CiAgICAgICAgICAgICBpZiBmYWxsYmFja19kaXIgYW5kIGZhbGxiYWNrX2ZpbGU6CiAgICAgICAg ICAgICAgICAgZmFsbGJhY2tfZnVsbHBhdGggPSBvcy5wYXRoLm5vcm1wYXRoKAo= 50548 2010-03-11 14:56:16 -0800 2010-03-11 16:32:57 -0800 Fixed tab in ChangeLog rebaseline.patch text/plain 3702 victorw SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDU1ODU2KQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTAtMDMtMTEgIFZpY3RvciBXYW5nICA8dmlj dG9yd0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgcmViYXNlbGluZV9jaHJvbWl1bV93ZWJraXRfdGVzdHMgY2FuIGdlbmVyYXRl IG5ldyBiYXNlbGluZXMgZm9yCisgICAgICAgIGFsbCBwbGF0Zm9ybXMgc28gaXQgbmVlZHMgdG8g a25vdyB0d28gcG9ydHMgaW4gb3JkZXIgdG8gd29yayBjb3JyZWN0bHk6CisgICAgICAgIHRoZSBw b3J0IHRoYXQgdGhlIHNjcmlwdCBpcyBydW5uaW5nIG9uIGFuZCB0aGUgcG9ydCB0aGF0IGl0IGdl bmVyYXRlcworICAgICAgICBuZXcgYmFzZWxpbmVzIGZvci4gVXBkYXRlIHJlYmFzZWxpbmluZyB0 b29sIHRvIGhhbmRsZSBib3RoIHBvcnQgY29ycmVjdGx5LgorCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNjAzMgorCisgICAgICAgICogU2NyaXB0cy93 ZWJraXRweS9sYXlvdXRfdGVzdHMvcmViYXNlbGluZV9jaHJvbWl1bV93ZWJraXRfdGVzdHMucHk6 CisKIDIwMTAtMDMtMTAgIERpcmsgUHJhbmtlICA8ZHByYW5rZUBjaHJvbWl1bS5vcmc+CiAKICAg ICAgICAgUmV2aWV3ZWQgYnkgRGltaXRyaSBHbGF6a292LgpJbmRleDogV2ViS2l0VG9vbHMvU2Ny aXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcmViYXNlbGluZV9jaHJvbWl1bV93ZWJraXRfdGVz dHMucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRf dGVzdHMvcmViYXNlbGluZV9jaHJvbWl1bV93ZWJraXRfdGVzdHMucHkJKHJldmlzaW9uIDU1ODU1 KQorKysgV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcmViYXNlbGlu ZV9jaHJvbWl1bV93ZWJraXRfdGVzdHMucHkJKHdvcmtpbmcgY29weSkKQEAgLTIwMywxMiArMjAz LDE2IEBAIGNsYXNzIFJlYmFzZWxpbmVyKG9iamVjdCk6CiAKICAgICBSRVZJU0lPTl9SRUdFWCA9 IHInPGEgaHJlZj1cIihcZCspL1wiPicKIAotICAgIGRlZiBfX2luaXRfXyhzZWxmLCBwb3J0LCBw bGF0Zm9ybSwgb3B0aW9ucyk6Ci0gICAgICAgIHNlbGYuX2ZpbGVfZGlyID0gcG9ydC5wYXRoX2Zy b21fY2hyb21pdW1fYmFzZSgnd2Via2l0JywgJ3Rvb2xzJywKLSAgICAgICAgICAgICdsYXlvdXRf dGVzdHMnKQotICAgICAgICBzZWxmLl9wb3J0ID0gcG9ydAorICAgIGRlZiBfX2luaXRfXyhzZWxm LCBydW5uaW5nX3BvcnQsIHBsYXRmb3JtLCBvcHRpb25zKToKKyAgICAgICAgc2VsZi5fZmlsZV9k aXIgPSBydW5uaW5nX3BvcnQucGF0aF9mcm9tX2Nocm9taXVtX2Jhc2UoCisgICAgICAgICAgICAn d2Via2l0JywgJ3Rvb2xzJywgJ2xheW91dF90ZXN0cycpCiAgICAgICAgIHNlbGYuX3BsYXRmb3Jt ID0gcGxhdGZvcm0KICAgICAgICAgc2VsZi5fb3B0aW9ucyA9IG9wdGlvbnMKKyAgICAgICAgIyBU aGlzIGlzIHRoZSBwb3J0IHRoYXQgdGhlIHNjcmlwdCBpcyBydW5uaW5nIG9uLgorICAgICAgICBz ZWxmLl9wb3J0ID0gcnVubmluZ19wb3J0CisgICAgICAgICMgVGhpcyBpcyB0aGUgcG9ydCB0aGF0 IHRoZSByZWJhc2VsaW5pbmcgdG9vbCBjcmVhdGVzIG5ldyBiYXNlbGluZXMgZm9yLgorICAgICAg ICBzZWxmLl9yZWJhc2VsaW5lX3BvcnQgPSBwb3J0LmdldCgKKyAgICAgICAgICAgIHNlbGYuX3Bv cnQudGVzdF9wbGF0Zm9ybV9uYW1lX3RvX25hbWUocGxhdGZvcm0pLCBvcHRpb25zKQogICAgICAg ICBzZWxmLl9yZWJhc2VsaW5pbmdfdGVzdHMgPSBbXQogICAgICAgICBzZWxmLl9yZWJhc2VsaW5l ZF90ZXN0cyA9IFtdCiAKQEAgLTIxNiw5ICsyMjAsOSBAQCBjbGFzcyBSZWJhc2VsaW5lcihvYmpl Y3QpOgogICAgICAgICAjICAgLS4gY29tcGlsZSBsaXN0IG9mIHRlc3RzIHRoYXQgbmVlZCByZWJh c2VsaW5pbmcuCiAgICAgICAgICMgICAtLiB1cGRhdGUgdGhlIHRlc3RzIGluIHRlc3RfZXhwZWN0 YXRpb25zIGZpbGUgYWZ0ZXIgcmViYXNlbGluZQogICAgICAgICAjICAgICAgaXMgZG9uZS4KLSAg ICAgICAgZXhwZWN0YXRpb25zX3N0ciA9IHNlbGYuX3BvcnQudGVzdF9leHBlY3RhdGlvbnMoKQor ICAgICAgICBleHBlY3RhdGlvbnNfc3RyID0gc2VsZi5fcmViYXNlbGluZV9wb3J0LnRlc3RfZXhw ZWN0YXRpb25zKCkKICAgICAgICAgc2VsZi5fdGVzdF9leHBlY3RhdGlvbnMgPSBcCi0gICAgICAg ICAgICB0ZXN0X2V4cGVjdGF0aW9ucy5UZXN0RXhwZWN0YXRpb25zKHNlbGYuX3BvcnQsCisgICAg ICAgICAgICB0ZXN0X2V4cGVjdGF0aW9ucy5UZXN0RXhwZWN0YXRpb25zKHNlbGYuX3JlYmFzZWxp bmVfcG9ydCwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg Tm9uZSwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZXhw ZWN0YXRpb25zX3N0ciwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgc2VsZi5fcGxhdGZvcm0sCkBAIC00MDQsNyArNDA4LDggQEAgY2xhc3MgUmViYXNlbGlu ZXIob2JqZWN0KToKICAgICAgICAgZm9yIG5hbWUgaW4gemlwX25hbWVsaXN0OgogICAgICAgICAg ICAgX2xvZy5kZWJ1ZygnICAnICsgbmFtZSkKIAotICAgICAgICBwbGF0Zm9ybSA9IHNlbGYuX3Bv cnQudGVzdF9wbGF0Zm9ybV9uYW1lX3RvX25hbWUoc2VsZi5fcGxhdGZvcm0pCisgICAgICAgIHBs YXRmb3JtID0gc2VsZi5fcmViYXNlbGluZV9wb3J0LnRlc3RfcGxhdGZvcm1fbmFtZV90b19uYW1l KAorICAgICAgICAgICAgc2VsZi5fcGxhdGZvcm0pCiAgICAgICAgIF9sb2cuZGVidWcoJ1BsYXRm b3JtIGRpcjogIiVzIicsIHBsYXRmb3JtKQogCiAgICAgICAgIHRlc3Rfbm8gPSAxCkBAIC01MDMs OCArNTA4LDggQEAgY2xhc3MgUmViYXNlbGluZXIob2JqZWN0KToKICAgICAgICAgICBGYWxzZSBv dGhlcndpc2UuCiAgICAgICAgICIiIgogICAgICAgICB0ZXN0X2ZpbGVwYXRoID0gb3MucGF0aC5q b2luKHNlbGYuX3BvcnQubGF5b3V0X3Rlc3RzX2RpcigpLCB0ZXN0KQotICAgICAgICBhbGxfYmFz ZWxpbmVzID0gc2VsZi5fcG9ydC5leHBlY3RlZF9iYXNlbGluZXModGVzdF9maWxlcGF0aCwKLSAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHN1ZmZp eCwgVHJ1ZSkKKyAgICAgICAgYWxsX2Jhc2VsaW5lcyA9IHNlbGYuX3JlYmFzZWxpbmVfcG9ydC5l eHBlY3RlZF9iYXNlbGluZXMoCisgICAgICAgICAgICB0ZXN0X2ZpbGVwYXRoLCBzdWZmaXgsIFRy dWUpCiAgICAgICAgIGZvciAoZmFsbGJhY2tfZGlyLCBmYWxsYmFja19maWxlKSBpbiBhbGxfYmFz ZWxpbmVzOgogICAgICAgICAgICAgaWYgZmFsbGJhY2tfZGlyIGFuZCBmYWxsYmFja19maWxlOgog ICAgICAgICAgICAgICAgIGZhbGxiYWNrX2Z1bGxwYXRoID0gb3MucGF0aC5ub3JtcGF0aCgK