<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>36020</bug_id>
          
          <creation_ts>2010-03-11 10:11:18 -0800</creation_ts>
          <short_desc>Spatial Navigation: Add a scrollIntoView call when focusing an element.</short_desc>
          <delta_ts>2010-03-16 06:48:17 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Accessibility</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>18662</dependson>
          <blocked>35984</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Antonio Gomes">tonikitoo</reporter>
          <assigned_to name="Antonio Gomes">tonikitoo</assigned_to>
          <cc>kenneth</cc>
    
    <cc>simon.fraser</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>198666</commentid>
    <comment_count>0</comment_count>
    <who name="Antonio Gomes">tonikitoo</who>
    <bug_when>2010-03-11 10:11:18 -0800</bug_when>
    <thetext>In the current Spatial Navigation logic, for an element to get the focus it just needs to be partially visible (in current viewport), not completely.

Even calling |element-&gt;focus()| does not necessarily bring element&apos;s rect to be completely visible in cases where it is already partially visible.

I think it would be nice to call &apos;element-&gt;scrollIntoView&apos; for that.

patch coming ...</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>198669</commentid>
    <comment_count>1</comment_count>
      <attachid>50515</attachid>
    <who name="Antonio Gomes">tonikitoo</who>
    <bug_when>2010-03-11 10:15:24 -0800</bug_when>
    <thetext>Created attachment 50515
patch 0.1

Calls element-&gt;scrollIntoView() before element-&gt;focus();</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>199145</commentid>
    <comment_count>2</comment_count>
      <attachid>50614</attachid>
    <who name="Antonio Gomes">tonikitoo</who>
    <bug_when>2010-03-12 11:25:36 -0800</bug_when>
    <thetext>Created attachment 50614
patch 0.2 - add a custom scrollIntoView method

Added a helper scrollIntoView in SpatialNavigation.h. There a inflate operation is performed before scrolling.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>199669</commentid>
    <comment_count>3</comment_count>
      <attachid>50711</attachid>
    <who name="Antonio Gomes">tonikitoo</who>
    <bug_when>2010-03-15 08:35:30 -0700</bug_when>
    <thetext>Created attachment 50711
patch 0.3 - same as 0.2 + adds a better ChangeLog entry

Simon, could you help me w/ that one?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>199739</commentid>
    <comment_count>4</comment_count>
      <attachid>50711</attachid>
    <who name="Simon Fraser (smfr)">simon.fraser</who>
    <bug_when>2010-03-15 12:08:51 -0700</bug_when>
    <thetext>Comment on attachment 50711
patch 0.3 - same as 0.2 + adds a better ChangeLog entry


&gt; +void scrollIntoView(Element* element)
&gt; +{
&gt; +    // NOTE: Element&apos;s scrollIntoView method could had been used here, but
&gt; +    // it is preferable to inflate |element|&apos;s bounding rect a bit before
&gt; +    // scrolling it for accurate reason.
&gt; +    // Element&apos;s scrollIntoView method does not provide this flexibility.
&gt; +    static const int fudgeFactor = 2;

Shouldn&apos;t this be related to the platform&apos;s focus outline width? That information doesn&apos;t seem to be available, though.

r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>200162</commentid>
    <comment_count>5</comment_count>
    <who name="Antonio Gomes">tonikitoo</who>
    <bug_when>2010-03-16 06:47:35 -0700</bug_when>
    <thetext>&gt; &gt; +void scrollIntoView(Element* element)
&gt; &gt; +{
&gt; &gt; +    // NOTE: Element&apos;s scrollIntoView method could had been used here, but
&gt; &gt; +    // it is preferable to inflate |element|&apos;s bounding rect a bit before
&gt; &gt; +    // scrolling it for accurate reason.
&gt; &gt; +    // Element&apos;s scrollIntoView method does not provide this flexibility.
&gt; &gt; +    static const int fudgeFactor = 2;
&gt; 
&gt; Shouldn&apos;t this be related to the platform&apos;s focus outline width? That
&gt; information doesn&apos;t seem to be available, though.

I can check that, for sure, Simon.

&gt; r=me

thx again


Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	LayoutTests/ChangeLog
	M	LayoutTests/platform/gtk/Skipped
	M	WebCore/ChangeLog
	M	WebCore/page/FocusController.cpp
	M	WebCore/page/SpatialNavigation.cpp
	M	WebCore/page/SpatialNavigation.h
Committed r56057
	M	WebCore/ChangeLog
	M	WebCore/page/SpatialNavigation.h
	M	WebCore/page/FocusController.cpp
	M	WebCore/page/SpatialNavigation.cpp
	M	LayoutTests/platform/gtk/Skipped
	M	LayoutTests/ChangeLog

r56057 = 4d0624cd978ee7b14b78500555f896a081b40466 (trunk)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>200163</commentid>
    <comment_count>6</comment_count>
    <who name="Antonio Gomes">tonikitoo</who>
    <bug_when>2010-03-16 06:48:17 -0700</bug_when>
    <thetext>I had a talk to Kenneth about the desired behaviour of scrolling actions when running Spatial Navigation on a mobo device. It turns out that most of the current browser clients that use it (via a fake mouse point or not) keep the focusable element (and the fake mouse point) on the center of the screen when possible. It will be addressed on its own bug. Current behaviour, matches Opera&apos;s destop browser.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>50515</attachid>
            <date>2010-03-11 10:15:24 -0800</date>
            <delta_ts>2010-03-12 11:25:36 -0800</delta_ts>
            <desc>patch 0.1</desc>
            <filename>0001-Spatial-Navigation-Add-a-scrollIntoView-call-when-f.patch</filename>
            <type>text/plain</type>
            <size>3179</size>
            <attacher name="Antonio Gomes">tonikitoo</attacher>
            
              <data encoding="base64">RnJvbSBmY2UyMWJmY2IyNjEwOThjYzBlM2I2OGY2ZDQ4OTA1ZDZiOTc1NDA3IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBBbnRvbmlvIEdvbWVzIDx0b25pa2l0b29Ad2Via2l0Lm9yZz4K
RGF0ZTogVGh1LCAxMSBNYXIgMjAxMCAxNDoxMzo0NCAtMDQwMApTdWJqZWN0OiBbUEFUQ0hdIFNw
YXRpYWwgTmF2aWdhdGlvbjogQWRkIGEgc2Nyb2xsSW50b1ZpZXcgY2FsbCB3aGVuIGZvY3VzaW5n
IGFuIGVsZW1lbnQuCiBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzYw
MjAKClJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgpQYXRjaCBieSBBbnRvbmlvIEdvbWVzIDx0
b25pa2l0b29Ad2Via2l0Lm9yZz4KCldlYkNvcmU6CgoqIHBhZ2UvRm9jdXNDb250cm9sbGVyLmNw
cDoKKFdlYkNvcmU6OkZvY3VzQ29udHJvbGxlcjo6YWR2YW5jZUZvY3VzRGlyZWN0aW9uYWxseSk6
CgpMYXlvdXRUZXN0czoKCiogcGxhdGZvcm0vZ3RrL1NraXBwZWQ6IFVuc2tpcCBzbmF2LWlmcmFt
ZS13aXRoLW9mZnNjcmVlbi1lbGVtZW50Lmh0bWwKLS0tCiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cg
ICAgICAgICAgICB8ICAgIDkgKysrKysrKysrCiBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvU2tp
cHBlZCB8ICAgIDQgLS0tLQogV2ViQ29yZS9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgfCAgIDEw
ICsrKysrKysrKysKIFdlYkNvcmUvcGFnZS9Gb2N1c0NvbnRyb2xsZXIuY3BwIHwgICAgNiArKysr
Ky0KIDQgZmlsZXMgY2hhbmdlZCwgMjQgaW5zZXJ0aW9ucygrKSwgNSBkZWxldGlvbnMoLSkKCmRp
ZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cK
aW5kZXggNTQyZWMwNi4uNjkwZTAwYiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9n
CisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDEwLTAzLTEx
ICBBbnRvbmlvIEdvbWVzICA8dG9uaWtpdG9vQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3
ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU3BhdGlhbCBOYXZpZ2F0aW9uOiBBZGQg
YSBzY3JvbGxJbnRvVmlldyBjYWxsIHdoZW4gZm9jdXNpbmcgYW4gZWxlbWVudC4KKyAgICAgICAg
aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM2MDIwCisKKyAgICAgICAg
KiBwbGF0Zm9ybS9ndGsvU2tpcHBlZDogVW5za2lwIHNuYXYtaWZyYW1lLXdpdGgtb2Zmc2NyZWVu
LWVsZW1lbnQuaHRtbAorCiAyMDEwLTAzLTEwICBBbnRvbmlvIEdvbWVzICA8dG9uaWtpdG9vQHdl
YmtpdC5vcmc+CiAKICAgICAgICAgVGhlIHRlc3Qgd2FzIGludHJvZHVjZWQgaW4gcjU1Nzk2LCBp
dCBoYXMgYmVlbiBmYWlsaW5nIGluIEd0ayBib3RzIHNpbmNlIHRoZW4uCmRpZmYgLS1naXQgYS9M
YXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvU2tpcHBlZCBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0
ay9Ta2lwcGVkCmluZGV4IDE2YjhjNzMuLjAxZGE1ZTkgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3Rz
L3BsYXRmb3JtL2d0ay9Ta2lwcGVkCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9Ta2lw
cGVkCkBAIC01ODI1LDcgKzU4MjUsMyBAQCBmYXN0L2V2ZW50cy9yZW1vdmUtY2hpbGQtb25zY3Jv
bGwuaHRtbAogCiAjIEFwcGFyZW50bHkgYSBzb3VwIGJ1ZzsgU2VlIGh0dHBzOi8vYnVncy53ZWJr
aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNTk0MgogaHR0cC90ZXN0cy9wbHVnaW5zL3RoaXJkLXBh
cnR5LWNvb2tpZS1hY2NlcHQtcG9saWN5Lmh0bWwKLQotIyBGb3Igc29tZSByZWFzb24gaXQgZmFp
bHMgb24gRFJULCBhbHRob3VnaCB3b3JrcyBvbiBHdGtMYXVuY2hlciBhbmQgb3RoZXIgcG9ydHMn
IERSVC4KLSMgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM1OTg0Ci1m
YXN0L2V2ZW50cy9zcGF0aWFsLW5hdmlnYXRpb24vc25hdi1pZnJhbWUtd2l0aC1vZmZzY3JlZW4t
Zm9jdXNhYmxlLWVsZW1lbnQuaHRtbApkaWZmIC0tZ2l0IGEvV2ViQ29yZS9DaGFuZ2VMb2cgYi9X
ZWJDb3JlL0NoYW5nZUxvZwppbmRleCA1ZjY2YjY0Li45OTNiZTkxIDEwMDY0NAotLS0gYS9XZWJD
b3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisy
MDEwLTAzLTExICBBbnRvbmlvIEdvbWVzICA8dG9uaWtpdG9vQHdlYmtpdC5vcmc+CisKKyAgICAg
ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU3BhdGlhbCBOYXZpZ2F0
aW9uOiBBZGQgYSBzY3JvbGxJbnRvVmlldyBjYWxsIHdoZW4gZm9jdXNpbmcgYW4gZWxlbWVudC4K
KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM2MDIwCisK
KyAgICAgICAgKiBwYWdlL0ZvY3VzQ29udHJvbGxlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpG
b2N1c0NvbnRyb2xsZXI6OmFkdmFuY2VGb2N1c0RpcmVjdGlvbmFsbHkpOgorCiAyMDEwLTAzLTEw
ICBDaGFybGVzIFdlaSAgPGNoYXJsZXMud2VpQHRvcmNobW9iaWxlLmNvbS5jbj4KIAogICAgICAg
ICBSZXZpZXdlZCBieSBHZW9yZ2UgU3RhaWtvcy4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGFnZS9G
b2N1c0NvbnRyb2xsZXIuY3BwIGIvV2ViQ29yZS9wYWdlL0ZvY3VzQ29udHJvbGxlci5jcHAKaW5k
ZXggN2IwNDMwZi4uMGNhNTY0OCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wYWdlL0ZvY3VzQ29udHJv
bGxlci5jcHAKKysrIGIvV2ViQ29yZS9wYWdlL0ZvY3VzQ29udHJvbGxlci5jcHAKQEAgLTMzMyw3
ICszMzMsMTEgQEAgYm9vbCBGb2N1c0NvbnRyb2xsZXI6OmFkdmFuY2VGb2N1c0RpcmVjdGlvbmFs
bHkoRm9jdXNEaXJlY3Rpb24gZGlyZWN0aW9uLCBLZXlib2EKICAgICBpZiAobmV3RG9jdW1lbnQp
CiAgICAgICAgIHNldEZvY3VzZWRGcmFtZShuZXdEb2N1bWVudC0+ZnJhbWUoKSk7CiAKLSAgICBz
dGF0aWNfY2FzdDxFbGVtZW50Kj4obm9kZSktPmZvY3VzKGZhbHNlKTsKKyAgICBFbGVtZW50KiBl
bGVtZW50ID0gc3RhdGljX2Nhc3Q8RWxlbWVudCo+KG5vZGUpOworICAgIEFTU0VSVChlbGVtZW50
KTsKKworICAgIGVsZW1lbnQtPnNjcm9sbEludG9WaWV3KCk7CisgICAgZWxlbWVudC0+Zm9jdXMo
ZmFsc2UpOwogICAgIHJldHVybiB0cnVlOwogfQogCi0tIAoxLjYuMC40Cgo=
</data>
<flag name="commit-queue"
          id="33672"
          type_id="3"
          status="-"
          setter="tonikitoo"
    />
          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>50614</attachid>
            <date>2010-03-12 11:25:36 -0800</date>
            <delta_ts>2010-03-15 08:35:30 -0700</delta_ts>
            <desc>patch 0.2 - add a custom scrollIntoView method</desc>
            <filename>0001-Spatial-Navigation-Add-a-scrollIntoView-call-when-f.patch</filename>
            <type>text/plain</type>
            <size>5158</size>
            <attacher name="Antonio Gomes">tonikitoo</attacher>
            
              <data encoding="base64">RnJvbSAwOTA0NTk5ODJlM2MwYWI1MjQ1NmNhZGIyOWI3YWI5NjZhYTIzODRiIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBBbnRvbmlvIEdvbWVzIDx0b25pa2l0b29Ad2Via2l0Lm9yZz4K
RGF0ZTogRnJpLCAxMiBNYXIgMjAxMCAxNToxNTowMyAtMDQwMApTdWJqZWN0OiBbUEFUQ0hdIFNw
YXRpYWwgTmF2aWdhdGlvbjogQWRkIGEgc2Nyb2xsSW50b1ZpZXcgY2FsbCB3aGVuIGZvY3VzaW5n
IGFuIGVsZW1lbnQuCiBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzYw
MjAKClJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgpQYXRjaCBieSBBbnRvbmlvIEdvbWVzIDx0
b25pa2l0b29Ad2Via2l0Lm9yZz4KCldlYkNvcmU6CgoqIHBhZ2UvRm9jdXNDb250cm9sbGVyLmNw
cDoKKFdlYkNvcmU6OkZvY3VzQ29udHJvbGxlcjo6YWR2YW5jZUZvY3VzRGlyZWN0aW9uYWxseSk6
CiogcGFnZS9TcGF0aWFsTmF2aWdhdGlvbi5jcHA6CihXZWJDb3JlOjpzY3JvbGxJbnRvVmlldyk6
CiogcGFnZS9TcGF0aWFsTmF2aWdhdGlvbi5oOgoKTGF5b3V0VGVzdHM6CgoqIHBsYXRmb3JtL2d0
ay9Ta2lwcGVkOiBVbnNraXAgc25hdi1pZnJhbWUtd2l0aC1vZmZzY3JlZW4tZWxlbWVudC5odG1s
Ci0tLQogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nICAgICAgICAgICAgICB8ICAgMTAgKysrKysrKysr
KwogTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1NraXBwZWQgICB8ICAgIDQgLS0tLQogV2ViQ29y
ZS9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICB8ICAgMTQgKysrKysrKysrKysrKysKIFdlYkNv
cmUvcGFnZS9Gb2N1c0NvbnRyb2xsZXIuY3BwICAgfCAgICA2ICsrKysrLQogV2ViQ29yZS9wYWdl
L1NwYXRpYWxOYXZpZ2F0aW9uLmNwcCB8ICAgMTIgKysrKysrKysrKysrCiBXZWJDb3JlL3BhZ2Uv
U3BhdGlhbE5hdmlnYXRpb24uaCAgIHwgICAgMiArKwogNiBmaWxlcyBjaGFuZ2VkLCA0MyBpbnNl
cnRpb25zKCspLCA1IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n
ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCAxOGM0OTM3Li41NzVjNzIxIDEwMDY0
NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9n
CkBAIC0xLDMgKzEsMTMgQEAKKzIwMTAtMDMtMTEgIEFudG9uaW8gR29tZXMgIDx0b25pa2l0b29A
d2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKyAgICAg
ICAgUGF0Y2ggYnkgQW50b25pbyBHb21lcyA8dG9uaWtpdG9vQHdlYmtpdC5vcmc+CisKKyAgICAg
ICAgU3BhdGlhbCBOYXZpZ2F0aW9uOiBBZGQgYSBzY3JvbGxJbnRvVmlldyBjYWxsIHdoZW4gZm9j
dXNpbmcgYW4gZWxlbWVudC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i
dWcuY2dpP2lkPTM2MDIwCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ndGsvU2tpcHBlZDogVW5za2lw
IHNuYXYtaWZyYW1lLXdpdGgtb2Zmc2NyZWVuLWVsZW1lbnQuaHRtbAorCiAyMDEwLTAzLTEyICBE
YW4gQmVybnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFy
aW4gQWRsZXIuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvU2tpcHBlZCBi
L0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9Ta2lwcGVkCmluZGV4IDE2YjkwYjEuLmYwZmQ4MTkg
MTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9Ta2lwcGVkCisrKyBiL0xheW91
dFRlc3RzL3BsYXRmb3JtL2d0ay9Ta2lwcGVkCkBAIC01ODIzLDEwICs1ODIzLDYgQEAgZmFzdC9m
b3Jtcy9tdWx0aXBsZS1mb3JtLXN1Ym1pc3Npb24tcHJvdGVjdGlvbi1tb3VzZS5odG1sCiAjIG1v
dXNlU2Nyb2xsQnkoKSBpcyBub3QgeWV0IGltcGxlbWVudGVkIGluIHRoZSBHVEsgRXZlbnRTZW5k
ZXIgQVBJLgogZmFzdC9ldmVudHMvcmVtb3ZlLWNoaWxkLW9uc2Nyb2xsLmh0bWwKIAotIyBGb3Ig
c29tZSByZWFzb24gaXQgZmFpbHMgb24gRFJULCBhbHRob3VnaCB3b3JrcyBvbiBHdGtMYXVuY2hl
ciBhbmQgb3RoZXIgcG9ydHMnIERSVC4KLSMgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i
dWcuY2dpP2lkPTM1OTg0Ci1mYXN0L2V2ZW50cy9zcGF0aWFsLW5hdmlnYXRpb24vc25hdi1pZnJh
bWUtd2l0aC1vZmZzY3JlZW4tZm9jdXNhYmxlLWVsZW1lbnQuaHRtbAotCiAjIE5lZWRzIG1vY2sg
c3VwcG9ydCwgYW5kIGJ1aWxkIHNsYXZlIEdlb2xvY2F0aW9uIHNlcnZpY2UKICMgU2VlIGh0dHBz
Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNjA1MwogZmFzdC9kb20vR2VvbG9j
YXRpb24vbWF4aW11bS1hZ2UuaHRtbApkaWZmIC0tZ2l0IGEvV2ViQ29yZS9DaGFuZ2VMb2cgYi9X
ZWJDb3JlL0NoYW5nZUxvZwppbmRleCBmYjAxZjY3Li4zMTRlZjNjIDEwMDY0NAotLS0gYS9XZWJD
b3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisy
MDEwLTAzLTEyICBBbnRvbmlvIEdvbWVzICA8dG9uaWtpdG9vQHdlYmtpdC5vcmc+CisKKyAgICAg
ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisgICAgICAgIFBhdGNoIGJ5IEFudG9uaW8g
R29tZXMgPHRvbmlraXRvb0B3ZWJraXQub3JnPgorCisgICAgICAgIFNwYXRpYWwgTmF2aWdhdGlv
bjogQWRkIGEgc2Nyb2xsSW50b1ZpZXcgY2FsbCB3aGVuIGZvY3VzaW5nIGFuIGVsZW1lbnQuCisg
ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNjAyMAorCisg
ICAgICAgICogcGFnZS9Gb2N1c0NvbnRyb2xsZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Rm9j
dXNDb250cm9sbGVyOjphZHZhbmNlRm9jdXNEaXJlY3Rpb25hbGx5KToKKyAgICAgICAgKiBwYWdl
L1NwYXRpYWxOYXZpZ2F0aW9uLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OnNjcm9sbEludG9WaWV3
KToKKyAgICAgICAgKiBwYWdlL1NwYXRpYWxOYXZpZ2F0aW9uLmg6CisKIDIwMTAtMDMtMTIgIERh
biBCZXJuc3RlaW4gIDxtaXR6QGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJp
biBBZGxlci4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGFnZS9Gb2N1c0NvbnRyb2xsZXIuY3BwIGIv
V2ViQ29yZS9wYWdlL0ZvY3VzQ29udHJvbGxlci5jcHAKaW5kZXggN2IwNDMwZi4uOTIwZThiMyAx
MDA2NDQKLS0tIGEvV2ViQ29yZS9wYWdlL0ZvY3VzQ29udHJvbGxlci5jcHAKKysrIGIvV2ViQ29y
ZS9wYWdlL0ZvY3VzQ29udHJvbGxlci5jcHAKQEAgLTMzMyw3ICszMzMsMTEgQEAgYm9vbCBGb2N1
c0NvbnRyb2xsZXI6OmFkdmFuY2VGb2N1c0RpcmVjdGlvbmFsbHkoRm9jdXNEaXJlY3Rpb24gZGly
ZWN0aW9uLCBLZXlib2EKICAgICBpZiAobmV3RG9jdW1lbnQpCiAgICAgICAgIHNldEZvY3VzZWRG
cmFtZShuZXdEb2N1bWVudC0+ZnJhbWUoKSk7CiAKLSAgICBzdGF0aWNfY2FzdDxFbGVtZW50Kj4o
bm9kZSktPmZvY3VzKGZhbHNlKTsKKyAgICBFbGVtZW50KiBlbGVtZW50ID0gc3RhdGljX2Nhc3Q8
RWxlbWVudCo+KG5vZGUpOworICAgIEFTU0VSVChlbGVtZW50KTsKKworICAgIHNjcm9sbEludG9W
aWV3KGVsZW1lbnQpOworICAgIGVsZW1lbnQtPmZvY3VzKGZhbHNlKTsKICAgICByZXR1cm4gdHJ1
ZTsKIH0KIApkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wYWdlL1NwYXRpYWxOYXZpZ2F0aW9uLmNwcCBi
L1dlYkNvcmUvcGFnZS9TcGF0aWFsTmF2aWdhdGlvbi5jcHAKaW5kZXggYzdmMTZhZS4uYzZjNmVk
MyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wYWdlL1NwYXRpYWxOYXZpZ2F0aW9uLmNwcAorKysgYi9X
ZWJDb3JlL3BhZ2UvU3BhdGlhbE5hdmlnYXRpb24uY3BwCkBAIC00NjUsNiArNDY1LDE4IEBAIGJv
b2wgc2Nyb2xsSW5EaXJlY3Rpb24oRnJhbWUqIGZyYW1lLCBGb2N1c0RpcmVjdGlvbiBkaXJlY3Rp
b24pCiAgICAgcmV0dXJuIGZyYW1lLT5ldmVudEhhbmRsZXIoKS0+c2Nyb2xsUmVjdXJzaXZlbHko
c2Nyb2xsRGlyZWN0aW9uLCBTY3JvbGxCeUxpbmUpOwogfQogCit2b2lkIHNjcm9sbEludG9WaWV3
KEVsZW1lbnQqIGVsZW1lbnQpCit7CisgICAgLy8gTk9URTogRWxlbWVudCdzIHNjcm9sbEludG9W
aWV3IG1ldGhvZCBjb3VsZCBoYWQgYmVlbiB1c2VkIGhlcmUsIGJ1dAorICAgIC8vIGl0IGlzIHBy
ZWZlcmFibGUgdG8gaW5mbGF0ZSB8ZWxlbWVudHwncyBib3VuZGluZyByZWN0IGEgYml0IGJlZm9y
ZQorICAgIC8vIHNjcm9sbGluZyBpdCBmb3IgYWNjdXJhdGUgcmVhc29uLgorICAgIC8vIEVsZW1l
bnQncyBzY3JvbGxJbnRvVmlldyBtZXRob2QgZG9lcyBub3QgcHJvdmlkZSB0aGlzIGZsZXhpYmls
aXR5LgorICAgIHN0YXRpYyBjb25zdCBpbnQgZnVkZ2VGYWN0b3IgPSAyOworICAgIEludFJlY3Qg
Ym91bmRzID0gZWxlbWVudC0+Z2V0UmVjdCgpOworICAgIGJvdW5kcy5pbmZsYXRlKGZ1ZGdlRmFj
dG9yKTsKKyAgICBlbGVtZW50LT5yZW5kZXJlcigpLT5lbmNsb3NpbmdMYXllcigpLT5zY3JvbGxS
ZWN0VG9WaXNpYmxlKGJvdW5kcyk7Cit9CisKIGJvb2wgaXNJblJvb3REb2N1bWVudChOb2RlKiBu
b2RlKQogewogICAgIGlmICghbm9kZSkKZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGFnZS9TcGF0aWFs
TmF2aWdhdGlvbi5oIGIvV2ViQ29yZS9wYWdlL1NwYXRpYWxOYXZpZ2F0aW9uLmgKaW5kZXggM2E3
M2QyOS4uZDU0NTU0ZCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wYWdlL1NwYXRpYWxOYXZpZ2F0aW9u
LmgKKysrIGIvV2ViQ29yZS9wYWdlL1NwYXRpYWxOYXZpZ2F0aW9uLmgKQEAgLTI3LDYgKzI3LDcg
QEAKIAogbmFtZXNwYWNlIFdlYkNvcmUgewogCitjbGFzcyBFbGVtZW50OwogY2xhc3MgRnJhbWU7
CiBjbGFzcyBJbnRSZWN0OwogY2xhc3MgTm9kZTsKQEAgLTEwNiw2ICsxMDcsNyBAQCBzdHJ1Y3Qg
Rm9jdXNDYW5kaWRhdGUgewogCiBsb25nIGxvbmcgZGlzdGFuY2VJbkRpcmVjdGlvbihOb2RlKiwg
Tm9kZSosIEZvY3VzRGlyZWN0aW9uLCBGb2N1c0NhbmRpZGF0ZSYpOwogYm9vbCBzY3JvbGxJbkRp
cmVjdGlvbihGcmFtZSosIEZvY3VzRGlyZWN0aW9uKTsKK3ZvaWQgc2Nyb2xsSW50b1ZpZXcoRWxl
bWVudCopOwogYm9vbCBoYXNPZmZzY3JlZW5SZWN0KE5vZGUqKTsKIGJvb2wgaXNJblJvb3REb2N1
bWVudChOb2RlKik7CiAKLS0gCjEuNi4wLjQKCg==
</data>
<flag name="commit-queue"
          id="33785"
          type_id="3"
          status="-"
          setter="tonikitoo"
    />
          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>50711</attachid>
            <date>2010-03-15 08:35:30 -0700</date>
            <delta_ts>2010-03-15 12:08:51 -0700</delta_ts>
            <desc>patch 0.3 - same as 0.2 + adds a better ChangeLog entry</desc>
            <filename>0001-Spatial-Navigation-Add-a-scrollIntoView-call-when-f.patch</filename>
            <type>text/plain</type>
            <size>6290</size>
            <attacher name="Antonio Gomes">tonikitoo</attacher>
            
              <data encoding="base64">RnJvbSAzM2I5OTkzN2JlZjI4YzgwZGY3M2Y2YmJjNzQxNmE5YjY5OGVkOTI2IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBBbnRvbmlvIEdvbWVzIDx0b25pa2l0b29Ad2Via2l0Lm9yZz4K
RGF0ZTogRnJpLCAxMiBNYXIgMjAxMCAxNToxNTowMyAtMDQwMApTdWJqZWN0OiBbUEFUQ0hdIFNw
YXRpYWwgTmF2aWdhdGlvbjogQWRkIGEgc2Nyb2xsSW50b1ZpZXcgY2FsbCB3aGVuIGZvY3VzaW5n
IGFuIGVsZW1lbnQuCiBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzYw
MjAKClJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgpQYXRjaCBieSBBbnRvbmlvIEdvbWVzIDx0
b25pa2l0b29Ad2Via2l0Lm9yZz4KCldlYkNvcmU6CgpXaGVuIGZvY3VzaW5nIGFuIGVsZW1lbnQg
aW4gU3BhdGlhbCBOYXZpZ2F0aW9uIGxvZ2ljLCBpdCBpcyBkZXNpcmVkIHRvIG1ha2UKdGhpcyBl
bGVtZW50IHZpc2libGUgaW4gdGhlIGN1cnJlbnQgdmlld3BvcnQuIEZvciB0aGF0IHRvIGhhcHBl
biwgdGhlcmUKY291bGQgYmUgYSBjYWxsIHRvIEVsZW1lbnQncyBzY3JvbGxJbnRvVmlldyBtZXRo
b2QgYXQgZm9jdXNpbmcgdGltZS4gSG93ZXZlcgpmb3IgdmlzdWFsIGFzcGVjdHMsIGl0IGlzIHBy
ZWZlcmFibGUgdG8gc2Nyb2xsIHRvIGFuIGluZmxhdGVkIHJlY3Qgb2YgfGVsZW1lbnR8CmluIG9y
ZGVyIHRvIGNvbnNpZGVyIHRoZSBmb2N1cyBvdXRsaW5lIHdpZHRoLgpBcyBFbGVtZW50J3Mgc2Ny
b2xsSW50b1ZpZXcgbWV0aG9kIGRvZXMgbm90IHByb3ZpZGUgdGhpcyBmbGV4aWJpbGl0eSwgcGF0
Y2ggYWRkcwphIGN1c3RvbSBzY3JvbGxJbnRvVmlldyBtZXRob2QgdG8gU3BhdGlhbE5hdmlnYXRp
b24uaCAuCgoqIHBhZ2UvRm9jdXNDb250cm9sbGVyLmNwcDoKKFdlYkNvcmU6OkZvY3VzQ29udHJv
bGxlcjo6YWR2YW5jZUZvY3VzRGlyZWN0aW9uYWxseSk6CiogcGFnZS9TcGF0aWFsTmF2aWdhdGlv
bi5jcHA6CihXZWJDb3JlOjpzY3JvbGxJbnRvVmlldyk6CiogcGFnZS9TcGF0aWFsTmF2aWdhdGlv
bi5oOgoKTGF5b3V0VGVzdHM6CgoqIHBsYXRmb3JtL2d0ay9Ta2lwcGVkOiBVbnNraXAgc25hdi1p
ZnJhbWUtd2l0aC1vZmZzY3JlZW4tZWxlbWVudC5odG1sCi0tLQogTGF5b3V0VGVzdHMvQ2hhbmdl
TG9nICAgICAgICAgICAgICB8ICAgMTAgKysrKysrKysrKwogTGF5b3V0VGVzdHMvcGxhdGZvcm0v
Z3RrL1NraXBwZWQgICB8ICAgIDQgLS0tLQogV2ViQ29yZS9DaGFuZ2VMb2cgICAgICAgICAgICAg
ICAgICB8ICAgMjIgKysrKysrKysrKysrKysrKysrKysrKwogV2ViQ29yZS9wYWdlL0ZvY3VzQ29u
dHJvbGxlci5jcHAgICB8ICAgIDYgKysrKystCiBXZWJDb3JlL3BhZ2UvU3BhdGlhbE5hdmlnYXRp
b24uY3BwIHwgICAxMiArKysrKysrKysrKysKIFdlYkNvcmUvcGFnZS9TcGF0aWFsTmF2aWdhdGlv
bi5oICAgfCAgICAyICsrCiA2IGZpbGVzIGNoYW5nZWQsIDUxIGluc2VydGlvbnMoKyksIDUgZGVs
ZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVz
dHMvQ2hhbmdlTG9nCmluZGV4IGUzMWEwYzMuLjRkZDUxM2QgMTAwNjQ0Ci0tLSBhL0xheW91dFRl
c3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTE3Nyw2ICsxNzcs
MTYgQEAKIAogMjAxMC0wMy0xMSAgQW50b25pbyBHb21lcyAgPHRvbmlraXRvb0B3ZWJraXQub3Jn
PgogCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorICAgICAgICBQYXRjaCBi
eSBBbnRvbmlvIEdvbWVzIDx0b25pa2l0b29Ad2Via2l0Lm9yZz4KKworICAgICAgICBTcGF0aWFs
IE5hdmlnYXRpb246IEFkZCBhIHNjcm9sbEludG9WaWV3IGNhbGwgd2hlbiBmb2N1c2luZyBhbiBl
bGVtZW50LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9
MzYwMjAKKworICAgICAgICAqIHBsYXRmb3JtL2d0ay9Ta2lwcGVkOiBVbnNraXAgc25hdi1pZnJh
bWUtd2l0aC1vZmZzY3JlZW4tZWxlbWVudC5odG1sCisKKzIwMTAtMDMtMTEgIEFudG9uaW8gR29t
ZXMgIDx0b25pa2l0b29Ad2Via2l0Lm9yZz4KKwogICAgICAgICBSdWJiZXItc3RhbXBlZCBieSBL
ZW5uZXRoIENocmlzdGlhbnNlbi4KICAgICAgICAgUGF0Y2ggYnkgQW50b25pbyBHb21lcyA8dG9u
aWtpdG9vQHdlYmtpdC5vcmc+CiAKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0
ay9Ta2lwcGVkIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1NraXBwZWQKaW5kZXggMWYwMjFl
YS4uMjQ0MGM5MiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1NraXBwZWQK
KysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1NraXBwZWQKQEAgLTU4MjgsMTAgKzU4Mjgs
NiBAQCBmYXN0L2V2ZW50cy9yZW1vdmUtY2hpbGQtb25zY3JvbGwuaHRtbAogZmFzdC9kb20vSFRN
TFByb2dyZXNzRWxlbWVudC9wcm9ncmVzcy1lbGVtZW50Lmh0bWwKIGZhc3QvZG9tL0hUTUxQcm9n
cmVzc0VsZW1lbnQvc2V0LXByb2dyZXNzLXByb3BlcnRpZXMuaHRtbAogCi0jIEZvciBzb21lIHJl
YXNvbiBpdCBmYWlscyBvbiBEUlQsIGFsdGhvdWdoIHdvcmtzIG9uIEd0a0xhdW5jaGVyIGFuZCBv
dGhlciBwb3J0cycgRFJULgotIyBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/
aWQ9MzU5ODQKLWZhc3QvZXZlbnRzL3NwYXRpYWwtbmF2aWdhdGlvbi9zbmF2LWlmcmFtZS13aXRo
LW9mZnNjcmVlbi1mb2N1c2FibGUtZWxlbWVudC5odG1sCi0KICMgTmVlZHMgbW9jayBzdXBwb3J0
LCBhbmQgYnVpbGQgc2xhdmUgR2VvbG9jYXRpb24gc2VydmljZQogIyBTZWUgaHR0cHM6Ly9idWdz
LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM2MDUzCiBmYXN0L2RvbS9HZW9sb2NhdGlvbi9t
YXhpbXVtLWFnZS5odG1sCmRpZmYgLS1naXQgYS9XZWJDb3JlL0NoYW5nZUxvZyBiL1dlYkNvcmUv
Q2hhbmdlTG9nCmluZGV4IDRiNzE5MTAuLmM0YzcwNWEgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvQ2hh
bmdlTG9nCisrKyBiL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjUgQEAKKzIwMTAtMDMt
MTIgIEFudG9uaW8gR29tZXMgIDx0b25pa2l0b29Ad2Via2l0Lm9yZz4KKworICAgICAgICBSZXZp
ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKyAgICAgICAgUGF0Y2ggYnkgQW50b25pbyBHb21lcyA8
dG9uaWtpdG9vQHdlYmtpdC5vcmc+CisKKyAgICAgICAgU3BhdGlhbCBOYXZpZ2F0aW9uOiBBZGQg
YSBzY3JvbGxJbnRvVmlldyBjYWxsIHdoZW4gZm9jdXNpbmcgYW4gZWxlbWVudC4KKyAgICAgICAg
aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM2MDIwCisKKyAgICAgICAg
V2hlbiBmb2N1c2luZyBhbiBlbGVtZW50IGluIFNwYXRpYWwgTmF2aWdhdGlvbiBsb2dpYywgaXQg
aXMgZGVzaXJlZCB0byBtYWtlCisgICAgICAgIHRoaXMgZWxlbWVudCB2aXNpYmxlIGluIHRoZSBj
dXJyZW50IHZpZXdwb3J0LiBGb3IgdGhhdCB0byBoYXBwZW4sIHRoZXJlCisgICAgICAgIGNvdWxk
IGJlIGEgY2FsbCB0byBFbGVtZW50J3Mgc2Nyb2xsSW50b1ZpZXcgbWV0aG9kIGF0IGZvY3VzaW5n
IHRpbWUuIEhvd2V2ZXIKKyAgICAgICAgZm9yIHZpc3VhbCBhc3BlY3RzLCBpdCBpcyBwcmVmZXJh
YmxlIHRvIHNjcm9sbCB0byBhbiBpbmZsYXRlZCByZWN0IG9mIHxlbGVtZW50fAorICAgICAgICBp
biBvcmRlciB0byBjb25zaWRlciB0aGUgZm9jdXMgb3V0bGluZSB3aWR0aC4KKyAgICAgICAgQXMg
RWxlbWVudCdzIHNjcm9sbEludG9WaWV3IG1ldGhvZCBkb2VzIG5vdCBwcm92aWRlIHRoaXMgZmxl
eGliaWxpdHksIHBhdGNoIGFkZHMKKyAgICAgICAgYSBjdXN0b20gc2Nyb2xsSW50b1ZpZXcgbWV0
aG9kIHRvIFNwYXRpYWxOYXZpZ2F0aW9uLmggLgorCisgICAgICAgICogcGFnZS9Gb2N1c0NvbnRy
b2xsZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Rm9jdXNDb250cm9sbGVyOjphZHZhbmNlRm9j
dXNEaXJlY3Rpb25hbGx5KToKKyAgICAgICAgKiBwYWdlL1NwYXRpYWxOYXZpZ2F0aW9uLmNwcDoK
KyAgICAgICAgKFdlYkNvcmU6OnNjcm9sbEludG9WaWV3KToKKyAgICAgICAgKiBwYWdlL1NwYXRp
YWxOYXZpZ2F0aW9uLmg6CisKIDIwMTAtMDMtMTEgIEFudG9uaW8gR29tZXMgIDx0b25pa2l0b29A
d2Via2l0Lm9yZz4KIAogICAgICAgICBSdWJiZXItc3RhbXBlZCBieSBIb2xnZXIgRnJleXRoZXIu
CmRpZmYgLS1naXQgYS9XZWJDb3JlL3BhZ2UvRm9jdXNDb250cm9sbGVyLmNwcCBiL1dlYkNvcmUv
cGFnZS9Gb2N1c0NvbnRyb2xsZXIuY3BwCmluZGV4IDdiMDQzMGYuLjkyMGU4YjMgMTAwNjQ0Ci0t
LSBhL1dlYkNvcmUvcGFnZS9Gb2N1c0NvbnRyb2xsZXIuY3BwCisrKyBiL1dlYkNvcmUvcGFnZS9G
b2N1c0NvbnRyb2xsZXIuY3BwCkBAIC0zMzMsNyArMzMzLDExIEBAIGJvb2wgRm9jdXNDb250cm9s
bGVyOjphZHZhbmNlRm9jdXNEaXJlY3Rpb25hbGx5KEZvY3VzRGlyZWN0aW9uIGRpcmVjdGlvbiwg
S2V5Ym9hCiAgICAgaWYgKG5ld0RvY3VtZW50KQogICAgICAgICBzZXRGb2N1c2VkRnJhbWUobmV3
RG9jdW1lbnQtPmZyYW1lKCkpOwogCi0gICAgc3RhdGljX2Nhc3Q8RWxlbWVudCo+KG5vZGUpLT5m
b2N1cyhmYWxzZSk7CisgICAgRWxlbWVudCogZWxlbWVudCA9IHN0YXRpY19jYXN0PEVsZW1lbnQq
Pihub2RlKTsKKyAgICBBU1NFUlQoZWxlbWVudCk7CisKKyAgICBzY3JvbGxJbnRvVmlldyhlbGVt
ZW50KTsKKyAgICBlbGVtZW50LT5mb2N1cyhmYWxzZSk7CiAgICAgcmV0dXJuIHRydWU7CiB9CiAK
ZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGFnZS9TcGF0aWFsTmF2aWdhdGlvbi5jcHAgYi9XZWJDb3Jl
L3BhZ2UvU3BhdGlhbE5hdmlnYXRpb24uY3BwCmluZGV4IDZiMzRhYWIuLmJmZDk0MTEgMTAwNjQ0
Ci0tLSBhL1dlYkNvcmUvcGFnZS9TcGF0aWFsTmF2aWdhdGlvbi5jcHAKKysrIGIvV2ViQ29yZS9w
YWdlL1NwYXRpYWxOYXZpZ2F0aW9uLmNwcApAQCAtNDY1LDYgKzQ2NSwxOCBAQCBib29sIHNjcm9s
bEluRGlyZWN0aW9uKEZyYW1lKiBmcmFtZSwgRm9jdXNEaXJlY3Rpb24gZGlyZWN0aW9uKQogICAg
IHJldHVybiBmcmFtZS0+ZXZlbnRIYW5kbGVyKCktPnNjcm9sbFJlY3Vyc2l2ZWx5KHNjcm9sbERp
cmVjdGlvbiwgU2Nyb2xsQnlMaW5lKTsKIH0KIAordm9pZCBzY3JvbGxJbnRvVmlldyhFbGVtZW50
KiBlbGVtZW50KQoreworICAgIC8vIE5PVEU6IEVsZW1lbnQncyBzY3JvbGxJbnRvVmlldyBtZXRo
b2QgY291bGQgaGFkIGJlZW4gdXNlZCBoZXJlLCBidXQKKyAgICAvLyBpdCBpcyBwcmVmZXJhYmxl
IHRvIGluZmxhdGUgfGVsZW1lbnR8J3MgYm91bmRpbmcgcmVjdCBhIGJpdCBiZWZvcmUKKyAgICAv
LyBzY3JvbGxpbmcgaXQgZm9yIGFjY3VyYXRlIHJlYXNvbi4KKyAgICAvLyBFbGVtZW50J3Mgc2Ny
b2xsSW50b1ZpZXcgbWV0aG9kIGRvZXMgbm90IHByb3ZpZGUgdGhpcyBmbGV4aWJpbGl0eS4KKyAg
ICBzdGF0aWMgY29uc3QgaW50IGZ1ZGdlRmFjdG9yID0gMjsKKyAgICBJbnRSZWN0IGJvdW5kcyA9
IGVsZW1lbnQtPmdldFJlY3QoKTsKKyAgICBib3VuZHMuaW5mbGF0ZShmdWRnZUZhY3Rvcik7Cisg
ICAgZWxlbWVudC0+cmVuZGVyZXIoKS0+ZW5jbG9zaW5nTGF5ZXIoKS0+c2Nyb2xsUmVjdFRvVmlz
aWJsZShib3VuZHMpOworfQorCiBib29sIGlzSW5Sb290RG9jdW1lbnQoTm9kZSogbm9kZSkKIHsK
ICAgICBpZiAoIW5vZGUpCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BhZ2UvU3BhdGlhbE5hdmlnYXRp
b24uaCBiL1dlYkNvcmUvcGFnZS9TcGF0aWFsTmF2aWdhdGlvbi5oCmluZGV4IDNhNzNkMjkuLmQ1
NDU1NGQgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGFnZS9TcGF0aWFsTmF2aWdhdGlvbi5oCisrKyBi
L1dlYkNvcmUvcGFnZS9TcGF0aWFsTmF2aWdhdGlvbi5oCkBAIC0yNyw2ICsyNyw3IEBACiAKIG5h
bWVzcGFjZSBXZWJDb3JlIHsKIAorY2xhc3MgRWxlbWVudDsKIGNsYXNzIEZyYW1lOwogY2xhc3Mg
SW50UmVjdDsKIGNsYXNzIE5vZGU7CkBAIC0xMDYsNiArMTA3LDcgQEAgc3RydWN0IEZvY3VzQ2Fu
ZGlkYXRlIHsKIAogbG9uZyBsb25nIGRpc3RhbmNlSW5EaXJlY3Rpb24oTm9kZSosIE5vZGUqLCBG
b2N1c0RpcmVjdGlvbiwgRm9jdXNDYW5kaWRhdGUmKTsKIGJvb2wgc2Nyb2xsSW5EaXJlY3Rpb24o
RnJhbWUqLCBGb2N1c0RpcmVjdGlvbik7Cit2b2lkIHNjcm9sbEludG9WaWV3KEVsZW1lbnQqKTsK
IGJvb2wgaGFzT2Zmc2NyZWVuUmVjdChOb2RlKik7CiBib29sIGlzSW5Sb290RG9jdW1lbnQoTm9k
ZSopOwogCi0tIAoxLjYuMC40Cgo=
</data>
<flag name="review"
          id="33877"
          type_id="1"
          status="+"
          setter="simon.fraser"
    />
    <flag name="commit-queue"
          id="33878"
          type_id="3"
          status="-"
          setter="tonikitoo"
    />
          </attachment>
      

    </bug>

</bugzilla>