36017 2010-03-11 08:34:22 -0800 REGRESSION (r53857): Crash when tabbing to <map> 2010-03-16 17:10:43 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Mac OS X 10.6 RESOLVED FIXED http://www.register.prometric.com/Login.asp InRadar, NeedsReduction, Regression P1 Normal --- 1 dev+webkit cfleizach ap cfleizach oldest_to_newest 198643 0 dev+webkit 2010-03-11 08:34:22 -0800 Go to <http://www.register.prometric.com/Login.asp> and press tab -> *BOOM*. This happens regardless of whether Safari is set to tab to individual elements or not. Tested in r55841 on Snow Leopard. Thread 0 Crashed: Dispatch queue: com.apple.main-thread 0 com.apple.WebCore 0x000000010169e1d0 WebCore::RenderObject::document() const + 16 (RenderObject.h:426) 1 com.apple.WebCore 0x00000001012771e1 WebCore::HTMLMapElement::imageElement() const + 29 (HTMLMapElement.cpp:82) 2 com.apple.WebCore 0x0000000101236018 WebCore::HTMLAreaElement::updateFocusAppearance(bool) + 86 (HTMLAreaElement.cpp:214) 3 com.apple.WebCore 0x000000010115bcef WebCore::Element::focus(bool) + 323 (Element.cpp:1323) 4 com.apple.WebCore 0x0000000101188110 WebCore::FocusController::advanceFocusInDocumentOrder(WebCore::FocusDirection, WebCore::KeyboardEvent*, bool) + 1592 (FocusController.cpp:283) 5 com.apple.WebCore 0x000000010118840a WebCore::FocusController::advanceFocus(WebCore::FocusDirection, WebCore::KeyboardEvent*, bool) + 68 (FocusController.cpp:167) 6 com.apple.WebCore 0x0000000101163f88 WebCore::EventHandler::defaultTabEventHandler(WebCore::KeyboardEvent*) + 204 (EventHandler.cpp:2550) 7 com.apple.WebCore 0x000000010116ce71 WebCore::EventHandler::defaultKeyboardEventHandler(WebCore::KeyboardEvent*) + 155 (EventHandler.cpp:2176) 8 com.apple.WebCore 0x00000001015f8448 WebCore::Node::defaultEventHandler(WebCore::Event*) + 212 (Node.cpp:2951) 9 com.apple.WebCore 0x00000001015f918b WebCore::Node::dispatchGenericEvent(WTF::PassRefPtr<WebCore::Event>) + 1645 (Node.cpp:2681) 10 com.apple.WebCore 0x00000001015f9409 WebCore::Node::dispatchEvent(WTF::PassRefPtr<WebCore::Event>) + 149 (Node.cpp:2567) 11 com.apple.WebCore 0x000000010117681c WebCore::EventTarget::dispatchEvent(WTF::PassRefPtr<WebCore::Event>, int&) + 178 (EventTarget.cpp:254) 12 com.apple.WebCore 0x0000000101164f2a WebCore::EventHandler::keyEvent(WebCore::PlatformKeyboardEvent const&) + 906 (EventHandler.cpp:2112) 13 com.apple.WebCore 0x00000001011712a9 WebCore::EventHandler::keyEvent(NSEvent*) + 181 (EventHandlerMac.mm:150) 14 com.apple.WebKit 0x000000010037fbd9 -[WebHTMLView keyDown:] + 430 (WebHTMLView.mm:4006) 15 com.apple.AppKit 0x00007fff84fb93af -[NSWindow sendEvent:] + 8769 16 com.apple.Safari 0x0000000100049117 0x100000000 + 299287 17 com.apple.AppKit 0x00007fff84eede22 -[NSApplication sendEvent:] + 4719 18 com.apple.Safari 0x0000000100031c10 0x100000000 + 203792 19 com.apple.AppKit 0x00007fff84e84796 -[NSApplication run] + 474 20 com.apple.AppKit 0x00007fff84e7d468 NSApplicationMain + 364 21 com.apple.Safari 0x0000000100001a28 0x100000000 + 6696 199300 1 ap 2010-03-12 21:47:20 -0800 Tabbing inside an element that doesn't have a renderer. 199301 2 ap 2010-03-12 21:47:56 -0800 <rdar://problem/7750748> 200457 3 ap 2010-03-16 15:01:45 -0700 <http://trac.webkit.org/changeset/53857>. 200500 4 50851 cfleizach 2010-03-16 16:27:42 -0700 Created attachment 50851 patch 200512 5 50851 ap 2010-03-16 16:52:14 -0700 Comment on attachment 50851 patch > +On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". > + > + > +PASS document.activeElement.id is 'area1' > + There is no TEST COMPLETE in expected results. I don't see why. Ideally, a test provides instructions for running it manually if eventSender is needed, but not available. 200513 6 cfleizach 2010-03-16 16:53:07 -0700 how do i add a test complete with the layout tests? 200516 7 ap 2010-03-16 17:01:31 -0700 It's supposed to be added by this line: +<script src="../fast/js/resources/js-test-post.js"></script> Something went wrong with it - probably something simple, but I don't see the problem. 200519 8 cfleizach 2010-03-16 17:06:02 -0700 looks like i'm including the wrong path 200523 9 cfleizach 2010-03-16 17:10:43 -0700 http://trac.webkit.org/changeset/56094 50851 2010-03-16 16:27:42 -0700 2010-03-16 17:07:47 -0700 patch patch.txt text/plain 3722 cfleizach SW5kZXg6IExheW91dFRlc3RzL2Zhc3QvZXZlbnRzL2ltYWdlbWFwLW5vcmVuZGVyLWNyYXNoLWV4 cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy9pbWFnZW1h cC1ub3JlbmRlci1jcmFzaC1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0 cy9mYXN0L2V2ZW50cy9pbWFnZW1hcC1ub3JlbmRlci1jcmFzaC1leHBlY3RlZC50eHQJKHJldmlz aW9uIDApCkBAIC0wLDAgKzEsMTAgQEAKK3N0YXJ0IGVsZW1lbnQKKworCitUaGlzIHRlc3RzIHRh YmJpbmcgdG8gYW4gaW1hZ2UgbWFwIGxpbmsgd2hlcmUgdGhlIG1hcCBtaWdodCBub3QgaGF2ZSBh IHJlbmRlcmVyIHdvbid0IGNyYXNoLgorCitPbiBzdWNjZXNzLCB5b3Ugd2lsbCBzZWUgYSBzZXJp ZXMgb2YgIlBBU1MiIG1lc3NhZ2VzLCBmb2xsb3dlZCBieSAiVEVTVCBDT01QTEVURSIuCisKKwor UEFTUyBkb2N1bWVudC5hY3RpdmVFbGVtZW50LmlkIGlzICdhcmVhMScKKwpJbmRleDogTGF5b3V0 VGVzdHMvZmFzdC9ldmVudHMvaW1hZ2VtYXAtbm9yZW5kZXItY3Jhc2guaHRtbAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy9pbWFnZW1hcC1ub3JlbmRlci1jcmFzaC5odG1s CShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9ldmVudHMvaW1hZ2VtYXAtbm9yZW5k ZXItY3Jhc2guaHRtbAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwzNCBAQAorPCFET0NUWVBFIEhU TUwgUFVCTElDICItLy9JRVRGLy9EVEQgSFRNTC8vRU4iPgorPGh0bWw+Cis8aGVhZD4KKzxsaW5r IHJlbD0ic3R5bGVzaGVldCIgaHJlZj0iLi4vanMvcmVzb3VyY2VzL2pzLXRlc3Qtc3R5bGUuY3Nz Ij4KKzxzY3JpcHQ+Cit2YXIgc3VjY2Vzc2Z1bGx5UGFyc2VkID0gZmFsc2U7Cis8L3NjcmlwdD4K KzxzY3JpcHQgc3JjPSIuLi9qcy9yZXNvdXJjZXMvanMtdGVzdC1wcmUuanMiPjwvc2NyaXB0Pgor PGJvZHkgaWQ9ImJvZHkiPgorCis8aDEgaWQ9ImhlYWRlciIgdGFiaW5kZXg9MD5zdGFydCBlbGVt ZW50PC9oMT4KKzxkaXY+PGltZyBzcmM9InJlc291cmNlcy9hYmUucG5nIiBhbHQ9InRlc3QiIHN0 eWxlPSJ3aWR0aDo2NzlweDsgaGVpZ2h0OjExMnB4IiB1c2VtYXA9IiNNYXAiPjwvZGl2PgorPGRp diBzdHlsZT0iZGlzcGxheTpub25lIj48bWFwIG5hbWU9Ik1hcCIgaWQ9Ik1hcCI+PGFyZWEgc2hh cGU9InJlY3QiIGNvb3Jkcz1jb29yZHM9IjUsNDgsMjQ3LDk3IiBocmVmPSJodHRwOi8vd3d3Lndl YmtpdC5vcmcvIiB0YXJnZXQ9Il9ibGFuayIgaWQ9ImFyZWExIi8+PC9tYXA+PC9kaXY+CisKKzxw IGlkPSJkZXNjcmlwdGlvbiI+PC9wPgorPGRpdiBpZD0iY29uc29sZSI+PC9kaXY+CisKKzxzY3Jp cHQ+CisKKyAgICBkZXNjcmlwdGlvbigiVGhpcyB0ZXN0cyB0YWJiaW5nIHRvIGFuIGltYWdlIG1h cCBsaW5rIHdoZXJlIHRoZSBtYXAgbWlnaHQgbm90IGhhdmUgYSByZW5kZXJlciB3b24ndCBjcmFz aC4iKTsKKworICAgIC8vIHN0YXJ0IGF0IHRoZSByaWdodCBwbGFjZQorICAgIGRvY3VtZW50Lmdl dEVsZW1lbnRCeUlkKCJoZWFkZXIiKS5mb2N1cygpOworCisgICAgLy8gdGFiIGZvcndhcmQKKyAg ICBldmVudFNlbmRlci5rZXlEb3duKCdcdCcpOworICAgIHNob3VsZEJlKCJkb2N1bWVudC5hY3Rp dmVFbGVtZW50LmlkIiwgIidhcmVhMSciKTsKKworICAgIHN1Y2Nlc3NmdWxseVBhcnNlZCA9IHRy dWU7Cis8L3NjcmlwdD4KKworPHNjcmlwdCBzcmM9Ii4uL2Zhc3QvanMvcmVzb3VyY2VzL2pzLXRl c3QtcG9zdC5qcyI+PC9zY3JpcHQ+Cis8L2JvZHk+Cis8L2h0bWw+CkluZGV4OiBXZWJDb3JlL2h0 bWwvSFRNTE1hcEVsZW1lbnQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvaHRtbC9IVE1MTWFw RWxlbWVudC5jcHAJKHJldmlzaW9uIDU2MDkwKQorKysgV2ViQ29yZS9odG1sL0hUTUxNYXBFbGVt ZW50LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNzksNyArNzksNyBAQAogCiBIVE1MSW1hZ2VFbGVt ZW50KiBIVE1MTWFwRWxlbWVudDo6aW1hZ2VFbGVtZW50KCkgY29uc3QKIHsKLSAgICBSZWZQdHI8 SFRNTENvbGxlY3Rpb24+IGNvbGwgPSByZW5kZXJlcigpLT5kb2N1bWVudCgpLT5pbWFnZXMoKTsK KyAgICBSZWZQdHI8SFRNTENvbGxlY3Rpb24+IGNvbGwgPSBkb2N1bWVudCgpLT5pbWFnZXMoKTsK ICAgICBmb3IgKE5vZGUqIGN1cnIgPSBjb2xsLT5maXJzdEl0ZW0oKTsgY3VycjsgY3VyciA9IGNv bGwtPm5leHRJdGVtKCkpIHsKICAgICAgICAgaWYgKCFjdXJyLT5oYXNUYWdOYW1lKGltZ1RhZykp CiAgICAgICAgICAgICBjb250aW51ZTsKSW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9nCShyZXZpc2lvbiA1NjA5MikKKysrIFdlYkNvcmUvQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTAtMDMtMTYgIENocmlz IEZsZWl6YWNoICA8Y2ZsZWl6YWNoQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSRUdSRVNTSU9OIChyNTM4NTcpOiBDcmFzaCB3aGVu IHRhYmJpbmcgdG8gPG1hcD4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTM2MDE3CisKKyAgICAgICAgVGVzdDogZmFzdC9ldmVudHMvaW1hZ2VtYXAtbm9y ZW5kZXItY3Jhc2guaHRtbAorCisgICAgICAgICogaHRtbC9IVE1MTWFwRWxlbWVudC5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpIVE1MTWFwRWxlbWVudDo6aW1hZ2VFbGVtZW50KToKKwogMjAxMC0w My0xNiAgQnJlbnQgRnVsZ2hhbSAgPGJmdWxnaGFtQHdlYmtpdC5vcmc+CiAKICAgICAgICAgQnVp bGQgZml4LiAgTm8gUmV2aWV3LgpJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gNTYwOTIpCisrKyBMYXlvdXRU ZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMyBAQAorMjAxMC0wMy0x NiAgQ2hyaXMgRmxlaXphY2ggIDxjZmxlaXphY2hAYXBwbGUuY29tPgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJFR1JFU1NJT04gKHI1Mzg1Nyk6IENy YXNoIHdoZW4gdGFiYmluZyB0byA8bWFwPgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MzYwMTcKKworICAgICAgICAqIGZhc3QvZXZlbnRzL2ltYWdlbWFw LW5vcmVuZGVyLWNyYXNoLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogZmFzdC9ldmVu dHMvaW1hZ2VtYXAtbm9yZW5kZXItY3Jhc2guaHRtbDogQWRkZWQuCisKIDIwMTAtMDMtMTUgIE9q YW4gVmFmYWkgIDxvamFuQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBBbGV4 ZXkgUHJvc2t1cnlha292Lgo=