36012 2010-03-11 06:09:19 -0800 Send the frame URL on GeolocationServiceBridgeImpl::startUpdating. 2010-03-23 13:09:39 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 0 bulach webkit-unassigned commit-queue jorlow joth oldest_to_newest 198581 0 bulach 2010-03-11 06:09:19 -0800 Send the frame URL on GeolocationServiceBridgeImpl::startUpdating. 198610 1 bulach 2010-03-11 07:25:24 -0800 This change adds URL when calling GeolocationServiceBridgeImpl::startUpdating so that the embedder can decide whether or not the origin is authorized before actually sending any geoposition. 198617 2 50502 bulach 2010-03-11 07:34:08 -0800 Created attachment 50502 Patch 198621 3 50502 joth 2010-03-11 07:47:29 -0800 Comment on attachment 50502 Patch > Index: WebKit/chromium/public/GeolocationServiceBridgeChromium.h > =================================================================== > --- WebKit/chromium/public/GeolocationServiceBridgeChromium.h (revision 55784) > +++ WebKit/chromium/public/GeolocationServiceBridgeChromium.h (working copy) > @@ -53,7 +53,7 @@ public: > class WebGeolocationServiceInterface { > public: > virtual void requestPermissionForFrame(int bridgeId, const WebURL& url) = 0; > - virtual void startUpdating(int bridgeId, bool hasHighAccuracy) = 0; > + virtual void startUpdating(int bridgeId, const WebURL& url, bool hasHighAccuracy) = 0; Nit: I'm not sure if there's a webkit convention on this, but wantsHighAccuracy would be closer to the intending meaning than hasHighAccuracy 198628 4 50505 bulach 2010-03-11 07:59:59 -0800 Created attachment 50505 Patch 198629 5 50505 jorlow 2010-03-11 08:01:15 -0800 Comment on attachment 50505 Patch r=me 199803 6 50505 commit-queue 2010-03-15 13:30:25 -0700 Comment on attachment 50505 Patch Clearing flags on attachment: 50505 Committed r56011: <http://trac.webkit.org/changeset/56011> 199804 7 commit-queue 2010-03-15 13:30:30 -0700 All reviewed patches have been landed. Closing bug. 203159 8 50505 fishd 2010-03-23 13:09:39 -0700 Comment on attachment 50505 Patch > Index: WebKit/chromium/src/GeolocationServiceBridgeChromium.cpp ... > + getWebViewClient()->getGeolocationService()->startUpdating(m_bridgeId, m_GeolocationServiceChromium->frame()->document()->url(), positionOptions->enableHighAccuracy()); please note that the WebViewClient can be null! 50502 2010-03-11 07:34:08 -0800 2010-03-11 07:59:54 -0800 Patch bug-36012-20100311153406.patch text/plain 2357 bulach SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gNTU4NDIpCisrKyBXZWJLaXQvY2hyb21pdW0vQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMDMtMTEgIE1hcmN1 cyBCdWxhY2ggIDxidWxhY2hAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFNlbmQgdGhlIGZyYW1lIFVSTCBvbiBHZW9sb2NhdGlv blNlcnZpY2VCcmlkZ2VJbXBsOjpzdGFydFVwZGF0aW5nLgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzYwMTIKKworICAgICAgICAqIHB1YmxpYy9HZW9s b2NhdGlvblNlcnZpY2VCcmlkZ2VDaHJvbWl1bS5oOgorICAgICAgICAqIHNyYy9HZW9sb2NhdGlv blNlcnZpY2VCcmlkZ2VDaHJvbWl1bS5jcHA6CisgICAgICAgIChXZWJLaXQ6Okdlb2xvY2F0aW9u U2VydmljZUJyaWRnZUltcGw6OnN0YXJ0VXBkYXRpbmcpOgorCiAyMDEwLTAzLTEwICBEYXJpbiBG aXNoZXIgIDxkYXJpbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgSmVyZW15 IE9ybG93LgpJbmRleDogV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9HZW9sb2NhdGlvblNlcnZpY2VC cmlkZ2VDaHJvbWl1bS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9jaHJvbWl1bS9wdWJsaWMvR2Vv bG9jYXRpb25TZXJ2aWNlQnJpZGdlQ2hyb21pdW0uaAkocmV2aXNpb24gNTU3ODQpCisrKyBXZWJL aXQvY2hyb21pdW0vcHVibGljL0dlb2xvY2F0aW9uU2VydmljZUJyaWRnZUNocm9taXVtLmgJKHdv cmtpbmcgY29weSkKQEAgLTUzLDcgKzUzLDcgQEAgcHVibGljOgogY2xhc3MgV2ViR2VvbG9jYXRp b25TZXJ2aWNlSW50ZXJmYWNlIHsKIHB1YmxpYzoKICAgICB2aXJ0dWFsIHZvaWQgcmVxdWVzdFBl cm1pc3Npb25Gb3JGcmFtZShpbnQgYnJpZGdlSWQsIGNvbnN0IFdlYlVSTCYgdXJsKSA9IDA7Ci0g ICAgdmlydHVhbCB2b2lkIHN0YXJ0VXBkYXRpbmcoaW50IGJyaWRnZUlkLCBib29sIGhhc0hpZ2hB Y2N1cmFjeSkgPSAwOworICAgIHZpcnR1YWwgdm9pZCBzdGFydFVwZGF0aW5nKGludCBicmlkZ2VJ ZCwgY29uc3QgV2ViVVJMJiB1cmwsIGJvb2wgaGFzSGlnaEFjY3VyYWN5KSA9IDA7CiAgICAgdmly dHVhbCB2b2lkIHN0b3BVcGRhdGluZyhpbnQgYnJpZGdlSWQpID0gMDsKICAgICB2aXJ0dWFsIHZv aWQgc3VzcGVuZChpbnQgYnJpZGdlSWQpID0gMDsKICAgICB2aXJ0dWFsIHZvaWQgcmVzdW1lKGlu dCBicmlkZ2VJZCkgPSAwOwpJbmRleDogV2ViS2l0L2Nocm9taXVtL3NyYy9HZW9sb2NhdGlvblNl cnZpY2VCcmlkZ2VDaHJvbWl1bS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2Nocm9taXVtL3Ny Yy9HZW9sb2NhdGlvblNlcnZpY2VCcmlkZ2VDaHJvbWl1bS5jcHAJKHJldmlzaW9uIDU1Nzg0KQor KysgV2ViS2l0L2Nocm9taXVtL3NyYy9HZW9sb2NhdGlvblNlcnZpY2VCcmlkZ2VDaHJvbWl1bS5j cHAJKHdvcmtpbmcgY29weSkKQEAgLTExNywxMCArMTE3LDcgQEAgYm9vbCBHZW9sb2NhdGlvblNl cnZpY2VCcmlkZ2VJbXBsOjpzdGFydAogewogICAgIGlmICghbV9icmlkZ2VJZCkKICAgICAgICAg bV9icmlkZ2VJZCA9IGdldFdlYlZpZXdDbGllbnQoKS0+Z2V0R2VvbG9jYXRpb25TZXJ2aWNlKCkt PmF0dGFjaEJyaWRnZSh0aGlzKTsKLSAgICBnZXRXZWJWaWV3Q2xpZW50KCktPmdldEdlb2xvY2F0 aW9uU2VydmljZSgpLT5zdGFydFVwZGF0aW5nKG1fYnJpZGdlSWQsIHBvc2l0aW9uT3B0aW9ucy0+ ZW5hYmxlSGlnaEFjY3VyYWN5KCkpOwotICAgIC8vLy8gRklYTUU6IHRoaXMgd2lsbCB0cmlnZ2Vy IGEgcGVybWlzc2lvbiByZXF1ZXN0IHJlZ2FyZGxlc3MuCi0gICAgLy8vLyBJcyBpdCBjb3JyZWN0 PyBjb25maXJtIHdpdGggYW5kcmVpcC4KLSAgICAvLyBwb3NpdGlvbkNoYW5nZWQoKTsKKyAgICBn ZXRXZWJWaWV3Q2xpZW50KCktPmdldEdlb2xvY2F0aW9uU2VydmljZSgpLT5zdGFydFVwZGF0aW5n KG1fYnJpZGdlSWQsIG1fR2VvbG9jYXRpb25TZXJ2aWNlQ2hyb21pdW0tPmZyYW1lKCktPmRvY3Vt ZW50KCktPnVybCgpLCBwb3NpdGlvbk9wdGlvbnMtPmVuYWJsZUhpZ2hBY2N1cmFjeSgpKTsKICAg ICByZXR1cm4gdHJ1ZTsKIH0KIAo= 50505 2010-03-11 07:59:59 -0800 2010-03-23 13:09:39 -0700 Patch bug-36012-20100311155957.patch text/plain 2360 bulach SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gNTU4NDIpCisrKyBXZWJLaXQvY2hyb21pdW0vQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMDMtMTEgIE1hcmN1 cyBCdWxhY2ggIDxidWxhY2hAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFNlbmQgdGhlIGZyYW1lIFVSTCBvbiBHZW9sb2NhdGlv blNlcnZpY2VCcmlkZ2VJbXBsOjpzdGFydFVwZGF0aW5nLgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzYwMTIKKworICAgICAgICAqIHB1YmxpYy9HZW9s b2NhdGlvblNlcnZpY2VCcmlkZ2VDaHJvbWl1bS5oOgorICAgICAgICAqIHNyYy9HZW9sb2NhdGlv blNlcnZpY2VCcmlkZ2VDaHJvbWl1bS5jcHA6CisgICAgICAgIChXZWJLaXQ6Okdlb2xvY2F0aW9u U2VydmljZUJyaWRnZUltcGw6OnN0YXJ0VXBkYXRpbmcpOgorCiAyMDEwLTAzLTEwICBEYXJpbiBG aXNoZXIgIDxkYXJpbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgSmVyZW15 IE9ybG93LgpJbmRleDogV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9HZW9sb2NhdGlvblNlcnZpY2VC cmlkZ2VDaHJvbWl1bS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9jaHJvbWl1bS9wdWJsaWMvR2Vv bG9jYXRpb25TZXJ2aWNlQnJpZGdlQ2hyb21pdW0uaAkocmV2aXNpb24gNTU3ODQpCisrKyBXZWJL aXQvY2hyb21pdW0vcHVibGljL0dlb2xvY2F0aW9uU2VydmljZUJyaWRnZUNocm9taXVtLmgJKHdv cmtpbmcgY29weSkKQEAgLTUzLDcgKzUzLDcgQEAgcHVibGljOgogY2xhc3MgV2ViR2VvbG9jYXRp b25TZXJ2aWNlSW50ZXJmYWNlIHsKIHB1YmxpYzoKICAgICB2aXJ0dWFsIHZvaWQgcmVxdWVzdFBl cm1pc3Npb25Gb3JGcmFtZShpbnQgYnJpZGdlSWQsIGNvbnN0IFdlYlVSTCYgdXJsKSA9IDA7Ci0g ICAgdmlydHVhbCB2b2lkIHN0YXJ0VXBkYXRpbmcoaW50IGJyaWRnZUlkLCBib29sIGhhc0hpZ2hB Y2N1cmFjeSkgPSAwOworICAgIHZpcnR1YWwgdm9pZCBzdGFydFVwZGF0aW5nKGludCBicmlkZ2VJ ZCwgY29uc3QgV2ViVVJMJiB1cmwsIGJvb2wgZW5hYmxlSGlnaEFjY3VyYWN5KSA9IDA7CiAgICAg dmlydHVhbCB2b2lkIHN0b3BVcGRhdGluZyhpbnQgYnJpZGdlSWQpID0gMDsKICAgICB2aXJ0dWFs IHZvaWQgc3VzcGVuZChpbnQgYnJpZGdlSWQpID0gMDsKICAgICB2aXJ0dWFsIHZvaWQgcmVzdW1l KGludCBicmlkZ2VJZCkgPSAwOwpJbmRleDogV2ViS2l0L2Nocm9taXVtL3NyYy9HZW9sb2NhdGlv blNlcnZpY2VCcmlkZ2VDaHJvbWl1bS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2Nocm9taXVt L3NyYy9HZW9sb2NhdGlvblNlcnZpY2VCcmlkZ2VDaHJvbWl1bS5jcHAJKHJldmlzaW9uIDU1Nzg0 KQorKysgV2ViS2l0L2Nocm9taXVtL3NyYy9HZW9sb2NhdGlvblNlcnZpY2VCcmlkZ2VDaHJvbWl1 bS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTExNywxMCArMTE3LDcgQEAgYm9vbCBHZW9sb2NhdGlv blNlcnZpY2VCcmlkZ2VJbXBsOjpzdGFydAogewogICAgIGlmICghbV9icmlkZ2VJZCkKICAgICAg ICAgbV9icmlkZ2VJZCA9IGdldFdlYlZpZXdDbGllbnQoKS0+Z2V0R2VvbG9jYXRpb25TZXJ2aWNl KCktPmF0dGFjaEJyaWRnZSh0aGlzKTsKLSAgICBnZXRXZWJWaWV3Q2xpZW50KCktPmdldEdlb2xv Y2F0aW9uU2VydmljZSgpLT5zdGFydFVwZGF0aW5nKG1fYnJpZGdlSWQsIHBvc2l0aW9uT3B0aW9u cy0+ZW5hYmxlSGlnaEFjY3VyYWN5KCkpOwotICAgIC8vLy8gRklYTUU6IHRoaXMgd2lsbCB0cmln Z2VyIGEgcGVybWlzc2lvbiByZXF1ZXN0IHJlZ2FyZGxlc3MuCi0gICAgLy8vLyBJcyBpdCBjb3Jy ZWN0PyBjb25maXJtIHdpdGggYW5kcmVpcC4KLSAgICAvLyBwb3NpdGlvbkNoYW5nZWQoKTsKKyAg ICBnZXRXZWJWaWV3Q2xpZW50KCktPmdldEdlb2xvY2F0aW9uU2VydmljZSgpLT5zdGFydFVwZGF0 aW5nKG1fYnJpZGdlSWQsIG1fR2VvbG9jYXRpb25TZXJ2aWNlQ2hyb21pdW0tPmZyYW1lKCktPmRv Y3VtZW50KCktPnVybCgpLCBwb3NpdGlvbk9wdGlvbnMtPmVuYWJsZUhpZ2hBY2N1cmFjeSgpKTsK ICAgICByZXR1cm4gdHJ1ZTsKIH0KIAo=