36003 2010-03-10 21:58:02 -0800 Enhance GTK DRT implementation to support platform scroll wheel events. 2012-09-07 08:16:54 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Enhancement --- 88070 1 aestes webkit-unassigned aestes jdapena mrobinson pnormand zan oldest_to_newest 198484 0 aestes 2010-03-10 21:58:02 -0800 DRT layout tests gained the ability to simulate mouse scroll wheel events in http://trac.webkit.org/changeset/55739. Currently this is only supported on Mac OS 10.5 and 10.6. The GTK DRT implementation should be enhanced to dispatch scroll wheel events, and layout tests that utilize this functionality should be removed from the Skipped file. 642433 1 146016 jdapena 2012-06-06 07:05:27 -0700 Created attachment 146016 Patch 657822 2 zan 2012-06-26 12:07:13 -0700 CC-ing reviewers to have a look at the patch. 657896 3 146016 mrobinson 2012-06-26 13:04:20 -0700 Comment on attachment 146016 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=146016&action=review Looks good, just a few style nits. Can't we unskip some tests now? > Tools/DumpRenderTree/gtk/EventSender.cpp:483 > + int horizontal = (int)JSValueToNumber(context, arguments[0], exception); > + g_return_val_if_fail((!exception || !*exception), JSValueMakeUndefined(context)); > + int vertical = (int)JSValueToNumber(context, arguments[1], exception); > + g_return_val_if_fail((!exception || !*exception), JSValueMakeUndefined(context)); You should use static_cast here instead of C-style casts. Is it possible to just elminate the cast entirely here? > Tools/DumpRenderTree/gtk/EventSender.cpp:487 > + gboolean paged = false; > + if (argumentCount == 3) { > + paged = JSValueToBoolean(context, arguments[2]); bool intead of gboolean would be more appropriate here. Why does paged need to be defined in outer scope? Seems like this could just be: g_return_val_if_fail(argumentcount < 3 || !JSValueToBoolean(context, arguments[2]), JSValueMakeUndefined(context)); 714538 4 jdapena 2012-09-07 08:16:54 -0700 Fix for #88070 already includes the implementation of DumpRenderTree smooth scroll wheel events for Gtk. 146016 2012-06-06 07:05:27 -0700 2012-06-26 13:04:19 -0700 Patch bug-36003-20120606160526.patch text/plain 4808 jdapena U3VidmVyc2lvbiBSZXZpc2lvbjogMTE5NTgxCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMDliZTNmOGY4Yzg1NDMzMmU2NTVjZjRiMTMzNmU2NjU2 YWVmYTQzNS4uMDk2ZmFhZmExM2I5M2IyY2M2NzlkOTFiNmZiNjFlYzAzNzU3NGEzYSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDEyLTA2LTA2ICBKb3PDqSBEYXBlbmEgUGF6ICA8amRhcGVuYUBpZ2FsaWEuY29tPgor CisgICAgICAgIEVuaGFuY2UgR1RLIERSVCBpbXBsZW1lbnRhdGlvbiB0byBzdXBwb3J0IHBsYXRm b3JtIHNjcm9sbCB3aGVlbCBldmVudHMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0zNjAwMworCisgICAgICAgIEFkZGVkIGxheW91dCB0ZXN0cyBzdXBw b3J0IGZvciBzbW9vdGggc2Nyb2xsIGluIEd0ayAzLjQsIGFuZCB1c2Ugc21vb3RoCisgICAgICAg IHNjcm9sbCBmb3IgZW11bGF0aW5nIG11bHRpLXRpY2sgbW91c2VTY3JvbGxCeSBldmVudHMuCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBEdW1wUmVu ZGVyVHJlZS9ndGsvRXZlbnRTZW5kZXIuY3BwOgorICAgICAgICAobW91c2VTY3JvbGxCeUNhbGxi YWNrKToKKyAgICAgICAgKGNvbnRpbnVvdXNNb3VzZVNjcm9sbEJ5Q2FsbGJhY2spOgorCiAyMDEy LTA2LTA2ICBNaWNoYWVsIEJyw7xuaW5nICA8bWljaGFlbC5icnVuaW5nQG5va2lhLmNvbT4KIAog ICAgICAgICBbUXRdW1dLMl0gQWRkIHByZWZlcnJlZE1pbmltdW1Db250ZW50c1dpZHRoIHRvIHRo ZSB2aWV3cG9ydCBpbmZvIGluIE1pbmlCcm93c2VyLgpkaWZmIC0tZ2l0IGEvVG9vbHMvRHVtcFJl bmRlclRyZWUvZ3RrL0V2ZW50U2VuZGVyLmNwcCBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2d0ay9F dmVudFNlbmRlci5jcHAKaW5kZXggYmMzOGEyMDI5MjEyZjRjNWIzY2FiNDljNTBjMDA2NmM1YTU2 MTA2NS4uYmJmNzJlYTFlYjhkYWVmODViY2MyMjI2NjRiMTdiNDA3YjZiMDM4NCAxMDA2NDQKLS0t IGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvZ3RrL0V2ZW50U2VuZGVyLmNwcAorKysgYi9Ub29scy9E dW1wUmVuZGVyVHJlZS9ndGsvRXZlbnRTZW5kZXIuY3BwCkBAIC04MCw2ICs4MCw5IEBAIHN0YXRp YyB1bnNpZ25lZCBzdGFydE9mUXVldWU7CiAKIHN0YXRpYyBjb25zdCBmbG9hdCB6b29tTXVsdGlw bGllclJhdGlvID0gMS4yZjsKIAorLy8gV2ViQ29yZSBhbmQgbGF5b3V0IHRlc3RzIGFzc3VtZSB0 aGlzIHZhbHVlCitzdGF0aWMgY29uc3QgZmxvYXQgcGl4ZWxzUGVyU2Nyb2xsVGljayA9IDQwLjBm OworCiAvLyBLZXkgZXZlbnQgbG9jYXRpb24gY29kZSBkZWZpbmVkIGluIERPTSBMZXZlbCAzLgog ZW51bSBLZXlMb2NhdGlvbkNvZGUgewogICAgIERPTV9LRVlfTE9DQVRJT05fU1RBTkRBUkQgICAg ICA9IDB4MDAsCkBAIC00MjYsOSArNDI5LDYgQEAgc3RhdGljIEpTVmFsdWVSZWYgbW91c2VTY3Jv bGxCeUNhbGxiYWNrKEpTQ29udGV4dFJlZiBjb250ZXh0LCBKU09iamVjdFJlZiBmdW5jdGkKICAg ICBpbnQgdmVydGljYWwgPSAoaW50KUpTVmFsdWVUb051bWJlcihjb250ZXh0LCBhcmd1bWVudHNb MV0sIGV4Y2VwdGlvbik7CiAgICAgZ19yZXR1cm5fdmFsX2lmX2ZhaWwoKCFleGNlcHRpb24gfHwg ISpleGNlcHRpb24pLCBKU1ZhbHVlTWFrZVVuZGVmaW5lZChjb250ZXh0KSk7CiAKLSAgICAvLyBH VEsrIGRvZXNuJ3Qgc3VwcG9ydCBtdWx0aXBsZSBkaXJlY3Rpb24gc2Nyb2xscyBpbiB0aGUgc2Ft ZSBldmVudCEKLSAgICBnX3JldHVybl92YWxfaWZfZmFpbCgoIXZlcnRpY2FsIHx8ICFob3Jpem9u dGFsKSwgSlNWYWx1ZU1ha2VVbmRlZmluZWQoY29udGV4dCkpOwotCiAgICAgR2RrRXZlbnQqIGV2 ZW50ID0gZ2RrX2V2ZW50X25ldyhHREtfU0NST0xMKTsKICAgICBldmVudC0+c2Nyb2xsLnggPSBs YXN0TW91c2VQb3NpdGlvblg7CiAgICAgZXZlbnQtPnNjcm9sbC55ID0gbGFzdE1vdXNlUG9zaXRp b25ZOwpAQCAtNDM2LDYgKzQzNiwyMSBAQCBzdGF0aWMgSlNWYWx1ZVJlZiBtb3VzZVNjcm9sbEJ5 Q2FsbGJhY2soSlNDb250ZXh0UmVmIGNvbnRleHQsIEpTT2JqZWN0UmVmIGZ1bmN0aQogICAgIGV2 ZW50LT5zY3JvbGwud2luZG93ID0gZ3RrX3dpZGdldF9nZXRfd2luZG93KEdUS19XSURHRVQodmll dykpOwogICAgIGdfb2JqZWN0X3JlZihldmVudC0+c2Nyb2xsLndpbmRvdyk7CiAKKyAgICAvLyBH VEsrIGRvZXNuJ3Qgc3VwcG9ydCBtdWx0aXBsZSBkaXJlY3Rpb24gc2Nyb2xscyBpbiB0aGUgc2Ft ZSBkaXJlY3Rpb25hbCBldmVudAorICAgIC8vIHNvIHdlIHVzZSBzbW9vdGggZXZlbnQgZm9yIHRo YXQgY2FzZSwgc3VwcG9ydGVkIGZyb20gR3RrIDMuMy4xOAorCisjaWYgR1RLX0NIRUNLX1ZFUlNJ T04oMywgMywgMTgpCisgICAgaWYgKChob3Jpem9udGFsICYmIHZlcnRpY2FsKSB8fCBob3Jpem9u dGFsID4gMSB8fCBob3Jpem9udGFsIDwgLTEgfHwgdmVydGljYWwgPiAxIHx8IHZlcnRpY2FsIDwg LTEpIHsKKyAgICAgICAgZXZlbnQtPnNjcm9sbC5kaXJlY3Rpb24gPSBHREtfU0NST0xMX1NNT09U SDsKKyAgICAgICAgZXZlbnQtPnNjcm9sbC5kZWx0YV94ID0gLWhvcml6b250YWw7CisgICAgICAg IGV2ZW50LT5zY3JvbGwuZGVsdGFfeSA9IC12ZXJ0aWNhbDsKKworICAgICAgICBzZW5kT3JRdWV1 ZUV2ZW50KGV2ZW50KTsKKyAgICAgICAgcmV0dXJuIEpTVmFsdWVNYWtlVW5kZWZpbmVkKGNvbnRl eHQpOworICAgIH0KKyNlbmRpZgorICAgIGdfcmV0dXJuX3ZhbF9pZl9mYWlsKCghdmVydGljYWwg fHwgIWhvcml6b250YWwpLCBKU1ZhbHVlTWFrZVVuZGVmaW5lZChjb250ZXh0KSk7CisKICAgICBp ZiAoaG9yaXpvbnRhbCA8IDApCiAgICAgICAgIGV2ZW50LT5zY3JvbGwuZGlyZWN0aW9uID0gR0RL X1NDUk9MTF9SSUdIVDsKICAgICBlbHNlIGlmIChob3Jpem9udGFsID4gMCkKQEAgLTQ1Myw3ICs0 NjgsNDEgQEAgc3RhdGljIEpTVmFsdWVSZWYgbW91c2VTY3JvbGxCeUNhbGxiYWNrKEpTQ29udGV4 dFJlZiBjb250ZXh0LCBKU09iamVjdFJlZiBmdW5jdGkKIAogc3RhdGljIEpTVmFsdWVSZWYgY29u dGludW91c01vdXNlU2Nyb2xsQnlDYWxsYmFjayhKU0NvbnRleHRSZWYgY29udGV4dCwgSlNPYmpl Y3RSZWYgZnVuY3Rpb24sIEpTT2JqZWN0UmVmIHRoaXNPYmplY3QsIHNpemVfdCBhcmd1bWVudENv dW50LCBjb25zdCBKU1ZhbHVlUmVmIGFyZ3VtZW50c1tdLCBKU1ZhbHVlUmVmKiBleGNlcHRpb24p CiB7Ci0gICAgLy8gR1RLIGRvZXNuJ3Qgc3VwcG9ydCBjb250aW51b3VzIHNjcm9sbCBldmVudHMu CisgICAgLy8gR1RLIHN1cHBvcnQgY29udGludW91cyBzY3JvbGwgZXZlbnRzIGZyb20gMy4zLjE4 CisjaWYgR1RLX0NIRUNLX1ZFUlNJT04oMywgMywgMTgpCisgICAgV2ViS2l0V2ViVmlldyogdmll dyA9IHdlYmtpdF93ZWJfZnJhbWVfZ2V0X3dlYl92aWV3KG1haW5GcmFtZSk7CisgICAgaWYgKCF2 aWV3KQorICAgICAgICByZXR1cm4gSlNWYWx1ZU1ha2VVbmRlZmluZWQoY29udGV4dCk7CisKKyAg ICBpZiAoYXJndW1lbnRDb3VudCA8IDIpCisgICAgICAgIHJldHVybiBKU1ZhbHVlTWFrZVVuZGVm aW5lZChjb250ZXh0KTsKKworICAgIGludCBob3Jpem9udGFsID0gKGludClKU1ZhbHVlVG9OdW1i ZXIoY29udGV4dCwgYXJndW1lbnRzWzBdLCBleGNlcHRpb24pOworICAgIGdfcmV0dXJuX3ZhbF9p Zl9mYWlsKCghZXhjZXB0aW9uIHx8ICEqZXhjZXB0aW9uKSwgSlNWYWx1ZU1ha2VVbmRlZmluZWQo Y29udGV4dCkpOworICAgIGludCB2ZXJ0aWNhbCA9IChpbnQpSlNWYWx1ZVRvTnVtYmVyKGNvbnRl eHQsIGFyZ3VtZW50c1sxXSwgZXhjZXB0aW9uKTsKKyAgICBnX3JldHVybl92YWxfaWZfZmFpbCgo IWV4Y2VwdGlvbiB8fCAhKmV4Y2VwdGlvbiksIEpTVmFsdWVNYWtlVW5kZWZpbmVkKGNvbnRleHQp KTsKKworICAgIGdib29sZWFuIHBhZ2VkID0gZmFsc2U7CisgICAgaWYgKGFyZ3VtZW50Q291bnQg PT0gMykgeworICAgICAgICBwYWdlZCA9IEpTVmFsdWVUb0Jvb2xlYW4oY29udGV4dCwgYXJndW1l bnRzWzJdKTsKKworICAgICAgICAvLyBHdGsrIGRvZXMgbm90IHN1cHBvcnQgcGFnZWQgc2Nyb2xs IGV2ZW50cworICAgICAgICBnX3JldHVybl92YWxfaWZfZmFpbCghcGFnZWQsIEpTVmFsdWVNYWtl VW5kZWZpbmVkKGNvbnRleHQpKTsKKyAgICB9CisgICAgCisgICAgR2RrRXZlbnQqIGV2ZW50ID0g Z2RrX2V2ZW50X25ldyhHREtfU0NST0xMKTsKKyAgICBldmVudC0+c2Nyb2xsLnggPSBsYXN0TW91 c2VQb3NpdGlvblg7CisgICAgZXZlbnQtPnNjcm9sbC55ID0gbGFzdE1vdXNlUG9zaXRpb25ZOwor ICAgIGV2ZW50LT5zY3JvbGwudGltZSA9IEdES19DVVJSRU5UX1RJTUU7CisgICAgZXZlbnQtPnNj cm9sbC53aW5kb3cgPSBndGtfd2lkZ2V0X2dldF93aW5kb3coR1RLX1dJREdFVCh2aWV3KSk7Cisg ICAgZ19vYmplY3RfcmVmKGV2ZW50LT5zY3JvbGwud2luZG93KTsKKworICAgIGV2ZW50LT5zY3Jv bGwuZGlyZWN0aW9uID0gR0RLX1NDUk9MTF9TTU9PVEg7CisgICAgZXZlbnQtPnNjcm9sbC5kZWx0 YV94ID0gLWhvcml6b250YWwgLyBwaXhlbHNQZXJTY3JvbGxUaWNrOworICAgIGV2ZW50LT5zY3Jv bGwuZGVsdGFfeSA9IC12ZXJ0aWNhbCAvIHBpeGVsc1BlclNjcm9sbFRpY2s7CisKKyAgICBzZW5k T3JRdWV1ZUV2ZW50KGV2ZW50KTsKKyNlbmRpZgogICAgIHJldHVybiBKU1ZhbHVlTWFrZVVuZGVm aW5lZChjb250ZXh0KTsKIH0KIAo=