35997 2010-03-10 17:26:14 -0800 Webkit doesn't build with workers on and database off 2010-03-12 06:53:25 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 noam webkit-unassigned commit-queue kent.hansen oldest_to_newest 198432 0 noam 2010-03-10 17:26:14 -0800 This was tested on the Qt version, but might be applicable elsewhere When building webkit with --no-database, but without --no-workers, the build fails in WorkerThread.cpp line 188 198659 1 kent.hansen 2010-03-11 09:35:56 -0800 I could make it compile by adding a few #if ENABLE(DATABASE). It looks like those were missed in r53595, since the patch does have DATABASE guards in other places. Anyways, this code is not Qt-specific. 198663 2 50513 kent.hansen 2010-03-11 10:00:21 -0800 Created attachment 50513 Proposed patch 199019 3 50513 commit-queue 2010-03-12 06:53:15 -0800 Comment on attachment 50513 Proposed patch Clearing flags on attachment: 50513 Committed r55896: <http://trac.webkit.org/changeset/55896> 199020 4 commit-queue 2010-03-12 06:53:25 -0800 All reviewed patches have been landed. Closing bug. 50513 2010-03-11 10:00:21 -0800 2010-03-12 06:53:15 -0800 Proposed patch CompileWithNoDatabase.diff text/plain 1762 kent.hansen ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg OTJkNzZhOS4uZDYzNThmOCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0wMy0xMSAgS2VudCBIYW5zZW4g IDxrZW50LmhhbnNlbkBub2tpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgV2Via2l0IGRvZXNuJ3QgYnVpbGQgd2l0aCB3b3JrZXJzIG9uIGFu ZCBkYXRhYmFzZSBvZmYKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTM1OTk3CisKKyAgICAgICAgQWRkZWQgbWlzc2luZyBFTkFCTEUoREFUQUJBU0UpIGd1 YXJkcy4KKworICAgICAgICAqIHdvcmtlcnMvV29ya2VyVGhyZWFkLmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OldvcmtlclRocmVhZFNodXRkb3duU3RhcnRUYXNrOjpwZXJmb3JtVGFzayk6CisKIDIw MTAtMDMtMDQgIFBoaWxpcHBlIE5vcm1hbmQgIDxwbm9ybWFuZEBpZ2FsaWEuY29tPgogCiAgICAg ICAgIFJldmlld2VkIGJ5IEVyaWMgU2VpZGVsLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS93b3JrZXJz L1dvcmtlclRocmVhZC5jcHAgYi9XZWJDb3JlL3dvcmtlcnMvV29ya2VyVGhyZWFkLmNwcAppbmRl eCAwNWZiZTY1Li4zODIzYWQ0IDEwMDY0NAotLS0gYS9XZWJDb3JlL3dvcmtlcnMvV29ya2VyVGhy ZWFkLmNwcAorKysgYi9XZWJDb3JlL3dvcmtlcnMvV29ya2VyVGhyZWFkLmNwcApAQCAtMTgzLDEw ICsxODMsMTIgQEAgcHVibGljOgogICAgICAgICBBU1NFUlQoY29udGV4dC0+aXNXb3JrZXJDb250 ZXh0KCkpOwogICAgICAgICBXb3JrZXJDb250ZXh0KiB3b3JrZXJDb250ZXh0ID0gc3RhdGljX2Nh c3Q8V29ya2VyQ29udGV4dCo+KGNvbnRleHQpOwogCisjaWYgRU5BQkxFKERBVEFCQVNFKQogICAg ICAgICAvLyBXZSBjdXJyZW50bHkgaWdub3JlIGFueSBEYXRhYmFzZVBvbGljeSB1c2VkIGZvciB0 aGUgZG9jdW1lbnQncwogICAgICAgICAvLyBkYXRhYmFzZXM7IGlmIGl0J3MgYWN0dWFsbHkgdXNl ZCBhbnl3aGVyZSwgdGhpcyBzaG91bGQgYmUgcmV2aXNpdGVkLgogICAgICAgICBEYXRhYmFzZVRh c2tTeW5jaHJvbml6ZXIgY2xlYW51cFN5bmM7CiAgICAgICAgIHdvcmtlckNvbnRleHQtPnN0b3BE YXRhYmFzZXMoJmNsZWFudXBTeW5jKTsKKyNlbmRpZgogCiAgICAgICAgIHdvcmtlckNvbnRleHQt PnN0b3BBY3RpdmVET01PYmplY3RzKCk7CiAKQEAgLTE5NSw5ICsxOTcsMTEgQEAgcHVibGljOgog ICAgICAgICB3b3JrZXJDb250ZXh0LT5yZW1vdmVBbGxFdmVudExpc3RlbmVycygpOwogICAgICAg ICB3b3JrZXJDb250ZXh0LT5jbGVhclNjcmlwdCgpOwogCisjaWYgRU5BQkxFKERBVEFCQVNFKQog ICAgICAgICAvLyBXZSB3YWl0IGZvciB0aGUgZGF0YWJhc2UgdGhyZWFkIHRvIGNsZWFuIHVwIGFs bCBpdHMgc3R1ZmYgc28gdGhhdCB3ZQogICAgICAgICAvLyBjYW4gZG8gbW9yZSBzdHJpbmdlbnQg bGVhayBjaGVja3MgYXMgd2UgZXhpdC4KICAgICAgICAgY2xlYW51cFN5bmMud2FpdEZvclRhc2tD b21wbGV0aW9uKCk7CisjZW5kaWYKIAogICAgICAgICAvLyBTdGljayBhIHNodXRkb3duIGNvbW1h bmQgYXQgdGhlIGVuZCBvZiB0aGUgcXVldWUsIHNvIHRoYXQgd2UgZGVhbAogICAgICAgICAvLyB3 aXRoIGFsbCB0aGUgY2xlYW51cCB0YXNrcyB0aGUgZGF0YWJhc2VzIHBvc3QgZmlyc3QuCg==