3599 2005-06-17 15:47:08 -0700 Incorrect layout of explicit embedding levels 2005-11-04 00:31:38 -0800 1 1 1 Unclassified WebKit Layout and Rendering 412 Mac OS X 10.4 CLOSED FIXED P2 Normal --- 1 mitz hyatt bugs.mano oldest_to_newest 12509 0 mitz 2005-06-17 15:47:08 -0700 Summary: The layout is wrong in many cases of explicit Unicode embedding (either by a <span> with direction property or by Unicode embedding characters) occurs. To Reproduce: See testcase. Expected/Actual: Testcase includes a description of expected rendering. Firefox renders as expected. Note that mirroring behavior is also affected by a separate ATSUI issue with certain fonts. Use Lucida Grande for testing. Analysis: The testcase actually expose three issues in bidi.cpp: 1. bidiReorderLine() not closing the "dangling" run when it sees an explicit embedding character (or PDF). 2. embed() not setting up the new run correctly following an embed/pop. 3. bidiReorderLine ()'s implementation of rule L2 of the Unicode bidi algorithm is broken for lines where the embedding levels aren't unimodal (the index variable is advancing too fast). The proposed patch addresses these issues and fixes all the lines in the testcase. Testcase can be used as a new layout test. 12510 1 2453 mitz 2005-06-17 15:49:17 -0700 Created attachment 2453 testcase 12511 2 2454 mitz 2005-06-17 15:59:11 -0700 Created attachment 2454 Proposed fix 12541 3 2454 mitz 2005-06-18 13:50:29 -0700 Comment on attachment 2454 Proposed fix Pulling the patch since it causes Safari to hang under some hard-to-reproduce circumstances. 12792 4 mitz 2005-06-21 05:41:27 -0700 I've split the 3rd issue (implementation of rule L2) off into bug 3633 . 12853 5 2551 mitz 2005-06-22 14:51:12 -0700 Created attachment 2551 Proposed fix 12878 6 darin 2005-06-22 19:45:29 -0700 If the test case requires using Lucida Grande, then we should add CSS to make it do that, instead of relying on the default font. 12879 7 2551 darin 2005-06-22 19:47:46 -0700 Comment on attachment 2551 Proposed fix I'm not really qualified to say whether this code is better or not, since I don't understand the bidi algorithm nor the details of our implementation of it. But as long as this fixes this test case and doesn't break any existing cases, I say r=me. 12918 8 2582 mitz 2005-06-23 05:58:19 -0700 Created attachment 2582 Testcase Specified the use of Lucida Grande and added an item. 13103 9 2632 mitz 2005-06-24 12:36:47 -0700 Created attachment 2632 Testcase Modified testcase so that the textual description of the expected layout (digits in increasing orders) would be correct. 2453 2005-06-17 15:49:17 -0700 2005-06-23 05:58:19 -0700 testcase explicitEmbedding.html text/html 1045 mitz PCFET0NUWVBFIEhUTUwgUFVCTElDICItLy9XM0MvL0RURCBIVE1MIDQuMDEgVHJhbnNpdGlvbmFs Ly9FTiIgCiJodHRwOi8vd3d3LnczLm9yZy9UUi9odG1sNC9sb29zZS5kdGQiPgo8aHRtbD4NCjxo ZWFkPg0KPHRpdGxlPkVtYmVkZGluZyBidWdzPC90aXRsZT4NCjwvaGVhZD4NCjxib2R5Pgo8cD4K SW4gZWFjaCBsaW5lLCByZWFkaW5nIGZyb20gbGVmdCB0byByaWdodCwgdGhlIGJyYWNrZXQgc2hv dWxkCmFwcGVhciBiZWZvcmUgdGhlIHBhcmVudGhlc2lzLiBUaGUgYnJhY2tldCBzaG91bGQgYmUg YSBsZWZ0IGJyYWNrZXQgYW5kCnRoZSBwYXJlbnRoZXNpcyBzaG91bGQgYmUgYSByaWdodCBwYXJl bnRoZXNpcy4gSW4gZWFjaCBsaW5lLCBSb21hbiBjaGFyYWN0ZXJzCmFuZCBkaWdpdHMgc2hvdWxk IGJlIGluIGluY3JlYXNpbmcgb3JkZXIgZnJvbSBsZWZ0IHRvIHJpZ2h0Lgo8L3A+CjxwPgomI3gw NWQwOyYjeDA1ZDE7JiN4MDVkMjsgZGVmIDxzcGFuIGRpcj0icnRsIj4oJiN4MDVkNjsmI3gwNWQ3 OyYjeDA1ZDg7XTwvc3Bhbj4gamtsCjwvcD4KPHA+CiYjeDA1ZDA7JiN4MDVkMTsmI3gwNWQyOyBk ZWYgPHNwYW4gZGlyPSJydGwiPihnaGldPC9zcGFuPiBqa2wKPC9wPgo8cD4KYWJjIDxzcGFuIGRp cj0icnRsIj4oMjMgNDVdPC9zcGFuPiBmZ2gKPC9wPgo8cD4KYWJjICYjeDIwMkI7KDIzIDQ1XSYj eDIwMkM7IGZnaAo8L3A+CjxwPgphYmMgJiN4MjAyQjsoZGUgZmddJiN4MjAyQzsgaGlqCjwvcD4K PHA+CjE8c3BhbiBkaXI9InJ0bCI+KGFiIGNkXTwvc3Bhbj4KPC9wPgo8cD4KMTxzcGFuIGRpcj0i cnRsIj4oYWIgJiN4MDVkMjsmI3gwNWQzO108L3NwYW4+CjwvcD4KPHA+CjE8c3Bhbj4mI3gyMDJC OygyXSYjeDIwMkM7PC9zcGFuPgo8L3A+CjxwPgoxPHNwYW4+JiN4MjAyQjsoYV0mI3gyMDJDOzwv c3Bhbj4KPC9wPgo8cD4KMSYjeDIwMkI7KGFiICYjeDA1ZDI7JiN4MDVkMztdJiN4MjAyQzsKPC9w Pgo8cD4KPHNwYW4gZGlyPSJydGwiPihkZWYgJiN4MDVkMDsmI3gwNWQxOyYjeDA1ZDI7IGFiY108 L3NwYW4+CjwvcD4KPC9ib2R5Pg== 2454 2005-06-17 15:59:11 -0700 2005-06-18 13:50:29 -0700 Proposed fix 3599_patch_r1.txt text/plain 1396 mitz SW5kZXg6IC4vV2ViQ29yZS9raHRtbC9yZW5kZXJpbmcvYmlkaS5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1Mg ZmlsZTogL2N2cy9yb290L1dlYkNvcmUva2h0bWwvcmVuZGVyaW5nL2JpZGkuY3BwLHYKcmV0cmll dmluZyByZXZpc2lvbiAxLjEyNwpkaWZmIC1wIC11IC1yMS4xMjcgLi9XZWJDb3JlL2todG1sL3Jl bmRlcmluZy9iaWRpLmNwcAotLS0gLi9XZWJDb3JlL2todG1sL3JlbmRlcmluZy9iaWRpLmNwcAky MDA1LzA1LzI3IDAxOjE3OjMyCTEuMTI3CisrKyAuL1dlYkNvcmUva2h0bWwvcmVuZGVyaW5nL2Jp ZGkuY3BwCTIwMDUvMDYvMTcgMjI6NTE6MjkKQEAgLTYyNiwxMCArNjI2LDE0IEBAIHN0YXRpYyB2 b2lkIGVtYmVkKCBRQ2hhcjo6RGlyZWN0aW9uIGQsIEIKIAogCSAgICBiaWRpLmNvbnRleHQgPSBu ZXcgQmlkaUNvbnRleHQobGV2ZWwsIHJ1bkRpciwgYmlkaS5jb250ZXh0LCBvdmVycmlkZSk7CiAJ ICAgIGJpZGkuY29udGV4dC0+cmVmKCk7Ci0JICAgIGlmICggb3ZlcnJpZGUgKQogCQlkaXIgPSBy dW5EaXI7Ci0JICAgIGJpZGkuc3RhdHVzLmxhc3QgPSBydW5EaXI7Ci0JICAgIGJpZGkuc3RhdHVz Lmxhc3RTdHJvbmcgPSBydW5EaXI7CisJICAgIGlmICggb3ZlcnJpZGUgKSB7CisJCSAgICBiaWRp LnN0YXR1cy5sYXN0ID0gcnVuRGlyOworCQkgICAgYmlkaS5zdGF0dXMubGFzdFN0cm9uZyA9IHJ1 bkRpcjsKKyAgICAgICAgfSBlbHNlIHsKKwkJICAgIGJpZGkuc3RhdHVzLmxhc3QgPSBRQ2hhcjo6 RGlyT047CisJCSAgICBiaWRpLnN0YXR1cy5sYXN0U3Ryb25nID0gUUNoYXI6OkRpck9OOworCQl9 CiAJfQogICAgIH0KICAgICBhZGp1c3RFbWJlZGRpbmcgPSBiOwpAQCAtOTE3LDcgKzkyMSw2IEBA IHZvaWQgUmVuZGVyQmxvY2s6OmJpZGlSZW9yZGVyTGluZShjb25zdCAKICAgICAgICAgY2FzZSBR Q2hhcjo6RGlyUkxPOgogICAgICAgICBjYXNlIFFDaGFyOjpEaXJMUk86CiAgICAgICAgIGNhc2Ug UUNoYXI6OkRpclBERjoKLSAgICAgICAgICAgIGJpZGkuZW9yID0gYmlkaS5sYXN0OwogICAgICAg ICAgICAgZW1iZWQoIGRpckN1cnJlbnQsIGJpZGkgKTsKICAgICAgICAgICAgIGJyZWFrOwogCkBA IC0xMjg4LDcgKzEyOTEsNiBAQCB2b2lkIFJlbmRlckJsb2NrOjpiaWRpUmVvcmRlckxpbmUoY29u c3QgCiAgICAgICAgICAgICAgICAgfQogICAgICAgICAgICAgICAgIGludCBlbmQgPSBpLTE7CiAg ICAgICAgICAgICAgICAgcmV2ZXJzZVJ1bnMoc3RhcnQsIGVuZCk7Ci0gICAgICAgICAgICAgICAg aSsrOwogICAgICAgICAgICAgICAgIGlmKGkgPj0gY291bnQpIGJyZWFrOwogICAgICAgICAgICAg fQogICAgICAgICAgICAgbGV2ZWxIaWdoLS07Cg== 2551 2005-06-22 14:51:12 -0700 2005-06-22 19:47:46 -0700 Proposed fix 3599_patch_r2.txt text/plain 774 mitz SW5kZXg6IGJpZGkuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9jdnMvcm9vdC9XZWJDb3JlL2to dG1sL3JlbmRlcmluZy9iaWRpLmNwcCx2CnJldHJpZXZpbmcgcmV2aXNpb24gMS4xMjgKZGlmZiAt dSAtcjEuMTI4IGJpZGkuY3BwCi0tLSBiaWRpLmNwcAkyMDA1LzA2LzIyIDE3OjM5OjUzCTEuMTI4 CisrKyBiaWRpLmNwcAkyMDA1LzA2LzIyIDIxOjI2OjUyCkBAIC02MjYsMTAgKzYyNiwxMCBAQAog CiAJICAgIGJpZGkuY29udGV4dCA9IG5ldyBCaWRpQ29udGV4dChsZXZlbCwgcnVuRGlyLCBiaWRp LmNvbnRleHQsIG92ZXJyaWRlKTsKIAkgICAgYmlkaS5jb250ZXh0LT5yZWYoKTsKLQkgICAgaWYg KCBvdmVycmlkZSApCiAJCWRpciA9IHJ1bkRpcjsKIAkgICAgYmlkaS5zdGF0dXMubGFzdCA9IHJ1 bkRpcjsKIAkgICAgYmlkaS5zdGF0dXMubGFzdFN0cm9uZyA9IHJ1bkRpcjsKKwkgICAgYmlkaS5z dGF0dXMuZW9yID0gcnVuRGlyOwogCX0KICAgICB9CiAgICAgYWRqdXN0RW1iZWRkaW5nID0gYjsK QEAgLTkxNyw3ICs5MTcsNiBAQAogICAgICAgICBjYXNlIFFDaGFyOjpEaXJSTE86CiAgICAgICAg IGNhc2UgUUNoYXI6OkRpckxSTzoKICAgICAgICAgY2FzZSBRQ2hhcjo6RGlyUERGOgotICAgICAg ICAgICAgYmlkaS5lb3IgPSBiaWRpLmxhc3Q7CiAgICAgICAgICAgICBlbWJlZCggZGlyQ3VycmVu dCwgYmlkaSApOwogICAgICAgICAgICAgYnJlYWs7CiAK 2582 2005-06-23 05:58:19 -0700 2005-06-24 12:36:47 -0700 Testcase explicitEmbedding_r2.html text/html 1142 mitz PCFET0NUWVBFIEhUTUwgUFVCTElDICItLy9XM0MvL0RURCBIVE1MIDQuMDEgVHJhbnNpdGlvbmFs Ly9FTiIgCiJodHRwOi8vd3d3LnczLm9yZy9UUi9odG1sNC9sb29zZS5kdGQiPgo8aHRtbD4NCjxo ZWFkPg0KPHRpdGxlPkVtYmVkZGluZyBidWdzPC90aXRsZT4NCjwvaGVhZD4NCjxib2R5IHN0eWxl PSJmb250LWZhbWlseTonTHVjaWRhIEdyYW5kZSc7Ij4KPHA+CkluIGVhY2ggbGluZSwgcmVhZGlu ZyBmcm9tIGxlZnQgdG8gcmlnaHQsIHRoZSBicmFja2V0IHNob3VsZAphcHBlYXIgYmVmb3JlIHRo ZSBwYXJlbnRoZXNpcy4gVGhlIGJyYWNrZXQgc2hvdWxkIGJlIGEgbGVmdCBicmFja2V0IGFuZAp0 aGUgcGFyZW50aGVzaXMgc2hvdWxkIGJlIGEgcmlnaHQgcGFyZW50aGVzaXMuIEluIGVhY2ggbGlu ZSwgUm9tYW4gY2hhcmFjdGVycwphbmQgZGlnaXRzIHNob3VsZCBiZSBpbiBpbmNyZWFzaW5nIG9y ZGVyIGZyb20gbGVmdCB0byByaWdodC4KPC9wPgo8cD4KJiN4MDVkMDsmI3gwNWQxOyYjeDA1ZDI7 IGRlZiA8c3BhbiBkaXI9InJ0bCI+KCYjeDA1ZDY7JiN4MDVkNzsmI3gwNWQ4O108L3NwYW4+IGpr bAo8L3A+CjxwPgomI3gwNWQwOyYjeDA1ZDE7JiN4MDVkMjsgZGVmIDxzcGFuIGRpcj0icnRsIj4o Z2hpXTwvc3Bhbj4gamtsCjwvcD4KPHA+CmFiYyA8c3BhbiBkaXI9InJ0bCI+KDIzIDQ1XTwvc3Bh bj4gZmdoCjwvcD4KPHA+CmFiYyAmI3gyMDJCOygyMyA0NV0mI3gyMDJDOyBmZ2gKPC9wPgo8cD4K YWJjICYjeDIwMkI7KGRlIGZnXSYjeDIwMkM7IGhpago8L3A+CjxwPgoxPHNwYW4gZGlyPSJydGwi PihhYiBjZF08L3NwYW4+CjwvcD4KPHA+CjE8c3BhbiBkaXI9InJ0bCI+KGFiICYjeDA1ZDI7JiN4 MDVkMztdPC9zcGFuPgo8L3A+CjxwPgoxPHNwYW4+JiN4MjAyQjsoMl0mI3gyMDJDOzwvc3Bhbj4K PC9wPgo8cD4KMTxzcGFuPiYjeDIwMkI7KGFdJiN4MjAyQzs8L3NwYW4+CjwvcD4KPHA+CjEmI3gy MDJCOyhhYiAmI3gwNWQyOyYjeDA1ZDM7XSYjeDIwMkM7CjwvcD4KPHA+CjxzcGFuIGRpcj0icnRs Ij4oZGVmICYjeDA1ZDA7JiN4MDVkMTsmI3gwNWQyOyBhYmNdPC9zcGFuPgo8L3A+CjxwPgomI3gy MDJCOyhkZWYgJiN4MDVkMDsmI3gwNWQxOyYjeDA1ZDI7IGFiY10mI3gyMDJDOwo8L3A+CjwvYm9k eT4= 2632 2005-06-24 12:36:47 -0700 2005-06-24 12:36:47 -0700 Testcase explicitEmbedding_r3.html text/html 1142 mitz PCFET0NUWVBFIEhUTUwgUFVCTElDICItLy9XM0MvL0RURCBIVE1MIDQuMDEgVHJhbnNpdGlvbmFs Ly9FTiIgCiJodHRwOi8vd3d3LnczLm9yZy9UUi9odG1sNC9sb29zZS5kdGQiPgo8aHRtbD4NCjxo ZWFkPg0KPHRpdGxlPkVtYmVkZGluZyBidWdzPC90aXRsZT4NCjwvaGVhZD4NCjxib2R5IHN0eWxl PSJmb250LWZhbWlseTonTHVjaWRhIEdyYW5kZSc7Ij4KPHA+CkluIGVhY2ggbGluZSwgcmVhZGlu ZyBmcm9tIGxlZnQgdG8gcmlnaHQsIHRoZSBicmFja2V0IHNob3VsZAphcHBlYXIgYmVmb3JlIHRo ZSBwYXJlbnRoZXNpcy4gVGhlIGJyYWNrZXQgc2hvdWxkIGJlIGEgbGVmdCBicmFja2V0IGFuZAp0 aGUgcGFyZW50aGVzaXMgc2hvdWxkIGJlIGEgcmlnaHQgcGFyZW50aGVzaXMuIEluIGVhY2ggbGlu ZSwgUm9tYW4gY2hhcmFjdGVycwphbmQgZGlnaXRzIHNob3VsZCBiZSBpbiBpbmNyZWFzaW5nIG9y ZGVyIGZyb20gbGVmdCB0byByaWdodC4KPC9wPgo8cD4KJiN4MDVkMDsmI3gwNWQxOyYjeDA1ZDI7 IGRlZiA8c3BhbiBkaXI9InJ0bCI+KCYjeDA1ZDY7JiN4MDVkNzsmI3gwNWQ4O108L3NwYW4+IGpr bAo8L3A+CjxwPgomI3gwNWQwOyYjeDA1ZDE7JiN4MDVkMjsgZGVmIDxzcGFuIGRpcj0icnRsIj4o Z2hpXTwvc3Bhbj4gamtsCjwvcD4KPHA+CmFiYyA8c3BhbiBkaXI9InJ0bCI+KDQ1IDIzXTwvc3Bh bj4gZmdoCjwvcD4KPHA+CmFiYyAmI3gyMDJCOyg0NSAyM10mI3gyMDJDOyBmZ2gKPC9wPgo8cD4K YWJjICYjeDIwMkI7KGRlIGZnXSYjeDIwMkM7IGhpago8L3A+CjxwPgoxPHNwYW4gZGlyPSJydGwi PihhYiBjZF08L3NwYW4+CjwvcD4KPHA+CjE8c3BhbiBkaXI9InJ0bCI+KGFiICYjeDA1ZDI7JiN4 MDVkMztdPC9zcGFuPgo8L3A+CjxwPgoxPHNwYW4+JiN4MjAyQjsoMl0mI3gyMDJDOzwvc3Bhbj4K PC9wPgo8cD4KMTxzcGFuPiYjeDIwMkI7KGFdJiN4MjAyQzs8L3NwYW4+CjwvcD4KPHA+CjEmI3gy MDJCOyhhYiAmI3gwNWQyOyYjeDA1ZDM7XSYjeDIwMkM7CjwvcD4KPHA+CjxzcGFuIGRpcj0icnRs Ij4oZGVmICYjeDA1ZDA7JiN4MDVkMTsmI3gwNWQyOyBhYmNdPC9zcGFuPgo8L3A+CjxwPgomI3gy MDJCOyhkZWYgJiN4MDVkMDsmI3gwNWQxOyYjeDA1ZDI7IGFiY10mI3gyMDJDOwo8L3A+CjwvYm9k eT4=