35980 2010-03-10 11:52:29 -0800 Web Inspector: now that audits panel is added, add it to the enums (for storing last active, etc.). 2010-03-10 12:37:12 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 pfeldman pfeldman bweinstein joepeck rik timothy webkit.review.bot oldest_to_newest 198250 0 pfeldman 2010-03-10 11:52:29 -0800 Subj. 198256 1 50421 pfeldman 2010-03-10 12:02:10 -0800 Created attachment 50421 [PATCH] Proposed change. 198258 2 webkit.review.bot 2010-03-10 12:06:07 -0800 Attachment 50421 did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebCore/inspector/InspectorFrontend.cpp:180: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style. 198267 3 pfeldman 2010-03-10 12:37:12 -0800 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/inspector/InspectorController.cpp M WebCore/inspector/InspectorController.h M WebCore/inspector/InspectorFrontend.cpp M WebCore/inspector/front-end/AuditLauncherView.js M WebCore/inspector/front-end/inspector.js Committed r55799 50421 2010-03-10 12:02:10 -0800 2010-03-10 12:31:18 -0800 [PATCH] Proposed change. audits_enums text/plain 4501 pfeldman ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NDYwMzBiYy4uOTE5ODQxMSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsNSArMSwyNCBAQAogMjAxMC0wMy0xMCAgUGF2ZWwgRmVsZG1h biAgPHBmZWxkbWFuQGNocm9taXVtLm9yZz4KIAorICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBub3cgdGhhdCBhdWRpdHMgcGFuZWwg aXMgYWRkZWQsIGFkZCBpdCB0byB0aGUKKyAgICAgICAgZW51bXMgKGZvciBzdG9yaW5nIGxhc3Qg YWN0aXZlLCBldGMuKS4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MzU5ODAKKworICAgICAgICAqIGluc3BlY3Rvci9JbnNwZWN0b3JDb250cm9sbGVy LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Okluc3BlY3RvckNvbnRyb2xsZXI6OnNldFdpbmRvd1Zp c2libGUpOgorICAgICAgICAoV2ViQ29yZTo6SW5zcGVjdG9yQ29udHJvbGxlcjo6c3BlY2lhbFBh bmVsRm9ySlNOYW1lKToKKyAgICAgICAgKiBpbnNwZWN0b3IvSW5zcGVjdG9yQ29udHJvbGxlci5o OgorICAgICAgICAoV2ViQ29yZTo6SW5zcGVjdG9yQ29udHJvbGxlcjo6KToKKyAgICAgICAgKiBp bnNwZWN0b3IvSW5zcGVjdG9yRnJvbnRlbmQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SW5zcGVj dG9yRnJvbnRlbmQ6OnNob3dQYW5lbCk6CisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9p bnNwZWN0b3IuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3Iuc2hvd0F1ZGl0c1BhbmVsKToKKwor MjAxMC0wMy0xMCAgUGF2ZWwgRmVsZG1hbiAgPHBmZWxkbWFuQGNocm9taXVtLm9yZz4KKwogICAg ICAgICBSZXZpZXdlZCBieSBUaW1vdGh5IEhhdGNoZXIuCiAKICAgICAgICAgV2ViIEluc3BlY3Rv cjogQXVkaXRzIHBhbmVsIG5lZWRzIGFuIGljb24uCmRpZmYgLS1naXQgYS9XZWJDb3JlL2luc3Bl Y3Rvci9JbnNwZWN0b3JDb250cm9sbGVyLmNwcCBiL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3Rv ckNvbnRyb2xsZXIuY3BwCmluZGV4IGUzNjlhYjUuLjMzMTQ0M2QgMTAwNjQ0Ci0tLSBhL1dlYkNv cmUvaW5zcGVjdG9yL0luc3BlY3RvckNvbnRyb2xsZXIuY3BwCisrKyBiL1dlYkNvcmUvaW5zcGVj dG9yL0luc3BlY3RvckNvbnRyb2xsZXIuY3BwCkBAIC0zMTIsOCArMzEyLDggQEAgdm9pZCBJbnNw ZWN0b3JDb250cm9sbGVyOjpzZXRXaW5kb3dWaXNpYmxlKGJvb2wgdmlzaWJsZSwgYm9vbCBhdHRh Y2hlZCkKICAgICAgICAgcG9wdWxhdGVTY3JpcHRPYmplY3RzKCk7CiAKICAgICAgICAgaWYgKG1f c2hvd0FmdGVyVmlzaWJsZSA9PSBDdXJyZW50UGFuZWwpIHsKLSAgICAgICAgICBTdHJpbmcgbGFz dEFjdGl2ZVBhbmVsU2V0dGluZyA9IHNldHRpbmcobGFzdEFjdGl2ZVBhbmVsU2V0dGluZ05hbWUp OwotICAgICAgICAgIG1fc2hvd0FmdGVyVmlzaWJsZSA9IHNwZWNpYWxQYW5lbEZvckpTTmFtZShs YXN0QWN0aXZlUGFuZWxTZXR0aW5nKTsKKyAgICAgICAgICAgIFN0cmluZyBsYXN0QWN0aXZlUGFu ZWxTZXR0aW5nID0gc2V0dGluZyhsYXN0QWN0aXZlUGFuZWxTZXR0aW5nTmFtZSk7CisgICAgICAg ICAgICBtX3Nob3dBZnRlclZpc2libGUgPSBzcGVjaWFsUGFuZWxGb3JKU05hbWUobGFzdEFjdGl2 ZVBhbmVsU2V0dGluZyk7CiAgICAgICAgIH0KIAogICAgICAgICBpZiAobV9ub2RlVG9Gb2N1cykK QEAgLTE5NTAsNiArMTk1MCw4IEBAIEluc3BlY3RvckNvbnRyb2xsZXI6OlNwZWNpYWxQYW5lbHMg SW5zcGVjdG9yQ29udHJvbGxlcjo6c3BlY2lhbFBhbmVsRm9ySlNOYW1lKGNvCiAgICAgICAgIHJl dHVybiBQcm9maWxlc1BhbmVsOwogICAgIGlmIChwYW5lbE5hbWUgPT0gInN0b3JhZ2UiIHx8IHBh bmVsTmFtZSA9PSAiZGF0YWJhc2VzIikKICAgICAgICAgcmV0dXJuIFN0b3JhZ2VQYW5lbDsKKyAg ICBpZiAocGFuZWxOYW1lID09ICJhdWRpdHMiKQorICAgICAgICByZXR1cm4gQXVkaXRzUGFuZWw7 CiAgICAgaWYgKHBhbmVsTmFtZSA9PSAiY29uc29sZSIpCiAgICAgICAgIHJldHVybiBDb25zb2xl UGFuZWw7CiAgICAgcmV0dXJuIEVsZW1lbnRzUGFuZWw7CmRpZmYgLS1naXQgYS9XZWJDb3JlL2lu c3BlY3Rvci9JbnNwZWN0b3JDb250cm9sbGVyLmggYi9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0 b3JDb250cm9sbGVyLmgKaW5kZXggYTZhMmFkYS4uZWFkNGQ1ZSAxMDA2NDQKLS0tIGEvV2ViQ29y ZS9pbnNwZWN0b3IvSW5zcGVjdG9yQ29udHJvbGxlci5oCisrKyBiL1dlYkNvcmUvaW5zcGVjdG9y L0luc3BlY3RvckNvbnRyb2xsZXIuaApAQCAtMTAxLDYgKzEwMSw3IEBAIHB1YmxpYzoKICAgICB0 eXBlZGVmIEhhc2hNYXA8aW50LCBSZWZQdHI8SW5zcGVjdG9yRE9NU3RvcmFnZVJlc291cmNlPiA+ IERPTVN0b3JhZ2VSZXNvdXJjZXNNYXA7CiAKICAgICB0eXBlZGVmIGVudW0geworICAgICAgICBB dWRpdHNQYW5lbCwKICAgICAgICAgQ3VycmVudFBhbmVsLAogICAgICAgICBDb25zb2xlUGFuZWws CiAgICAgICAgIEVsZW1lbnRzUGFuZWwsCmRpZmYgLS1naXQgYS9XZWJDb3JlL2luc3BlY3Rvci9J bnNwZWN0b3JGcm9udGVuZC5jcHAgYi9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JGcm9udGVu ZC5jcHAKaW5kZXggNzgxYTA5NS4uYWY1NjIwZiAxMDA3NTUKLS0tIGEvV2ViQ29yZS9pbnNwZWN0 b3IvSW5zcGVjdG9yRnJvbnRlbmQuY3BwCisrKyBiL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3Rv ckZyb250ZW5kLmNwcApAQCAtMTc3LDYgKzE3Nyw5IEBAIHZvaWQgSW5zcGVjdG9yRnJvbnRlbmQ6 OnNob3dQYW5lbChpbnQgcGFuZWwpCiB7CiAgICAgY29uc3QgY2hhciogc2hvd0Z1bmN0aW9uTmFt ZTsKICAgICBzd2l0Y2ggKHBhbmVsKSB7CisgICAgICAgIGNhc2UgSW5zcGVjdG9yQ29udHJvbGxl cjo6QXVkaXRzUGFuZWw6CisgICAgICAgICAgICBzaG93RnVuY3Rpb25OYW1lID0gInNob3dBdWRp dHNQYW5lbCI7CisgICAgICAgICAgICBicmVhazsKICAgICAgICAgY2FzZSBJbnNwZWN0b3JDb250 cm9sbGVyOjpDb25zb2xlUGFuZWw6CiAgICAgICAgICAgICBzaG93RnVuY3Rpb25OYW1lID0gInNo b3dDb25zb2xlUGFuZWwiOwogICAgICAgICAgICAgYnJlYWs7CkBAIC0xODYsMTUgKzE4OSwxNSBA QCB2b2lkIEluc3BlY3RvckZyb250ZW5kOjpzaG93UGFuZWwoaW50IHBhbmVsKQogICAgICAgICBj YXNlIEluc3BlY3RvckNvbnRyb2xsZXI6OlJlc291cmNlc1BhbmVsOgogICAgICAgICAgICAgc2hv d0Z1bmN0aW9uTmFtZSA9ICJzaG93UmVzb3VyY2VzUGFuZWwiOwogICAgICAgICAgICAgYnJlYWs7 Ci0gICAgICAgIGNhc2UgSW5zcGVjdG9yQ29udHJvbGxlcjo6U2NyaXB0c1BhbmVsOgotICAgICAg ICAgICAgc2hvd0Z1bmN0aW9uTmFtZSA9ICJzaG93U2NyaXB0c1BhbmVsIjsKLSAgICAgICAgICAg IGJyZWFrOwogICAgICAgICBjYXNlIEluc3BlY3RvckNvbnRyb2xsZXI6OlRpbWVsaW5lUGFuZWw6 CiAgICAgICAgICAgICBzaG93RnVuY3Rpb25OYW1lID0gInNob3dUaW1lbGluZVBhbmVsIjsKICAg ICAgICAgICAgIGJyZWFrOwogICAgICAgICBjYXNlIEluc3BlY3RvckNvbnRyb2xsZXI6OlByb2Zp bGVzUGFuZWw6CiAgICAgICAgICAgICBzaG93RnVuY3Rpb25OYW1lID0gInNob3dQcm9maWxlc1Bh bmVsIjsKICAgICAgICAgICAgIGJyZWFrOworICAgICAgICBjYXNlIEluc3BlY3RvckNvbnRyb2xs ZXI6OlNjcmlwdHNQYW5lbDoKKyAgICAgICAgICAgIHNob3dGdW5jdGlvbk5hbWUgPSAic2hvd1Nj cmlwdHNQYW5lbCI7CisgICAgICAgICAgICBicmVhazsKICAgICAgICAgY2FzZSBJbnNwZWN0b3JD b250cm9sbGVyOjpTdG9yYWdlUGFuZWw6CiAgICAgICAgICAgICBzaG93RnVuY3Rpb25OYW1lID0g InNob3dTdG9yYWdlUGFuZWwiOwogICAgICAgICAgICAgYnJlYWs7CmRpZmYgLS1naXQgYS9XZWJD b3JlL2luc3BlY3Rvci9mcm9udC1lbmQvaW5zcGVjdG9yLmpzIGIvV2ViQ29yZS9pbnNwZWN0b3Iv ZnJvbnQtZW5kL2luc3BlY3Rvci5qcwppbmRleCA2ODU5ODYxLi41OTEyMGNkIDEwMDY0NAotLS0g YS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvaW5zcGVjdG9yLmpzCisrKyBiL1dlYkNvcmUv aW5zcGVjdG9yL2Zyb250LWVuZC9pbnNwZWN0b3IuanMKQEAgLTEwNDUsNiArMTA0NSwxMSBAQCBX ZWJJbnNwZWN0b3Iuc2hvd0NvbnNvbGVQYW5lbCA9IGZ1bmN0aW9uKCkKICAgICB0aGlzLmN1cnJl bnRQYW5lbCA9IHRoaXMucGFuZWxzLmNvbnNvbGU7CiB9CiAKK1dlYkluc3BlY3Rvci5zaG93QXVk aXRzUGFuZWwgPSBmdW5jdGlvbigpCit7CisgICAgdGhpcy5jdXJyZW50UGFuZWwgPSB0aGlzLnBh bmVscy5hdWRpdHM7Cit9CisKIFdlYkluc3BlY3Rvci5jbGVhckNvbnNvbGVNZXNzYWdlcyA9IGZ1 bmN0aW9uKCkKIHsKICAgICBXZWJJbnNwZWN0b3IuY29uc29sZS5jbGVhck1lc3NhZ2VzKCk7Cg==