35977 2010-03-10 10:45:52 -0800 REGRESSION(55738): http/tests/cookies/third-party-cookie-relaxing.html is failing intermittently on Leopard Commit Bot 2010-03-13 07:20:39 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 35905 1 eric beidson beidson ddkilzer oldest_to_newest 198207 0 eric 2010-03-10 10:45:52 -0800 REGRESSION(55738): http/tests/cookies/third-party-cookie-relaxing.html is failing intermittently on Leopard Commit Bot I believe Bradey is already working on a fix. Mostly writing this down in bugzilla so we can track it. Between this bug, and bug 35905 19 patches are currently blocked in the commit-queue waiting for the tree to consistently roll green again. 198214 1 beidson 2010-03-10 10:54:19 -0800 Are you sure this is intermittent...? Are you sure it hasn't always been failing since r55742? Please try deleting ~/Library/Cookies/Coookies.plist from the builder account. 198219 2 eric 2010-03-10 10:57:23 -0800 Yes, this has been intermittent on the commit bot. I'm happy to send you any and all failure logs if those would be helpful. 198223 3 eric 2010-03-10 10:57:52 -0800 I've just deleted the cookies.plist file per your instructions. Hopefully it will pass consistently now. 198226 4 eric 2010-03-10 10:59:38 -0800 it's possible that this failure has not in fact been intermittent and that some other intermittent test (like bug 35905) ahead of this one has occasionally shown up as causing the failure instead of this. 198277 5 eric 2010-03-10 12:56:22 -0800 Per Brady's instructions I ran: rm ~/Library/Cookies/Cookies.plist But I've still seen: http/tests/cookies/third-party-cookie-relaxing.html -> failed at least once since. :( 198303 6 50431 beidson 2010-03-10 13:30:41 -0800 Created attachment 50431 Attempt to make cookie resetting much more 100% 198309 7 beidson 2010-03-10 13:35:47 -0800 Hopefully http://trac.webkit.org/changeset/55801 will improve this... 198434 8 beidson 2010-03-10 17:33:50 -0800 All of the build.webkit.org bots have been passing these tests since I landed 55801 (though most were passing before) How's the commit bot doing? 198494 9 eric 2010-03-10 22:50:52 -0800 Don't know yet. The build bots are red, thus blocking the commit-queue from running at all at the moment. Once those green up we'll soon know if it has intermittent cookie problems still. The problem would be visible here: http://webkit-commit-queue.appspot.com/ because it would say "unable to build and test" for the commit-bot status. 199364 10 ddkilzer 2010-03-13 07:20:39 -0800 I believe this can be marked as fixed. 50431 2010-03-10 13:30:41 -0800 2010-03-10 13:33:18 -0800 Attempt to make cookie resetting much more 100% patch.txt text/plain 6656 beidson SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDU1Nzk5KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMjYgQEAKKzIwMTAtMDMtMTAgIEJyYWR5IEVpZHNvbiAgPGJl aWRzb25AYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNTk3Nwor ICAgICAgICAKKyAgICAgICAgVHVybnMgb3V0IHRoZSBwcmV2aW91cyBhdHRlbXB0IHRvIGNsZWFy L3Jlc2V0IGNvb2tpZXMgd2Fzbid0IHdvcmtpbmcgYmVjYXVzZSBvZiB0aGUgd2F5CisgICAgICAg IHRoZSBVUkxzIGZvciB0aGUgLmpzIGFuZCBpdHMgLmNnaSB3ZXJlIGJlaW5nIHJlc29sdmVkLgor CisgICAgICAgIFNvIHRoaXMgaXMgYSBiZXR0ZXIgd2F5IHRvIG1ha2UgdGhlIGNvb2tpZXMgY29u c2lzdGVudCBib3RoIGJlZm9yZSBhbmQgYWZ0ZXIgdGhlc2UgdGVzdHMuCisgICAgICAgIAorICAg ICAgICBJZiB0aGlzIGZhaWxzIHRvIG1ha2UgY29va2llLXJlbGF0ZWQgdGVzdHMgcmVsaWFibGUs IHRoZW4gd2UgbWlnaHQgaGF2ZSB0byBiaXRlIHRoZSBidWxsZXQKKyAgICAgICAgYW5kIGdpdmUg RFJUIGl0c2VsZiB0aGUgYWJpbGl0eSB0byBmb3JjaWJseSByZW1vdmUgY29va2llcyB2aWEgQVBJ IG1ldGhvZHMuCisgICAgICAgIAorICAgICAgICBUaGlzIHdvdWxkIGJlIGJ1bGxldHByb29mIGFu ZCBjb3VsZCBiZSBhdXRvbWF0aWMgaWYgYSB0ZXN0IGRlY2xhcmVzIGl0c2VsZiAiY29va2llIHNl bnNpdGl2ZSIKKyAgICAgICAgYnV0IHdlJ2QgbG9zZSB0aGUgYWJpbGl0eSB0byByZWxpYWJseSBy dW4gdGhlc2UgdGVzdHMgaW4gdGhlIGJyb3dzZXIuICA6KAorCisgICAgICAgICogaHR0cC90ZXN0 cy9jb29raWVzL3Jlc291cmNlcy9yZXNldENvb2tpZXMuanM6IEFkZGVkLgorICAgICAgICAqIGh0 dHAvdGVzdHMvY29va2llcy9yZXNvdXJjZXMvdGhpcmQtcGFydHktY29va2llLXJlbGF4aW5nLWlm cmFtZS5odG1sOgorICAgICAgICAqIGh0dHAvdGVzdHMvY29va2llcy90aGlyZC1wYXJ0eS1jb29r aWUtcmVsYXhpbmcuaHRtbDoKKyAgICAgICAgKiBodHRwL3Rlc3RzL3BsdWdpbnMvcmVzb3VyY2Vz L3RoaXJkLXBhcnR5LWNvb2tpZS1hY2NlcHQtcG9saWN5LWlmcmFtZS5odG1sOgorICAgICAgICAq IGh0dHAvdGVzdHMvcGx1Z2lucy90aGlyZC1wYXJ0eS1jb29raWUtYWNjZXB0LXBvbGljeS5odG1s OgorCiAyMDEwLTAzLTEwICBBbnRvbmlvIEdvbWVzICA8dG9uaWtpdG9vQHdlYmtpdC5vcmc+CiAK ICAgICAgICAgUmV2aWV3ZWQgYnkgRGF2ZSBIeWF0dC4KSW5kZXg6IExheW91dFRlc3RzL2h0dHAv dGVzdHMvY29va2llcy90aGlyZC1wYXJ0eS1jb29raWUtcmVsYXhpbmcuaHRtbAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBMYXlvdXRUZXN0cy9odHRwL3Rlc3RzL2Nvb2tpZXMvdGhpcmQtcGFydHktY29va2llLXJl bGF4aW5nLmh0bWwJKHJldmlzaW9uIDU1Nzg1KQorKysgTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9j b29raWVzL3RoaXJkLXBhcnR5LWNvb2tpZS1yZWxheGluZy5odG1sCSh3b3JraW5nIGNvcHkpCkBA IC0xLDE0ICsxLDEyIEBACiA8aHRtbD4KIDxoZWFkPgotPHNjcmlwdCBzcmM9InJlc291cmNlcy9j b29raWVzLXRlc3QtcHJlLmpzIj48L3NjcmlwdD4KKzxzY3JpcHQgc3JjPSJyZXNvdXJjZXMvcmVz ZXRDb29raWVzLmpzIj48L3NjcmlwdD4KIDxzY3JpcHQ+CityZXNldENvb2tpZXMoKTsKIAogaWYg KHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikgewogICAgIGxheW91dFRlc3RDb250cm9sbGVy LmR1bXBBc1RleHQoKTsKICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci53YWl0VW50aWxEb25lKCk7 Ci0gICAgbGF5b3V0VGVzdENvbnRyb2xsZXIuc2V0QWx3YXlzQWNjZXB0Q29va2llcyh0cnVlKTsK LSAgICBjbGVhckNvb2tpZXMoKTsKLSAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5zZXRBbHdheXNB Y2NlcHRDb29raWVzKGZhbHNlKTsKIH0KIAogd2luZG93Lm9ubWVzc2FnZSA9IGZ1bmN0aW9uKGV2 dCkKQEAgLTgwLDEwICs3OCw4IEBAIGZ1bmN0aW9uIHJ1bk5leHRUZXN0T3JGaW5pc2goKQogewog ICAgIGlmIChjdXJyZW50RnVuY3Rpb24gPj0gZnVuY3Rpb25zLmxlbmd0aCkgewogICAgICAgICBp ZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKSB7Ci0gICAgICAgICAgICBsYXlvdXRUZXN0 Q29udHJvbGxlci5ub3RpZnlEb25lKCk7Ci0gICAgICAgICAgICBsYXlvdXRUZXN0Q29udHJvbGxl ci5zZXRBbHdheXNBY2NlcHRDb29raWVzKHRydWUpOwotICAgICAgICAgICAgY2xlYXJDb29raWVz KCk7Ci0gICAgICAgICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5zZXRBbHdheXNBY2NlcHRDb29r aWVzKGZhbHNlKTsKKyAgICAgICAgICAgIHJlc2V0Q29va2llcygpOworICAgICAgICAgICAgd2lu ZG93LmZyYW1lc1swXS5wb3N0TWVzc2FnZSgicmVzZXRDb29raWVzQW5kTm90aWZ5RG9uZSIsICIq Iik7CiAgICAgICAgIH0KICAgICAgICAgcmV0dXJuOwogICAgIH0KSW5kZXg6IExheW91dFRlc3Rz L2h0dHAvdGVzdHMvY29va2llcy9yZXNvdXJjZXMvcmVzZXRDb29raWVzLmpzCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIExheW91dFRlc3RzL2h0dHAvdGVzdHMvY29va2llcy9yZXNvdXJjZXMvcmVzZXRDb29raWVz LmpzCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9jb29raWVzL3Jlc291 cmNlcy9yZXNldENvb2tpZXMuanMJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMTggQEAKK2Z1bmN0 aW9uIHJlc2V0Q29va2llcygpCit7CisgICAgaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxl cikKKwkJbGF5b3V0VGVzdENvbnRyb2xsZXIuc2V0QWx3YXlzQWNjZXB0Q29va2llcyh0cnVlKTsK KworICAgIC8vIER1ZSB0byBjcm9zcy1vcmlnaW4gcmVzdHJpY3Rpb25zLCB3ZSBjYW4gb25seSAo c2ltcGx5KSByZXNldCBjb29raWVzIGZvciBvdXIgY3VycmVudCBvcmlnaW4uCisgICAgdmFyIHVy bCA9ICJodHRwOi8vIiArIHdpbmRvdy5sb2NhdGlvbi5ob3N0bmFtZSArIjo4MDAwL2Nvb2tpZXMv cmVzb3VyY2VzL2Nvb2tpZS11dGlsaXR5LnBocD9xdWVyeWZ1bmN0aW9uPWRlbGV0ZUNvb2tpZXMi OworCXZhciByZXEgPSBuZXcgWE1MSHR0cFJlcXVlc3QoKTsKKwl0cnkgeworCQlyZXEub3Blbign R0VUJywgdXJsLCBmYWxzZSk7CisJCXJlcS5zZW5kKCk7CisJfSBjYXRjaCAoZSkgeworCQlhbGVy dCgiQXR0ZW1wdCB0byBjbGVhciAiICsgdXJsICsgIiBjb29raWVzIG1pZ2h0IGhhdmUgZmFpbGVk LiAgVGVzdCByZXN1bHRzIG1pZ2h0IGJlIG9mZiBmcm9tIGhlcmUgb24gb3V0LiAoIiArIGUgKyAi KSIpOworCX0KKwkKKwlpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKQorCQlsYXlvdXRU ZXN0Q29udHJvbGxlci5zZXRBbHdheXNBY2NlcHRDb29raWVzKGZhbHNlKTsKK30KSW5kZXg6IExh eW91dFRlc3RzL2h0dHAvdGVzdHMvY29va2llcy9yZXNvdXJjZXMvdGhpcmQtcGFydHktY29va2ll LXJlbGF4aW5nLWlmcmFtZS5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2h0dHAvdGVz dHMvY29va2llcy9yZXNvdXJjZXMvdGhpcmQtcGFydHktY29va2llLXJlbGF4aW5nLWlmcmFtZS5o dG1sCShyZXZpc2lvbiA1NTc4NSkKKysrIExheW91dFRlc3RzL2h0dHAvdGVzdHMvY29va2llcy9y ZXNvdXJjZXMvdGhpcmQtcGFydHktY29va2llLXJlbGF4aW5nLWlmcmFtZS5odG1sCSh3b3JraW5n IGNvcHkpCkBAIC0xLDUgKzEsNyBAQAogPGh0bWw+Cis8c2NyaXB0IHNyYz0icmVzZXRDb29raWVz LmpzIj48L3NjcmlwdD4KIDxzY3JpcHQ+CityZXNldENvb2tpZXMoKTsKIAogaWYgKHdpbmRvdy5s YXlvdXRUZXN0Q29udHJvbGxlcikKICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0 KCk7CkBAIC0xMiw2ICsxNCw5IEBAIHdpbmRvdy5vbm1lc3NhZ2UgPSBmdW5jdGlvbihldnQpCiAg ICAgfSBlbHNlIGlmIChldnQuZGF0YS5zcGxpdCgiICIpWzBdID09ICJzZW5kWEhSIikgewogICAg ICAgICBzZW5kWEhSKGV2dC5kYXRhLnNwbGl0KCIgIilbMV0pOwogICAgICAgICByZXR1cm47Cisg ICAgfSBlbHNlIGlmIChldnQuZGF0YSA9PSAicmVzZXRDb29raWVzQW5kTm90aWZ5RG9uZSIpIHsK KyAgICAgICAgcmVzZXRDb29raWVzQW5kTm90aWZ5RG9uZSgpOworICAgICAgICByZXR1cm47CiAg ICAgfSBlbHNlCiAgICAgICAgIGFsZXJ0KCJVbmtub3duIG1lc3NhZ2UuIik7CiB9CkBAIC00MCw2 ICs0NSwxMyBAQCBmdW5jdGlvbiBzZW5kWEhSKHF1ZXJ5Q29tbWFuZCkKICAgICBwYXJlbnQud2lu ZG93LnBvc3RNZXNzYWdlKCJkb25lIiwgIioiKTsgICAgCiB9CiAKK2Z1bmN0aW9uIHJlc2V0Q29v a2llc0FuZE5vdGlmeURvbmUoKQoreworICAgIHJlc2V0Q29va2llcygpOworICAgIGlmICh3aW5k b3cubGF5b3V0VGVzdENvbnRyb2xsZXIpCisgICAgICAgIGxheW91dFRlc3RDb250cm9sbGVyLm5v dGlmeURvbmUoKTsKK30KKwogPC9zY3JpcHQ+CiA8Ym9keT4KIEhFTExPIFRIRVJFCkluZGV4OiBM YXlvdXRUZXN0cy9odHRwL3Rlc3RzL3BsdWdpbnMvdGhpcmQtcGFydHktY29va2llLWFjY2VwdC1w b2xpY3kuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9odHRwL3Rlc3RzL3BsdWdpbnMv dGhpcmQtcGFydHktY29va2llLWFjY2VwdC1wb2xpY3kuaHRtbAkocmV2aXNpb24gNTU3ODUpCisr KyBMYXlvdXRUZXN0cy9odHRwL3Rlc3RzL3BsdWdpbnMvdGhpcmQtcGFydHktY29va2llLWFjY2Vw dC1wb2xpY3kuaHRtbAkod29ya2luZyBjb3B5KQpAQCAtMSwxNCArMSwxMiBAQAogPGh0bWw+CiA8 aGVhZD4KLTxzY3JpcHQgc3JjPSIuLi9jb29raWVzL3Jlc291cmNlcy9jb29raWVzLXRlc3QtcHJl LmpzIj48L3NjcmlwdD4gICAgCis8c2NyaXB0IHNyYz0iLi4vY29va2llcy9yZXNvdXJjZXMvcmVz ZXRDb29raWVzLmpzIj48L3NjcmlwdD4KIDxzY3JpcHQ+CityZXNldENvb2tpZXMoKTsKIAogaWYg KHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikgewogICAgIGxheW91dFRlc3RDb250cm9sbGVy LmR1bXBBc1RleHQoKTsKICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci53YWl0VW50aWxEb25lKCk7 Ci0gICAgbGF5b3V0VGVzdENvbnRyb2xsZXIuc2V0QWx3YXlzQWNjZXB0Q29va2llcyh0cnVlKTsK LSAgICBjbGVhckNvb2tpZXMoKTsKLSAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5zZXRBbHdheXNB Y2NlcHRDb29raWVzKGZhbHNlKTsKIH0KIAogPC9zY3JpcHQ+CkluZGV4OiBMYXlvdXRUZXN0cy9o dHRwL3Rlc3RzL3BsdWdpbnMvcmVzb3VyY2VzL3RoaXJkLXBhcnR5LWNvb2tpZS1hY2NlcHQtcG9s aWN5LWlmcmFtZS5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2h0dHAvdGVzdHMvcGx1 Z2lucy9yZXNvdXJjZXMvdGhpcmQtcGFydHktY29va2llLWFjY2VwdC1wb2xpY3ktaWZyYW1lLmh0 bWwJKHJldmlzaW9uIDU1Nzg1KQorKysgTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9wbHVnaW5zL3Jl c291cmNlcy90aGlyZC1wYXJ0eS1jb29raWUtYWNjZXB0LXBvbGljeS1pZnJhbWUuaHRtbAkod29y a2luZyBjb3B5KQpAQCAtMSw2ICsxLDggQEAKIDxodG1sPgogPGhlYWQ+Cis8c2NyaXB0IHNyYz0i Li4vLi4vY29va2llcy9yZXNvdXJjZXMvcmVzZXRDb29raWVzLmpzIj48L3NjcmlwdD4KIDxzY3Jp cHQ+CityZXNldENvb2tpZXMoKTsKIAogaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikg ewogICAgIGxheW91dFRlc3RDb250cm9sbGVyLmR1bXBBc1RleHQoKTsKQEAgLTMwLDEyICszMiw5 IEBAIGZ1bmN0aW9uIHRyeVNldENvb2tpZSgpCiBmdW5jdGlvbiBjb21wbGV0ZVRlc3QoKQogewog ICAgYWxlcnQoIkNvb2tpZXMgc2hvdWxkIHN0aWxsIGJlIGNsZWFyLCBhbmQgYXJlOiAnIiArIGRv Y3VtZW50LmNvb2tpZSArICInIik7Ci0gICBpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVy KSB7CisgICByZXNldENvb2tpZXMoKTsKKyAgIGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xs ZXIpCiAgICAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIubm90aWZ5RG9uZSgpOwotICAgICAgIGxh eW91dFRlc3RDb250cm9sbGVyLnNldEFsd2F5c0FjY2VwdENvb2tpZXModHJ1ZSk7Ci0gICAgICAg Y2xlYXJDb29raWVzKCk7Ci0gICAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIuc2V0QWx3YXlzQWNj ZXB0Q29va2llcyhmYWxzZSk7ICAgCi0gICB9CiB9CiAKIDwvc2NyaXB0Pgo=