35976 2010-03-10 10:19:21 -0800 On Window, dwItemData from a custom context menu item cannot be retrieved when that item is selected. 2010-03-10 11:07:47 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) PC Windows 7 RESOLVED FIXED P2 Normal --- 1 adachan adachan oldest_to_newest 198191 0 adachan 2010-03-10 10:19:21 -0800 A WebKit client can add a custom context menu item to the context menu via the IWebUIDelegate::contextMenuItemsForElement(). That custom context menu item (the MENUITEMINFO object) can have a non-null dwItemData. If that context menu item is selected, IWebUIDelegate::contextMenuItemSelected() is called, but the MENUITEMINFO no longer has the dwItemData. That's because in contextMenuItemByIdOrPosition() in ContextMenuWin.cpp, we didn't specify MIIM_DATA in the fMask when copying over the menu item information. 198192 1 50413 adachan 2010-03-10 10:24:07 -0800 Created attachment 50413 Patch 198201 2 50413 aroben 2010-03-10 10:34:14 -0800 Comment on attachment 50413 Patch > Index: WebCore/ChangeLog > =================================================================== > --- WebCore/ChangeLog (revision 55785) > +++ WebCore/ChangeLog (working copy) > @@ -1,3 +1,13 @@ > +2010-03-10 Ada Chan <adachan@apple.com> > + > + Reviewed by NOBODY (OOPS!). > + > + https://bugs.webkit.org/show_bug.cgi?id=35976 > + > + Retrieve any dwItemData that's set on the context menu item in contextMenuItemByIdOrPosition(). I think you should mention that this is useful for WebKit clients who store data in this member for their custom menu items. r=me -Adam 198233 3 adachan 2010-03-10 11:07:47 -0800 Fixed in r55787. 50413 2010-03-10 10:24:07 -0800 2010-03-10 10:34:14 -0800 Patch 35976.patch.txt text/plain 1114 adachan SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1NTc4NSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTMgQEAKKzIwMTAtMDMtMTAgIEFkYSBDaGFuICA8YWRhY2hhbkBhcHBsZS5jb20+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM1OTc2CisKKyAgICAgICAgUmV0cmll dmUgYW55IGR3SXRlbURhdGEgdGhhdCdzIHNldCBvbiB0aGUgY29udGV4dCBtZW51IGl0ZW0gaW4g Y29udGV4dE1lbnVJdGVtQnlJZE9yUG9zaXRpb24oKS4KKworICAgICAgICAqIHBsYXRmb3JtL3dp bi9Db250ZXh0TWVudVdpbi5jcHA6CisKIDIwMTAtMDMtMTAgIEplcmVteSBPcmxvdyAgPGpvcmxv d0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gRmlzaGVyLgpJbmRl eDogV2ViQ29yZS9wbGF0Zm9ybS93aW4vQ29udGV4dE1lbnVXaW4uY3BwCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFdlYkNvcmUvcGxhdGZvcm0vd2luL0NvbnRleHRNZW51V2luLmNwcAkocmV2aXNpb24gNTU3ODUp CisrKyBXZWJDb3JlL3BsYXRmb3JtL3dpbi9Db250ZXh0TWVudVdpbi5jcHAJKHdvcmtpbmcgY29w eSkKQEAgLTkwLDcgKzkwLDcgQEAgc3RhdGljIENvbnRleHRNZW51SXRlbSogY29udGV4dE1lbnVJ dGVtQgogCiAgICAgaW5mby0+Y2JTaXplID0gc2l6ZW9mKE1FTlVJVEVNSU5GTyk7CiAgICAgCi0g ICAgaW5mby0+Zk1hc2sgPSBNSUlNX0ZUWVBFIHwgTUlJTV9JRCB8IE1JSU1fU1RSSU5HOworICAg IGluZm8tPmZNYXNrID0gTUlJTV9GVFlQRSB8IE1JSU1fSUQgfCBNSUlNX1NUUklORyB8IE1JSU1f REFUQTsKIAogICAgIGlmICghOjpHZXRNZW51SXRlbUluZm8obWVudSwgaWQsIGJ5UG9zaXRpb24s IGluZm8pKSB7CiAgICAgICAgIGZyZWUoaW5mbyk7Cg==