35967 2010-03-10 04:17:24 -0800 Remove extra <new> include and add guards to operator new/delete definitions 2010-03-16 09:20:17 -0700 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 1 zoltan webkit-unassigned oldest_to_newest 197977 0 zoltan 2010-03-10 04:17:24 -0800 Remove extra <new> header include from FastAlloc.cpp since it is included in FastAlloc.h. Add ENABLE_GLOBAL_FASTMALLOC_NEW macro guard to operator new/delete/new []/delete [] definitions. 197979 1 50392 zoltan 2010-03-10 04:19:30 -0800 Created attachment 50392 proposed patch 199023 2 50392 laszlo.gombos 2010-03-12 06:57:45 -0800 Comment on attachment 50392 proposed patch > +#if defined(ENABLE_GLOBAL_FASTMALLOC_NEW) Should this be the following instead ? +#if ENABLE(GLOBAL_FASTMALLOC_NEW) 199862 3 50392 eric 2010-03-15 15:24:14 -0700 Comment on attachment 50392 proposed patch Should use the ENABLE macros. 200056 4 50773 zoltan 2010-03-16 00:51:22 -0700 Created attachment 50773 Patch 200242 5 50773 zoltan 2010-03-16 09:20:09 -0700 Comment on attachment 50773 Patch Clearing flags on attachment: 50773 Committed r56066: <http://trac.webkit.org/changeset/56066> 200243 6 zoltan 2010-03-16 09:20:17 -0700 All reviewed patches have been landed. Closing bug. 50392 2010-03-10 04:19:30 -0800 2010-03-16 00:51:16 -0700 proposed patch fastmalloc.patch text/plain 1710 zoltan ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0No YW5nZUxvZwppbmRleCBkYjZkM2Q5Li4zYTc3Zjc4IDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTAtMDMtMTAgIFpvbHRhbiBIb3J2YXRoICA8em9sdGFuQHdlYmtpdC5vcmc+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVtb3ZlIGV4dHJh IDxuZXc+IGluY2x1ZGUgYW5kIGFkZCBndWFyZHMgdG8gb3BlcmF0b3IgbmV3L2RlbGV0ZSBkZWZp bml0aW9ucworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MzU5NjcKKworICAgICAgICBSZW1vdmUgZXh0cmEgPG5ldz4gaGVhZGVyIGluY2x1ZGUgZnJvbSBG YXN0QWxsb2MuY3BwIHNpbmNlIGl0IGlzIGluY2x1ZGVkIGluIAorICAgICAgICBGYXN0QWxsb2Mu aC4gQWRkIEVOQUJMRV9HTE9CQUxfRkFTVE1BTExPQ19ORVcgbWFjcm8gZ3VhcmQgdG8gb3BlcmF0 b3IKKyAgICAgICAgbmV3L2RlbGV0ZS9uZXcgW10vZGVsZXRlIFtdIGRlZmluaXRpb25zLgorCisg ICAgICAgICogd3RmL0Zhc3RNYWxsb2MuY3BwOgorCiAyMDEwLTAzLTEwICBLZXZpbiBPbGxpdmll ciAgPGtldmlub0B0aGVvbGxpdmllcnMuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEVyaWMg U2VpZGVsLgpkaWZmIC0tZ2l0IGEvSmF2YVNjcmlwdENvcmUvd3RmL0Zhc3RNYWxsb2MuY3BwIGIv SmF2YVNjcmlwdENvcmUvd3RmL0Zhc3RNYWxsb2MuY3BwCmluZGV4IGQxYTRkMjguLjc0MWVmZjkg MTAwNjQ0Ci0tLSBhL0phdmFTY3JpcHRDb3JlL3d0Zi9GYXN0TWFsbG9jLmNwcAorKysgYi9KYXZh U2NyaXB0Q29yZS93dGYvRmFzdE1hbGxvYy5jcHAKQEAgLTQxNyw3ICs0MTcsNiBAQCBleHRlcm4g IkMiIGNvbnN0IGludCBqc2NvcmVfZmFzdG1hbGxvY19pbnRyb3NwZWN0aW9uID0gMDsKICNpbmNs dWRlIDxhbGdvcml0aG0+CiAjaW5jbHVkZSA8ZXJybm8uaD4KICNpbmNsdWRlIDxsaW1pdHM+Ci0j aW5jbHVkZSA8bmV3PgogI2luY2x1ZGUgPHB0aHJlYWQuaD4KICNpbmNsdWRlIDxzdGRhcmcuaD4K ICNpbmNsdWRlIDxzdGRkZWYuaD4KQEAgLTM5NDMsNiArMzk0Miw4IEBAIHN0YXRpYyBpbmxpbmUg dm9pZCogY3BwX2FsbG9jKHNpemVfdCBzaXplLCBib29sIG5vdGhyb3cpIHsKICAgfQogfQogCisj aWYgZGVmaW5lZChFTkFCTEVfR0xPQkFMX0ZBU1RNQUxMT0NfTkVXKQorCiB2b2lkKiBvcGVyYXRv ciBuZXcoc2l6ZV90IHNpemUpIHsKICAgdm9pZCogcCA9IGNwcF9hbGxvYyhzaXplLCBmYWxzZSk7 CiAgIC8vIFdlIGtlZXAgdGhpcyBuZXh0IGluc3RydWN0aW9uIG91dCBvZiBjcHBfYWxsb2MgZm9y IGEgcmVhc29uOiB3aGVuCkBAIC0zOTk3LDYgKzM5OTgsOCBAQCB2b2lkIG9wZXJhdG9yIGRlbGV0 ZVtdKHZvaWQqIHAsIGNvbnN0IHN0ZDo6bm90aHJvd190JikgX19USFJPVyB7CiAgIGRvX2ZyZWUo cCk7CiB9CiAKKyNlbmRpZgorCiBleHRlcm4gIkMiIHZvaWQqIG1lbWFsaWduKHNpemVfdCBhbGln biwgc2l6ZV90IHNpemUpIF9fVEhST1cgewogICB2b2lkKiByZXN1bHQgPSBkb19tZW1hbGlnbihh bGlnbiwgc2l6ZSk7CiAgIE1hbGxvY0hvb2s6Okludm9rZU5ld0hvb2socmVzdWx0LCBzaXplKTsK 50773 2010-03-16 00:51:22 -0700 2010-03-16 09:20:09 -0700 Patch bug-35967-20100316085119.patch text/plain 1697 zoltan SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDU2MDQ2KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTAtMDMtMTYgIFpvbHRhbiBI b3J2YXRoICA8em9sdGFuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgUmVtb3ZlIGV4dHJhIDxuZXc+IGluY2x1ZGUgYW5kIGFkZCBn dWFyZHMgdG8gb3BlcmF0b3IgbmV3L2RlbGV0ZSBkZWZpbml0aW9ucworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzU5NjcKKworICAgICAgICBSZW1vdmUg ZXh0cmEgPG5ldz4gaGVhZGVyIGluY2x1ZGUgZnJvbSBGYXN0QWxsb2MuY3BwIHNpbmNlIGl0IGlz IGluY2x1ZGVkIGluIAorICAgICAgICBGYXN0QWxsb2MuaC4gQWRkIEVOQUJMRShHTE9CQUxfRkFT VE1BTExPQ19ORVcpIG1hY3JvIGd1YXJkIHRvIG9wZXJhdG9yCisgICAgICAgIG5ldy9kZWxldGUv bmV3IFtdL2RlbGV0ZSBbXSBkZWZpbml0aW9ucy4KKworICAgICAgICAqIHd0Zi9GYXN0TWFsbG9j LmNwcDoKKwogMjAxMC0wMy0xNSAgS3dhbmcgWXVsIFNlbyAgPHNreXVsQGNvbXBhbnkxMDAubmV0 PgogCiAgICAgICAgIFJldmlld2VkIGJ5IEVyaWMgU2VpZGVsLgpJbmRleDogSmF2YVNjcmlwdENv cmUvd3RmL0Zhc3RNYWxsb2MuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEphdmFTY3JpcHRDb3JlL3d0Zi9G YXN0TWFsbG9jLmNwcAkocmV2aXNpb24gNTYwNDYpCisrKyBKYXZhU2NyaXB0Q29yZS93dGYvRmFz dE1hbGxvYy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQxNyw3ICs0MTcsNiBAQCBleHRlcm4gIkMi IGNvbnN0IGludCBqc2NvcmVfZmFzdG1hbGxvY19pCiAjaW5jbHVkZSA8YWxnb3JpdGhtPgogI2lu Y2x1ZGUgPGVycm5vLmg+CiAjaW5jbHVkZSA8bGltaXRzPgotI2luY2x1ZGUgPG5ldz4KICNpbmNs dWRlIDxwdGhyZWFkLmg+CiAjaW5jbHVkZSA8c3RkYXJnLmg+CiAjaW5jbHVkZSA8c3RkZGVmLmg+ CkBAIC0zOTQyLDYgKzM5NDEsOCBAQCBzdGF0aWMgaW5saW5lIHZvaWQqIGNwcF9hbGxvYyhzaXpl X3Qgc2l6CiAgIH0KIH0KIAorI2lmIEVOQUJMRShHTE9CQUxfRkFTVE1BTExPQ19ORVcpCisKIHZv aWQqIG9wZXJhdG9yIG5ldyhzaXplX3Qgc2l6ZSkgewogICB2b2lkKiBwID0gY3BwX2FsbG9jKHNp emUsIGZhbHNlKTsKICAgLy8gV2Uga2VlcCB0aGlzIG5leHQgaW5zdHJ1Y3Rpb24gb3V0IG9mIGNw cF9hbGxvYyBmb3IgYSByZWFzb246IHdoZW4KQEAgLTM5OTYsNiArMzk5Nyw4IEBAIHZvaWQgb3Bl cmF0b3IgZGVsZXRlW10odm9pZCogcCwgY29uc3Qgc3QKICAgZG9fZnJlZShwKTsKIH0KIAorI2Vu ZGlmCisKIGV4dGVybiAiQyIgdm9pZCogbWVtYWxpZ24oc2l6ZV90IGFsaWduLCBzaXplX3Qgc2l6 ZSkgX19USFJPVyB7CiAgIHZvaWQqIHJlc3VsdCA9IGRvX21lbWFsaWduKGFsaWduLCBzaXplKTsK ICAgTWFsbG9jSG9vazo6SW52b2tlTmV3SG9vayhyZXN1bHQsIHNpemUpOwo=