35963 2010-03-10 03:52:29 -0800 input type other than text won't work with autofill 2010-03-10 05:25:15 -0800 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) Mac (Intel) OS X 10.6 RESOLVED FIXED http://dag.bytestudios.com/test.html P2 Minor --- 35895 1 sullivan sullivan ap sullivan oldest_to_newest 197964 0 sullivan 2010-03-10 03:52:29 -0800 +++ This bug was initially created as a clone of Bug #35895 +++ Unless I change my zipcode fields from input type="number" and my email fields from input type="email" to input type="text" autofill will not populate them 197966 1 sullivan 2010-03-10 03:54:27 -0800 The problem is in -[WebHTMLRepresentation elementDoesAutocomplete:], where only type TEXT is considered. 197967 2 sullivan 2010-03-10 03:59:07 -0800 I'll have a patch up later this morning. 197970 3 50388 sullivan 2010-03-10 04:02:16 -0800 Created attachment 50388 Patch to make WebHTMLRepresentation elementDoesAutocomplete return true for any text fields other than passwords. 198000 4 sullivan 2010-03-10 05:25:15 -0800 http://trac.webkit.org/changeset/55776 50388 2010-03-10 04:02:16 -0800 2010-03-10 04:12:48 -0800 Patch to make WebHTMLRepresentation elementDoesAutocomplete return true for any text fields other than passwords. autocomplete_patch.txt text/plain 2582 sullivan SW5kZXg6IFdlYktpdC9tYWMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9tYWMvQ2hh bmdlTG9nCShyZXZpc2lvbiA1NTc3NCkKKysrIFdlYktpdC9tYWMvQ2hhbmdlTG9nCSh3b3JraW5n IGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTAtMDMtMTAgIEpvaG4gU3VsbGl2YW4gIDxzdWxs aXZhbkBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgPGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNTk2Mz4K KyAgICAgICAgaW5wdXQgdHlwZSBvdGhlciB0aGFuIHRleHQgd29uJ3Qgd29yayB3aXRoIGF1dG9m aWxsCisKKyAgICAgICAgKiBXZWJWaWV3L1dlYkhUTUxSZXByZXNlbnRhdGlvbi5tbToKKyAgICAg ICAgKC1bV2ViSFRNTFJlcHJlc2VudGF0aW9uIGVsZW1lbnREb2VzQXV0b0NvbXBsZXRlOl0pOgor ICAgICAgICBSZXR1cm4gdHJ1ZSBmb3IgYW55IHRleHQgZmllbGQgdGhhdCdzIG5vdCBhIHBhc3N3 b3JkLCByYXRoZXIgdGhhbiBvbmx5CisgICAgICAgIGZvciBURVhUIHR5cGUuCisKIDIwMTAtMDMt MDkgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2Vk IGJ5IFRpbSBIYXRjaGVyLgpJbmRleDogV2ViS2l0L21hYy9XZWJWaWV3L1dlYkhUTUxSZXByZXNl bnRhdGlvbi5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXQvbWFjL1dlYlZpZXcvV2ViSFRNTFJlcHJl c2VudGF0aW9uLm1tCShyZXZpc2lvbiA1NTc0MCkKKysrIFdlYktpdC9tYWMvV2ViVmlldy9XZWJI VE1MUmVwcmVzZW50YXRpb24ubW0JKHdvcmtpbmcgY29weSkKQEAgLTMwMiw3ICszMDIsOCBAQCBz dGF0aWMgSFRNTElucHV0RWxlbWVudCogaW5wdXRFbGVtZW50RnJvCiB7CiAgICAgSFRNTElucHV0 RWxlbWVudCogaW5wdXRFbGVtZW50ID0gaW5wdXRFbGVtZW50RnJvbURPTUVsZW1lbnQoZWxlbWVu dCk7CiAgICAgcmV0dXJuIGlucHV0RWxlbWVudAotICAgICAgICAmJiBpbnB1dEVsZW1lbnQtPmlu cHV0VHlwZSgpID09IEhUTUxJbnB1dEVsZW1lbnQ6OlRFWFQKKyAgICAgICAgJiYgaW5wdXRFbGVt ZW50LT5pc1RleHRGaWVsZCgpCisgICAgICAgICYmIGlucHV0RWxlbWVudC0+aW5wdXRUeXBlKCkg IT0gSFRNTElucHV0RWxlbWVudDo6UEFTU1dPUkQKICAgICAgICAgJiYgaW5wdXRFbGVtZW50LT5h dXRvQ29tcGxldGUoKTsKIH0KIApJbmRleDogV2ViS2l0L3dpbi9DaGFuZ2VMb2cKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gV2ViS2l0L3dpbi9DaGFuZ2VMb2cJKHJldmlzaW9uIDU1Nzc0KQorKysgV2ViS2l0L3dp bi9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0wMy0xMCAg Sm9obiBTdWxsaXZhbiAgPHN1bGxpdmFuQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKyAgICAgICAgCisgICAgICAgIDxodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzU5NjM+CisgICAgICAgIGlucHV0IHR5cGUgb3RoZXIgdGhh biB0ZXh0IHdvbid0IHdvcmsgd2l0aCBhdXRvZmlsbAorCisgICAgICAgICogV2ViRnJhbWUuY3Bw OgorICAgICAgICAoV2ViRnJhbWU6OmVsZW1lbnREb2VzQXV0b0NvbXBsZXRlKToKKyAgICAgICAg UmV0dXJuIHRydWUgZm9yIGFueSB0ZXh0IGZpZWxkIHRoYXQncyBub3QgYSBwYXNzd29yZCwgcmF0 aGVyIHRoYW4gb25seQorICAgICAgICBmb3IgVEVYVCB0eXBlLgorCiAyMDEwLTAzLTA5ICBCcmFk eSBFaWRzb24gIDxiZWlkc29uQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBUaW0g SGF0Y2hlci4KSW5kZXg6IFdlYktpdC93aW4vV2ViRnJhbWUuY3BwCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdl YktpdC93aW4vV2ViRnJhbWUuY3BwCShyZXZpc2lvbiA1NTc0MCkKKysrIFdlYktpdC93aW4vV2Vi RnJhbWUuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMTUyLDcgKzExNTIsNyBAQCBIUkVTVUxUIFdl YkZyYW1lOjplbGVtZW50RG9lc0F1dG9Db21wbGV0CiAgICAgaWYgKCFpbnB1dEVsZW1lbnQpCiAg ICAgICAgICpyZXN1bHQgPSBmYWxzZTsKICAgICBlbHNlCi0gICAgICAgICpyZXN1bHQgPSAoaW5w dXRFbGVtZW50LT5pbnB1dFR5cGUoKSA9PSBIVE1MSW5wdXRFbGVtZW50OjpURVhUICYmIGlucHV0 RWxlbWVudC0+YXV0b0NvbXBsZXRlKCkpOworICAgICAgICAqcmVzdWx0ID0gaW5wdXRFbGVtZW50 LT5pc1RleHRGaWVsZCgpICYmIGlucHV0RWxlbWVudC0+aW5wdXRUeXBlKCkgIT0gSFRNTElucHV0 RWxlbWVudDo6UEFTU1dPUkQgJiYgaW5wdXRFbGVtZW50LT5hdXRvQ29tcGxldGUoKTsKIAogICAg IHJldHVybiBTX09LOwogfQo=